coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: mb/asus/p8h61-m_lx3_r2_0: Transform into variant setup
by Angel Pons (Code Review) 17 May '21

17 May '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54372 ) Change subject: mb/asus/p8h61-m_lx3_r2_0: Transform into variant setup ...................................................................... mb/asus/p8h61-m_lx3_r2_0: Transform into variant setup Get ready to squash all Asus H61 boards together, so as to factor out lots of redundant code. Tested with BUILD_TIMELESS=1, coreboot.rom for the Asus P8H61-M LX3 R2.0 remains identical when not adding the .config file in it. Change-Id: I738197bf4d5ea8b879ae26ecbcb0cf3714316662 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- A src/mainboard/asus/h61-series/Kconfig A src/mainboard/asus/h61-series/Kconfig.name A src/mainboard/asus/h61-series/Makefile.inc R src/mainboard/asus/h61-series/acpi/ec.asl R src/mainboard/asus/h61-series/acpi/platform.asl R src/mainboard/asus/h61-series/acpi/superio.asl A src/mainboard/asus/h61-series/board_info.txt R src/mainboard/asus/h61-series/dsdt.asl C src/mainboard/asus/h61-series/hda_verb.c R src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/board_info.txt R src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/data.vbt R src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/devicetree.cb R src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/early_init.c R src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/gma-mainboard.ads R src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/gpio.c R src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/hda_verb.c D src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig D src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig.name D src/mainboard/asus/p8h61-m_lx3_r2_0/Makefile.inc 19 files changed, 53 insertions(+), 38 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/54372/1 diff --git a/src/mainboard/asus/h61-series/Kconfig b/src/mainboard/asus/h61-series/Kconfig new file mode 100644 index 0000000..2ef6642 --- /dev/null +++ b/src/mainboard/asus/h61-series/Kconfig @@ -0,0 +1,32 @@ +## SPDX-License-Identifier: GPL-2.0-only + +config BOARD_ASUS_H61_SERIES + bool + select HAVE_ACPI_RESUME + select HAVE_ACPI_TABLES + select INTEL_GMA_HAVE_VBT + select MAINBOARD_HAS_LIBGFXINIT + select NORTHBRIDGE_INTEL_SANDYBRIDGE + select SERIRQ_CONTINUOUS_MODE + select SOUTHBRIDGE_INTEL_BD82X6X + select USE_NATIVE_RAMINIT + +if BOARD_ASUS_H61_SERIES + +config MAINBOARD_DIR + string + default "asus/h61-series" + +config VARIANT_DIR + string + default "p8h61-m_lx3_r2_0" if BOARD_ASUS_P8H61_M_LX3_R2_0 + +config MAINBOARD_PART_NUMBER + string + default "P8H61-M LX3 R2.0" if BOARD_ASUS_P8H61_M_LX3_R2_0 + +config DEVICETREE + string + default "variants/\$(CONFIG_VARIANT_DIR)/devicetree.cb" + +endif diff --git a/src/mainboard/asus/h61-series/Kconfig.name b/src/mainboard/asus/h61-series/Kconfig.name new file mode 100644 index 0000000..14ca540 --- /dev/null +++ b/src/mainboard/asus/h61-series/Kconfig.name @@ -0,0 +1,8 @@ +config BOARD_ASUS_P8H61_M_LX3_R2_0 + bool "P8H61-M LX3 R2.0" + select BOARD_ASUS_H61_SERIES + select BOARD_ROMSIZE_KB_8192 + select NO_UART_ON_SUPERIO + select REALTEK_8168_RESET + select RT8168_SET_LED_MODE + select SUPERIO_NUVOTON_NCT6779D diff --git a/src/mainboard/asus/h61-series/Makefile.inc b/src/mainboard/asus/h61-series/Makefile.inc new file mode 100644 index 0000000..e339285 --- /dev/null +++ b/src/mainboard/asus/h61-series/Makefile.inc @@ -0,0 +1,8 @@ +## SPDX-License-Identifier: GPL-2.0-only + +bootblock-y += variants/$(VARIANT_DIR)/early_init.c +romstage-y += variants/$(VARIANT_DIR)/early_init.c +bootblock-y += variants/$(VARIANT_DIR)/gpio.c +romstage-y += variants/$(VARIANT_DIR)/gpio.c +ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c +ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += variants/$(VARIANT_DIR)/gma-mainboard.ads diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/acpi/ec.asl b/src/mainboard/asus/h61-series/acpi/ec.asl similarity index 100% rename from src/mainboard/asus/p8h61-m_lx3_r2_0/acpi/ec.asl rename to src/mainboard/asus/h61-series/acpi/ec.asl diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/acpi/platform.asl b/src/mainboard/asus/h61-series/acpi/platform.asl similarity index 100% rename from src/mainboard/asus/p8h61-m_lx3_r2_0/acpi/platform.asl rename to src/mainboard/asus/h61-series/acpi/platform.asl diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/acpi/superio.asl b/src/mainboard/asus/h61-series/acpi/superio.asl similarity index 100% rename from src/mainboard/asus/p8h61-m_lx3_r2_0/acpi/superio.asl rename to src/mainboard/asus/h61-series/acpi/superio.asl diff --git a/src/mainboard/asus/h61-series/board_info.txt b/src/mainboard/asus/h61-series/board_info.txt new file mode 100644 index 0000000..8f74c04 --- /dev/null +++ b/src/mainboard/asus/h61-series/board_info.txt @@ -0,0 +1,5 @@ +Category: desktop +ROM package: DIP-8 +ROM protocol: SPI +ROM socketed: y +Flashrom support: y diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl b/src/mainboard/asus/h61-series/dsdt.asl similarity index 100% rename from src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl rename to src/mainboard/asus/h61-series/dsdt.asl diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/acpi/ec.asl b/src/mainboard/asus/h61-series/hda_verb.c similarity index 100% copy from src/mainboard/asus/p8h61-m_lx3_r2_0/acpi/ec.asl copy to src/mainboard/asus/h61-series/hda_verb.c diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/board_info.txt b/src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/board_info.txt similarity index 100% rename from src/mainboard/asus/p8h61-m_lx3_r2_0/board_info.txt rename to src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/board_info.txt diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/data.vbt b/src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/data.vbt similarity index 100% rename from src/mainboard/asus/p8h61-m_lx3_r2_0/data.vbt rename to src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/data.vbt Binary files differ diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/devicetree.cb b/src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/devicetree.cb similarity index 100% rename from src/mainboard/asus/p8h61-m_lx3_r2_0/devicetree.cb rename to src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/devicetree.cb diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/early_init.c b/src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/early_init.c similarity index 100% rename from src/mainboard/asus/p8h61-m_lx3_r2_0/early_init.c rename to src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/early_init.c diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/gma-mainboard.ads b/src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/gma-mainboard.ads similarity index 100% rename from src/mainboard/asus/p8h61-m_lx3_r2_0/gma-mainboard.ads rename to src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/gma-mainboard.ads diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/gpio.c b/src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/gpio.c similarity index 100% rename from src/mainboard/asus/p8h61-m_lx3_r2_0/gpio.c rename to src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/gpio.c diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/hda_verb.c b/src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/hda_verb.c similarity index 100% rename from src/mainboard/asus/p8h61-m_lx3_r2_0/hda_verb.c rename to src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/hda_verb.c diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig b/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig deleted file mode 100644 index 16fbbb8..0000000 --- a/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig +++ /dev/null @@ -1,29 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-only - -if BOARD_ASUS_P8H61_M_LX3_R2_0 - -config BOARD_SPECIFIC_OPTIONS - def_bool y - select BOARD_ROMSIZE_KB_8192 - select HAVE_ACPI_RESUME - select HAVE_ACPI_TABLES - select INTEL_GMA_HAVE_VBT - select MAINBOARD_HAS_LIBGFXINIT - select NO_UART_ON_SUPERIO - select NORTHBRIDGE_INTEL_SANDYBRIDGE - select REALTEK_8168_RESET - select RT8168_SET_LED_MODE - select SERIRQ_CONTINUOUS_MODE - select SOUTHBRIDGE_INTEL_BD82X6X - select SUPERIO_NUVOTON_NCT6779D - select USE_NATIVE_RAMINIT - -config MAINBOARD_DIR - string - default "asus/p8h61-m_lx3_r2_0" - -config MAINBOARD_PART_NUMBER - string - default "P8H61-M LX3 R2.0" - -endif diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig.name b/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig.name deleted file mode 100644 index 6d10dcf..0000000 --- a/src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig.name +++ /dev/null @@ -1,2 +0,0 @@ -config BOARD_ASUS_P8H61_M_LX3_R2_0 - bool "P8H61-M LX3 R2.0" diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/Makefile.inc b/src/mainboard/asus/p8h61-m_lx3_r2_0/Makefile.inc deleted file mode 100644 index 7167e10..0000000 --- a/src/mainboard/asus/p8h61-m_lx3_r2_0/Makefile.inc +++ /dev/null @@ -1,7 +0,0 @@ -bootblock-y += early_init.c -bootblock-y += gpio.c - -romstage-y += early_init.c -romstage-y += gpio.c - -ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads -- To view, visit https://review.coreboot.org/c/coreboot/+/54372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I738197bf4d5ea8b879ae26ecbcb0cf3714316662 Gerrit-Change-Number: 54372 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/asus/{h61m-cs,p8h61-m_lx}: Reorder `_PTS` and `_WAK`
by Angel Pons (Code Review) 17 May '21

17 May '21

Attention is currently required from: Tristan Corrick. Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54371 ) Change subject: mb/asus/{h61m-cs,p8h61-m_lx}: Reorder `_PTS` and `_WAK` ...................................................................... mb/asus/{h61m-cs,p8h61-m_lx}: Reorder `_PTS` and `_WAK` Done to preserve reproducibility when switching to a variant setup. Change-Id: I78241c807f767846774b8e1a2e0d25f3452ed544 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asus/h61m-cs/acpi/platform.asl M src/mainboard/asus/p8h61-m_lx/acpi/platform.asl 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/54371/1 diff --git a/src/mainboard/asus/h61m-cs/acpi/platform.asl b/src/mainboard/asus/h61m-cs/acpi/platform.asl index 7b1b2b2..90cf05b 100644 --- a/src/mainboard/asus/h61m-cs/acpi/platform.asl +++ b/src/mainboard/asus/h61m-cs/acpi/platform.asl @@ -1,10 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ +Method(_PTS,1) +{ +} + Method(_WAK,1) { Return(Package(){0,0}) } - -Method(_PTS,1) -{ -} diff --git a/src/mainboard/asus/p8h61-m_lx/acpi/platform.asl b/src/mainboard/asus/p8h61-m_lx/acpi/platform.asl index 77a0295..90cf05b 100644 --- a/src/mainboard/asus/p8h61-m_lx/acpi/platform.asl +++ b/src/mainboard/asus/p8h61-m_lx/acpi/platform.asl @@ -1,10 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -Method(_WAK, 1) +Method(_PTS,1) { - Return (Package() { 0, 0 }) } -Method(_PTS, 1) +Method(_WAK,1) { + Return(Package(){0,0}) } -- To view, visit https://review.coreboot.org/c/coreboot/+/54371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78241c807f767846774b8e1a2e0d25f3452ed544 Gerrit-Change-Number: 54371 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Asus H61 boards: Align dsdt.asl with other boards
by Angel Pons (Code Review) 17 May '21

17 May '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54370 ) Change subject: Asus H61 boards: Align dsdt.asl with other boards ...................................................................... Asus H61 boards: Align dsdt.asl with other boards Prepare to transform Asus H61 boards into a variant setup. Change-Id: Ifd5808edac22ebdba9b29a711ad129b91d9975d0 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asus/p8h61-m_lx/dsdt.asl M src/mainboard/asus/p8h61-m_pro/dsdt.asl 2 files changed, 3 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/54370/1 diff --git a/src/mainboard/asus/p8h61-m_lx/dsdt.asl b/src/mainboard/asus/p8h61-m_lx/dsdt.asl index b9fc14e..dc53527 100644 --- a/src/mainboard/asus/p8h61-m_lx/dsdt.asl +++ b/src/mainboard/asus/p8h61-m_lx/dsdt.asl @@ -17,12 +17,9 @@ #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> #include <southbridge/intel/common/acpi/sleepstates.asl> - Scope (\_SB) + Device (\_SB.PCI0) { - Device (PCI0) - { #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> #include <southbridge/intel/bd82x6x/acpi/pch.asl> - } } } diff --git a/src/mainboard/asus/p8h61-m_pro/dsdt.asl b/src/mainboard/asus/p8h61-m_pro/dsdt.asl index 9a12f1e..149d548 100644 --- a/src/mainboard/asus/p8h61-m_pro/dsdt.asl +++ b/src/mainboard/asus/p8h61-m_pro/dsdt.asl @@ -19,11 +19,9 @@ #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> #include <southbridge/intel/common/acpi/sleepstates.asl> - Scope (\_SB) { - Device (PCI0) - { + Device (\_SB.PCI0) + { #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> #include <southbridge/intel/bd82x6x/acpi/pch.asl> - } } } -- To view, visit https://review.coreboot.org/c/coreboot/+/54370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd5808edac22ebdba9b29a711ad129b91d9975d0 Gerrit-Change-Number: 54370 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: UPSTREAM: mb/google/dedede/var/sasukette: Enable ELAN touchpad
by Zhi7 Li (Code Review) 17 May '21

17 May '21

Zhi7 Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54369 ) Change subject: UPSTREAM: mb/google/dedede/var/sasukette: Enable ELAN touchpad ...................................................................... UPSTREAM: mb/google/dedede/var/sasukette: Enable ELAN touchpad Add ELAN touchpad into devicetree for sasukette. BUG=b:188376649 BRANCH=dedede TEST=built sasukette firmware and verified touchpad function Signed-off-by: lizhi7 <lizhi7(a)huaqin.corp-partner.google.com> Change-Id: I898aeda936eb10ef4ead679a1c087060fad71a08 --- M src/mainboard/google/dedede/variants/sasukette/overridetree.cb 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/54369/1 diff --git a/src/mainboard/google/dedede/variants/sasukette/overridetree.cb b/src/mainboard/google/dedede/variants/sasukette/overridetree.cb index 8d1b95b..cb4c78f 100644 --- a/src/mainboard/google/dedede/variants/sasukette/overridetree.cb +++ b/src/mainboard/google/dedede/variants/sasukette/overridetree.cb @@ -127,6 +127,14 @@ register "hid_desc_reg_offset" = "0x20" device i2c 2c on end end + chip drivers/i2c/hid + register "generic.hid" = ""ELAN0000"" + register "generic.desc" = ""ELAN Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_B3_IRQ)" + register "generic.wake" = "GPE0_DW0_03" + register "generic.probed" = "1" + device i2c 15 on end + end end #I2C 0 device pci 19.0 on chip drivers/i2c/generic -- To view, visit https://review.coreboot.org/c/coreboot/+/54369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I898aeda936eb10ef4ead679a1c087060fad71a08 Gerrit-Change-Number: 54369 Gerrit-PatchSet: 1 Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/alderlake: mb/intel/sm: Add tcss code
by EricR Lai (Code Review) 17 May '21

17 May '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Deepti Deshatty, Patrick Rudolph. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54089 ) Change subject: soc/intel/alderlake: mb/intel/sm: Add tcss code ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/alderlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/54089/comment/c3d74251_626651a0 PS2, Line 133: params->IomTypeCPortPadCfg[i] = config->IomTypeCPortPadCfg[i]; If you didn't set it, default is 0, right? -- To view, visit https://review.coreboot.org/c/coreboot/+/54089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifce6abb0fce20e408931b904426131a42a5a4a36 Gerrit-Change-Number: 54089 Gerrit-PatchSet: 2 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 17 May 2021 11:12:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/sm: Enable TCSS
by EricR Lai (Code Review) 17 May '21

17 May '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak, Deepti Deshatty. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54091 ) Change subject: mb/intel/sm: Enable TCSS ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Can we move the mainboard code to the soc level? Looks like it the same. Or maybe the TSCC driver? -- To view, visit https://review.coreboot.org/c/coreboot/+/54091 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8be796295a900bed58b5c7ed6c2300fe504d58a3 Gerrit-Change-Number: 54091 Gerrit-PatchSet: 2 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Comment-Date: Mon, 17 May 2021 11:09:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Enable TCSS
by EricR Lai (Code Review) 17 May '21

17 May '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak, Deepti Deshatty. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54090 ) Change subject: mb/google/brya: Enable TCSS ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Can we move the mainboard code to the soc level? Looks like it the same. -- To view, visit https://review.coreboot.org/c/coreboot/+/54090 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3cb8b8836b17fa00ab0089d03fca9f22c4d702e Gerrit-Change-Number: 54090 Gerrit-PatchSet: 2 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Comment-Date: Mon, 17 May 2021 11:08:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/sm: Enable TCSS
by Deepti Deshatty (Code Review) 17 May '21

17 May '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak. Deepti Deshatty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54091 ) Change subject: mb/intel/sm: Enable TCSS ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/54091 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8be796295a900bed58b5c7ed6c2300fe504d58a3 Gerrit-Change-Number: 54091 Gerrit-PatchSet: 2 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Mon, 17 May 2021 11:00:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Enable TCSS
by Deepti Deshatty (Code Review) 17 May '21

17 May '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak. Deepti Deshatty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54090 ) Change subject: mb/google/brya: Enable TCSS ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/54090 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3cb8b8836b17fa00ab0089d03fca9f22c4d702e Gerrit-Change-Number: 54090 Gerrit-PatchSet: 2 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Mon, 17 May 2021 10:59:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: mb/intel/sm: Add tcss code
by Deepti Deshatty (Code Review) 17 May '21

17 May '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph, Deepti Deshatty. Deepti Deshatty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54089 ) Change subject: soc/intel/alderlake: mb/intel/sm: Add tcss code ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/54089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifce6abb0fce20e408931b904426131a42a5a4a36 Gerrit-Change-Number: 54089 Gerrit-PatchSet: 2 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Comment-Date: Mon, 17 May 2021 10:59:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021