coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: acpi/device: Add ability to generate proper _STA for PowerResource
by Raul Rangel (Code Review) 27 May '21

27 May '21

Attention is currently required from: Lance Zhao, Furquan Shaikh, Tim Wawrzynczak. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55027 ) Change subject: acpi/device: Add ability to generate proper _STA for PowerResource ...................................................................... Patch Set 2: (1 comment) File src/acpi/device.c: https://review.coreboot.org/c/coreboot/+/55027/comment/826d982c_3e9eb035 PS1, Line 605: acpigen_write_method > If you're going to go with reading GPIOs, this needs to be Serialized, so it won't run with _ON or _ […] Ah, good catch! We would still need code to set the initial state, and at that point, I don't really think having local state buys us much. It doesn't reduce the complexity of the code. PowerResources are not toggled often enough for a few extra instructions to make a difference. -- To view, visit https://review.coreboot.org/c/coreboot/+/55027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91410556db002c620fd9aaa99981457808da93a5 Gerrit-Change-Number: 55027 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 27 May 2021 22:18:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: acpi/device: Add ability to generate proper _STA for PowerResource
by Raul Rangel (Code Review) 27 May '21

27 May '21

Attention is currently required from: Lance Zhao, Furquan Shaikh, Tim Wawrzynczak. Hello Lance Zhao, Furquan Shaikh, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55027 to look at the new patch set (#2). Change subject: acpi/device: Add ability to generate proper _STA for PowerResource ...................................................................... acpi/device: Add ability to generate proper _STA for PowerResource acpi_device_add_power_res currently generates a `_STA` method hardcoded to ON. This change enables the ability to generate a `_STA` method that queries the status of the GPIOs to determine if the power resource is ON or OFF. The acpigen_write_power_res_STA method was copied from soc/intel/common/block/pcie/rtd3.c:pcie_rtd3_acpi_method_status. I also added support for checking the stop_gpio. BUG=b:184617186 TEST=Dump SSDT table for guybrush Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I91410556db002c620fd9aaa99981457808da93a5 --- M src/acpi/device.c M src/include/acpi/acpi_device.h 2 files changed, 40 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/55027/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91410556db002c620fd9aaa99981457808da93a5 Gerrit-Change-Number: 55027 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cbmem: Introduce "early" init hooks for console
by build bot (Jenkins) (Code Review) 27 May '21

27 May '21

Attention is currently required from: Aaron Durbin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54737 ) Change subject: cbmem: Introduce "early" init hooks for console ...................................................................... Patch Set 2: (2 comments) File src/include/cbmem.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120202): https://review.coreboot.org/c/coreboot/+/54737/comment/bec8fd76_42750dc4 PS2, Line 145: #define ROMSTAGE_CBMEM_INIT_HOOK_EARLY(init_fn_) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120202): https://review.coreboot.org/c/coreboot/+/54737/comment/15fbac21_fa6ccc25 PS2, Line 149: #define ROMSTAGE_CBMEM_INIT_HOOK_EARLY(init_fn_) __attribute__((unused)) \ macros should not use a trailing semicolon -- To view, visit https://review.coreboot.org/c/coreboot/+/54737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2c849a89f07a87d448ec1edbad4ce404afb0746 Gerrit-Change-Number: 54737 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Thu, 27 May 2021 22:13:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Inject Pre-CPU reset TS into timestamp_table
by Subrata Banik (Code Review) 27 May '21

27 May '21

Attention is currently required from: Bora Guvendik, Martin Roth, Tim Wawrzynczak, Paul Menzel, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51446 ) Change subject: soc/intel/alderlake: Inject Pre-CPU reset TS into timestamp_table ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/alderlake/telemetry.c: https://review.coreboot.org/c/coreboot/+/51446/comment/5e0f5cfc_52e685d2 PS5, Line 97: for (; hob && hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { : if (hob->type != HOB_TYPE_GUID_EXTENSION) : continue; : : res = fsp_hob_header_to_resource(hob); : : if (fsp_guid_compare(res->owner_guid, fsp_me_bios_payload_hob_guid)) { : get_pre_reset_ts_from_hob(hob); : return; : } : } > I think this just could be: […] Thanks Tim for your review, I will be joining back office from June 1st after my vacation for over. will address your feedback and ones in tree. -- To view, visit https://review.coreboot.org/c/coreboot/+/51446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4b7728d3da0d38dc0f1b465743486025dcf354b3 Gerrit-Change-Number: 51446 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 27 May 2021 22:12:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Enable WFC
by Tim Wawrzynczak (Code Review) 27 May '21

27 May '21

Attention is currently required from: Varshit B Pandya, Furquan Shaikh, Rizwan Qureshi, Meera Ravindranath, EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52013 ) Change subject: mb/google/brya: Enable WFC ...................................................................... Patch Set 8: Code-Review+1 (3 comments) File src/mainboard/google/brya/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/52013/comment/a9827e69_dfc71fd3 PS8, Line 179: 3 Could we get an SoC #define or enum for these? https://review.coreboot.org/c/coreboot/+/52013/comment/1428dc6c_5dca9179 PS8, Line 180: 1 Same with this, a set of #defines or enums would be nice File src/soc/intel/alderlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/52013/comment/efa7454b_16626660 PS1, Line 220: params->PchSerialIoI2cSdaPinMux[4] = GPIO_VER2_LP_MUXING_SERIALIO_I2C4_SDA_GPP_D13; : params->PchSerialIoI2cSclPinMux[4] = GPIO_VER2_LP_MUXING_SERIALIO_I2C4_SCL_GPP_D14; > ACK, this is not the final change we were trying out few things to see if the detection works Done -- To view, visit https://review.coreboot.org/c/coreboot/+/52013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5e9c28f255bdf86a68ce80a4f853be4e7c7ccfe Gerrit-Change-Number: 52013 Gerrit-PatchSet: 8 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-CC: Shobhit Srivastava <shobhit.srivastava(a)intel.com> Gerrit-CC: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 27 May 2021 22:10:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Varshit B Pandya <varshit.b.pandya(a)intel.com> Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/adl: Update power limits with SKU specific values
by Anil Kumar K (Code Review) 27 May '21

27 May '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Sumeet R Pawnikar, Rajasekhar Venkatanagapavan, Karthik Ramasubramanian. Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54926 ) Change subject: mb/adl: Update power limits with SKU specific values ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: HI Sumeet . can u pls add hashtag SYSCROS-58389 -- To view, visit https://review.coreboot.org/c/coreboot/+/54926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80ac9512306006b7cd9a78ae54e3757ec26261b1 Gerrit-Change-Number: 54926 Gerrit-PatchSet: 4 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rajasekhar Venkatanagapavan <rajasekhar.venkatanagapavan(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Rajasekhar Venkatanagapavan <rajasekhar.venkatanagapavan(a)intel.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 27 May 2021 22:08:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbmem: Introduce "early" init hooks for console
by Julius Werner (Code Review) 27 May '21

27 May '21

Attention is currently required from: Aaron Durbin. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54737 ) Change subject: cbmem: Introduce "early" init hooks for console ...................................................................... Patch Set 2: (1 comment) File src/include/cbmem.h: https://review.coreboot.org/c/coreboot/+/54737/comment/fe90c976_98f97cf8 PS1, Line 150: _unused_ > In file included from src/lib/cbmem_console.c:5: […] I hate that Gerrit doesn't send you emails for Jenkins comments, I never notice when I get a Verified -1... -- To view, visit https://review.coreboot.org/c/coreboot/+/54737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2c849a89f07a87d448ec1edbad4ce404afb0746 Gerrit-Change-Number: 54737 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Thu, 27 May 2021 22:08:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl: Add SKU specific power limits support
by Anil Kumar K (Code Review) 27 May '21

27 May '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Sumeet R Pawnikar, Rajasekhar Venkatanagapavan, Patrick Rudolph, Karthik Ramasubramanian. Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54676 ) Change subject: soc/intel/adl: Add SKU specific power limits support ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: HI Sumeet . can u pls add hashtag SYSCROS-58389 -- To view, visit https://review.coreboot.org/c/coreboot/+/54676 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1676e2b4d611cdc85e770f131d5b6d5ecd180be Gerrit-Change-Number: 54676 Gerrit-PatchSet: 6 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rajasekhar Venkatanagapavan <rajasekhar.venkatanagapavan(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Rajasekhar Venkatanagapavan <rajasekhar.venkatanagapavan(a)intel.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 27 May 2021 22:08:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbmem: Introduce "early" init hooks for console
by Julius Werner (Code Review) 27 May '21

27 May '21

Attention is currently required from: Julius Werner. Hello build bot (Jenkins), Aaron Durbin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54737 to look at the new patch set (#2). Change subject: cbmem: Introduce "early" init hooks for console ...................................................................... cbmem: Introduce "early" init hooks for console Over the last couple of years we have continuously added more and more CBMEM init hooks related to different independent components. One disadvantage of the API is that it can not model any dependencies between the different hooks, and their order is essentially undefined (based on link order). For most hooks this is not a problem, and in fact it's probably not a bad thing to discourage implicit dependencies between unrelated components like this... but one resource the components obviously all share is CBMEM, and since many CBMEM init hooks are used to create new CBMEM areas, the arbitrary order means that the order of these areas becomes unpredictable. Generally code using CBMEM should not care where exactly an area is allocated, but one exception is the persistent CBMEM console which relies (on a best effort basis) on always getting allocated at the same address on every boot. This is, technically, a hack, but it's a pretty harmless hack that has served us reasonably well so far and would be difficult to realize in a more robust way (without adding a lot of new infrastructure). Most of the time, coreboot will allocate the same CBMEM areas in the same order with the same sizes on every boot, and this all kinda works out (and since it's only a debug console, we don't need to be afraid of the odd one-in-a-million edge case breaking it). But one reproducible difference we can have between boots is the vboot boot mode (e.g. normal vs. recovery boot), and we had just kinda gotten lucky in the past that we didn't have differences in CBMEM allocations in different boot modes. With the recent addition of the RW_MCACHE (which does not get allocated in recovery mode), this is no longer true, and as a result CBMEM consoles can no longer persist between normal and recovery modes. The somewhat kludgy but simple solution is to just create a new class of specifically "early" CBMEM init hooks that will always run before all the others. While arbitrarily partitioning hooks into "early" and "not early" without any precise definition of what these things mean may seem a bit haphazard, I think it will be good enough in practice for the very few cases where this matters and beats building anything much more complicated (FWIW Linux has been doing something similar for years with device suspend/resume ordering). Since the current use case only relates to CBMEM allocation ordering and you can only really be "first" if you allocate in romstage, the "early" hook is only available in romstage for now (could be expanded later if we find a use case for it). Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: If2c849a89f07a87d448ec1edbad4ce404afb0746 --- M src/include/cbmem.h M src/lib/cbmem_console.c M src/lib/program.ld 3 files changed, 26 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/54737/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2c849a89f07a87d448ec1edbad4ce404afb0746 Gerrit-Change-Number: 54737 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: acpi/device: Add ability to generate proper _STA for PowerResource
by Tim Wawrzynczak (Code Review) 27 May '21

27 May '21

Attention is currently required from: Lance Zhao, Raul Rangel, Furquan Shaikh. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55027 ) Change subject: acpi/device: Add ability to generate proper _STA for PowerResource ...................................................................... Patch Set 1: (1 comment) File src/acpi/device.c: https://review.coreboot.org/c/coreboot/+/55027/comment/3485efe8_f881caa1 PS1, Line 605: acpigen_write_method If you're going to go with reading GPIOs, this needs to be Serialized, so it won't run with _ON or _OFF or be reentrant. Honestly though, my thought for this was always to have a Name in the PowerResource that stores the state, like so: ``` PowerResource (FOO) { Name (STA, 0) // or maybe some way to set the default state if it's already ON Method (_ON) { ... // GPIOs STA = 1 } Method (_OFF) { .. // GPIOs STA = 0 } Method (_STA) { Return (STA) } } ``` WDYT? It's a little simpler (and faster too) -- To view, visit https://review.coreboot.org/c/coreboot/+/55027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91410556db002c620fd9aaa99981457808da93a5 Gerrit-Change-Number: 55027 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Thu, 27 May 2021 22:03:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021