coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: drivers/amd/i2s_machine_dev: Populate _WOV ACPI method
by Karthik Ramasubramanian (Code Review) 27 May '21

27 May '21

Attention is currently required from: Raul Rangel, Furquan Shaikh, Yu-hsuan Hsu. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55029 ) Change subject: drivers/amd/i2s_machine_dev: Populate _WOV ACPI method ...................................................................... Patch Set 1: (1 comment) File src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c: https://review.coreboot.org/c/coreboot/+/55029/comment/80e37516_0a873474 PS1, Line 73: _WOV > Is it safe to expose this as 0 for older platforms too? e.g. Picasso. For Picasso, dmic_select_gpio is configured and so this method will return 1 there too. But I am not sure, if it should return 1 or 0 in previous SoC generation. I can check with audio experts and update the code accordingly here. -- To view, visit https://review.coreboot.org/c/coreboot/+/55029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide84f45f5ea2ae42d5efe71ac6d1595886157045 Gerrit-Change-Number: 55029 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Comment-Date: Thu, 27 May 2021 23:05:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Update flashmap descriptor to add RW_UCODE_STAGED
by Furquan Shaikh (Code Review) 27 May '21

27 May '21

Attention is currently required from: Meera Ravindranath. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54758 ) Change subject: mb/google/brya: Update flashmap descriptor to add RW_UCODE_STAGED ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: Keeping this as -2 since the decision is still pending if brya will be enabling this feature. -- To view, visit https://review.coreboot.org/c/coreboot/+/54758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5a41d9527e2666b51a3ab7cd327663fc9894eeb Gerrit-Change-Number: 54758 Gerrit-PatchSet: 1 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Comment-Date: Thu, 27 May 2021 23:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/amd/i2s_machine_dev: Populate _WOV ACPI method
by Furquan Shaikh (Code Review) 27 May '21

27 May '21

Attention is currently required from: Raul Rangel, Yu-hsuan Hsu, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55029 ) Change subject: drivers/amd/i2s_machine_dev: Populate _WOV ACPI method ...................................................................... Patch Set 1: (1 comment) File src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c: https://review.coreboot.org/c/coreboot/+/55029/comment/f254f272_8e26ccae PS1, Line 73: _WOV Is it safe to expose this as 0 for older platforms too? e.g. Picasso. -- To view, visit https://review.coreboot.org/c/coreboot/+/55029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide84f45f5ea2ae42d5efe71ac6d1595886157045 Gerrit-Change-Number: 55029 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 27 May 2021 23:01:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Indicate the presence of ACP dmic
by Karthik Ramasubramanian (Code Review) 27 May '21

27 May '21

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55030 ) Change subject: mb/google/guybrush: Indicate the presence of ACP dmic ...................................................................... mb/google/guybrush: Indicate the presence of ACP dmic In order to enable ACP DMIC hardware runtime detection, indicate that ACP DMIC is present. BUG=b:182960979 TEST=Build and boot to OS in guybrush. Ensure that the _WOV ACPI method is populated in the ACP device. Change-Id: I9a53d158ed08a6b46c29bcb8fe3a2a0d108bd6cd Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M src/mainboard/google/guybrush/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/55030/1 diff --git a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb index c778914..b935b42 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb @@ -273,6 +273,7 @@ device ref acp on chip drivers/amd/i2s_machine_dev register "hid" = ""AMDI5682"" + register "dmic_present" = "1" device generic 0.0 on end end end # Audio -- To view, visit https://review.coreboot.org/c/coreboot/+/55030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a53d158ed08a6b46c29bcb8fe3a2a0d108bd6cd Gerrit-Change-Number: 55030 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/amd/i2s_machine_dev: Populate _WOV ACPI method
by Karthik Ramasubramanian (Code Review) 27 May '21

27 May '21

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55029 ) Change subject: drivers/amd/i2s_machine_dev: Populate _WOV ACPI method ...................................................................... drivers/amd/i2s_machine_dev: Populate _WOV ACPI method In order to support Audio Co-processor (ACP) DMIC hardware runtime detection on the platform, ACPI _WOV method is populated on the concerned ACP device. This method returns the ACPI Integer value as 1 if ACP DMIC exists on the platform or else it will return zero. Since DMIC select GPIO is optional, add a flag to indicate the presence of DMIC. BUG=b:182960979 TEST=Build and boot to OS in guybrush. Ensure that the _WOV ACPI method is populated under the scope of ACP device. Scope (\_SB.PCI0.GP41.ACPD) { Device (I2S0) { Name (_HID, "AMDI5682") // _HID: Hardware ID Name (_UID, Zero) // _UID: Unique ID Name (_DDN, "I2S machine driver") // _DDN: DOS Device Name Method (_STA, 0, NotSerialized) // _STA: Status { Return (0x0F) } Method (_WOV, 0, NotSerialized) { Return (One) } } } Change-Id: Ide84f45f5ea2ae42d5efe71ac6d1595886157045 Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M src/drivers/amd/i2s_machine_dev/chip.h M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/55029/1 diff --git a/src/drivers/amd/i2s_machine_dev/chip.h b/src/drivers/amd/i2s_machine_dev/chip.h index 0ca00a8..a8e94ca 100644 --- a/src/drivers/amd/i2s_machine_dev/chip.h +++ b/src/drivers/amd/i2s_machine_dev/chip.h @@ -17,6 +17,12 @@ * all the mics and select the right channel based on the use-case. */ struct acpi_gpio dmic_select_gpio; + + /* + * DMIC present (optional) to support ACP DMIC hardware runtime detection on the + * platform. + */ + bool dmic_present; }; #endif /* ___DRIVERS_AMD_I2S_MACHINE_DEV_H__ */ diff --git a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c index 7bd256d..06b8c00 100644 --- a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c +++ b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c @@ -69,6 +69,14 @@ if (dmic_select_gpio->pin_count) i2s_machine_dev_fill_crs_dsd(path, dmic_select_gpio); + /* For ACP DMIC hardware runtime detection on the platform, _WOV method is populated. */ + acpigen_write_method("_WOV", 0); + if (dmic_select_gpio->pin_count || cfg->dmic_present) + acpigen_write_return_integer(1); + else + acpigen_write_return_integer(0); + acpigen_pop_len(); /* Method */ + acpigen_pop_len(); /* Device */ acpigen_pop_len(); /* Scope */ -- To view, visit https://review.coreboot.org/c/coreboot/+/55029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide84f45f5ea2ae42d5efe71ac6d1595886157045 Gerrit-Change-Number: 55029 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/guybrush/var/guybrush: Reconfigure left speaker amplifier
by Karthik Ramasubramanian (Code Review) 27 May '21

27 May '21

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55028 ) Change subject: mb/google/guybrush/var/guybrush: Reconfigure left speaker amplifier ...................................................................... mb/google/guybrush/var/guybrush: Reconfigure left speaker amplifier In order to resolve the I2C address conflict with another peripheral in the upcoming hardware build, left speaker amplifier I2C address is reconfigured. BUG=b:188539052 TEST=Build Guybrush mainboard. Change-Id: I69a7e7dd65a459c2e5629ada1dea1f1660dd9990 Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M src/mainboard/google/guybrush/variants/guybrush/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/55028/1 diff --git a/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb b/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb index fb8d9ca..a8d69b5 100644 --- a/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb +++ b/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb @@ -140,6 +140,12 @@ register "uid" = "1" device i2c 29 on end end + chip drivers/i2c/generic + register "hid" = ""10EC1019"" + register "desc" = ""Realtek SPK AMP L"" + register "uid" = "0" + device i2c 2a on end + end end # I2C2 device ref uart_1 on -- To view, visit https://review.coreboot.org/c/coreboot/+/55028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69a7e7dd65a459c2e5629ada1dea1f1660dd9990 Gerrit-Change-Number: 55028 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Documentation: Fix up toctree
by Michael Niewöhner (Code Review) 27 May '21

27 May '21

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55020 ) Change subject: Documentation: Fix up toctree ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If959fa63d4ddbc3916c49c5ad6602e76b12a7e60 Gerrit-Change-Number: 55020 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 May 2021 22:47:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Fix named link
by Michael Niewöhner (Code Review) 27 May '21

27 May '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55019 ) Change subject: Documentation: Fix named link ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98ebe714e57f50017755eed7888f0dd2637a3066 Gerrit-Change-Number: 55019 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 27 May 2021 22:46:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Update vboot submodule to upstream main
by Daisuke Nojiri (Code Review) 27 May '21

27 May '21

Attention is currently required from: Julius Werner. Hello build bot (Jenkins), Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55026 to look at the new patch set (#2). Change subject: Update vboot submodule to upstream main ...................................................................... Update vboot submodule to upstream main Updating from commit id e681c37: change node locked version expectations to commit id b38e3a63: cros_ec: Use boot mode to check if EC can be trusted Change-Id: Id6de185af85a61a3843b302fef6fa0d4d3c17aef Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/55026/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6de185af85a61a3843b302fef6fa0d4d3c17aef Gerrit-Change-Number: 55026 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vboot: Add VB2_CONTEXT_EC_TRUSTED
by Daisuke Nojiri (Code Review) 27 May '21

27 May '21

Attention is currently required from: Joel Kitching, Aaron Durbin. Hello build bot (Jenkins), Joel Kitching, Furquan Shaikh, Julius Werner, Aaron Durbin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54099 to look at the new patch set (#8). Change subject: vboot: Add VB2_CONTEXT_EC_TRUSTED ...................................................................... vboot: Add VB2_CONTEXT_EC_TRUSTED This patch makes coreboot set VB2_CONTEXT_EC_TRUSTED based on the EC"s boot mode. Vboot will check VB2_CONTEXT_EC_TRUSTED to determine whether it can enter recovery mode or not. BUG=b:180927027, b:187871195 BRANCH=none TEST=build Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> Change-Id: I9fa09dd7ae5baa1efb4e1ed4f0fe9a6803167c93 --- M src/security/vboot/vboot_logic.c 1 file changed, 12 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/54099/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/54099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fa09dd7ae5baa1efb4e1ed4f0fe9a6803167c93 Gerrit-Change-Number: 54099 Gerrit-PatchSet: 8 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Joel Kitching <kitching(a)google.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021