coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: soc/intel/tigerlake: Hook up FSP repository
by Wonkyu Kim (Code Review) 27 May '21

27 May '21

Attention is currently required from: Felix Singer, Tim Wawrzynczak, Subrata Banik, Srinidhi N Kaushik, Raj Astekar, Nathaniel L Desimone. Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48713 ) Change subject: soc/intel/tigerlake: Hook up FSP repository ...................................................................... Patch Set 13: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/48713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e694b91be7734dd98665051a6a3d9eccab7dac7 Gerrit-Change-Number: 48713 Gerrit-PatchSet: 13 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Duncan Laurie Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.corp-partner.google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Comment-Date: Thu, 27 May 2021 20:53:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/majolica: enable crypto coprocessor PCIe device
by Felix Held (Code Review) 27 May '21

27 May '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54963 ) Change subject: mb/amd/majolica: enable crypto coprocessor PCIe device ...................................................................... mb/amd/majolica: enable crypto coprocessor PCIe device This fixes the following error from the Linux kernel: ccp 0000:03:00.2: ioremap failed ccp 0000:03:00.2: initialization failed ccp: probe of 0000:03:00.2 failed with error -12 BUG=b:186575712,b:189202985 Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Id1c6a6cbbdda2cb22e81e2b52b364617d6765e09 Reviewed-on: https://review.coreboot.org/c/coreboot/+/54963 Reviewed-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/amd/majolica/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Marshall Dawson: Looks good to me, approved diff --git a/src/mainboard/amd/majolica/devicetree.cb b/src/mainboard/amd/majolica/devicetree.cb index 8f4fc9b..dc73b84 100644 --- a/src/mainboard/amd/majolica/devicetree.cb +++ b/src/mainboard/amd/majolica/devicetree.cb @@ -27,6 +27,7 @@ device ref gpp_bridge_5 on end device ref gpp_bridge_a on # Internal GPP Bridge 0 to Bus A device ref gfx on end # Internal GPU (GFX) + device ref crypto on end # Crypto Coprocessor device ref xhci_0 on # USB 3.1 (USB0) chip drivers/usb/acpi device ref xhci_0_root_hub on -- To view, visit https://review.coreboot.org/c/coreboot/+/54963 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1c6a6cbbdda2cb22e81e2b52b364617d6765e09 Gerrit-Change-Number: 54963 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/guybrush,mancomb: enable crypto coprocessor PCIe device
by Felix Held (Code Review) 27 May '21

27 May '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54962 ) Change subject: mb/google/guybrush,mancomb: enable crypto coprocessor PCIe device ...................................................................... mb/google/guybrush,mancomb: enable crypto coprocessor PCIe device This fixes the following error from the Linux kernel: ccp 0000:03:00.2: ioremap failed ccp 0000:03:00.2: initialization failed ccp: probe of 0000:03:00.2 failed with error -12 BUG=b:186575712,b:189202985 Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I5cbc620001d3c21c538b62ab2811b6e07269feb2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/54962 Reviewed-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/guybrush/variants/baseboard/devicetree.cb M src/mainboard/google/mancomb/variants/baseboard/devicetree.cb 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Marshall Dawson: Looks good to me, approved diff --git a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb index 18e7012..c778914 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb @@ -193,6 +193,7 @@ device ref gpp_bridge_a on # Internal GPP Bridge 0 to Bus A device ref gfx on end # Internal GPU (GFX) device ref gfx_hda on end # GFX HD Audio Controller + device ref crypto on end # Crypto Coprocessor device ref xhci_0 on # USB 3.1 (USB0) chip drivers/usb/acpi device ref xhci_0_root_hub on diff --git a/src/mainboard/google/mancomb/variants/baseboard/devicetree.cb b/src/mainboard/google/mancomb/variants/baseboard/devicetree.cb index 8f89dd0..166d6f2 100644 --- a/src/mainboard/google/mancomb/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/mancomb/variants/baseboard/devicetree.cb @@ -61,6 +61,7 @@ device ref gpp_bridge_a on # Internal GPP Bridge 0 to Bus A device ref gfx on end # Internal GPU (GFX) device ref gfx_hda on end # GFX HD Audio Controller + device ref crypto on end # Crypto Coprocessor device ref xhci_0 on # USB 3.1 (USB0) chip drivers/usb/acpi device ref xhci_0_root_hub on -- To view, visit https://review.coreboot.org/c/coreboot/+/54962 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5cbc620001d3c21c538b62ab2811b6e07269feb2 Gerrit-Change-Number: 54962 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/intel/tigerlake: Hook up FSP repository
by Srinidhi N Kaushik (Code Review) 27 May '21

27 May '21

Attention is currently required from: Felix Singer, Wonkyu Kim, Tim Wawrzynczak, Subrata Banik, Raj Astekar, Nathaniel L Desimone. Srinidhi N Kaushik has uploaded a new patch set (#13) to the change originally created by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/48713 ) Change subject: soc/intel/tigerlake: Hook up FSP repository ...................................................................... soc/intel/tigerlake: Hook up FSP repository Select `HAVE_INTEL_FSP_REPO` so that the FSP binary from the FSP repository is used by default. Also, use the FSP headers from the FSP repository and adjust some UPD names so that coreboot is able to use them. Also added new config FSP_TYPE_CLIENT/IOT. Respective mainboard Kconfigs to select right FSP_TYPE when using FSP repository. BUG=b:175957775 BRANCH=none Change-Id: I5e694b91be7734dd98665051a6a3d9eccab7dac7 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Signed-off-by: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> --- M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/volteer/Kconfig M src/mainboard/intel/tglrvp/Kconfig M src/soc/intel/tigerlake/Kconfig M src/soc/intel/tigerlake/fsp_params.c M src/soc/intel/tigerlake/meminit.c 6 files changed, 57 insertions(+), 37 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/48713/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/48713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e694b91be7734dd98665051a6a3d9eccab7dac7 Gerrit-Change-Number: 48713 Gerrit-PatchSet: 13 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Duncan Laurie Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.corp-partner.google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush: Unassign I2C1 and set GPIOs to input/no-pull
by Raul Rangel (Code Review) 27 May '21

27 May '21

Attention is currently required from: Martin Roth. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55022 ) Change subject: mb/google/guybrush: Unassign I2C1 and set GPIOs to input/no-pull ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I244b398c695683fa4e217d83aa0498bcd8f0fbbe Gerrit-Change-Number: 55022 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Thu, 27 May 2021 20:29:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: Fix printf format errors in SMM module loader
by Benjamin Doron (Code Review) 27 May '21

27 May '21

Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52428 ) Change subject: cpu/x86/smm: Fix printf format errors in SMM module loader ...................................................................... Patch Set 7: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/52428/comment/6cd8e154_356c5948 PS7, Line 9: GCC 10.2.1 > It’s with 64-bit and -m32, right? Yes. Patchset: PS7: > Hmm, I duplicated your work: […] PRIxPTR vs %lx is a stylistic choice. I don't mind which fix is merged. -- To view, visit https://review.coreboot.org/c/coreboot/+/52428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I629de5b0604300b6cf14730161b6b164c8fac723 Gerrit-Change-Number: 52428 Gerrit-PatchSet: 7 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 27 May 2021 20:26:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: Fix printf format errors in SMM module loader
by Paul Menzel (Code Review) 27 May '21

27 May '21

Attention is currently required from: Nico Huber, Benjamin Doron, Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52428 ) Change subject: cpu/x86/smm: Fix printf format errors in SMM module loader ...................................................................... Patch Set 7: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/52428/comment/48917c36_8e3d30fb PS7, Line 9: GCC 10.2.1 It’s with 64-bit and -m32, right? Patchset: PS7: Hmm, I duplicated your work: 1. https://review.coreboot.org/c/coreboot/+/54341 2. https://review.coreboot.org/c/coreboot/+/54342 3. https://review.coreboot.org/c/coreboot/+/54343 -- To view, visit https://review.coreboot.org/c/coreboot/+/52428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I629de5b0604300b6cf14730161b6b164c8fac723 Gerrit-Change-Number: 52428 Gerrit-PatchSet: 7 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 27 May 2021 20:11:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add firmware configuration probing for audio
by Paul Menzel (Code Review) 27 May '21

27 May '21

Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Sathya Prakash M R, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54716 ) Change subject: mb/google/brya: Add firmware configuration probing for audio ...................................................................... Patch Set 6: (3 comments) File src/mainboard/google/brya/variants/brya0/fw_config.c: https://review.coreboot.org/c/coreboot/+/54716/comment/67aa6d99_309dd32b PS6, Line 61: printk(BIOS_INFO, "FW config is not provisioned or audio is disabled.\n"); This sounds like a warning or notice to me. https://review.coreboot.org/c/coreboot/+/54716/comment/44a1f8d2_5a0664d5 PS6, Line 61: FW config is not provisioned or audio is disabled. … disable all pads. (or something similar) https://review.coreboot.org/c/coreboot/+/54716/comment/9a1ed4a3_4b721792 PS6, Line 69: printk(BIOS_INFO, "Configure GPIOs for SoundWire audio.\n"); I’d also put the model number into the message. -- To view, visit https://review.coreboot.org/c/coreboot/+/54716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f159442516830f9d304d78c83f070e4fcff4a37 Gerrit-Change-Number: 54716 Gerrit-PatchSet: 6 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Attention: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 27 May 2021 20:02:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x8/include/bert_storage: introduce and use bert_generate_ssdt
by Felix Held (Code Review) 27 May '21

27 May '21

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55024 ) Change subject: arch/x8/include/bert_storage: introduce and use bert_generate_ssdt ...................................................................... arch/x8/include/bert_storage: introduce and use bert_generate_ssdt Since bert_errors_present() is only available when ACPI_BERT is selected the ACPI table generation code needs to check that before calling the function, so add bert_generate_ssdt that returns false when ACPI_BERT isn't selected or the return value of bert_errors_present() when ACPI_BERT is selected. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ia955f627c190ea38e05b5aaedc7cb2d030274e83 --- M src/arch/x86/include/arch/bert_storage.h M src/soc/amd/stoneyridge/northbridge.c 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/55024/1 diff --git a/src/arch/x86/include/arch/bert_storage.h b/src/arch/x86/include/arch/bert_storage.h index 6378333..794fb83 100644 --- a/src/arch/x86/include/arch/bert_storage.h +++ b/src/arch/x86/include/arch/bert_storage.h @@ -56,6 +56,11 @@ size_t bert_storage_remaining(void); /* Find if errors were added, a BERT region is present, and ACPI table needed */ bool bert_errors_present(void); +/* The BERT SSDT should only be generated when BERT support is enabled and there's an error */ +static inline bool bert_generate_ssdt(void) +{ + return CONFIG(ACPI_BERT) && bert_errors_present(); +} /* Get the number of entries associated with status */ static inline size_t bert_entry_count(acpi_generic_error_status_t *status) diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c index eb59cdc..1998e1b 100644 --- a/src/soc/amd/stoneyridge/northbridge.c +++ b/src/soc/amd/stoneyridge/northbridge.c @@ -239,7 +239,7 @@ current += hest->header.length; /* BERT */ - if (CONFIG(ACPI_BERT) && bert_errors_present()) { + if (bert_generate_ssdt()) { /* Skip the table if no errors are present. ACPI driver reports * a table with a 0-length region: * BERT: [Firmware Bug]: table invalid. -- To view, visit https://review.coreboot.org/c/coreboot/+/55024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia955f627c190ea38e05b5aaedc7cb2d030274e83 Gerrit-Change-Number: 55024 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: arch/x86/acpi_bert_storage: change return type of bert_errors_present
by Felix Held (Code Review) 27 May '21

27 May '21

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55023 ) Change subject: arch/x86/acpi_bert_storage: change return type of bert_errors_present ...................................................................... arch/x86/acpi_bert_storage: change return type of bert_errors_present The return value is a boolean, so use the bool type. Also add the types.h header to have the bool type defined. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I13d6472deeb26ba92d257761df069e32d9b2e5d4 --- M src/arch/x86/acpi_bert_storage.c M src/arch/x86/include/arch/bert_storage.h 2 files changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/55023/1 diff --git a/src/arch/x86/acpi_bert_storage.c b/src/arch/x86/acpi_bert_storage.c index b07b67e..550f4a3 100644 --- a/src/arch/x86/acpi_bert_storage.c +++ b/src/arch/x86/acpi_bert_storage.c @@ -8,6 +8,7 @@ #include <acpi/acpi.h> #include <arch/bert_storage.h> #include <string.h> +#include <types.h> /* BERT region management: Allow the chipset to determine the specific * location of the BERT region. We find that base and size, then manage @@ -32,7 +33,7 @@ return bert_region_broken ? 0 : bert_region_size - bert_region_used; } -int bert_errors_present(void) +bool bert_errors_present(void) { return bert_region_broken ? 0 : !!bert_region_used; } diff --git a/src/arch/x86/include/arch/bert_storage.h b/src/arch/x86/include/arch/bert_storage.h index 0d373e1..6378333 100644 --- a/src/arch/x86/include/arch/bert_storage.h +++ b/src/arch/x86/include/arch/bert_storage.h @@ -3,8 +3,8 @@ #ifndef _BERT_STORAGE_H_ #define _BERT_STORAGE_H_ -#include <stdint.h> #include <acpi/acpi.h> +#include <types.h> /* Items in the BERT region * @@ -55,7 +55,7 @@ /* Get amount of available storage left for error info */ size_t bert_storage_remaining(void); /* Find if errors were added, a BERT region is present, and ACPI table needed */ -int bert_errors_present(void); +bool bert_errors_present(void); /* Get the number of entries associated with status */ static inline size_t bert_entry_count(acpi_generic_error_status_t *status) -- To view, visit https://review.coreboot.org/c/coreboot/+/55023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13d6472deeb26ba92d257761df069e32d9b2e5d4 Gerrit-Change-Number: 55023 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021