coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: mb/prodrive/hermes: Fix eeprom reading
by Angel Pons (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Patrick Rudolph, Christian Walter, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52207 ) Change subject: mb/prodrive/hermes: Fix eeprom reading ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/mainboard/prodrive/hermes/eeprom.c: https://review.coreboot.org/c/coreboot/+/52207/comment/fd3a2053_80740e5c PS2, Line 125: memcpy(writePointer, tmp, bytes_to_copy); Shouldn't this be: uint8_t writePointer = (uint8_t *)blob + write_offset + i; writePointer[0] = tmp[0]; if (size - i > 1) writePointer[1] = tmp[1]; Otherwise, we will write one byte too many when size is odd and greater than 1 (e.g. 3). I was writing the above for Patchset 1, but you pushed Patchset 2 in the meantime. Still, I'd rather not use memcpy here. -- To view, visit https://review.coreboot.org/c/coreboot/+/52207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic08cf01d800babd4a9176dfb2337411b789040f3 Gerrit-Change-Number: 52207 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 09 Apr 2021 09:28:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/prodrive/hermes: Fix eeprom reading
by Arthur Heymans (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Patrick Rudolph, Christian Walter. Hello Patrick Rudolph, Christian Walter, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52207 to look at the new patch set (#2). Change subject: mb/prodrive/hermes: Fix eeprom reading ...................................................................... mb/prodrive/hermes: Fix eeprom reading The logic for bytes to copy to the function input pointer was wrong. What it did was to loop over all 2 bytes that need to be read and only copy the first byte. Change-Id: Ic08cf01d800babd4a9176dfb2337411b789040f3 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/prodrive/hermes/eeprom.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/52207/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic08cf01d800babd4a9176dfb2337411b789040f3 Gerrit-Change-Number: 52207 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/prodrive/hermes: Fix eeprom reading
by Arthur Heymans (Code Review) 09 Apr '21

09 Apr '21

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52207 ) Change subject: mb/prodrive/hermes: Fix eeprom reading ...................................................................... mb/prodrive/hermes: Fix eeprom reading The logic for bytes to copy to the function input pointer was wrong. What it did was to loop over all 2 bytes that need to be read and only copy the first byte. Change-Id: Ic08cf01d800babd4a9176dfb2337411b789040f3 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/prodrive/hermes/eeprom.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/52207/1 diff --git a/src/mainboard/prodrive/hermes/eeprom.c b/src/mainboard/prodrive/hermes/eeprom.c index 6f61b30..8d2c056 100644 --- a/src/mainboard/prodrive/hermes/eeprom.c +++ b/src/mainboard/prodrive/hermes/eeprom.c @@ -121,10 +121,8 @@ /* Write to UPD */ uint8_t *writePointer = (uint8_t *)blob + write_offset + i; - if (size > 1 && (size % 2 == 0)) - memcpy(writePointer, tmp, 2); - else - *writePointer = tmp[0]; + const size_t bytes_to_copy = size >= 2 ? 2 : 1; + memcpy(writePointer, tmp, bytes_to_copy); } /* Restore I2C_EN bit */ -- To view, visit https://review.coreboot.org/c/coreboot/+/52207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic08cf01d800babd4a9176dfb2337411b789040f3 Gerrit-Change-Number: 52207 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F
by Angel Pons (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Felix Singer, Christian Walter, Arthur Heymans, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 ) Change subject: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F ...................................................................... Patch Set 68: (1 comment) File MAINTAINERS: https://review.coreboot.org/c/coreboot/+/37441/comment/792fd224_6d8c2797 PS67, Line 438: s > it's not for consistency but to make it actually work. […] Oh, I recall now. Yeah, having a linter script for this sounds like a good idea. -- To view, visit https://review.coreboot.org/c/coreboot/+/37441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ab1cb9462607b9af068bc2374508d99c60d0a30 Gerrit-Change-Number: 37441 Gerrit-PatchSet: 68 Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Guido Beyer @ Prodrive Technologies <guido.beyer(a)prodrive-technologies.com> Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stef van Os <stef.van.os(a)prodrive-technologies.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wouter.eckhardt(a)prodrive-technologies.com Gerrit-CC: Jonas Löffelholz Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 09 Apr 2021 09:18:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: dsi: fine tune the delta time for EoTp
by Yu-Ping Wu (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: jitao shi. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51432 ) Change subject: soc/mediatek: dsi: fine tune the delta time for EoTp ...................................................................... Patch Set 6: (1 comment) File src/soc/mediatek/common/dsi.c: https://review.coreboot.org/c/coreboot/+/51432/comment/d1b4381a_00ba6e30 PS2, Line 207: 10 > Hi Yuping, […] From coreboot header: /* disable EoT packets in HS mode */ MIPI_DSI_MODE_EOT_PACKET = BIT(9), I really think we should make coreboot consistent with kernel. -- To view, visit https://review.coreboot.org/c/coreboot/+/51432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0666068cfb04b78eb706278814163f050da32b9c Gerrit-Change-Number: 51432 Gerrit-PatchSet: 6 Gerrit-Owner: jitao shi <jitao.shi(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-CC: Jitao Shi <jitao.shi(a)mediatek.corp-partner.google.com> Gerrit-CC: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: jitao shi <jitao.shi(a)mediatek.com> Gerrit-Comment-Date: Fri, 09 Apr 2021 09:15:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Chen-Tsung Hsieh <chentsung(a)google.com> Comment-In-Reply-To: Chen-Tsung Hsieh <chentsung(a)chromium.org> Comment-In-Reply-To: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Jitao Shi <jitao.shi(a)mediatek.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/vilboz: Update register parameters for sx9324 tuning
by Kangheui Won (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Frank Wu, Martin Roth, EricR Lai. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51936 ) Change subject: mb/google/zork/vilboz: Update register parameters for sx9324 tuning ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51936/comment/58d57663_302286de PS2, Line 9: According to b/172397658, to fine-tune the sx9324 with new parameters. It'd better to state that these numbers came from RF testing rather than referencing a bug here. -- To view, visit https://review.coreboot.org/c/coreboot/+/51936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief85bc61952144a1d7a151100d89938517078ab4 Gerrit-Change-Number: 51936 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 09 Apr 2021 09:13:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: dsi: fine tune the delta time for EoTp
by Chen-Tsung Hsieh (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: jitao shi. Chen-Tsung Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51432 ) Change subject: soc/mediatek: dsi: fine tune the delta time for EoTp ...................................................................... Patch Set 6: (1 comment) File src/soc/mediatek/common/dsi.c: https://review.coreboot.org/c/coreboot/+/51432/comment/dc98ffcd_aaaa73d7 PS2, Line 207: 10 > According to https://patchwork.kernel.org/project/linux-mediatek/patch/20210201033603.12…. […] Hi Yuping, MIPI_DSI_MODE_EOT_PACKET is a disable bit in kernel.(https://chromium.googlesource.com/chromiumos/third_party/kernel/+/r… But it is an enable bit in coreboot. (https://review.coreboot.org/c/coreboot/+/51432/2..6/src/soc/mediatek/common…) -- To view, visit https://review.coreboot.org/c/coreboot/+/51432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0666068cfb04b78eb706278814163f050da32b9c Gerrit-Change-Number: 51432 Gerrit-PatchSet: 6 Gerrit-Owner: jitao shi <jitao.shi(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-CC: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-CC: Jitao Shi <jitao.shi(a)mediatek.corp-partner.google.com> Gerrit-CC: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: jitao shi <jitao.shi(a)mediatek.com> Gerrit-Comment-Date: Fri, 09 Apr 2021 09:12:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Chen-Tsung Hsieh <chentsung(a)google.com> Comment-In-Reply-To: Chen-Tsung Hsieh <chentsung(a)chromium.org> Comment-In-Reply-To: Shaoming Chen <shaoming.chen(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Jitao Shi <jitao.shi(a)mediatek.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/intel/common: use lapicid api
by Angel Pons (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Wonkyu Kim, Subrata Banik, Raj Astekar, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51725 ) Change subject: cpu/intel/common: use lapicid api ...................................................................... Patch Set 11: Code-Review-1 (1 comment) File src/cpu/intel/common/hyperthreading.c: https://review.coreboot.org/c/coreboot/+/51725/comment/ef6926d7_6be3738d PS11, Line 26: apic_ids = lapicid(); > Um, how is this equivalent to the code before? The SDM says this is the "maximum number of addressable IDs for logical processors in this physical package": https://imgur.com/E89ugCr.png -- To view, visit https://review.coreboot.org/c/coreboot/+/51725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ca5b09ae67941adcc07dfafdfe4ba78b0f81009 Gerrit-Change-Number: 51725 Gerrit-PatchSet: 11 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 09 Apr 2021 09:05:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F
by Michael Niewöhner (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Felix Singer, Christian Walter, Angel Pons, Arthur Heymans. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 ) Change subject: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F ...................................................................... Patch Set 68: (1 comment) File MAINTAINERS: https://review.coreboot.org/c/coreboot/+/37441/comment/e58ae757_b5e3e8a5 PS67, Line 438: s > I'll add it for consistency. it's not for consistency but to make it actually work. without the slash, gerrit only matches the folder itself. I definitely should add a linter script for that... -- To view, visit https://review.coreboot.org/c/coreboot/+/37441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ab1cb9462607b9af068bc2374508d99c60d0a30 Gerrit-Change-Number: 37441 Gerrit-PatchSet: 68 Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Guido Beyer @ Prodrive Technologies <guido.beyer(a)prodrive-technologies.com> Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stef van Os <stef.van.os(a)prodrive-technologies.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wouter.eckhardt(a)prodrive-technologies.com Gerrit-CC: Jonas Löffelholz Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 09 Apr 2021 08:50:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/intel/common: use lapicid api
by Angel Pons (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Wonkyu Kim, Subrata Banik, Raj Astekar, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51725 ) Change subject: cpu/intel/common: use lapicid api ...................................................................... Patch Set 11: (1 comment) File src/cpu/intel/common/hyperthreading.c: https://review.coreboot.org/c/coreboot/+/51725/comment/8e89d73f_8fbc8968 PS11, Line 26: apic_ids = lapicid(); Um, how is this equivalent to the code before? -- To view, visit https://review.coreboot.org/c/coreboot/+/51725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ca5b09ae67941adcc07dfafdfe4ba78b0f81009 Gerrit-Change-Number: 51725 Gerrit-PatchSet: 11 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 09 Apr 2021 08:45:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021