coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: soc/intel/common: Allow to override power on after failure
by Angel Pons (Code Review) 09 Apr '21

09 Apr '21

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47960 ) Change subject: soc/intel/common: Allow to override power on after failure ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/47960 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4902930f288c1ab9c0cb4d1e79cf2f7d481e4a2 Gerrit-Change-Number: 47960 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/prodrive/hermes: Override power state after failure
by Angel Pons (Code Review) 09 Apr '21

09 Apr '21

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47961 ) Change subject: mb/prodrive/hermes: Override power state after failure ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/47961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86dde3ce052c663bfc1e7a3f9cfa70223000be91 Gerrit-Change-Number: 47961 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/guybrush/var/guybrush: Add FPMCU configration
by Ivy Jian (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Furquan Shaikh, Bhanu Prakash Maiya, EricR Lai. Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52181 ) Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration ...................................................................... Patch Set 9: (1 comment) File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb: https://review.coreboot.org/c/coreboot/+/52181/comment/f381d17a_e9096054 PS9, Line 113: register "has_power_resource" = "1" > For GPIO_11, we will have to ensure that there is an external PD so that the default state is driven […] Can you please probe the signals from reset to see what they look like? ==>Hi Furquan, I posted it in b/182201937 in details. It seems both GPIO_11(reset) and GPIO_32(enable) will become high before calling early_gpio_table. -- To view, visit https://review.coreboot.org/c/coreboot/+/52181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c56b0db193be6804d07c2f333445c2a1dbf9f59 Gerrit-Change-Number: 52181 Gerrit-PatchSet: 9 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 09 Apr 2021 10:22:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/intel/common: use lapicid api
by Angel Pons (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Lance Zhao, Nico Huber, Jamie Ryu, Furquan Shaikh, Wonkyu Kim, Ravishankar Sarawadi, Subrata Banik, Srinidhi N Kaushik, Raj Astekar, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51725 ) Change subject: cpu/intel/common: use lapicid api ...................................................................... Patch Set 11: (1 comment) File src/cpu/intel/common/hyperthreading.c: https://review.coreboot.org/c/coreboot/+/51725/comment/f3cdb125_83c3ddff PS11, Line 26: apic_ids = lapicid(); > The SDM says this is the "maximum number of addressable IDs for logical processors in this physical […] Reading further: in x2APIC mode, this would need to be done using CPUID leaf 0xb (or 0x1f). One would use EAX bits 4..0 from sub-leaf 0 (SMT level) to know how many x2APIC ID bits correspond to SMT level, and use this to know if a logical processor is an HT sibling. I haven't tested it, but this should work for x2APIC: if (x2apic) { if (cpuid_eax(0) >= 0xb) { result = cpuid_ext(0xb, 0); const uint32_t div = 1 << (result.eax & 0x1f); if (div == 0) return false; return result.edx % div > 0; } } -- To view, visit https://review.coreboot.org/c/coreboot/+/51725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ca5b09ae67941adcc07dfafdfe4ba78b0f81009 Gerrit-Change-Number: 51725 Gerrit-PatchSet: 11 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Lance Zhao Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 09 Apr 2021 10:00:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/prodrive/hermes: Fix eeprom reading
by Christian Walter (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Patrick Rudolph, Arthur Heymans. Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52207 ) Change subject: mb/prodrive/hermes: Fix eeprom reading ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic08cf01d800babd4a9176dfb2337411b789040f3 Gerrit-Change-Number: 52207 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 09 Apr 2021 09:55:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/prodrive/hermes: Fix eeprom reading
by Angel Pons (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Patrick Rudolph, Christian Walter, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52207 ) Change subject: mb/prodrive/hermes: Fix eeprom reading ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic08cf01d800babd4a9176dfb2337411b789040f3 Gerrit-Change-Number: 52207 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 09 Apr 2021 09:55:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/prodrive/hermes: Fix eeprom reading
by Arthur Heymans (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52207 ) Change subject: mb/prodrive/hermes: Fix eeprom reading ...................................................................... Patch Set 2: (1 comment) File src/mainboard/prodrive/hermes/eeprom.c: https://review.coreboot.org/c/coreboot/+/52207/comment/6a5c042d_f13ba401 PS2, Line 125: memcpy(writePointer, tmp, bytes_to_copy); > Shouldn't this be: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/52207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic08cf01d800babd4a9176dfb2337411b789040f3 Gerrit-Change-Number: 52207 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 09 Apr 2021 09:38:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/prodrive/hermes: Fix eeprom reading
by Arthur Heymans (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Patrick Rudolph, Christian Walter, Arthur Heymans. Hello build bot (Jenkins), Patrick Rudolph, Christian Walter, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52207 to look at the new patch set (#3). Change subject: mb/prodrive/hermes: Fix eeprom reading ...................................................................... mb/prodrive/hermes: Fix eeprom reading The logic for bytes to copy to the function input pointer was wrong. What it did was to loop over all 2 bytes that need to be read and only copy the first byte. Change-Id: Ic08cf01d800babd4a9176dfb2337411b789040f3 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/prodrive/hermes/eeprom.c 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/52207/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic08cf01d800babd4a9176dfb2337411b789040f3 Gerrit-Change-Number: 52207 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: lillupup: provide additional VBT for lillipup OLED sku
by Kevin Chang (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee, YH Lin. Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52150 ) Change subject: lillupup: provide additional VBT for lillipup OLED sku ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > This line: https://review.coreboot. […] Hi Tim In the patchset 3 modify to using FW config to distinguish VBIOS. So I think this can be keep. File src/mainboard/google/volteer/variants/lindar/variant.c: https://review.coreboot.org/c/coreboot/+/52150/comment/263691dd_744d2834 PS2, Line 26: case SKU_6_OLED: : case SKU_7_OLED: > I think we shouldn't use the SKU information in the coreboot. Instead, we should use the fw_config. Update in patchset 3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I576297b8296def3c37a01ae0223fa332aa9f02b1 Gerrit-Change-Number: 52150 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Fri, 09 Apr 2021 09:33:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Zhuohao Lee <zhuohao(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lillupup: provide additional VBT for lillipup OLED sku
by Kevin Chang (Code Review) 09 Apr '21

09 Apr '21

Attention is currently required from: Kevin Chang, Nick Vaccaro, YH Lin, Zhuohao Lee. Hello build bot (Jenkins), YH Lin, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee, YH Lin, Zhuohao Lee, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52150 to look at the new patch set (#3). Change subject: lillupup: provide additional VBT for lillipup OLED sku ...................................................................... lillupup: provide additional VBT for lillipup OLED sku Lillipup add two sku for OLED panel. Additional VBT is necessary to modify PWM source from VESA eDP AUX interface BUG=b:183630802 TEST=emerge-volteer coreboot-private-files-baseboard-volteer check vbt_lillipup.bin is under build folder and check in CPU log. Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Change-Id: I576297b8296def3c37a01ae0223fa332aa9f02b1 --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/lindar/variant.c 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/52150/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I576297b8296def3c37a01ae0223fa332aa9f02b1 Gerrit-Change-Number: 52150 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com> Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021