coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: soc/amd/common: Drop ACPIMMIO GPIO bank separation
by Felix Held (Code Review) 01 Feb '21

01 Feb '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42690 ) Change subject: soc/amd/common: Drop ACPIMMIO GPIO bank separation ...................................................................... soc/amd/common: Drop ACPIMMIO GPIO bank separation It's assumed in ASL already that the banks appear one after other in ACPIMMIO space. There is no need for the separation of accessor functions by name. Change-Id: I4c8c3f2028ca89dca5c7f0548fcd18e1045999d6 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/42690 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Raul Rangel <rrangel(a)chromium.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/soc/amd/common/block/acpimmio/mmio_util.c M src/soc/amd/common/block/include/amdblocks/acpimmio.h 2 files changed, 0 insertions(+), 97 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Raul Rangel: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve diff --git a/src/soc/amd/common/block/acpimmio/mmio_util.c b/src/soc/amd/common/block/acpimmio/mmio_util.c index 9e8342b..1cacd44 100644 --- a/src/soc/amd/common/block/acpimmio/mmio_util.c +++ b/src/soc/amd/common/block/acpimmio/mmio_util.c @@ -35,8 +35,6 @@ DECLARE_ACPIMMIO(acpimmio_wdt, WDT); DECLARE_ACPIMMIO(acpimmio_hpet, HPET); DECLARE_ACPIMMIO(acpimmio_dpvga, DPVGA); -DECLARE_ACPIMMIO(acpimmio_gpio1, GPIO1); -DECLARE_ACPIMMIO(acpimmio_gpio2, GPIO2); DECLARE_ACPIMMIO(acpimmio_xhci_pm, XHCIPM); DECLARE_ACPIMMIO(acpimmio_acdc_tmr, ACDCTMR); #endif diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h index 8443d29..ca32f23 100644 --- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h +++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h @@ -61,8 +61,6 @@ extern uint8_t *MAYBE_CONST acpimmio_misc; extern uint8_t *MAYBE_CONST acpimmio_dpvga; extern uint8_t *MAYBE_CONST acpimmio_gpio0; -extern uint8_t *MAYBE_CONST acpimmio_gpio1; -extern uint8_t *MAYBE_CONST acpimmio_gpio2; extern uint8_t *MAYBE_CONST acpimmio_xhci_pm; extern uint8_t *MAYBE_CONST acpimmio_acdc_tmr; extern uint8_t *MAYBE_CONST acpimmio_aoac; @@ -349,99 +347,6 @@ write32(gpio_ctrl_ptr(gpio_num), value); } -/* GPIO bank 0 */ -static inline uint8_t gpio0_read8(uint8_t reg) -{ - return read8(acpimmio_gpio0 + reg); -} - -static inline uint16_t gpio0_read16(uint8_t reg) -{ - return read16(acpimmio_gpio0 + reg); -} - -static inline uint32_t gpio0_read32(uint8_t reg) -{ - return read32(acpimmio_gpio0 + reg); -} - -static inline void gpio0_write8(uint8_t reg, uint8_t value) -{ - write8(acpimmio_gpio0 + reg, value); -} - -static inline void gpio0_write16(uint8_t reg, uint16_t value) -{ - write16(acpimmio_gpio0 + reg, value); -} - -static inline void gpio0_write32(uint8_t reg, uint32_t value) -{ - write32(acpimmio_gpio0 + reg, value); -} - -/* GPIO bank 1 */ -static inline uint8_t gpio1_read8(uint8_t reg) -{ - return read8(acpimmio_gpio1 + reg); -} - -static inline uint16_t gpio1_read16(uint8_t reg) -{ - return read16(acpimmio_gpio1 + reg); -} - -static inline uint32_t gpio1_read32(uint8_t reg) -{ - return read32(acpimmio_gpio1 + reg); -} - -static inline void gpio1_write8(uint8_t reg, uint8_t value) -{ - write8(acpimmio_gpio1 + reg, value); -} - -static inline void gpio1_write16(uint8_t reg, uint16_t value) -{ - write16(acpimmio_gpio1 + reg, value); -} - -static inline void gpio1_write32(uint8_t reg, uint32_t value) -{ - write32(acpimmio_gpio1 + reg, value); -} - -/* GPIO bank 2 */ -static inline uint8_t gpio2_read8(uint8_t reg) -{ - return read8(acpimmio_gpio2 + reg); -} - -static inline uint16_t gpio2_read16(uint8_t reg) -{ - return read16(acpimmio_gpio2 + reg); -} - -static inline uint32_t gpio2_read32(uint8_t reg) -{ - return read32(acpimmio_gpio2 + reg); -} - -static inline void gpio2_write8(uint8_t reg, uint8_t value) -{ - write8(acpimmio_gpio2 + reg, value); -} - -static inline void gpio2_write16(uint8_t reg, uint16_t value) -{ - write16(acpimmio_gpio2 + reg, value); -} - -static inline void gpio2_write32(uint8_t reg, uint32_t value) -{ - write32(acpimmio_gpio2 + reg, value); -} - static inline uint8_t xhci_pm_read8(uint8_t reg) { return read8(acpimmio_xhci_pm + reg); -- To view, visit https://review.coreboot.org/c/coreboot/+/42690 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c8c3f2028ca89dca5c7f0548fcd18e1045999d6 Gerrit-Change-Number: 42690 Gerrit-PatchSet: 14 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: [RFC] util/liveiso: Add NixOS config for a testing live system
by Angel Pons (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Felix Singer, Nico Huber, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Michael Niewöhner, Marcello Sylvester Bauer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50194 ) Change subject: [RFC] util/liveiso: Add NixOS config for a testing live system ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/50194/comment/cd4ec6b6_f402fa17 PS4, Line 19: a variant with Gnome Shell As far as I can tell, the current inception of the script doesn't include any graphical environment. It would be nice to mention so in the commit message. Patchset: PS4: As discussed on IRC, persistence would be very useful to have. File util/liveiso/console.nix: https://review.coreboot.org/c/coreboot/+/50194/comment/2dee02fa_0c5905f1 PS4, Line 54: environment.systemPackages = with pkgs; [ Would be nice to include msr-tools or (preferably) https://github.com/adurbin/iotools as well -- To view, visit https://review.coreboot.org/c/coreboot/+/50194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Gerrit-Change-Number: 50194 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Comment-Date: Mon, 01 Feb 2021 14:56:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC] util/liveiso: Add NixOS config for a testing live system
by Felix Singer (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Nico Huber, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Michael Niewöhner, Marcello Sylvester Bauer. Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Michael Niewöhner, Marcello Sylvester Bauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50194 to look at the new patch set (#4). Change subject: [RFC] util/liveiso: Add NixOS config for a testing live system ...................................................................... [RFC] util/liveiso: Add NixOS config for a testing live system Add a NixOS configuration for a bootable live system containing a set of tools which might be useful for working on firmware in general and coreboot. It can be built using build-console.sh, which requires Nix utilities to be installed. After building, the resulting iso image can be found in `result/iso/nixos.iso` and its size is about 676MB. An additional configuration for a variant with Gnome Shell as window manager installed is WIP. Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A util/liveiso/.gitignore A util/liveiso/build-console.sh A util/liveiso/console.nix A util/liveiso/description.md 4 files changed, 112 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/50194/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/50194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Gerrit-Change-Number: 50194 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/baytrail,braswell: Sync PCI memory region in ASL
by Angel Pons (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Kyösti Mälkki, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50192 ) Change subject: soc/intel/baytrail,braswell: Sync PCI memory region in ASL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d1bf45c6e5520c0b7643602843c665bfb81f9da Gerrit-Change-Number: 50192 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Feb 2021 13:35:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC] util/liveiso: Add NixOS config for a testing live system
by Felix Singer (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Nico Huber, Patrick Rudolph, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Michael Niewöhner, Marcello Sylvester Bauer. Hello Nico Huber, Patrick Rudolph, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Michael Niewöhner, Marcello Sylvester Bauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50194 to look at the new patch set (#3). Change subject: [RFC] util/liveiso: Add NixOS config for a testing live system ...................................................................... [RFC] util/liveiso: Add NixOS config for a testing live system Add a NixOS configuration for a bootable live system containing a set of tools which might be useful for working on firmware in general and coreboot. It can be built using build-console.sh, which requires Nix utilities to be installed. After building, the resulting iso image can be found in `result/iso/nixos.iso` and its size is about 676MB. An additional configuration for a variant with Gnome Shell as window manager installed is WIP. Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A util/liveiso/.gitignore A util/liveiso/build-console.sh A util/liveiso/console.nix A util/liveiso/description.md 4 files changed, 111 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/50194/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/50194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Gerrit-Change-Number: 50194 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [RFC] util/liveiso: Add NixOS config for a testing live system
by Felix Singer (Code Review) 01 Feb '21

01 Feb '21

Felix Singer has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/50194 ) Change subject: [RFC] util/liveiso: Add NixOS config for a testing live system ...................................................................... [RFC] util/liveiso: Add NixOS config for a testing live system Add a NixOS configuration for a bootable live system containing a set of tools which might be useful for working on firmware in general and coreboot. It can be built using build-console.sh, which requires Nix utilities to be installed. After building, the resulting iso image can be found in `result/iso/nixos.iso` and its size is about 676MB. An additional configuration for a variant with Gnome Shell as window manager installed is WIP. Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A util/liveiso/build-console.sh A util/liveiso/console.nix A util/liveiso/description.md 3 files changed, 110 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/50194/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Gerrit-Change-Number: 50194 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [RFC] util/liveiso: Add initial NixOS config for corebootiso
by Felix Singer (Code Review) 01 Feb '21

01 Feb '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50194 ) Change subject: [RFC] util/liveiso: Add initial NixOS config for corebootiso ...................................................................... [RFC] util/liveiso: Add initial NixOS config for corebootiso Add a NixOS configuration for a bootable live system containing a set of tools which might be useful for working on firmware in general and coreboot. It can be built using build-console.sh, which requires Nix utilities to be installed. After building, the resulting iso image can be found in `result/iso/nixos.iso` and its size is about 676MB. An additional configuration for a variant with Gnome Shell as window manager installed is WIP. Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A util/liveiso/build-console.sh A util/liveiso/console.nix A util/liveiso/description.md 3 files changed, 110 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/50194/1 diff --git a/util/liveiso/build-console.sh b/util/liveiso/build-console.sh new file mode 100755 index 0000000..45517dc --- /dev/null +++ b/util/liveiso/build-console.sh @@ -0,0 +1,3 @@ +#!/usr/bin/env bash + +nix-build '<nixpkgs/nixos>' -A config.system.build.isoImage -I nixos-config=console.nix diff --git a/util/liveiso/console.nix b/util/liveiso/console.nix new file mode 100644 index 0000000..cd6e2fa --- /dev/null +++ b/util/liveiso/console.nix @@ -0,0 +1,106 @@ +{ config, pkgs, ... }: + +{ + imports = [ + <nixpkgs/nixos/modules/installer/cd-dvd/iso-image.nix> + ]; + + system.stateVersion = "20.09"; + + documentation.nixos.enable = false; + + isoImage.makeEfiBootable = true; + isoImage.makeUsbBootable = true; + boot.loader.grub.memtest86.enable = true; + boot.kernelParams = [ "console=ttyS0,115200" "console=tty0" ]; + + # pkgs.linuxPackages == lts + # pkgs.linuxPackages_latest == stable + boot.kernelPackages = pkgs.linuxPackages; + boot.extraModulePackages = with config.boot.kernelPackages; [ acpi_call chipsec ]; + + nixpkgs.config.allowUnfree = true; + hardware = { + cpu.intel.updateMicrocode = true; + cpu.amd.updateMicrocode = true; + enableAllFirmware = true; + }; + + networking = { + hostName = "corebootiso"; + networkmanager.enable = true; + }; + + services.openssh = { + enable = true; + permitRootLogin = "yes"; + }; + + services.mingetty.autologinUser = "user"; + security.sudo.wheelNeedsPassword = false; + users = { + groups.user = {}; + users.user = { + group = "user"; + home = "/home/user"; + createHome = true; + useDefaultShell = true; + extraGroups = [ "users" "wheel" "networkmanager" "uucp" ]; + initialHashedPassword = ""; + }; + users.root.initialHashedPassword = ""; + }; + + environment.systemPackages = with pkgs; [ + acpica-tools + btrfs-progs + bzip2 + ccrypt + chipsec + coreboot-utils + cryptsetup + curl + ddrescue + dosfstools + e2fsprogs + efibootmgr + efivar + exfat + f2fs-tools + flashrom + fuse + fuse3 + fwts + gitAndTools.gitFull + gitAndTools.tig + gptfdisk + gzip + hdparm + htop + jfsutils + mdadm + mkpasswd + ms-sys + neovim + ntfsprogs + p7zip + parted + pciutils + phoronix-test-suite + python3Full + rsync + screen + sdparm + smartmontools + socat + sshfs-fuse + testdisk + tmux + unzip + usbutils + wget + xfsprogs.bin + zip + zstd + ]; +} diff --git a/util/liveiso/description.md b/util/liveiso/description.md new file mode 100644 index 0000000..b9beac4 --- /dev/null +++ b/util/liveiso/description.md @@ -0,0 +1 @@ +Provides a configuration file for a NixOS live system with useful utilities pre-installed. -- To view, visit https://review.coreboot.org/c/coreboot/+/50194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Gerrit-Change-Number: 50194 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src: Remove unused <cbfs.h>
by HAOUAS Elyes (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Hung-Te Lin, Jason Glenesk, Raul Rangel, Philipp Hug, Marshall Dawson, Julius Werner, ron minnich, Felix Held. Hello Hung-Te Lin, build bot (Jenkins), Jason Glenesk, Raul Rangel, Philipp Hug, Marshall Dawson, Julius Werner, ron minnich, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50166 to look at the new patch set (#5). Change subject: src: Remove unused <cbfs.h> ...................................................................... src: Remove unused <cbfs.h> Change-Id: Idc11f1e131df2e01864fedac864bda5e11f2d17b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/arm64/fit_payload.c M src/mainboard/google/auron/variants/auron_paine/spd/spd.c M src/mainboard/google/auron/variants/auron_yuna/spd/spd.c M src/mainboard/google/auron/variants/gandof/spd/spd.c M src/mainboard/google/auron/variants/lulu/spd/spd.c M src/mainboard/google/auron/variants/samus/spd/spd.c M src/mainboard/google/zork/mainboard.c M src/mainboard/intel/adlrvp/romstage_fsp_params.c M src/soc/amd/common/block/psp/psp_smm.c M src/soc/qualcomm/sc7180/aop_load_reset.c 10 files changed, 1 insertion(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/50166/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/50166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc11f1e131df2e01864fedac864bda5e11f2d17b Gerrit-Change-Number: 50166 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: arch/{arm,riscv}/boot.c: Add missing <commonlib/bsd/cbfs_serialized.h>
by HAOUAS Elyes (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Philipp Hug, Julius Werner, ron minnich. Hello build bot (Jenkins), Philipp Hug, Julius Werner, ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50167 to look at the new patch set (#2). Change subject: arch/{arm,riscv}/boot.c: Add missing <commonlib/bsd/cbfs_serialized.h> ...................................................................... arch/{arm,riscv}/boot.c: Add missing <commonlib/bsd/cbfs_serialized.h> Change-Id: I98fb5df0148a3f5fe0bc5b08c5a0b8b1e95c4624 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/arm/boot.c M src/arch/riscv/boot.c M src/lib/fit.c M src/lib/fit_payload.c M src/lib/selfboot.c 5 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/50167/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50167 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98fb5df0148a3f5fe0bc5b08c5a0b8b1e95c4624 Gerrit-Change-Number: 50167 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/baytrail,braswell: Drop TOLM from GNVS
by Angel Pons (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Kyösti Mälkki, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50121 ) Change subject: soc/intel/baytrail,braswell: Drop TOLM from GNVS ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife6611a11e5627d39d59e0e93af9aa2d87885601 Gerrit-Change-Number: 50121 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Feb 2021 12:33:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021