coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: soc/intel/cannonlake: Configure GPIOs again after FSP-S is done
by Michael Niewöhner (Code Review) 01 Feb '21

01 Feb '21

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31250 ) Change subject: soc/intel/cannonlake: Configure GPIOs again after FSP-S is done ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Furquan, do you remember what pads exactly were overwritten? I'm surprised there was no problem in skl/kbl, because FSP-S configures some pads, too, there, based on a few UPDs (S0ix, HDA/Azalia, Clkreq, ...). That's what is happening on CNL, too. See CB:45211 I doubt that we will get any "fix" for this in FSP because it seems to be absolutely intended. - I'm not saying I like what FSP does, though. ;) -- To view, visit https://review.coreboot.org/c/coreboot/+/31250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7787aa8f185f633627bcedc7f23504bf4a5250b4 Gerrit-Change-Number: 31250 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 01 Feb 2021 19:25:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/{skylake,cannonlake}: Co-ordinate lockdown configuration
by Angel Pons (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Nico Huber, Benjamin Doron, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50048 ) Change subject: soc/intel/{skylake,cannonlake}: Co-ordinate lockdown configuration ...................................................................... Patch Set 4: (2 comments) File src/soc/intel/cannonlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/50048/comment/abe7cf4f_9e0a5623 PS4, Line 158: params->PchLockDownRtcMemoryLock = 0; OK: Unconditionally set later in this function. File src/soc/intel/skylake/finalize.c: https://review.coreboot.org/c/coreboot/+/50048/comment/ba66154d_8d034544 PS4, Line 79: config No longer used. -- To view, visit https://review.coreboot.org/c/coreboot/+/50048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab97f545597388d9c4811b5baac82d3e06d86484 Gerrit-Change-Number: 50048 Gerrit-PatchSet: 4 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Feb 2021 19:24:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/skylake: Set "PEG?Enable" UPD directly
by Angel Pons (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Felix Singer, Nico Huber, Benjamin Doron, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50045 ) Change subject: soc/intel/skylake: Set "PEG?Enable" UPD directly ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: I'm still not convinced this patch can really improve much. What's the reason for this change? File src/soc/intel/skylake/romstage/romstage.c: https://review.coreboot.org/c/coreboot/+/50045/comment/d579fdb0_deed1fbb PS4, Line 174: if (dev && dev->enabled) { Now this will leave FSP UPDs unprogrammed for disabled PEG RPs. If you want to avoid rewriting the UPD, you have to write the desired values in one statement, and actually remove the write in the if-block: m_cfg->Peg0Enable = dev && dev->enabled ? 2 : 0; if (m_cfg->Peg0Enable) { ... How many nanoseconds does this shave off the boot time, though? -- To view, visit https://review.coreboot.org/c/coreboot/+/50045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib90e8335d68f3406103f247609ee627d4e956d1d Gerrit-Change-Number: 50045 Gerrit-PatchSet: 4 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Feb 2021 19:19:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: doc/soc/intel/crashlog: add CrashLog Spec
by Francois Toguo Fotso (Code Review) 01 Feb '21

01 Feb '21

Francois Toguo Fotso has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50202 ) Change subject: doc/soc/intel/crashlog: add CrashLog Spec ...................................................................... doc/soc/intel/crashlog: add CrashLog Spec Signed-off-by: Francois Toguo <francois.toguo.fotso(a)intel.com> Change-Id: Ibb597a0ed3fbffd2d8233bcebe6b97bc0c3afd4d --- A Documentation/soc/intel/crashLog/CrashLog_Technology_Spec.pdf 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/50202/1 diff --git a/Documentation/soc/intel/crashLog/CrashLog_Technology_Spec.pdf b/Documentation/soc/intel/crashLog/CrashLog_Technology_Spec.pdf new file mode 100644 index 0000000..bb9570f --- /dev/null +++ b/Documentation/soc/intel/crashLog/CrashLog_Technology_Spec.pdf Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/50202 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb597a0ed3fbffd2d8233bcebe6b97bc0c3afd4d Gerrit-Change-Number: 50202 Gerrit-PatchSet: 1 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: hatch: Modify genesis PcieClkSrc settings
by Furquan Shaikh (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Neill Corlett. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50101 ) Change subject: hatch: Modify genesis PcieClkSrc settings ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/50101/comment/2e388535_c775d679 PS2, Line 9: to work around issue with Longsys SSD I think it would be good to provide some context as to why the change is being made. I understand that you are submitting this change on behalf of Quanta, but a quick explanation as to why this change is required would be very helpful. -- To view, visit https://review.coreboot.org/c/coreboot/+/50101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30c2179be9b9ddd50168a7f35be800e969800e10 Gerrit-Change-Number: 50101 Gerrit-PatchSet: 2 Gerrit-Owner: Neill Corlett <corlett(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Joe Tessler <jrt(a)google.com> Gerrit-CC: Matthew Ziegelbaum <ziegs(a)google.com> Gerrit-Attention: Neill Corlett <corlett(a)google.com> Gerrit-Comment-Date: Mon, 01 Feb 2021 19:10:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: hatch: Update fan and thermal settings for ambassador
by Furquan Shaikh (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Neill Corlett. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50100 ) Change subject: hatch: Update fan and thermal settings for ambassador ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/50100/comment/5c938d91_432be4a8 PS2, Line 7: hatch: Update fan and thermal settings for ambassador, per recommendations from Quanta. > Updated word wrapping; please let me know if I need to remove the CrOS-specific metadata as well Cros-specific metadata is fine. Patchset: PS3: Change looks okay to me. It would be good if someone more familiar with the project can ensure that the settings make sense. -- To view, visit https://review.coreboot.org/c/coreboot/+/50100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I080859f872caf696f0c085defb8372de658da58a Gerrit-Change-Number: 50100 Gerrit-PatchSet: 3 Gerrit-Owner: Neill Corlett <corlett(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Joe Tessler <jrt(a)google.com> Gerrit-CC: Matthew Ziegelbaum <ziegs(a)google.com> Gerrit-Attention: Neill Corlett <corlett(a)google.com> Gerrit-Comment-Date: Mon, 01 Feb 2021 19:08:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Neill Corlett <corlett(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: hatch: Update fan and thermal settings for ambassador
by Furquan Shaikh (Code Review) 01 Feb '21

01 Feb '21

1 0

Change in coreboot[master]: soc/intel/skylake: Remove unnecessary DdrFreqLimit override
by Benjamin Doron (Code Review) 01 Feb '21

01 Feb '21

Benjamin Doron has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/50046 ) Change subject: soc/intel/skylake: Remove unnecessary DdrFreqLimit override ...................................................................... Abandoned Not depending on FSP default -- To view, visit https://review.coreboot.org/c/coreboot/+/50046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I805d81dec23d67e877d14f76e3f7850b5767e55c Gerrit-Change-Number: 50046 Gerrit-PatchSet: 2 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/intel/skylake: Remove X2ApicOptOut UPD override
by Benjamin Doron (Code Review) 01 Feb '21

01 Feb '21

Benjamin Doron has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/50047 ) Change subject: soc/intel/skylake: Remove X2ApicOptOut UPD override ...................................................................... Abandoned Not depending on FSP default -- To view, visit https://review.coreboot.org/c/coreboot/+/50047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96ef07c68f1c01500999ed6973f4bf4d40af452a Gerrit-Change-Number: 50047 Gerrit-PatchSet: 2 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/intel/skylake: Set "PEG?Enable" UPD directly
by Benjamin Doron (Code Review) 01 Feb '21

01 Feb '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Patrick Rudolph. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50045 ) Change subject: soc/intel/skylake: Set "PEG?Enable" UPD directly ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/50045/comment/de0a6958_e9622772 PS3, Line 9: This configuration duplicates FSP defaults. > I agree, we should not rely on someone else defaults. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/50045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib90e8335d68f3406103f247609ee627d4e956d1d Gerrit-Change-Number: 50045 Gerrit-PatchSet: 4 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 01 Feb 2021 19:02:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021