Attention is currently required from: Damien Zammit, Angel Pons, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49746 )
Change subject: nb/intel/pineview: Guard {MCH,DMI,EP}BAR macros
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49746/comment/c9a6746c_aae79a48
PS4, Line 9: should not have
: any functional impact
> how so?
CB:50355 knows the details. I assume it's the only thing that
changes with this commit.
--
To view, visit https://review.coreboot.org/c/coreboot/+/49746
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8be8d7b8a0f289d2be76d3dec43999f6b42e3265
Gerrit-Change-Number: 49746
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Sat, 06 Feb 2021 14:05:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Martin Roth.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50354 )
Change subject: Revert "util/lint: Add test for documentation in util dirs"
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/50354
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38a86c8a5d5dc14ca5f6cba789bcb8c0fcaefb0b
Gerrit-Change-Number: 50354
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Sat, 06 Feb 2021 14:00:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50354 )
Change subject: Revert "util/lint: Add test for documentation in util dirs"
......................................................................
Revert "util/lint: Add test for documentation in util dirs"
This reverts commit 15e379aaf334e7931710b4208ccedf2f9ee44b0d.
It triggers on directories that only contain artifacts and no
checked in code. As this happens a lot when switching branches,
it makes it impossible to commit new code.
Change-Id: I38a86c8a5d5dc14ca5f6cba789bcb8c0fcaefb0b
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
D util/lint/lint-stable-025-description-md
1 file changed, 0 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/50354/1
diff --git a/util/lint/lint-stable-025-description-md b/util/lint/lint-stable-025-description-md
deleted file mode 100755
index 88c3d76..0000000
--- a/util/lint/lint-stable-025-description-md
+++ /dev/null
@@ -1,16 +0,0 @@
-#!/bin/sh
-# SPDX-License-Identifier: GPL-2.0-or-later
-#
-# DESCR: Check that every utility has a description
-
-LC_ALL=C export LC_ALL
-FAIL=0
-
-for i in util/*/; do
- if [ ! -r "$i/description.md" ]; then
- echo " Failure: util directory $i missing description.md file."
- FAIL=1
- fi
-done
-
-exit $FAIL
--
To view, visit https://review.coreboot.org/c/coreboot/+/50354
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38a86c8a5d5dc14ca5f6cba789bcb8c0fcaefb0b
Gerrit-Change-Number: 50354
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: newchange