coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: nb/intel/x4x: Drop commented-out statement
by Angel Pons (Code Review) 06 Feb '21

06 Feb '21

Attention is currently required from: Damien Zammit, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49389 ) Change subject: nb/intel/x4x: Drop commented-out statement ...................................................................... Patch Set 1: (1 comment) File src/northbridge/intel/x4x/raminit_ddr23.c: https://review.coreboot.org/c/coreboot/+/49389/comment/20153c26_26c2de23 PS1, Line 775: MCHBAR8_AND(0x400 * i + 0x5a0 + 3, : ~rank2clken[r + i * 4]); > > I do remember that I needed this to have all clock signals enabled for a (DDR3) board to work (bet […] Alright, I added comments on that patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/49389 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iff4cdd71435e4fd69d4f3284e9fb2830fdd5b173 Gerrit-Change-Number: 49389 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Damien Zammit Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 06 Feb 2021 14:56:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Fix Clock Enable on DDR3
by Angel Pons (Code Review) 06 Feb '21

06 Feb '21

Attention is currently required from: Damien Zammit, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50353 ) Change subject: nb/intel/x4x/raminit: Fix Clock Enable on DDR3 ...................................................................... Patch Set 3: (1 comment) File src/northbridge/intel/x4x/raminit_ddr23.c: https://review.coreboot.org/c/coreboot/+/50353/comment/55cb5b7c_89ccb902 PS3, Line 779: * clock for all ranks. nb/intel/i945 has the `OVERRIDE_CLOCK_DISABLE` Kconfig option, maybe add it to x4x as well? We know other x4x boards work well with DDR3 (various G41 boards, and the Acer G43T-AM3). -- To view, visit https://review.coreboot.org/c/coreboot/+/50353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1eb77ed2d2b563fb3b92ca33b900f7d1dbc85fe Gerrit-Change-Number: 50353 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 06 Feb 2021 14:55:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/haswell: Use common {DMI,EP,MCH}BAR accessors
by Angel Pons (Code Review) 06 Feb '21

06 Feb '21

Attention is currently required from: Nico Huber, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49749 ) Change subject: nb/intel/haswell: Use common {DMI,EP,MCH}BAR accessors ...................................................................... Patch Set 4: (1 comment) File src/northbridge/intel/haswell/haswell.h: https://review.coreboot.org/c/coreboot/+/49749/comment/03f683b4_0b869fcf PS4, Line 64: EPBAR64 > Is the reason for keeping those here, that older Intel NB don't have any EP/DMI 64bit registers? I kept these here because other northbridges don't use them, and I'm not sure if 64-bit register accesses would work properly on all northbridges (I know they work on Haswell, but no idea about others). -- To view, visit https://review.coreboot.org/c/coreboot/+/49749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ff4577ce662697cb3d8fb34003217fd6275dd42 Gerrit-Change-Number: 49749 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 06 Feb 2021 14:51:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/pineview: Rewrite hex values in lowercase
by Nico Huber (Code Review) 06 Feb '21

06 Feb '21

Attention is currently required from: Damien Zammit, Angel Pons, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50356 ) Change subject: nb/intel/pineview: Rewrite hex values in lowercase ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50356 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I185b448ca7822fa89c57efe788e05b582b259c37 Gerrit-Change-Number: 50356 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 06 Feb 2021 14:38:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/pineview: Rewrite hex values in lowercase
by Angel Pons (Code Review) 06 Feb '21

06 Feb '21

Attention is currently required from: Nico Huber, Damien Zammit, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50356 ) Change subject: nb/intel/pineview: Rewrite hex values in lowercase ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Maybe add some rationale to the commit message. I've added something. -- To view, visit https://review.coreboot.org/c/coreboot/+/50356 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I185b448ca7822fa89c57efe788e05b582b259c37 Gerrit-Change-Number: 50356 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Damien Zammit Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 06 Feb 2021 14:37:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/pineview: Rewrite hex values in lowercase
by Angel Pons (Code Review) 06 Feb '21

06 Feb '21

Attention is currently required from: Damien Zammit, Angel Pons, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Damien Zammit, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50356 to look at the new patch set (#2). Change subject: nb/intel/pineview: Rewrite hex values in lowercase ...................................................................... nb/intel/pineview: Rewrite hex values in lowercase Most hex values are already lowercase. For consistency reasons, rewrite uppercase hex values in lowercase. Tested with BUILD_TIMELESS=1, Foxconn D41S does not change. Change-Id: I185b448ca7822fa89c57efe788e05b582b259c37 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/pineview/mchbar_regs.h M src/northbridge/intel/pineview/raminit.c 2 files changed, 314 insertions(+), 314 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/50356/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50356 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I185b448ca7822fa89c57efe788e05b582b259c37 Gerrit-Change-Number: 50356 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel/pineview: Delete rude and useless comment
by Arthur Heymans (Code Review) 06 Feb '21

06 Feb '21

Attention is currently required from: Damien Zammit, Angel Pons, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50357 ) Change subject: nb/intel/pineview: Delete rude and useless comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5bcadf04b5d5b9dad3523bce98942f2792be905f Gerrit-Change-Number: 50357 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 06 Feb 2021 14:19:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/pineview: Clean up FIXMEs in raminit
by Arthur Heymans (Code Review) 06 Feb '21

06 Feb '21

Attention is currently required from: Nico Huber, Damien Zammit, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50355 ) Change subject: nb/intel/pineview: Clean up FIXMEs in raminit ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50355 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id10882225c8e82b02583aa73e73d661c25abdef9 Gerrit-Change-Number: 50355 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Damien Zammit Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 06 Feb 2021 14:17:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "util/lint: Add test for documentation in util dirs"
by Nico Huber (Code Review) 06 Feb '21

06 Feb '21

Attention is currently required from: Martin Roth. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50354 ) Change subject: Revert "util/lint: Add test for documentation in util dirs" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Just pushed to share my local solution to be able to commit again. There's likely a better way. -- To view, visit https://review.coreboot.org/c/coreboot/+/50354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38a86c8a5d5dc14ca5f6cba789bcb8c0fcaefb0b Gerrit-Change-Number: 50354 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Sat, 06 Feb 2021 14:16:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/pineview: Delete rude and useless comment
by Nico Huber (Code Review) 06 Feb '21

06 Feb '21

Attention is currently required from: Damien Zammit, Angel Pons, Arthur Heymans, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50357 ) Change subject: nb/intel/pineview: Delete rude and useless comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5bcadf04b5d5b9dad3523bce98942f2792be905f Gerrit-Change-Number: 50357 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 06 Feb 2021 14:14:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021