Attention is currently required from: Felix Singer, Patrick Rudolph.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60580 )
Change subject: drivers/intel/gma/acpi: Replace Increment() with ASL 2.0 syntax
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60580
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0c11f43713bf7afec6dd600289776eefd1331e8
Gerrit-Change-Number: 60580
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 31 Dec 2021 13:43:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Andrey Petrov, Patrick Rudolph.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60581 )
Change subject: soc/intel/apollolake/acpi: Replace Increment() with ASL 2.0 syntax
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60581
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40d5df41e2e077cb9d3e7f3945f0dbae18382a28
Gerrit-Change-Number: 60581
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 31 Dec 2021 13:42:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60597 )
Change subject: ec/smsc/mec1308/acpi: Replace LNot() with ASL 2.0 syntax
......................................................................
ec/smsc/mec1308/acpi: Replace LNot() with ASL 2.0 syntax
Replace `LNot (a)` with `!a`.
Change-Id: I16e30f4a774c8ffca3bdbbf57c9a0c6f6d3ca72c
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M src/ec/smsc/mec1308/acpi/battery.asl
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/60597/1
diff --git a/src/ec/smsc/mec1308/acpi/battery.asl b/src/ec/smsc/mec1308/acpi/battery.asl
index 59d6c4f..0cc41a1 100644
--- a/src/ec/smsc/mec1308/acpi/battery.asl
+++ b/src/ec/smsc/mec1308/acpi/battery.asl
@@ -148,7 +148,7 @@
Local1++
}
- If (BFWK && ACEX && LNot (Local0)) {
+ If (BFWK && ACEX && !Local0) {
// On AC power and battery is neither charging
// nor discharging. Linux expects a full battery
// to report same capacity as last full charge.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60597
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16e30f4a774c8ffca3bdbbf57c9a0c6f6d3ca72c
Gerrit-Change-Number: 60597
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Held.
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60596 )
Change subject: superio/winbond/w83627hf/acpi: Replace LNot() with ASL 2.0 syntax
......................................................................
superio/winbond/w83627hf/acpi: Replace LNot() with ASL 2.0 syntax
Replace `LNot (a)` with `!a`.
Change-Id: I9f08cc180614e7d966256b2944745b0bc1d29865
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M src/superio/winbond/w83627hf/acpi/superio.asl
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/60596/1
diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl
index 326b717..cc4bb87 100644
--- a/src/superio/winbond/w83627hf/acpi/superio.asl
+++ b/src/superio/winbond/w83627hf/acpi/superio.asl
@@ -306,7 +306,7 @@
EXIT_CONFIG_MODE ()
ShiftLeft(Local1, 8, Local1)
Or(Local1, Local2, Local1)
- If (LNot(Local0)) {
+ If (!Local0) {
Return (FDE)
}
@@ -724,7 +724,7 @@
{
Store (0x00, Local0)
ENTER_CONFIG_MODE (3)
- If (LNot(And(OPT2, 0x30)))
+ If (!And(OPT2, 0x30))
{
If (ACTR) {
Store (0x0F, Local0)
--
To view, visit https://review.coreboot.org/c/coreboot/+/60596
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f08cc180614e7d966256b2944745b0bc1d29865
Gerrit-Change-Number: 60596
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60595 )
Change subject: ec/quanta/it8518/acpi: Replace LNot() with ASL 2.0 syntax
......................................................................
ec/quanta/it8518/acpi: Replace LNot() with ASL 2.0 syntax
Replace `LNot (a)` with `!a`.
Change-Id: I98ac7a9c1cd16609cf6bd38e1bd9bf8cf54817fb
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M src/ec/quanta/it8518/acpi/battery.asl
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/60595/1
diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl
index 5b51c89..4fcc30c 100644
--- a/src/ec/quanta/it8518/acpi/battery.asl
+++ b/src/ec/quanta/it8518/acpi/battery.asl
@@ -275,7 +275,7 @@
}
Else
{
- If (LNot (AND (Local0, 2)))
+ If (!(AND (Local0, 2)))
{
// Battery is not charging
Store (Zero, Local1)
@@ -306,7 +306,7 @@
Store (ECRC, Local1)
}
- If (BFWK && ACPW && LNot (Local0))
+ If (BFWK && ACPW && !Local0)
{
// On AC power and battery is neither charging
// nor discharging. Linux expects a full battery
--
To view, visit https://review.coreboot.org/c/coreboot/+/60595
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98ac7a9c1cd16609cf6bd38e1bd9bf8cf54817fb
Gerrit-Change-Number: 60595
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newchange
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60593 )
Change subject: ec/google/chromeec/acpi: Replace LNot() with ASL 2.0 syntax
......................................................................
ec/google/chromeec/acpi: Replace LNot() with ASL 2.0 syntax
Replace `LNot (a)` with `!a`.
Change-Id: I2bf5a09df831b66197c2a9af780c873290e12b42
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M src/ec/google/chromeec/acpi/battery.asl
M src/ec/google/chromeec/acpi/ec.asl
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/60593/1
diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl
index 8cbe710..ce4462d 100644
--- a/src/ec/google/chromeec/acpi/battery.asl
+++ b/src/ec/google/chromeec/acpi/battery.asl
@@ -201,7 +201,7 @@
// 2: BATTERY REMAINING CAPACITY
//
Store (BTRA, Local1)
- If (Arg3 && ACEX && LNot (BFDC && BFCG)) {
+ If (Arg3 && ACEX && !(BFDC && BFCG)) {
// On AC power and battery is neither charging
// nor discharging. Linux expects a full battery
// to report same capacity as last full charge.
diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl
index 10d930d..69d608b 100644
--- a/src/ec/google/chromeec/acpi/ec.asl
+++ b/src/ec/google/chromeec/acpi/ec.asl
@@ -489,7 +489,7 @@
*/
Method (_Q09, 0, NotSerialized)
{
- If (LNot(Acquire (^PATM, 1000))) {
+ If (!Acquire (^PATM, 1000)) {
/* Read sensor ID for event */
Store (^PATI, Local0)
--
To view, visit https://review.coreboot.org/c/coreboot/+/60593
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bf5a09df831b66197c2a9af780c873290e12b42
Gerrit-Change-Number: 60593
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Singer.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60582 )
Change subject: ec/smsc/mec1308/acpi: Replace Increment() with ASL 2.0 syntax
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60582
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2154767cfc547ca9bd0a23937d50689be13fbcf
Gerrit-Change-Number: 60582
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Fri, 31 Dec 2021 13:42:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60584 )
Change subject: ec/quanta/ene_kb3940q/acpi: Replace Increment() with ASL 2.0 syntax
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60584
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic009a868e98cc23dff16154244d65080c1edfa22
Gerrit-Change-Number: 60584
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Fri, 31 Dec 2021 13:41:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment