coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h
by Angel Pons (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: Julius Werner, Alex James. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 ) Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h ...................................................................... Patch Set 9: (1 comment) File util/cbfstool/cbfs_image.c: https://review.coreboot.org/c/coreboot/+/60233/comment/4219e8c1_38696393 PS6, Line 528: uint32_t type = htobe32(cur->type); : : /* Current entry is empty. Kepp track of it. */ : if ((type == htobe32(CBFS_TYPE_NULL)) || : (type == htobe32(CBFS_TYPE_DELETED))) { > I'd prefer to do functional changes in a separate commit. I mean, I know changing this is fine, but I don't think it belongs in a commit that replaces function calls. -- To view, visit https://review.coreboot.org/c/coreboot/+/60233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e Gerrit-Change-Number: 60233 Gerrit-PatchSet: 9 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-Comment-Date: Fri, 31 Dec 2021 15:52:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h
by Angel Pons (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: Julius Werner, Alex James. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 ) Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h ...................................................................... Patch Set 9: (1 comment) File util/cbfstool/cbfs_image.c: https://review.coreboot.org/c/coreboot/+/60233/comment/058b20a3_3ca54c1e PS6, Line 528: uint32_t type = htobe32(cur->type); : : /* Current entry is empty. Kepp track of it. */ : if ((type == htobe32(CBFS_TYPE_NULL)) || : (type == htobe32(CBFS_TYPE_DELETED))) { > Will do, thanks for reviewing! I'd prefer to do functional changes in a separate commit. -- To view, visit https://review.coreboot.org/c/coreboot/+/60233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e Gerrit-Change-Number: 60233 Gerrit-PatchSet: 9 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-Comment-Date: Fri, 31 Dec 2021 15:50:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/{brask,gimble}: Use eNEM for CAR by default
by EricR Lai (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: David Wu, Subrata Banik, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60377 ) Change subject: mb/google/brya/{brask,gimble}: Use eNEM for CAR by default ...................................................................... Patch Set 8: Code-Review+2 (1 comment) Patchset: PS8: We almost get rid of ES :p -- To view, visit https://review.coreboot.org/c/coreboot/+/60377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5734606e58410545a5f5421837080680664707f Gerrit-Change-Number: 60377 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quantatw.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Fri, 31 Dec 2021 15:50:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h
by Angel Pons (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: Julius Werner, Alex James. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 ) Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h ...................................................................... Patch Set 9: (1 comment) File util/cbfstool/cbfs_image.c: https://review.coreboot.org/c/coreboot/+/60233/comment/05c8d11c_49781b76 PS6, Line 1031: be32toh(stage->loadaddr) > Ack I'd prefer to fix this in a separate commit. -- To view, visit https://review.coreboot.org/c/coreboot/+/60233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e Gerrit-Change-Number: 60233 Gerrit-PatchSet: 9 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-Comment-Date: Fri, 31 Dec 2021 15:50:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/dram/lpddr4.c: Remove unused <string.h>
by Angel Pons (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60556 ) Change subject: device/dram/lpddr4.c: Remove unused <string.h> ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60556 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba3135178f2d6021702971e4d887e9b4f8afeb76 Gerrit-Change-Number: 60556 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 31 Dec 2021 15:47:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/sb: Remove unused <string.h>
by Angel Pons (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: Patrick Rudolph, HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60554 ) Change subject: src/sb: Remove unused <string.h> ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60554/comment/8e4219b5_22c0c1b9 PS3, Line 7: src/sb nit: I think `southbridge` would be clearer -- To view, visit https://review.coreboot.org/c/coreboot/+/60554 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc0cd9d6865cd9c1b95e6c838795cce9dbc643a3 Gerrit-Change-Number: 60554 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 31 Dec 2021 15:47:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/mb: Remove unused <string.h>
by Angel Pons (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: Michał Żygowski, Patrick Rudolph, Jonathan Zhang, Johnny Lin, Christian Walter, Tim Wawrzynczak, Arthur Heymans, HAOUAS Elyes, Piotr Król, Tim Chu. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60551 ) Change subject: src/mb: Remove unused <string.h> ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60551 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f2710b2034882a24a041d99e37ec364193d85e6 Gerrit-Change-Number: 60551 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 31 Dec 2021 15:45:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/{sandybridge,haswell}: Rename PCIe driver
by Angel Pons (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: Patrick Rudolph. Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60600 ) Change subject: nb/intel/{sandybridge,haswell}: Rename PCIe driver ...................................................................... nb/intel/{sandybridge,haswell}: Rename PCIe driver Rename the PCIe driver from `pch_pcie` to `sa_pcie`, as the driver is for the System Agent's PCIe root ports, not for the PCH's root ports. Change-Id: I019088fcaa7866d8002e6884c25e1acd1d149093 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/haswell/pcie.c M src/northbridge/intel/sandybridge/pcie.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/60600/1 diff --git a/src/northbridge/intel/haswell/pcie.c b/src/northbridge/intel/haswell/pcie.c index 95c0240..b63101c 100644 --- a/src/northbridge/intel/haswell/pcie.c +++ b/src/northbridge/intel/haswell/pcie.c @@ -168,7 +168,7 @@ 0x0d01, 0x0d05, 0x0d09, /* Crystal Well */ 0 }; -static const struct pci_driver pch_pcie __pci_driver = { +static const struct pci_driver sa_pcie __pci_driver = { .ops = &device_ops, .vendor = PCI_VENDOR_ID_INTEL, .devices = pci_device_ids, diff --git a/src/northbridge/intel/sandybridge/pcie.c b/src/northbridge/intel/sandybridge/pcie.c index 36e9f26..6f7937d 100644 --- a/src/northbridge/intel/sandybridge/pcie.c +++ b/src/northbridge/intel/sandybridge/pcie.c @@ -63,7 +63,7 @@ 0, }; -static const struct pci_driver pch_pcie __pci_driver = { +static const struct pci_driver sa_pcie __pci_driver = { .ops = &device_ops, .vendor = PCI_VENDOR_ID_INTEL, .devices = pci_device_ids, -- To view, visit https://review.coreboot.org/c/coreboot/+/60600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I019088fcaa7866d8002e6884c25e1acd1d149093 Gerrit-Change-Number: 60600 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: pci_device.c: Don't guard `pci_dev_disable_bus_master()`
by Angel Pons (Code Review) 31 Dec '21

31 Dec '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60599 ) Change subject: pci_device.c: Don't guard `pci_dev_disable_bus_master()` ...................................................................... pci_device.c: Don't guard `pci_dev_disable_bus_master()` The `pci_dev_disable_bus_master()` function doesn't need to be guarded with `CONFIG(PC80_SYSTEM)`, so move it out of the guard. Change-Id: I813e0f72c3c624c73ab9ecbe7512359608ace927 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/device/pci_device.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/60599/1 diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 1075ef7..a61fbd6 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -1472,6 +1472,11 @@ pci_scan_bus(link, PCI_DEVFN(0, 0), 0xff); } +void pci_dev_disable_bus_master(const struct device *dev) +{ + pci_update_config16(dev, PCI_COMMAND, ~PCI_COMMAND_MASTER, 0x0); +} + /** * Take an INT_PIN number (0, 1 - 4) and convert * it to a string ("NO PIN", "PIN A" - "PIN D") @@ -1665,9 +1670,4 @@ i8259_configure_irq_trigger(irq, IRQ_LEVEL_TRIGGERED); } } - -void pci_dev_disable_bus_master(const struct device *dev) -{ - pci_update_config16(dev, PCI_COMMAND, ~PCI_COMMAND_MASTER, 0x0); -} #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/60599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I813e0f72c3c624c73ab9ecbe7512359608ace927 Gerrit-Change-Number: 60599 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: security/memory/memory.c: Include 'stdbool' instead of 'stdint'
by Angel Pons (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60550 ) Change subject: security/memory/memory.c: Include 'stdbool' instead of 'stdint' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4eac157c8b48c1c10178bb84822b6462c245deca Gerrit-Change-Number: 60550 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 31 Dec 2021 15:41:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021