Attention is currently required from: Nico Huber, Subrata Banik, Paul Menzel, Tim Wawrzynczak, Andrey Petrov, Patrick Rudolph, EricR Lai.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60471 )
Change subject: drivers/intel/fsp: Map FSP debug level to coreboot console level
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/intel/fsp2_0/debug.c:
https://review.coreboot.org/c/coreboot/+/60471/comment/a44f681f_710c592f
PS3, Line 9: enum {
The `fsp_map_console_log_level()` function returns values of this enum, but the enum itself is local to this file. I'd move the enum to the `fsp/debug.h` header.
Also, I'd give a name to this enum type, e.g. `enum fsp_log_level`, and use it as the return type of `fsp_map_console_log_level()`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60471
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I398d576fad68a0d0fc931c175bbc04fcbc2e54ec
Gerrit-Change-Number: 60471
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 31 Dec 2021 16:40:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Subrata Banik, Tim Wawrzynczak, EricR Lai.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60470 )
Change subject: console: Create helper function to get max console log level
......................................................................
Patch Set 2:
(1 comment)
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/60470/comment/f6e16056_ed0ff44d
PS2, Line 57: -1
> Why?
This will vanish with the changes suggested in my other comment.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56349f22c71c9db757b2be8eeb2dbfe959f80397
Gerrit-Change-Number: 60470
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 31 Dec 2021 16:35:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Subrata Banik, Tim Wawrzynczak, EricR Lai.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60470 )
Change subject: console: Create helper function to get max console log level
......................................................................
Patch Set 2:
(2 comments)
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/60470/comment/8605c765_ab1a4fe2
PS2, Line 55: return get_log_level();
Looking further into the patch series, you only need the value returned by `get_log_level()`. Why not make `get_log_level()` public (i.e. non-static) instead?
https://review.coreboot.org/c/coreboot/+/60470/comment/e87a686b_3b278dc8
PS2, Line 57: -1
Why?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56349f22c71c9db757b2be8eeb2dbfe959f80397
Gerrit-Change-Number: 60470
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 31 Dec 2021 16:34:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58188 )
Change subject: nb/intel/sandybridge: Populate meminfo when using MRC
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
> what is build_timeless and why would the image be the same if the 2 files those code were not added in before and after ?
Building coreboot with `make BUILD_TIMELESS=1` produces a coreboot.rom that is meant to be reproducible, as it doesn't contain stuff like version information or build time. Reproducible coreboot images can be compared using `diff`, which is useful in some cases to ensure commits don't alter the behavior of the code.
For example, CB:58902 rewrites the HDA configuration for Broadwell-based Purism Librem laptops using macros, but the coreboot.rom doesn't change after the rewrite. This means the rewritten settings exactly correspond to the original settings, so the commit can't cause any issues.
In this commit, `raminit_mrc.c` is not compiled in when using native raminit, and the change to `raminit.h` doesn't have any effect (it's just an unused declaration). This is why the coreboot.rom doesn't change.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58188
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15e00a01121150b778cfa684b9147d0cac97beb8
Gerrit-Change-Number: 58188
Gerrit-PatchSet: 6
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-CC: xin hua wang <xinhuawang0101(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 31 Dec 2021 16:13:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: xin hua wang <xinhuawang0101(a)gmail.com>
Comment-In-Reply-To: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-MessageType: comment
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60377 )
Change subject: mb/google/brya/{brask,gimble}: Use eNEM for CAR by default
......................................................................
mb/google/brya/{brask,gimble}: Use eNEM for CAR by default
More Brya variants like Brask and Gimble have migrated to use Alder Lake
QS SoC which enables eNEM feature by default. Hence, select eNEM for CAR
by default for these variants.
BUG=b:168820083
TEST=Able to build and boot gimble variant using eNEM mode.
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
Change-Id: Ie5734606e58410545a5f5421837080680664707f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60377
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-by: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Reviewed-by: Felix Singer <felixsinger(a)posteo.net>
---
M src/mainboard/google/brya/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Felix Singer: Looks good to me, approved
Angel Pons: Looks good to me, approved
EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig
index 13628dd..b000baf 100644
--- a/src/mainboard/google/brya/Kconfig
+++ b/src/mainboard/google/brya/Kconfig
@@ -176,7 +176,7 @@
choice
prompt "Cache as RAM (CAR) setup configuration to use"
- default USE_ADL_ENEM if BOARD_GOOGLE_KANO || BOARD_GOOGLE_FELWINTER || BOARD_GOOGLE_REDRIX
+ default USE_ADL_ENEM if BOARD_GOOGLE_KANO || BOARD_GOOGLE_FELWINTER || BOARD_GOOGLE_REDRIX || BOARD_GOOGLE_GIMBLE || BOARD_GOOGLE_BRASK
default USE_ADL_NEM
config USE_ADL_ENEM
--
To view, visit https://review.coreboot.org/c/coreboot/+/60377
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5734606e58410545a5f5421837080680664707f
Gerrit-Change-Number: 60377
Gerrit-PatchSet: 9
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: merged
Attention is currently required from: David Wu, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60377 )
Change subject: mb/google/brya/{brask,gimble}: Use eNEM for CAR by default
......................................................................
Patch Set 8:
(2 comments)
Patchset:
PS4:
> Thanks Felix
Thanks Angel and Eric for reviewing even on new year eve. Appreciate your help.
Patchset:
PS8:
> We almost get rid of ES :p
Yup, finally. few more variants to go 😊
--
To view, visit https://review.coreboot.org/c/coreboot/+/60377
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5734606e58410545a5f5421837080680664707f
Gerrit-Change-Number: 60377
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: David Wu <david_wu(a)quantatw.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Fri, 31 Dec 2021 16:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, HAOUAS Elyes.
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60554
to look at the new patch set (#4).
Change subject: src/southbridge: Remove unused <string.h>
......................................................................
src/southbridge: Remove unused <string.h>
Change-Id: Idc0cd9d6865cd9c1b95e6c838795cce9dbc643a3
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/southbridge/intel/bd82x6x/early_me.c
M src/southbridge/intel/bd82x6x/early_me_mrc.c
M src/southbridge/intel/bd82x6x/me.c
M src/southbridge/intel/bd82x6x/me_smm.c
M src/southbridge/intel/common/acpi_pirq_gen.c
M src/southbridge/intel/lynxpoint/early_me.c
6 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/60554/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/60554
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc0cd9d6865cd9c1b95e6c838795cce9dbc643a3
Gerrit-Change-Number: 60554
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset