coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: util: Allow overriding install options
by Stefan Reinauer (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: Tim Crawford. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60540 ) Change subject: util: Allow overriding install options ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a31ea0fde9922731e1621dcc8f94b2c1326c93c Gerrit-Change-Number: 60540 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Comment-Date: Fri, 31 Dec 2021 18:51:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Replace Add(a,b) with ASL 2.0 syntax
by 9elements QA (Code Review) 31 Dec '21

31 Dec '21

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60511 ) Change subject: ec/quanta/it8518/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... Patch Set 4: Automatic boot test returned (PASS/FAIL/TOTAL): 7 / 1 / 8 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/86833 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/86832 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/86831 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/86830 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/86829 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/86828 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/86827 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/86826 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/60511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib00f671d448aa1987542dd1ec81410df65695708 Gerrit-Change-Number: 60511 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 31 Dec 2021 17:49:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: console: Create helper function to get max console log level
by Subrata Banik (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60470 ) Change subject: console: Create helper function to get max console log level ...................................................................... Patch Set 2: (2 comments) File src/console/init.c: https://review.coreboot.org/c/coreboot/+/60470/comment/2fd8a1f6_aae4e08f PS2, Line 55: return get_log_level(); > Looking further into the patch series, you only need the value returned by `get_log_level()`. […] Initially I had the same understanding as well but later I realised that `get_log_level()` will return always Kconfig value irrespective of the console level. For example: irrespective of console type (CONSOLE_LOG_FAST), it will alway return '8' (BIOS_SPEW). Will also let Nico to share his thoughts as he suggested to create console level to msg level function at the first place. https://review.coreboot.org/c/coreboot/+/60470/comment/3ced0d42_6a7efcdb PS2, Line 57: -1 > This will vanish with the changes suggested in my other comment. -1 is kind of invalid so fsp can return `disable` as part of default switch case -- To view, visit https://review.coreboot.org/c/coreboot/+/60470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56349f22c71c9db757b2be8eeb2dbfe959f80397 Gerrit-Change-Number: 60470 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 31 Dec 2021 17:48:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/lib: Remove unused <stdlib.h>
by HAOUAS Elyes (Code Review) 31 Dec '21

31 Dec '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60621 ) Change subject: src/lib: Remove unused <stdlib.h> ...................................................................... src/lib: Remove unused <stdlib.h> Change-Id: I5ad171679cbfa67d522bd1105fb58e0f84b9cb89 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/lib/bootmem.c M src/lib/coreboot_table.c M src/lib/fit.c M src/lib/hardwaremain.c M src/lib/imd.c M src/lib/imd_cbmem.c M src/lib/prog_loaders.c M src/lib/rmodule.c M src/lib/selfboot.c M src/lib/thread.c 10 files changed, 0 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/60621/1 diff --git a/src/lib/bootmem.c b/src/lib/bootmem.c index 1fe23c2..54ab3af 100644 --- a/src/lib/bootmem.c +++ b/src/lib/bootmem.c @@ -4,7 +4,6 @@ #include <bootmem.h> #include <cbmem.h> #include <device/resource.h> -#include <stdlib.h> #include <symbols.h> #include <assert.h> diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index d0cba80..b13d28e 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -14,7 +14,6 @@ #include <drivers/tpm/tpm_ppi.h> #include <fmap.h> #include <fw_config.h> -#include <stdlib.h> #include <cbfs.h> #include <cbmem.h> #include <bootmem.h> diff --git a/src/lib/fit.c b/src/lib/fit.c index 748cd61..6f5186d 100644 --- a/src/lib/fit.c +++ b/src/lib/fit.c @@ -8,7 +8,6 @@ #include <endian.h> #include <stdint.h> #include <bootmem.h> -#include <stdlib.h> #include <string.h> #include <program_loading.h> #include <memrange.h> diff --git a/src/lib/hardwaremain.c b/src/lib/hardwaremain.c index b646e0c..bd57f8c 100644 --- a/src/lib/hardwaremain.c +++ b/src/lib/hardwaremain.c @@ -19,7 +19,6 @@ #include <device/device.h> #include <device/pci.h> #include <program_loading.h> -#include <stdlib.h> #include <thread.h> #include <timer.h> #include <timestamp.h> diff --git a/src/lib/imd.c b/src/lib/imd.c index ac19d76..5cba121 100644 --- a/src/lib/imd.c +++ b/src/lib/imd.c @@ -4,7 +4,6 @@ #include <cbmem.h> #include <console/console.h> #include <imd.h> -#include <stdlib.h> #include <string.h> #include <types.h> #include <imd_private.h> diff --git a/src/lib/imd_cbmem.c b/src/lib/imd_cbmem.c index 4b7c412..93341f2 100644 --- a/src/lib/imd_cbmem.c +++ b/src/lib/imd_cbmem.c @@ -7,7 +7,6 @@ #include <cbmem.h> #include <imd.h> #include <lib.h> -#include <stdlib.h> /* The program loader passes on cbmem_top and the program entry point has to fill in the _cbmem_top_ptr symbol based on the calling arguments. */ diff --git a/src/lib/prog_loaders.c b/src/lib/prog_loaders.c index 878f729e..d23a30b 100644 --- a/src/lib/prog_loaders.c +++ b/src/lib/prog_loaders.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <stdlib.h> #include <cbfs.h> #include <cbmem.h> #include <console/console.h> diff --git a/src/lib/rmodule.c b/src/lib/rmodule.c index 31bf141..5834dbb 100644 --- a/src/lib/rmodule.c +++ b/src/lib/rmodule.c @@ -3,7 +3,6 @@ #include <cbmem.h> #include <cbfs.h> #include <stdint.h> -#include <stdlib.h> #include <string.h> #include <console/console.h> #include <program_loading.h> diff --git a/src/lib/selfboot.c b/src/lib/selfboot.c index f1c0b97..9ccec11 100644 --- a/src/lib/selfboot.c +++ b/src/lib/selfboot.c @@ -4,7 +4,6 @@ #include <commonlib/endian.h> #include <console/console.h> #include <stdint.h> -#include <stdlib.h> #include <string.h> #include <symbols.h> #include <cbfs.h> diff --git a/src/lib/thread.c b/src/lib/thread.c index 0393ca7..0dcf895 100644 --- a/src/lib/thread.c +++ b/src/lib/thread.c @@ -3,7 +3,6 @@ #include <assert.h> #include <stddef.h> #include <stdint.h> -#include <stdlib.h> #include <bootstate.h> #include <commonlib/bsd/compiler.h> #include <console/console.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/60621 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ad171679cbfa67d522bd1105fb58e0f84b9cb89 Gerrit-Change-Number: 60621 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/commonlib: Remove unused <stdlib.h>
by HAOUAS Elyes (Code Review) 31 Dec '21

31 Dec '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60620 ) Change subject: src/commonlib: Remove unused <stdlib.h> ...................................................................... src/commonlib: Remove unused <stdlib.h> Change-Id: I3c2668013c16d6771268e8739b1370968c2e120b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/commonlib/fsp_relocate.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/60620/1 diff --git a/src/commonlib/fsp_relocate.c b/src/commonlib/fsp_relocate.c index 5d326b6..7a82e73 100644 --- a/src/commonlib/fsp_relocate.c +++ b/src/commonlib/fsp_relocate.c @@ -18,7 +18,6 @@ #pragma pack(pop) #include <commonlib/helpers.h> -#include <stdlib.h> #include <stdint.h> #include <string.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/60620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c2668013c16d6771268e8739b1370968c2e120b Gerrit-Change-Number: 60620 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/drivers/i2c/gpiomux: Remove unused <stdlib.h>
by HAOUAS Elyes (Code Review) 31 Dec '21

31 Dec '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60619 ) Change subject: src/drivers/i2c/gpiomux: Remove unused <stdlib.h> ...................................................................... src/drivers/i2c/gpiomux: Remove unused <stdlib.h> Change-Id: Id3bd3d8a2d3609a13ecbc4eab14ba745e6365cab Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/i2c/gpiomux/bus/bus.c M src/drivers/i2c/gpiomux/mux/mux.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/60619/1 diff --git a/src/drivers/i2c/gpiomux/bus/bus.c b/src/drivers/i2c/gpiomux/bus/bus.c index 7530e54..be48313 100644 --- a/src/drivers/i2c/gpiomux/bus/bus.c +++ b/src/drivers/i2c/gpiomux/bus/bus.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> -#include <stdlib.h> #include "chip.h" diff --git a/src/drivers/i2c/gpiomux/mux/mux.c b/src/drivers/i2c/gpiomux/mux/mux.c index 0730536..64e56e5 100644 --- a/src/drivers/i2c/gpiomux/mux/mux.c +++ b/src/drivers/i2c/gpiomux/mux/mux.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> -#include <stdlib.h> #include "chip.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/60619 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3bd3d8a2d3609a13ecbc4eab14ba745e6365cab Gerrit-Change-Number: 60619 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/mainboard: Remove unused <stdlib.h>
by HAOUAS Elyes (Code Review) 31 Dec '21

31 Dec '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60618 ) Change subject: src/mainboard: Remove unused <stdlib.h> ...................................................................... src/mainboard: Remove unused <stdlib.h> Change-Id: Ibc594dc6904b26842cf007884ad1913f99a337f2 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c M src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c M src/mainboard/lippert/frontrunner-af/variants/toucan-af/mainboard.c 4 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/60618/1 diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c index 45b9e1d..ffcfb25 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c @@ -5,7 +5,6 @@ #include <gpio.h> #include <soc/gpio.h> #include <soc/smi.h> -#include <stdlib.h> #include <variant/gpio.h> static const struct soc_amd_gpio gpio_set_stage_ram[] = { diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c index 7220c38..ae1252d 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c @@ -7,7 +7,6 @@ #include <gpio.h> #include <soc/gpio.h> #include <soc/smi.h> -#include <stdlib.h> #include <variant/gpio.h> static const struct soc_amd_gpio gpio_set_stage_ram[] = { diff --git a/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c b/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c index 3302556..8fa897e 100644 --- a/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c +++ b/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <stdlib.h> #include <amdblocks/acpimmio.h> #include <amdblocks/acpimmio_legacy_gpio100.h> #include <console/console.h> diff --git a/src/mainboard/lippert/frontrunner-af/variants/toucan-af/mainboard.c b/src/mainboard/lippert/frontrunner-af/variants/toucan-af/mainboard.c index 09695d4..6492f56 100644 --- a/src/mainboard/lippert/frontrunner-af/variants/toucan-af/mainboard.c +++ b/src/mainboard/lippert/frontrunner-af/variants/toucan-af/mainboard.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <stdlib.h> #include <amdblocks/acpimmio.h> #include <amdblocks/acpimmio_legacy_gpio100.h> #include <console/console.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/60618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc594dc6904b26842cf007884ad1913f99a337f2 Gerrit-Change-Number: 60618 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/soc: Remove unused <stdlib.h>
by HAOUAS Elyes (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Anjaneya "Reddy" Chagam, Marshall Dawson, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Patrick Rudolph, Tim Chu, Felix Held. HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60617 ) Change subject: src/soc: Remove unused <stdlib.h> ...................................................................... src/soc: Remove unused <stdlib.h> Change-Id: I08e1a680de9bfcc7d74e88a15abe9eef327b4961 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/amd/common/block/acpi/ivrs.c M src/soc/amd/picasso/agesa_acpi.c M src/soc/intel/common/block/tcss/tcss.c M src/soc/intel/xeon_sp/cpx/soc_util.c 4 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/60617/1 diff --git a/src/soc/amd/common/block/acpi/ivrs.c b/src/soc/amd/common/block/acpi/ivrs.c index 7b2db3a..c5218ea 100644 --- a/src/soc/amd/common/block/acpi/ivrs.c +++ b/src/soc/amd/common/block/acpi/ivrs.c @@ -15,7 +15,6 @@ #include <soc/acpi.h> #include <soc/data_fabric.h> #include <soc/pci_devs.h> -#include <stdlib.h> #define MAX_DEV_ID 0xFFFF diff --git a/src/soc/amd/picasso/agesa_acpi.c b/src/soc/amd/picasso/agesa_acpi.c index 4ab31e5..95feaed 100644 --- a/src/soc/amd/picasso/agesa_acpi.c +++ b/src/soc/amd/picasso/agesa_acpi.c @@ -19,7 +19,6 @@ #include <amdblocks/ioapic.h> #include <soc/data_fabric.h> #include <soc/pci_devs.h> -#include <stdlib.h> #include <arch/mmio.h> static unsigned long gen_crat_hsa_entry(struct acpi_crat_header *crat, unsigned long current) diff --git a/src/soc/intel/common/block/tcss/tcss.c b/src/soc/intel/common/block/tcss/tcss.c index 03f630c..3e11865 100644 --- a/src/soc/intel/common/block/tcss/tcss.c +++ b/src/soc/intel/common/block/tcss/tcss.c @@ -11,7 +11,6 @@ #include <soc/pci_devs.h> #include <soc/pcr_ids.h> #include <soc/tcss.h> -#include <stdlib.h> #include <drivers/intel/pmc_mux/conn/chip.h> #define BIAS_CTRL_VW_INDEX_SHIFT 16 diff --git a/src/soc/intel/xeon_sp/cpx/soc_util.c b/src/soc/intel/xeon_sp/cpx/soc_util.c index 7a8403e..ed23976 100644 --- a/src/soc/intel/xeon_sp/cpx/soc_util.c +++ b/src/soc/intel/xeon_sp/cpx/soc_util.c @@ -8,7 +8,6 @@ #include <soc/pci_devs.h> #include <soc/soc_util.h> #include <soc/util.h> -#include <stdlib.h> const struct SystemMemoryMapHob *get_system_memory_map(void) { -- To view, visit https://review.coreboot.org/c/coreboot/+/60617 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08e1a680de9bfcc7d74e88a15abe9eef327b4961 Gerrit-Change-Number: 60617 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/superio/smsc: Remove unused <stdlib.h>
by HAOUAS Elyes (Code Review) 31 Dec '21

31 Dec '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60616 ) Change subject: src/superio/smsc: Remove unused <stdlib.h> ...................................................................... src/superio/smsc: Remove unused <stdlib.h> Change-Id: Icb747bcb702a81750a927272432666ffe603ca55 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/superio/smsc/sch5545/superio.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/60616/1 diff --git a/src/superio/smsc/sch5545/superio.c b/src/superio/smsc/sch5545/superio.c index 2fe5d03..7952eb8 100644 --- a/src/superio/smsc/sch5545/superio.c +++ b/src/superio/smsc/sch5545/superio.c @@ -6,7 +6,6 @@ #include <superio/conf_mode.h> #include <console/console.h> #include <pc80/keyboard.h> -#include <stdlib.h> #include "sch5545.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/60616 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb747bcb702a81750a927272432666ffe603ca55 Gerrit-Change-Number: 60616 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/common/cse: Implement HECI notify
by Subrata Banik (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: Arthur Heymans, Felix Singer, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60405 ) Change subject: soc/intel/common/cse: Implement HECI notify ...................................................................... Patch Set 7: (1 comment) File src/soc/intel/common/block/cse/cse_eop.c: https://review.coreboot.org/c/coreboot/+/60405/comment/86dc386d_33a5c0bb PS7, Line 279: HeciEnabled > Hmmm, `soc/intel/cannonlake` doesn't have this. […] I do remember CNL/CML I used this config for sure. But let it might have dropped. https://review.coreboot.org/c/coreboot/+/33193/9/src/soc/intel/cannonlake/s… `HeciEnabled` we can replace using below check ? WDYT? if (!is_devfn_enabled(PCH_DEVFN_CSE)) -- To view, visit https://review.coreboot.org/c/coreboot/+/60405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70bde33f77026e8be165ff082defe3cab6686ec7 Gerrit-Change-Number: 60405 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 31 Dec 2021 17:38:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021