coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: northbridge/amd/pi/00730F01: enable PARALLEL_MP
by Michał Kopeć (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Michał Żygowski, Paul Menzel, Angel Pons, Arthur Heymans. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59808 ) Change subject: northbridge/amd/pi/00730F01: enable PARALLEL_MP ...................................................................... Patch Set 5: (2 comments) File src/northbridge/amd/pi/00730F01/northbridge.c: https://review.coreboot.org/c/coreboot/+/59808/comment/db6d705b_8ee3a574 PS2, Line 955: /* : * APIC ID calculation is tightly coupled with AGESA v5 code. : * This calculation MUST match the assignment calculation done : * in LocalApicInitializationAtEarly() function. : * And reference GetLocalApicIdForCore() : * : * Apply APIC enumeration rules : * For systems with >= 16 APICs, put the IO-APICs at 0..n and : * put the local-APICs at m..z : * : * This is needed because many IO-APIC devices only have 4 bits : * for their APIC id and therefore must reside at 0..15 : */ : if ((node_nums * core_max) + ioapic_count >= 0x10) { : lapicid_start = (ioapic_count - 1) / core_max; : lapicid_start = (lapicid_start + 1) * core_max; : printk(BIOS_SPEW, "lpaicid_start = 0x%x ", lapicid_start); : } : u32 apic_id = (lapicid_start * (i/modules + 1)) + ((i % modules) ? (j + (siblings + 1)) : j); : printk(BIOS_SPEW, "node 0x%x core 0x%x apicid = 0x%x\n", : i, j, apic_id); : : struct device *cpu = add_cpu_device(cpu_bus, apic_id, enable_node); : if (cpu) : amd_cpu_topology(cpu, i, j); > Removed Done File src/northbridge/amd/pi/00730F01/northbridge.c: https://review.coreboot.org/c/coreboot/+/59808/comment/ac9856b8_55b2ac3f PS4, Line 900: /* The flash is now no longer cacheable. Reset to WP for performance. */ : mtrr_use_temp_range(OPTIMAL_CACHE_ROM_BASE, OPTIMAL_CACHE_ROM_SIZE, : MTRR_TYPE_WRPROT); > If I do it in `pre_mp_init`, Linux complains about inconsistent MTRRs. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib49e7d3f5956ac7831664d50db5f233b70aa54db Gerrit-Change-Number: 59808 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 02 Dec 2021 14:49:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h
by Michał Kopeć (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Michał Żygowski. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59809 ) Change subject: cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59809/comment/0a4dbe8b_6f6ddcdb PS4, Line 12: TEST=Boot on PC Engines apu1 > Boot what? Seems something is missing between "Boot" and "on" Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59809 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09bbe036a88dada847219606ec79c68e7ca8e5cc Gerrit-Change-Number: 59809 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Thu, 02 Dec 2021 14:16:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/amd/pi/Kconfig: select NO_SMM
by Michał Kopeć (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Michał Żygowski. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59810 ) Change subject: cpu/amd/pi/Kconfig: select NO_SMM ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59810/comment/a917b861_a167e531 PS2, Line 9: Disable SMM_ASEG and select NO_SMM since we don't use SMM. > `we don't` -> `the platforms do not use SMM` Done https://review.coreboot.org/c/coreboot/+/59810/comment/d6c0c4b7_44ace60a PS2, Line 11: TEST=Boot on PC Engines apu3 > Boot what? Seems something is missing between "Boot" and "on" Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47237421c3dd5bd043447831263d72c9956cdaf4 Gerrit-Change-Number: 59810 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Thu, 02 Dec 2021 14:15:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/amd/pi/Kconfig: select NO_SMM
by Michał Kopeć (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Michał Kopeć. Hello build bot (Jenkins), Michał Żygowski, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59810 to look at the new patch set (#3). Change subject: cpu/amd/pi/Kconfig: select NO_SMM ...................................................................... cpu/amd/pi/Kconfig: select NO_SMM Disable SMM_ASEG and select NO_SMM since the platforms do not use SMM. TEST=Boot Debian 11 on PC Engines apu3 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Change-Id: I47237421c3dd5bd043447831263d72c9956cdaf4 --- M src/cpu/amd/pi/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/59810/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/59810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47237421c3dd5bd043447831263d72c9956cdaf4 Gerrit-Change-Number: 59810 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h
by Michał Kopeć (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Michał Kopeć. Hello build bot (Jenkins), Michał Żygowski, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59809 to look at the new patch set (#5). Change subject: cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h ...................................................................... cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h Select NO_SMM for Family 14h since since there is not a single platform selecting HAVE_SMI_HANDLER. TEST=Boot Debian 11 on PC Engines apu1 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Change-Id: I09bbe036a88dada847219606ec79c68e7ca8e5cc --- M src/cpu/amd/agesa/Kconfig 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/59809/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/59809 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09bbe036a88dada847219606ec79c68e7ca8e5cc Gerrit-Change-Number: 59809 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/amd/pi/Kconfig: select NO_SMM
by Michał Żygowski (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Michał Kopeć. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59810 ) Change subject: cpu/amd/pi/Kconfig: select NO_SMM ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59810/comment/f561e65c_ef97ca6e PS2, Line 9: Disable SMM_ASEG and select NO_SMM since we don't use SMM. `we don't` -> `the platforms do not use SMM` https://review.coreboot.org/c/coreboot/+/59810/comment/09c450a5_37de0e58 PS2, Line 11: TEST=Boot on PC Engines apu3 Boot what? Seems something is missing between "Boot" and "on" -- To view, visit https://review.coreboot.org/c/coreboot/+/59810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47237421c3dd5bd043447831263d72c9956cdaf4 Gerrit-Change-Number: 59810 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Thu, 02 Dec 2021 14:11:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h
by Michał Żygowski (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Michał Kopeć. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59809 ) Change subject: cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59809/comment/df38c404_c807ee39 PS4, Line 12: TEST=Boot on PC Engines apu1 Boot what? Seems something is missing between "Boot" and "on" -- To view, visit https://review.coreboot.org/c/coreboot/+/59809 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09bbe036a88dada847219606ec79c68e7ca8e5cc Gerrit-Change-Number: 59809 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Thu, 02 Dec 2021 14:10:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: northbridge/amd/pi/00730F01: enable PARALLEL_MP
by Arthur Heymans (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Michał Żygowski, Michał Kopeć, Paul Menzel, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59808 ) Change subject: northbridge/amd/pi/00730F01: enable PARALLEL_MP ...................................................................... Patch Set 5: (1 comment) File src/northbridge/amd/pi/00730F01/northbridge.c: https://review.coreboot.org/c/coreboot/+/59808/comment/7aa6fe11_dd9a4cb5 PS4, Line 874: sysconf_init > It's also used in `domain_read_resources`. I'm not sure where else this can be moved Something like "static int get_node_nums()" which first does a PCI read but later returns a static local variable instead of relying on a global variable? -- To view, visit https://review.coreboot.org/c/coreboot/+/59808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib49e7d3f5956ac7831664d50db5f233b70aa54db Gerrit-Change-Number: 59808 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Dec 2021 13:43:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/amd/pi/Kconfig: select NO_SMM
by Michał Kopeć (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Michał Żygowski. Hello build bot (Jenkins), Michał Żygowski, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59810 to look at the new patch set (#2). Change subject: cpu/amd/pi/Kconfig: select NO_SMM ...................................................................... cpu/amd/pi/Kconfig: select NO_SMM Disable SMM_ASEG and select NO_SMM since we don't use SMM. TEST=Boot on PC Engines apu3 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Change-Id: I47237421c3dd5bd043447831263d72c9956cdaf4 --- M src/cpu/amd/pi/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/59810/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47237421c3dd5bd043447831263d72c9956cdaf4 Gerrit-Change-Number: 59810 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h
by Michał Kopeć (Code Review) 02 Dec '21

02 Dec '21

Attention is currently required from: Michał Żygowski. Hello build bot (Jenkins), Michał Żygowski, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59809 to look at the new patch set (#4). Change subject: cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h ...................................................................... cpu/amd/agesa/Kconfig: select NO_SMM for Family 14h Select NO_SMM for Family 14h since since there is not a single platform selecting HAVE_SMI_HANDLER. TEST=Boot on PC Engines apu1 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Change-Id: I09bbe036a88dada847219606ec79c68e7ca8e5cc --- M src/cpu/amd/agesa/Kconfig 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/59809/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/59809 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09bbe036a88dada847219606ec79c68e7ca8e5cc Gerrit-Change-Number: 59809 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021