coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: cpu/intel: Get cpu index based on LAPIC id
by Sridhar Siricilla (Code Review) 03 Dec '21

03 Dec '21

Sridhar Siricilla has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/59357 ) Change subject: cpu/intel: Get cpu index based on LAPIC id ...................................................................... Abandoned As the patch has been reformatted, so abandoning the patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/59357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If18116472aaa78cfa88350f313c246a28f67303d Gerrit-Change-Number: 59357 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Makefile.inc: Enable iasl multiple types warning
by HAOUAS Elyes (Code Review) 03 Dec '21

03 Dec '21

Attention is currently required from: Martin Roth. Hello build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59415 to look at the new patch set (#2). Change subject: Makefile.inc: Enable iasl multiple types warning ...................................................................... Makefile.inc: Enable iasl multiple types warning Intel Lynxpoint ASL code is fixed. So don't ignore "Multiple types (Device object requires either a _HID or _ADR, but not both)" warning. Change-Id: Ie9398879a76ad3d36454772a1c23da083af14b59 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M Makefile.inc 1 file changed, 0 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/59415/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59415 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9398879a76ad3d36454772a1c23da083af14b59 Gerrit-Change-Number: 59415 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Add dewatt device config
by Kenneth Chan (Code Review) 03 Dec '21

03 Dec '21

Attention is currently required from: Paul Menzel, Rob Barnes. Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59839 ) Change subject: mb/google/guybrush/var/dewatt: Add dewatt device config ...................................................................... Patch Set 3: Code-Review+1 (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59839/comment/7c20b666_cff5814e PS2, Line 7: initial dewatt device config > Please make it a statement by adding a verb (in imperative mood): […] Done https://review.coreboot.org/c/coreboot/+/59839/comment/a1d6a923_659d078f PS2, Line 7: initial > There is already some device configuration? Why “initial”? Done https://review.coreboot.org/c/coreboot/+/59839/comment/b23d8fd8_cc026c40 PS2, Line 7: dewatt > var/dewatt Done https://review.coreboot.org/c/coreboot/+/59839/comment/777daebe_86016370 PS2, Line 9: add Synaptics S9831 touch pad for dewatt : add Elan 6918 touch screen for dewatt : add Realtek 5682 , ALC1019 for dewatt > Please format it as a list. Done https://review.coreboot.org/c/coreboot/+/59839/comment/ba30ec1c_cdc57d80 PS2, Line 11: 5682 , > Please remove the space. Done https://review.coreboot.org/c/coreboot/+/59839/comment/28879b54_070a3052 PS2, Line 12: > Where did you get the “data” from. […] 1.Synaptics S9831 product spec located in https://partnerissuetracker.corp.google.com/issues/208182457 commit#4. 2.Elan 6918 referred to other project's setting : https://review.coreboot.org/c/coreboot/+/58967/3/src/mainboard/google/deded… 3.Realtek 5682 and ALC1019 referred to guybrush reference board setting. -- To view, visit https://review.coreboot.org/c/coreboot/+/59839 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01eb3b7c194dffd417b81386903d5bd437cd9b3e Gerrit-Change-Number: 59839 Gerrit-PatchSet: 3 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Fri, 03 Dec 2021 09:07:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Add dewatt device config
by Kenneth Chan (Code Review) 03 Dec '21

03 Dec '21

Attention is currently required from: Kenneth Chan, Rob Barnes. Hello build bot (Jenkins), Rob Barnes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59839 to look at the new patch set (#3). Change subject: mb/google/guybrush/var/dewatt: Add dewatt device config ...................................................................... mb/google/guybrush/var/dewatt: Add dewatt device config 1.Add Synaptics S9831 touch pad for dewatt. 2.Add Elan 6918 touch screen for dewatt. 3.Add Realtek 5682 and ALC1019 for dewatt. BUG=b:208182457,b:208373433,b:208172493 TEST=emerge-guybrush coreboot chromeos-bootimage Change-Id: I01eb3b7c194dffd417b81386903d5bd437cd9b3e Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> --- M src/mainboard/google/guybrush/variants/dewatt/Makefile.inc A src/mainboard/google/guybrush/variants/dewatt/gpio.c M src/mainboard/google/guybrush/variants/dewatt/overridetree.cb 3 files changed, 131 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/59839/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/59839 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01eb3b7c194dffd417b81386903d5bd437cd9b3e Gerrit-Change-Number: 59839 Gerrit-PatchSet: 3 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: TEST - touch screen ELAN9008
by Paul2 Huang (Code Review) 03 Dec '21

03 Dec '21

Paul2 Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59859 ) Change subject: TEST - touch screen ELAN9008 ...................................................................... TEST - touch screen ELAN9008 Change-Id: Ie0919d40a6c39ffaed52bb9e24a3509eb353127c --- M src/mainboard/google/octopus/variants/ampton/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/59859/1 diff --git a/src/mainboard/google/octopus/variants/ampton/overridetree.cb b/src/mainboard/google/octopus/variants/ampton/overridetree.cb index cfc5e8a..dbc4c95 100644 --- a/src/mainboard/google/octopus/variants/ampton/overridetree.cb +++ b/src/mainboard/google/octopus/variants/ampton/overridetree.cb @@ -135,6 +135,20 @@ register "hid_desc_reg_offset" = "0x01" device i2c 40 on end end + chip drivers/i2c/hid + register "generic.hid" = ""ELAN9008"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" + register "generic.reset_delay_ms" = "20" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)" + register "generic.enable_delay_ms" = "7" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 10 on end + end end # - I2C 7 end end -- To view, visit https://review.coreboot.org/c/coreboot/+/59859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie0919d40a6c39ffaed52bb9e24a3509eb353127c Gerrit-Change-Number: 59859 Gerrit-PatchSet: 1 Gerrit-Owner: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: tests: Disable -Wmain-return-type for clang
by Jakub Czapiga (Code Review) 03 Dec '21

03 Dec '21

Attention is currently required from: Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59815 ) Change subject: tests: Disable -Wmain-return-type for clang ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Oh, and please add it to the payloads/libpayload/tests/Makefile.inc too. -- To view, visit https://review.coreboot.org/c/coreboot/+/59815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I867c9dac659be86e7b7cf4cc41d6fa105aa9ac41 Gerrit-Change-Number: 59815 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 03 Dec 2021 08:53:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Fix objcopy --add-symbol arguments creation
by Jakub Czapiga (Code Review) 03 Dec '21

03 Dec '21

Jakub Czapiga has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59858 ) Change subject: tests: Fix objcopy --add-symbol arguments creation ...................................................................... tests: Fix objcopy --add-symbol arguments creation Remove unnecessary escape bachslashes from: addr="$(echo \"$$$$sym_line\" ... The 'echo' will print output line with double quote characters, which then will be included in the values passed to --add-symbol. This can cause errors. Change-Id: I6023515191d6c236bf57870159a35d518f25e9d8 Reported-by: Yu-Ping Wu <yupingso(a)chromium.org> Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> --- M payloads/libpayload/tests/Makefile.inc M tests/Makefile.inc 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/59858/1 diff --git a/payloads/libpayload/tests/Makefile.inc b/payloads/libpayload/tests/Makefile.inc index c4463d7..bf484bb 100644 --- a/payloads/libpayload/tests/Makefile.inc +++ b/payloads/libpayload/tests/Makefile.inc @@ -141,8 +141,8 @@ sym_line="$$$$($(HOSTOBJDUMP) -t $$@.orig \ | grep -E "[0-9a-fA-F]+\\s+w\\s+F\\s+.*\\s+$$$$sym$$$$")"; \ if [ ! -z "$$$$sym_line" ] ; then \ - addr="$$$$(echo \"$$$$sym_line\" | awk '{ print $$$$1 }')"; \ - section="$$$$(echo \"$$$$sym_line\" | awk '{ print $$$$(NF - 2) }')"; \ + addr="$$$$(echo "$$$$sym_line" | awk '{ print $$$$1 }')"; \ + section="$$$$(echo "$$$$sym_line" | awk '{ print $$$$(NF - 2) }')"; \ objcopy_wrap_flags="$$$$objcopy_wrap_flags --add-symbol __real_$$$${sym}=$$$${section}:0x$$$${addr},function,global"; \ fi \ done ; \ diff --git a/tests/Makefile.inc b/tests/Makefile.inc index 7a7ab1d..cbaf2c2 100644 --- a/tests/Makefile.inc +++ b/tests/Makefile.inc @@ -156,10 +156,11 @@ -MF $$(basename $$(a)).d -MT $$@ -c $$< -o $$@.orig objcopy_wrap_flags=''; \ for sym in $$($(1)-mocks); do \ - sym_line="$$$$($(OBJDUMP) -t $$@.orig | grep -E "[0-9a-fA-F]+\\s+w\\s+F\\s+.*\\s$$$$sym$$$$")"; \ + sym_line="$$$$($(OBJDUMP) -t $$@.orig \ + | grep -E "[0-9a-fA-F]+\\s+w\\s+F\\s+.*\\s$$$$sym$$$$")"; \ if [ ! -z "$$$$sym_line" ] ; then \ - addr="$$$$(echo \"$$$$sym_line\" | awk '{ print $$$$1 }')"; \ - section="$$$$(echo \"$$$$sym_line\" | awk '{ print $$$$(NF - 2) }')"; \ + addr="$$$$(echo "$$$$sym_line" | awk '{ print $$$$1 }')"; \ + section="$$$$(echo "$$$$sym_line" | awk '{ print $$$$(NF - 2) }')"; \ objcopy_wrap_flags="$$$$objcopy_wrap_flags --add-symbol __real_$$$${sym}=$$$${section}:0x$$$${addr},function,global"; \ fi \ done ; \ -- To view, visit https://review.coreboot.org/c/coreboot/+/59858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6023515191d6c236bf57870159a35d518f25e9d8 Gerrit-Change-Number: 59858 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/common: Refactor cpu_set_p_state_to_max_non_turbo_ratio
by Subrata Banik (Code Review) 03 Dec '21

03 Dec '21

Attention is currently required from: Sridhar Siricilla, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59789 ) Change subject: soc/intel/common: Refactor cpu_set_p_state_to_max_non_turbo_ratio ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If73df17faaf7b870ae311460a868d52352683c0c Gerrit-Change-Number: 59789 Gerrit-PatchSet: 2 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 03 Dec 2021 08:34:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Disable -Wsource-mgr for clang
by Jakub Czapiga (Code Review) 03 Dec '21

03 Dec '21

Attention is currently required from: Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59814 ) Change subject: tests: Disable -Wsource-mgr for clang ...................................................................... Patch Set 1: (1 comment) File tests/Makefile.inc: https://review.coreboot.org/c/coreboot/+/59814/comment/7733c586_26ee3a36 PS1, Line 48: -Wno-source-mgr It should probably be enclosed in check for correct version of clang. I tried compiling unit-tests with clang 11.1.0-4+build2 and it fails to recognize this option. Another option is to disable unknown fwarning option error: -Wno-unknown-warning-option -- To view, visit https://review.coreboot.org/c/coreboot/+/59814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie49c9eef3c74592c068c899c6717621dbcb9f609 Gerrit-Change-Number: 59814 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 03 Dec 2021 07:57:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Disable -Wmain-return-type for clang
by Jakub Czapiga (Code Review) 03 Dec '21

03 Dec '21

Attention is currently required from: Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59815 ) Change subject: tests: Disable -Wmain-return-type for clang ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I867c9dac659be86e7b7cf4cc41d6fa105aa9ac41 Gerrit-Change-Number: 59815 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 03 Dec 2021 07:49:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021