coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: drivers/intel/mipi_camera: Add ACPI entry to provide silicon type info
by Sugnan Prabhu S (Code Review) 07 Dec '21

07 Dec '21

Attention is currently required from: Tian Shu Qiu, Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph. Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59869 ) Change subject: drivers/intel/mipi_camera: Add ACPI entry to provide silicon type info ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59869/comment/997f219f_a37ca584 PS3, Line 13: 207721978 > Can you add below text to commit? […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e0af1dd50b9c014cae5454fcd4f9f76d0e0a85f Gerrit-Change-Number: 59869 Gerrit-PatchSet: 4 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tian Shu Qiu <tian.shu.qiu(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tian Shu Qiu <tian.shu.qiu(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 07 Dec 2021 09:55:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/mipi_camera: Add ACPI entry to provide silicon type info
by Sugnan Prabhu S (Code Review) 07 Dec '21

07 Dec '21

Attention is currently required from: Tian Shu Qiu, Sugnan Prabhu S, Tim Wawrzynczak, Patrick Rudolph. Hello build bot (Jenkins), Tian Shu Qiu, Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59869 to look at the new patch set (#4). Change subject: drivers/intel/mipi_camera: Add ACPI entry to provide silicon type info ...................................................................... drivers/intel/mipi_camera: Add ACPI entry to provide silicon type info Add entry in ACPI table under IPU device to provide silicon type information to IPU driver. IPU driver can decide the type of firmware to load based on this information. BUG=b:207721978 BRANCH=none TEST=Check for the ACPI entry in the SSDT after booting to kernel Change-Id: I4e0af1dd50b9c014cae5454fcd4f9f76d0e0a85f Cq-Depend: chromium:3319905 Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> --- M src/drivers/intel/mipi_camera/camera.c M src/soc/intel/alderlake/Kconfig 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/59869/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/59869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e0af1dd50b9c014cae5454fcd4f9f76d0e0a85f Gerrit-Change-Number: 59869 Gerrit-PatchSet: 4 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tian Shu Qiu <tian.shu.qiu(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tian Shu Qiu <tian.shu.qiu(a)intel.com> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/mipi_camera: Add ACPI entry to provide silicon type info
by Sridhar Siricilla (Code Review) 07 Dec '21

07 Dec '21

Attention is currently required from: Tian Shu Qiu, Sugnan Prabhu S, Tim Wawrzynczak, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59869 ) Change subject: drivers/intel/mipi_camera: Add ACPI entry to provide silicon type info ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59869/comment/2359b8d4_ed4c9c15 PS3, Line 13: 207721978 Can you add below text to commit? `Cq-Depend: chromium:3319905` -- To view, visit https://review.coreboot.org/c/coreboot/+/59869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e0af1dd50b9c014cae5454fcd4f9f76d0e0a85f Gerrit-Change-Number: 59869 Gerrit-PatchSet: 3 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tian Shu Qiu <tian.shu.qiu(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tian Shu Qiu <tian.shu.qiu(a)intel.com> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 07 Dec 2021 09:50:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/octopus/var/ampton: add touchscreen into SSFC support
by Paul2 Huang (Code Review) 07 Dec '21

07 Dec '21

Attention is currently required from: Henry Sun, Marco Chen. Paul2 Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59859 ) Change subject: mb/google/octopus/var/ampton: add touchscreen into SSFC support ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/octopus/variants/baseboard/include/baseboard/cbi_ssfc.h: https://review.coreboot.org/c/coreboot/+/59859/comment/4077b867_5cb753b4 PS7, Line 44: SSFC_TOUCHSCREEN_ELAN9008, > Generally for touch devices, we allow multiple objects to be registered in the device tree for kerne […] Yes, ELAN9008 and ELAN0001 both are at same slave address (0x10) -- To view, visit https://review.coreboot.org/c/coreboot/+/59859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie0919d40a6c39ffaed52bb9e24a3509eb353127c Gerrit-Change-Number: 59859 Gerrit-PatchSet: 7 Gerrit-Owner: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Marco Chen <marcochen(a)google.com> Gerrit-Comment-Date: Tue, 07 Dec 2021 09:29:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marco Chen <marcochen(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Provide includes for payloads
by Jakub Czapiga (Code Review) 07 Dec '21

07 Dec '21

Attention is currently required from: Patrick Georgi. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59916 ) Change subject: libpayload: Provide includes for payloads ...................................................................... Patch Set 2: (1 comment) File payloads/libpayload/Makefile.inc: https://review.coreboot.org/c/coreboot/+/59916/comment/39eb7ce9_ef06ad49 PS2, Line 132: for file in `find $(coreboottop)/src/commonlib/bsd/include -name *.h -type f`; do \ 1. Do we want to provide (PD)curses includes? 2. Should the structure of libpayload build dir be changed to reflect one from the <install> target? -- To view, visit https://review.coreboot.org/c/coreboot/+/59916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc7175240f3077ec98280331f9a952310aae4341 Gerrit-Change-Number: 59916 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Dec 2021 08:56:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/octopus: add audio codec into SSFC support for ApelE
by Marco Chen (Code Review) 07 Dec '21

07 Dec '21

Attention is currently required from: Henry Sun, Paul2 Huang. Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59856 ) Change subject: mb/google/octopus: add audio codec into SSFC support for ApelE ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/octopus/mainboard.c: https://review.coreboot.org/c/coreboot/+/59856/comment/b24d8ead_755be3e7 PS4, Line 218: cfg->hid = "RTL5682"; Originally we expect overridetree.cb should give us a clear view of what candidate components are possible to be in this variant. For example, RT5682_VD / DS7219 / CS42L42 are candidates. Then SSFC can filter out others and keep the real candidate only. This CL mixes the usage of SSFC and overridetree.cb together by changing the hid name here which is what we would like to avoid. As a result, please make another object for VS in the overridetree.cb explicitly then manage it specifically here without touching VD object. Since they are all using drivers_i2c_generic_ops, we can combine VD / VS into a if () like if ((audio_dev->chip_ops == &drivers_i2c_generic_ops) { if (SSFC_VD && hid == 10EC5682) { .... } if (SSFC_VS && hid == RTL5682) { .... } } -- To view, visit https://review.coreboot.org/c/coreboot/+/59856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80be12d88e100ce8586371fc49b36447859e24f8 Gerrit-Change-Number: 59856 Gerrit-PatchSet: 4 Gerrit-Owner: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Tue, 07 Dec 2021 08:43:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Disable -Wmain-return-type for clang
by Jakub Czapiga (Code Review) 07 Dec '21

07 Dec '21

Attention is currently required from: Paul Menzel, Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59815 ) Change subject: tests: Disable -Wmain-return-type for clang ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I867c9dac659be86e7b7cf4cc41d6fa105aa9ac41 Gerrit-Change-Number: 59815 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 07 Dec 2021 08:42:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Disable -Wsource-mgr for clang
by Jakub Czapiga (Code Review) 07 Dec '21

07 Dec '21

Attention is currently required from: Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59814 ) Change subject: tests: Disable -Wsource-mgr for clang ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie49c9eef3c74592c068c899c6717621dbcb9f609 Gerrit-Change-Number: 59814 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 07 Dec 2021 08:41:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/octopus/var/ampton: add touchscreen into SSFC support
by Marco Chen (Code Review) 07 Dec '21

07 Dec '21

Attention is currently required from: Henry Sun, Paul2 Huang. Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59859 ) Change subject: mb/google/octopus/var/ampton: add touchscreen into SSFC support ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/octopus/variants/baseboard/include/baseboard/cbi_ssfc.h: https://review.coreboot.org/c/coreboot/+/59859/comment/8a3823ee_06a4f175 PS7, Line 44: SSFC_TOUCHSCREEN_ELAN9008, Generally for touch devices, we allow multiple objects to be registered in the device tree for kernel to probe the correct one in the end. As a result, we don't need SSFC here to filter correct touch device in this device in the coreboot stage. Or do you have any special reason of the model above might not work? For example, the slave address of 9008 is the same with other existed touch device and kernel can't probe them correctly? -- To view, visit https://review.coreboot.org/c/coreboot/+/59859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie0919d40a6c39ffaed52bb9e24a3509eb353127c Gerrit-Change-Number: 59859 Gerrit-PatchSet: 7 Gerrit-Owner: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Tue, 07 Dec 2021 08:33:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Implement function to map physical port to EC port
by Maulik V Vaghela (Code Review) 07 Dec '21

07 Dec '21

Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Patrick Rudolph. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59666 ) Change subject: soc/intel/alderlake: Implement function to map physical port to EC port ...................................................................... Patch Set 15: (3 comments) Patchset: PS14: > Eventually I have some thoughts about moving this into devicetree, but this will work for now thanks […] Thank you Tim 😊 File src/soc/intel/alderlake/retimer.c: https://review.coreboot.org/c/coreboot/+/59666/comment/d5e6d70d_54ee1f09 PS14, Line 4: #include <drivers/intel/usb4/retimer/retimer.h> > nit: should include <device/device. […] Ack https://review.coreboot.org/c/coreboot/+/59666/comment/b1d66138_3c6a11fa PS14, Line 6: #include <string.h> > nit: is this required? Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/59666 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3735b7c7794b46123aba3beac8c0268ce72d658c Gerrit-Change-Number: 59666 Gerrit-PatchSet: 15 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 07 Dec 2021 08:31:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021