coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: MAINTAINERS: Add libpayload unit-tests to TESTS section
by Jakub Czapiga (Code Review) 15 Dec '21

15 Dec '21

Jakub Czapiga has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60138 ) Change subject: MAINTAINERS: Add libpayload unit-tests to TESTS section ...................................................................... MAINTAINERS: Add libpayload unit-tests to TESTS section Change-Id: I09aca01d9bb2624983e0d62628aef617c10eba9c Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> --- M MAINTAINERS 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/60138/1 diff --git a/MAINTAINERS b/MAINTAINERS index d4ec29b..7d87771 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -892,6 +892,7 @@ M: Jakub Czapiga <jacz(a)semihalf.com> S: Maintained F: tests/ +F: payloads/libpayload/tests/ MISSING: TIMERS / DELAYS -- To view, visit https://review.coreboot.org/c/coreboot/+/60138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09aca01d9bb2624983e0d62628aef617c10eba9c Gerrit-Change-Number: 60138 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/common/include/spi: fix SPI_FIFO_LAST_BYTE define
by Raul Rangel (Code Review) 15 Dec '21

15 Dec '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60116 ) Change subject: soc/amd/common/include/spi: fix SPI_FIFO_LAST_BYTE define ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60116 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1676be902ccf57e2e9f69d81251b4315866a0628 Gerrit-Change-Number: 60116 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 15 Dec 2021 15:48:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [UNTESTED] soc/amd/cezanne/fch: disable 48MHz output in S0i3
by Raul Rangel (Code Review) 15 Dec '21

15 Dec '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60125 ) Change subject: [UNTESTED] soc/amd/cezanne/fch: disable 48MHz output in S0i3 ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60125/comment/ee42b75d_40992c61 PS1, Line 7: S0i3 Does this save power? -- To view, visit https://review.coreboot.org/c/coreboot/+/60125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If445f5825dc7b795c95d73c061156cc485421ada Gerrit-Change-Number: 60125 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 15 Dec 2021 15:45:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/felwinter: Add stylus probe for garage
by Tim Wawrzynczak (Code Review) 15 Dec '21

15 Dec '21

Attention is currently required from: Nick Vaccaro, EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60073 ) Change subject: mb/google/brya/var/felwinter: Add stylus probe for garage ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60073 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06a2c125f2b5a73f9f7c27bf1b20ff8712664809 Gerrit-Change-Number: 60073 Gerrit-PatchSet: 3 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 15 Dec 2021 15:03:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Implement new CBFS access API
by Jakub Czapiga (Code Review) 15 Dec '21

15 Dec '21

Attention is currently required from: Paul Menzel, Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59497 ) Change subject: libpayload: Implement new CBFS access API ...................................................................... Patch Set 7: (16 comments) File payloads/libpayload/include/cbfs.h: https://review.coreboot.org/c/coreboot/+/59497/comment/cdb331a0_93f5665b PS7, Line 24: /* Removes a previously allocated CBFS mapping. */ > (It's kinda weird that this has a documentation comment when everything else doesn't, though... […] Right. the name is pretty straightforward, and it is also in coreboots <cbfs.h> :) https://review.coreboot.org/c/coreboot/+/59497/comment/d34742d3_452095de PS7, Line 40: #include <cbfs_boot_device.h> > Please move this to the includes at the top of the file. Done https://review.coreboot.org/c/coreboot/+/59497/comment/9e955468_5559feaa PS7, Line 120: > > Even though file sizes shouldn't be zero, I would write >= here to have the proper symmetry with the […] Done File payloads/libpayload/libcbfs/Kconfig: https://review.coreboot.org/c/coreboot/+/59497/comment/26f7fec2_732cee99 PS7, Line 19: bool "Enable CBFS files verification" > nit: I'd say "Enable CBFS verification" to match coreboot. Done File payloads/libpayload/libcbfs/cbfs.c: https://review.coreboot.org/c/coreboot/+/59497/comment/14e0c1e8_3486a58f PS5, Line 10: #define CB_CBFS_CORE_WITH_LZ4 > > You can just always include <lzma.h> and <lz4.h>, you don't need to guard that. Eh... Reading be difficult... Sorry https://review.coreboot.org/c/coreboot/+/59497/comment/4d8b5cd8_d035ccd9 PS5, Line 34: if (!rw.mcache_size) { > Well, mcache_size is always used to determine whether the mcache is valid or not, and that doesn't r […] I do not know, what I was thinking. It should be obvious. Thanks https://review.coreboot.org/c/coreboot/+/59497/comment/777bdc3b_5c7b2dab PS5, Line 49: if (!ro.mcache_size) { > Don't think you need to check this either. Done https://review.coreboot.org/c/coreboot/+/59497/comment/917c7455_b6316c08 PS5, Line 96: void *file_hash_unused > I'm leaving it like that for now, because I'm working on compiling vboot_reference lib with libpaylo […] Done File payloads/libpayload/libcbfs/cbfs.c: https://review.coreboot.org/c/coreboot/+/59497/comment/96480af1_e15f6572 PS7, Line 28: rw.dev.offset = (size_t)phys_to_virt(lib_sysinfo.cbfs_offset); > Nonono, phys_to_virt() is for pointers, this is a flash offset. Done https://review.coreboot.org/c/coreboot/+/59497/comment/620871c7_6d278862 PS7, Line 43: ro.dev.offset = (size_t)phys_to_virt(ro.dev.offset); > same Done https://review.coreboot.org/c/coreboot/+/59497/comment/91dce732_b718e36e PS7, Line 109: size > nit: I'd maybe call it in_size for clarity Done https://review.coreboot.org/c/coreboot/+/59497/comment/e1c5229e_bdc701e9 PS7, Line 123: return size; > Careful with the early return now... […] Done https://review.coreboot.org/c/coreboot/+/59497/comment/7340cdd9_6f9c9447 PS7, Line 131: if (cbfs_file_hash_mismatch(buffer, size, mdata)) > This must happen after the boot_device_read(), obviously. […] Thank you for this implementation. It looks a lot nicer than mine. Regarding the verification: It was not ready yet. I pushed this version of patch too early. https://review.coreboot.org/c/coreboot/+/59497/comment/9495cb8b_999961ee PS7, Line 139: ERROR("Failed to read contents of file\n"); > Need to free() scratch here. Done https://review.coreboot.org/c/coreboot/+/59497/comment/6d42be3f_dccba6e7 PS7, Line 185: { > Forgot to delete the brace Done https://review.coreboot.org/c/coreboot/+/59497/comment/85baa7de_51f3b827 PS7, Line 197: NULL > You gotta actually pass it if you want to use it, though. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00da0658dbac0cddf92ad55611def947932d23c7 Gerrit-Change-Number: 59497 Gerrit-PatchSet: 7 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 15 Dec 2021 13:55:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Enable vboot integration
by Jakub Czapiga (Code Review) 15 Dec '21

15 Dec '21

Attention is currently required from: Julius Werner, Jan Dabros, Yu-Ping Wu. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60080 ) Change subject: libpayload: Enable vboot integration ...................................................................... Patch Set 2: (22 comments) File payloads/libpayload/Makefile: https://review.coreboot.org/c/coreboot/+/60080/comment/6328baf6_9b298361 PS2, Line 276: $(eval $(1)-libs:=) \ > Since you need to filter for file extensions in the end anyway, I'm not so sure this really does muc […] Done File payloads/libpayload/Makefile.inc: https://review.coreboot.org/c/coreboot/+/60080/comment/d5890923_19b03e58 PS2, Line 82: $(addsuffix .a,$(addprefix $(obj)/,$(libraries))) > Doesn't this also ask for an $(obj)/vboot.a (which it then tries to install with make install)? It looks like that would break to me. Ok, so now Make builds $(obj)/vboot.a and correctly installs it. However, I am not sure if we should install it (it works). What do you think? > Maybe the simpler version is just to add vboot to classes-y after `libraries` was initially assigned, and then add the correct vboot and tlcl library names to it manually in vboot/Makefile? I changed recipe for all $(obj)/%.a targets. Now all of them support additional archives in %-objs. So $(obj)/libpayload.a and $(obj)/vboot.a will contain vboot_fw.a and tlcl.a. It solves the problem. I checked and all symbols and objects seem to be correctly merged. https://review.coreboot.org/c/coreboot/+/60080/comment/71ddb5b2_f0b161dd PS2, Line 98: cat <(printf "open %s\n" "$@") \ > I'm not sure how portable this Makefile needs to be... I believe the <() pattern is bash-specific. […] It worked, thanks :) File payloads/libpayload/vboot/Kconfig: https://review.coreboot.org/c/coreboot/+/60080/comment/8ef45a9e_ffafe618 PS2, Line 6: VBoot > It's `vboot`, all letters lower case. […] Done https://review.coreboot.org/c/coreboot/+/60080/comment/c6cb92ab_f95fdbe6 PS2, Line 9: buildinf > typo Done https://review.coreboot.org/c/coreboot/+/60080/comment/2b8ac758_4d3076d9 PS2, Line 14: string "vboot architecture" > Are you intentionally making this menuconfig-configurable? I don't see why anyone would ever want to […] Done https://review.coreboot.org/c/coreboot/+/60080/comment/3f0ed0f1_9f1168b3 PS2, Line 20: config VBOOT_DEBUG > We should just always enable this for firmware builds, same as coreboot. Done in vboot/Makefile.inc https://review.coreboot.org/c/coreboot/+/60080/comment/2f9c554e_0ea391a9 PS2, Line 24: config VBOOT_DEBUG_PRINT > This is equivalent to DEBUG for firmware builds. Done https://review.coreboot.org/c/coreboot/+/60080/comment/fb6f00e8_03f3ee29 PS2, Line 28: config VBOOT_FORCE_LOGGING_ON > Irrelevant for firmware Done https://review.coreboot.org/c/coreboot/+/60080/comment/27a87186_88cb4fcf PS2, Line 36: config VBOOT_GPT_SPI_NOR > Irrelevant for firmware Done https://review.coreboot.org/c/coreboot/+/60080/comment/17ead6de_3ad3ca27 PS2, Line 40: config VBOOT_TPM2_SIMULATOR > same Done https://review.coreboot.org/c/coreboot/+/60080/comment/a994996a_4536d032 PS2, Line 44: config VBOOT_VTPM_PROXY > same Done https://review.coreboot.org/c/coreboot/+/60080/comment/8e9239e9_36b549e9 PS2, Line 48: config VBOOT_STATIC > same Done https://review.coreboot.org/c/coreboot/+/60080/comment/20c65c3e_bff3f27b PS2, Line 52: config VBOOT_EXTRA_CFLAGS > What did you add this for? FUZZ_FLAGS is irrelevant for firmware builds anyway. Done https://review.coreboot.org/c/coreboot/+/60080/comment/0e1ef6d4_abd141ee PS2, Line 59: default y if ARCH_X86 > This should probably just default to off, because both older Intel chips and AMD don't support it. Oh, I thought that it is present in all chips now. Thanks :) https://review.coreboot.org/c/coreboot/+/60080/comment/8f3b0f26_db590067 PS2, Line 63: bool > Well, if it's not menuconfig-visible you don't need to have it at all. […] Done File payloads/libpayload/vboot/Makefile.inc: https://review.coreboot.org/c/coreboot/+/60080/comment/5aa6e00d_66f5085f PS2, Line 7: TLCL_LIB = $(VBOOT_BUILD_DIR)/tlcl.a > Since make doesn't track dependencies across sub-invocations, you should mark both of these targets […] Done https://review.coreboot.org/c/coreboot/+/60080/comment/105799b6_640b4d9c PS2, Line 9: ifeq ($(CONFIG_LP_VBOOT),y) > Doesn't the subdirs-y already guard this whole file, do we need to check this here again? Done https://review.coreboot.org/c/coreboot/+/60080/comment/d96252db_24bc9b55 PS2, Line 12: vboot-libs += $(TLCL_LIB) > No, TLCL needs to always be added, for both TPM versions (that's what the TPM2_MODE flag mainly deci […] Done https://review.coreboot.org/c/coreboot/+/60080/comment/d31a9939_054dc8ed PS2, Line 16: kconfig-to-binary=$(if $(strip $(1)),$(strip $(subst n,0,$(subst y,1,$(1)))),0) > Can `n` even occur here? I thought this is always either defined to `y` or not defined at all. […] Done https://review.coreboot.org/c/coreboot/+/60080/comment/69ff6ec4_8a31c412 PS2, Line 23: +$(Q) unset CFLAGS CXXFLAGS LDFLAGS && \ > For firmware targets, vboot should always be built with the same CFLAGS as the calling binary (at le […] I mimicked coreboot's approach. There is a problem with $(src) (it seems to be pointless in libpayload Makefiles), so I used $(top) instead to translate paths in a similar way to coreboot src/security/vboot/Makefile.inc. CFLAGS are now also overriden by libpayloads CFLAGS. https://review.coreboot.org/c/coreboot/+/60080/comment/163323c6_666bb747 PS2, Line 27: DEBUG=$(call kconfig-to-binary, $(CONFIG_LP_VBOOT_DEBUG)) \ > This *should* be the same as just adding -DVBOOT_DEBUG to CFLAGS for firmware targets, but since bot […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60080 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d9d766a461edaa0081041c020ecf580fd2ca64e Gerrit-Change-Number: 60080 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 15 Dec 2021 13:55:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload/libc/fmap: Implement new FlashMap API
by Jakub Czapiga (Code Review) 15 Dec '21

15 Dec '21

Attention is currently required from: Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59494 ) Change subject: libpayload/libc/fmap: Implement new FlashMap API ...................................................................... Patch Set 6: (9 comments) File payloads/libpayload/libc/fmap.c: https://review.coreboot.org/c/coreboot/+/59494/comment/3306c814_01f9ca8c PS6, Line 34: #include <fmap_serialized.h> > While you're here would you mind also getting rid of this version of the file and have libpayload us […] Done https://review.coreboot.org/c/coreboot/+/59494/comment/64109664_0d09cfef PS6, Line 41: int > This should then also be cb_err_t Done https://review.coreboot.org/c/coreboot/+/59494/comment/37767eb2_f6274076 PS6, Line 50: 0 > CB_SUCCESS Done https://review.coreboot.org/c/coreboot/+/59494/comment/8a94e3e2_cb6def6c PS6, Line 53: -1 > Probably not worth making a new type for this, so maybe just reuse CB_CBFS_NOT_FOUND here? CB_CBFS_NOT_FOUND has description: "File not found in directory", which indicates, that we are looking for a CBFS file. I think, it will be misleading for user/developer and might suggest, that an error is in a different place in the code. https://review.coreboot.org/c/coreboot/+/59494/comment/de06c7f1_bb46d937 PS6, Line 73: int > I'm actually surprised the compiler doesn't complain, but this should match the declaration (cb_err_ […] It does not complain, because cb_err_t is: > typedef int32_t cb_err_t; File payloads/libpayload/tests/libc/fmap_locate_area-test.c: https://review.coreboot.org/c/coreboot/+/59494/comment/32ab4b6e_369b7b33 PS6, Line 14: extern struct fmap *_fmap_cache; > This no longer belongs here Done https://review.coreboot.org/c/coreboot/+/59494/comment/bbca9f3c_bd8f9d9b PS6, Line 98: _fmap_cache = NULL; > Why not use reset_fmap_cache() for these? Because _fmap_cache will be pointing to fmap_buffer, which is allocated on the stack. https://review.coreboot.org/c/coreboot/+/59494/comment/9b10267d_788f2e28 PS6, Line 100: /* Different number of areas in fmap_cache and fmap_offset */ > Okay so now the comment is correct but I'm still not sure why we want to test this? I would say the […] Done https://review.coreboot.org/c/coreboot/+/59494/comment/7643efaa_025c0135 PS6, Line 101: lib_sysinfo.fmap_offset = (uint64_t)fmap_buffer; > This is super weird anyway. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59494 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idbf9016ce73aa58e17f3ee19920ab83dc6c25abb Gerrit-Change-Number: 59494 Gerrit-PatchSet: 6 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 15 Dec 2021 13:55:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/nipperkin: config eSPI as dedicated alert
by Paul Menzel (Code Review) 15 Dec '21

15 Dec '21

Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60082 ) Change subject: mb/google/guybrush/var/nipperkin: config eSPI as dedicated alert ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60082/comment/4ac87607_d7f8b698 PS2, Line 2: Author: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Use your company address? Kevin Chiu <kevin.chiu(a)quantatw.com> https://review.coreboot.org/c/coreboot/+/60082/comment/833e56aa_9f218a9a PS2, Line 8: What problem is fixed? Please summarize the bug reports. https://review.coreboot.org/c/coreboot/+/60082/comment/f274ae5f_7a49a2f3 PS2, Line 12: DUT(6 units) Space before (. -- To view, visit https://review.coreboot.org/c/coreboot/+/60082 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55cda7a1af22e555a4f55285cb7e337a69e6c234 Gerrit-Change-Number: 60082 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Comment-Date: Wed, 15 Dec 2021 13:54:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/nipperkin: config eSPI as dedicated alert
by Rob Barnes (Code Review) 15 Dec '21

15 Dec '21

Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60082 ) Change subject: mb/google/guybrush/var/nipperkin: config eSPI as dedicated alert ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS1: > Hi Rob, […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/60082 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55cda7a1af22e555a4f55285cb7e337a69e6c234 Gerrit-Change-Number: 60082 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Comment-Date: Wed, 15 Dec 2021 13:45:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Implement new CBFS access API
by Jakub Czapiga (Code Review) 15 Dec '21

15 Dec '21

Attention is currently required from: Jakub Czapiga, Paul Menzel. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59497 to look at the new patch set (#8). Change subject: libpayload: Implement new CBFS access API ...................................................................... libpayload: Implement new CBFS access API Change-Id: I00da0658dbac0cddf92ad55611def947932d23c7 Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> --- M payloads/libpayload/Kconfig M payloads/libpayload/Makefile.inc M payloads/libpayload/include/cbfs.h A payloads/libpayload/include/cbfs_boot_device.h M payloads/libpayload/include/cbfs_core.h A payloads/libpayload/include/cbfs_glue.h A payloads/libpayload/include/cbfs_legacy.h A payloads/libpayload/libcbfs/Kconfig M payloads/libpayload/libcbfs/Makefile.inc M payloads/libpayload/libcbfs/cbfs.c M payloads/libpayload/libcbfs/cbfs_core.c A payloads/libpayload/libcbfs/cbfs_legacy.c M payloads/libpayload/tests/Makefile.inc A payloads/libpayload/tests/include/mocks/cbfs_util.h A payloads/libpayload/tests/libcbfs/Makefile.inc A payloads/libpayload/tests/libcbfs/cbfs-lookup-test.c A payloads/libpayload/tests/libcbfs/cbfs-verification-test.c A payloads/libpayload/tests/mocks/cbfs_file_mock.c A payloads/libpayload/tests/mocks/die.c 19 files changed, 2,115 insertions(+), 406 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/59497/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/59497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00da0658dbac0cddf92ad55611def947932d23c7 Gerrit-Change-Number: 59497 Gerrit-PatchSet: 8 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021