coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed
by Nico Huber (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Nick Vaccaro, Zhuohao Lee. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60129 ) Change subject: libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60129/comment/e183fae9_d52e10cf PS2, Line 13: when doing the autotest. I'm not sure if I quite follow. It sounds like you are saying that the code should change because the test environment is lacking? That's not it, is it? -- To view, visit https://review.coreboot.org/c/coreboot/+/60129 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2880c854b873a2a00aa0d8b1cbb4f86fa8139255 Gerrit-Change-Number: 60129 Gerrit-PatchSet: 2 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Thu, 16 Dec 2021 13:21:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Add -Wno-address-of-packed-member for ARCH_MOCK
by Jakub Czapiga (Code Review) 16 Dec '21

16 Dec '21

Jakub Czapiga has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60169 ) Change subject: libpayload: Add -Wno-address-of-packed-member for ARCH_MOCK ...................................................................... libpayload: Add -Wno-address-of-packed-member for ARCH_MOCK When compiling libpayload using x86_64 toolchain for ARCH_MOCK compiler reports an error about gerring address of packed member. Until now it had to be disabled by passing -Wno-address-of-packed-member to EXTRA_CFLAGS. This patch disables this warning. Change-Id: I9a948fabe66f7297632ecaca8ec1bfa5c842b750 Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> --- M payloads/libpayload/arch/mock/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/60169/1 diff --git a/payloads/libpayload/arch/mock/Makefile.inc b/payloads/libpayload/arch/mock/Makefile.inc index f15f0f9..415886a 100644 --- a/payloads/libpayload/arch/mock/Makefile.inc +++ b/payloads/libpayload/arch/mock/Makefile.inc @@ -5,3 +5,5 @@ libc-y += virtual.c libcbfs-$(CONFIG_LP_CBFS) += mock_media.c + +CFLAGS += -Wno-address-of-packed-member -- To view, visit https://review.coreboot.org/c/coreboot/+/60169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a948fabe66f7297632ecaca8ec1bfa5c842b750 Gerrit-Change-Number: 60169 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: coreboot-sdk/Dockerfile: Build and install libflashrom
by Paul Menzel (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Hsuan Ting Chen, Martin Roth, Hsuan-ting Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60095 ) Change subject: coreboot-sdk/Dockerfile: Build and install libflashrom ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60095/comment/e0b5b10d_6bb20887 PS3, Line 14: of on? -- To view, visit https://review.coreboot.org/c/coreboot/+/60095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7269a5140fb02da6d143b339116db2fd089f8da8 Gerrit-Change-Number: 60095 Gerrit-PatchSet: 3 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Comment-Date: Thu, 16 Dec 2021 13:20:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed
by Paul Menzel (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Nico Huber, Nick Vaccaro, Zhuohao Lee. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60129 ) Change subject: libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60129 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2880c854b873a2a00aa0d8b1cbb4f86fa8139255 Gerrit-Change-Number: 60129 Gerrit-PatchSet: 2 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Thu, 16 Dec 2021 13:18:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: google/trogdor: Enable Parade ps8640 edp bridge for pazquel
by Paul Menzel (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Henry Sun, Yunlong Jia, Bob Moragues, Julius Werner. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60130 ) Change subject: google/trogdor: Enable Parade ps8640 edp bridge for pazquel ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/trogdor/mainboard.c: https://review.coreboot.org/c/coreboot/+/60130/comment/54b9bfd5_00959db7 PS3, Line 87: 0x4 The other lines use no 0x? -- To view, visit https://review.coreboot.org/c/coreboot/+/60130 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6130ee00a0e6f469142f5416627e38c7b5076071 Gerrit-Change-Number: 60130 Gerrit-PatchSet: 3 Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kelsey Wang <peihwang(a)qualcomm.corp-partner.google.com> Gerrit-CC: Patrick Chang <changp(a)qualcomm.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 16 Dec 2021 13:18:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/primus: remove board_id check for ALC5682I-VS
by Paul Menzel (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Malik Hsu, Nick Vaccaro. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60128 ) Change subject: mb/google/brya/variants/primus: remove board_id check for ALC5682I-VS ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60128/comment/513c5c52_d7b1571e PS2, Line 9: The board ID check for audio codec is no longer required, therefore : remove it. Why is it not required anymore? -- To view, visit https://review.coreboot.org/c/coreboot/+/60128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbe838186da2e64737a9ffb557cf324124e79a9d Gerrit-Change-Number: 60128 Gerrit-PatchSet: 2 Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 16 Dec 2021 13:17:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Herobrine: sc7280: Add support for audio
by Paul Menzel (Code Review) 16 Dec '21

16 Dec '21

1 0

Change in coreboot[master]: Herobrine: sc7280: Add support for audio
by Paul Menzel (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Shelley Chen, Ravi kumar, Sudheer Amrabadi. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57449 ) Change subject: Herobrine: sc7280: Add support for audio ...................................................................... Patch Set 29: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57449/comment/2c648bae_43830156 PS29, Line 7: Herobrine mb/google/herobrine https://review.coreboot.org/c/coreboot/+/57449/comment/12624b1e_2f56c92f PS29, Line 7: sc7280: Not needed. https://review.coreboot.org/c/coreboot/+/57449/comment/cb7f9daa_22b83bed PS29, Line 7: Herobrine: sc7280: Add support for audio … and TPM? https://review.coreboot.org/c/coreboot/+/57449/comment/8c6bd4d1_393e6a23 PS29, Line 9: gpio GPIO https://review.coreboot.org/c/coreboot/+/57449/comment/9db17b33_b24d54ed PS29, Line 9: Add gpio configuration for target specific i2s ports 1. Please add a dot/period at the end of the line. 2. Please mention the source. Schematics? File src/mainboard/google/herobrine/mainboard.c: https://review.coreboot.org/c/coreboot/+/57449/comment/cd350c5f_2cf66bc1 PS28, Line 43: No blank line needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/57449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ce95332f892d5d4acb2755307df84d37feb8002 Gerrit-Change-Number: 57449 Gerrit-PatchSet: 29 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Comment-Date: Thu, 16 Dec 2021 13:16:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: do not lock GPP_B16/ GPP_B17
by Paul Menzel (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Scott Chao, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60126 ) Change subject: soc/intel/alderlake: do not lock GPP_B16/ GPP_B17 ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60126/comment/a91b40f0_ee08a9ef PS2, Line 7: do not lock GPP_B16/ GPP_B17 Please remove the space after the slash (/). https://review.coreboot.org/c/coreboot/+/60126/comment/5cbb726b_13e20f5e PS2, Line 9: Do not lock GPP_B16/ GPP_B17 because we set it as NF2. This will let i2c device lost function after warm reboot. Please wrap lines after 72 characters. https://review.coreboot.org/c/coreboot/+/60126/comment/186c202e_627d69a6 PS2, Line 9: This will let i2c device lost function after warm reboot. Maybe: > This causes the I2C touchpad device to stop working after warm reboot. https://review.coreboot.org/c/coreboot/+/60126/comment/9914efd9_c2c08060 PS2, Line 13: work works -- To view, visit https://review.coreboot.org/c/coreboot/+/60126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I106ddc96c3185656d3f1fbcd45f198d2d46f3f4d Gerrit-Change-Number: 60126 Gerrit-PatchSet: 2 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 16 Dec 2021 12:54:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/nipperkin: config eSPI as dedicated alert
by Rob Barnes (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Paul Menzel, Eric Peers. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60082 ) Change subject: mb/google/guybrush/var/nipperkin: config eSPI as dedicated alert ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60082 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55cda7a1af22e555a4f55285cb7e337a69e6c234 Gerrit-Change-Number: 60082 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Comment-Date: Thu, 16 Dec 2021 12:42:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021