coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: ec/starlabs/merlin: Apply EC settings when suspending
by Sean Rhodes (Code Review) 16 Dec '21

16 Dec '21

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60165 ) Change subject: ec/starlabs/merlin: Apply EC settings when suspending ...................................................................... ec/starlabs/merlin: Apply EC settings when suspending Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I998d5509cd5e95736468f88663a1423217cf6ddf --- M src/ec/starlabs/merlin/acpi/suspend.asl 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/60165/1 diff --git a/src/ec/starlabs/merlin/acpi/suspend.asl b/src/ec/starlabs/merlin/acpi/suspend.asl index 7c8f2b1..56805f3 100644 --- a/src/ec/starlabs/merlin/acpi/suspend.asl +++ b/src/ec/starlabs/merlin/acpi/suspend.asl @@ -10,10 +10,17 @@ \_SB.PCI0.LPCB.EC.TPLA = \_SB.PCI0.LPCB.TPLS \_SB.PCI0.LPCB.EC.FLKA = \_SB.PCI0.LPCB.FLKS \_SB.PCI0.LPCB.EC.KLBE = \_SB.PCI0.LPCB.KLBC + \_SB.PCI0.LPCB.EC.KLSE = \_SB.PCI0.LPCB.KLSC } } Method (RWAK, 1, Serialized) { \_SB.PCI0.LPCB.EC.OSFG = 0x01 + + /* Restore settings from CMOS */ + \_SB.PCI0.LPCB.TPLS = \_SB.PCI0.LPCB.EC.TPLA + \_SB.PCI0.LPCB.FLKS = \_SB.PCI0.LPCB.EC.FLKA + \_SB.PCI0.LPCB.KLBC = _SB.PCI0.LPCB.EC.KLBE + \_SB.PCI0.LPCB.KLSC = \_SB.PCI0.LPCB.EC.KLSE } -- To view, visit https://review.coreboot.org/c/coreboot/+/60165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I998d5509cd5e95736468f88663a1423217cf6ddf Gerrit-Change-Number: 60165 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/stoneyridge: split southbridge code
by Kyösti Mälkki (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Marshall Dawson, Felix Held. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60142 ) Change subject: soc/amd/stoneyridge: split southbridge code ...................................................................... Patch Set 1: (1 comment) File src/soc/amd/stoneyridge/fch.c: https://review.coreboot.org/c/coreboot/+/60142/comment/b24621bd_a8ef4534 PS1, Line 175: if (gnvs) { There's probably no need to have them in GNVS or update on S3 resume path. So xHCI has to reload firmware from SPI flash on D0 transition? -- To view, visit https://review.coreboot.org/c/coreboot/+/60142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib660fbef8dc25ba0fab803ccd82b3408878d1588 Gerrit-Change-Number: 60142 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 16 Dec 2021 07:18:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Configure GPIOs for Alder Lake-N
by Usha P (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Anilkumar N, Kangheui Won, Maulik V Vaghela, Tim Wawrzynczak, Rizwan Qureshi, Subrata Banik, Sridhar Siricilla, Krishna P Bhat D. Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59937 ) Change subject: mb/intel/adlrvp: Configure GPIOs for Alder Lake-N ...................................................................... Patch Set 7: (5 comments) File src/mainboard/intel/adlrvp/gpio_n.c: https://review.coreboot.org/c/coreboot/+/59937/comment/ce6549ce_9d51fcef PS6, Line 147: > nit: extra line Ack https://review.coreboot.org/c/coreboot/+/59937/comment/5d2ad740_d5c0f88b PS6, Line 158: > nit: extra line Ack https://review.coreboot.org/c/coreboot/+/59937/comment/905e3303_16e61f3f PS6, Line 164: > nit: extra line Ack https://review.coreboot.org/c/coreboot/+/59937/comment/0282fca3_a399005b PS6, Line 180: > nit: extra line Ack https://review.coreboot.org/c/coreboot/+/59937/comment/19ad9d43_35d765b4 PS6, Line 184: > nit: extra line Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/59937 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c0ca52d0cc73acfd8503007d5f3d2ad9a48f8ca Gerrit-Change-Number: 59937 Gerrit-PatchSet: 7 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Comment-Date: Thu, 16 Dec 2021 07:00:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Configure GPIOs for Alder Lake-N
by Usha P (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Anilkumar N, Kangheui Won, Maulik V Vaghela, Tim Wawrzynczak, Rizwan Qureshi, Subrata Banik, Sridhar Siricilla. Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59937 ) Change subject: mb/intel/adlrvp: Configure GPIOs for Alder Lake-N ...................................................................... Patch Set 6: (1 comment) File src/mainboard/intel/adlrvp/gpio_n.c: https://review.coreboot.org/c/coreboot/+/59937/comment/996f1745_c484c916 PS5, Line 52: /*TCP1_DISP_AUX_P_BIAS_GPIO*/ : PAD_CFG_GPO(GPP_E20, 1, PLTRST), : /*TCP1_DISP_AUX_N_BIAS_GPIO*/ : PAD_CFG_GPO(GPP_E21, 0, PLTRST), : /*TCP0_DISP_AUX_P_BIAS_GPIO*/ : PAD_CFG_GPO(GPP_E22, 0, PLTRST), : /*TCP0_DISP_AUX_N_BIAS_GPIO*/ : PAD_CFG_GPO(GPP_E23, 1, PLTRST), > I am guessing here from the pad names, but should these be NF6 for AUX BIAS functionality? These are GPIO pins used for providing BIAS functionality to the AUX lines. We will configure them based on the orientation of the display device plugged on Type-C. -- To view, visit https://review.coreboot.org/c/coreboot/+/59937 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c0ca52d0cc73acfd8503007d5f3d2ad9a48f8ca Gerrit-Change-Number: 59937 Gerrit-PatchSet: 6 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Thu, 16 Dec 2021 06:53:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: coreboot-sdk/Dockerfile: Build and install libflashrom
by Hsuan-ting Chen (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Hsuan Ting Chen, Martin Roth, Hsuan-ting Chen. Hello build bot (Jenkins), Hsuan Ting Chen, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60095 to look at the new patch set (#3). Change subject: coreboot-sdk/Dockerfile: Build and install libflashrom ...................................................................... coreboot-sdk/Dockerfile: Build and install libflashrom By updating vboot submodule to ToT in commit 18437a7b (Update vboot submodule to upstream master), crrev.com/c/3247852 (vboot_reference/futility: Port W path to using libflashrom) will be included as well. The vboot CL added a dependency of libflashrom because it included libflashrom.h header in futility/updater_utils.c. Missing this dependency will cause Jenkins build failure while building the vboot uprev CL. Add the dependency of cloning from flashrom repository, making libinstall to support libflashrom. Change-Id: I7269a5140fb02da6d143b339116db2fd089f8da8 Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/60095/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7269a5140fb02da6d143b339116db2fd089f8da8 Gerrit-Change-Number: 60095 Gerrit-PatchSet: 3 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Add SAR sensor
by Gwendal Grignou (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: SH Kim. Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59609 ) Change subject: mb/google/dedede/var/bugzzy: Add SAR sensor ...................................................................... Patch Set 5: (6 comments) File src/mainboard/google/dedede/variants/bugzzy/gpio.c: https://review.coreboot.org/c/coreboot/+/59609/comment/d4a3f074_3257b86c PS3, Line 51: /* E11 : WIFI_SAR_SENSOR_INT */ : PAD_CFG_GPI_APIC(GPP_E11, NONE, PLTRST, LEVEL, NONE), > We will not add Wifi P-sensor for bugzzy, so we can disable I2C5 port and remove the device from tre […] Done File src/mainboard/google/dedede/variants/bugzzy/overridetree.cb: https://review.coreboot.org/c/coreboot/+/59609/comment/5911b190_ca4f9f17 PS3, Line 51: [PchSerialIoIndexI2C5] = PchSerialIoPci, > We will not add Wifi P-sensor for bugzzy, so we can disable I2C5 port and remove the device from tre […] Done https://review.coreboot.org/c/coreboot/+/59609/comment/fff1991a_1f07b6b6 PS3, Line 67: #| I2C5 | P-sensor(Wifi) | > We will not add Wifi P-sensor for bugzzy, so we can disable I2C5 port and remove the device from tre […] Done https://review.coreboot.org/c/coreboot/+/59609/comment/38ed1f0a_fe4a590b PS3, Line 231: device i2c 28 on end > Can we add this as well: […] Done https://review.coreboot.org/c/coreboot/+/59609/comment/5a2fbde6_1ce54d77 PS3, Line 239: #register "generic.probed" = "1" > We don't need it. Done https://review.coreboot.org/c/coreboot/+/59609/comment/ef5b61a3_7e901825 PS3, Line 338: device pci 19.1 on : chip drivers/i2c/sx9360 : register "desc" = ""SAR Proximity Sensor - Wifi"" : register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E11_IRQ)" : register "uid" = "2" : register "proxraw_strength" = "2" : register "avg_pos_strength" = "16" : register "resolution" = "1024" : device i2c 28 on end : end : end #I2C 5 > We will not add Wifi P-sensor for bugzzy, so we can disable I2C5 port and remove the device from tre […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9feef9d132c60738bafb22ceb7d3468c798fab9b Gerrit-Change-Number: 59609 Gerrit-PatchSet: 5 Gerrit-Owner: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Comment-Date: Thu, 16 Dec 2021 05:44:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: driver/i2c: Add sx9360 driver
by Gwendal Grignou (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59608 ) Change subject: driver/i2c: Add sx9360 driver ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59608/comment/2fd49d2d_50b6729b PS3, Line 12: Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml > That’s not yet in Linus’ master branch? It was presumptive: the patch has been submitted only: https://patchwork.kernel.org/project/linux-iio/patch/20211213024057.3824985… File src/drivers/i2c/sx9360/sx9360.c: PS2: > Good point. Please mention in the commit message, what code you took as base. Done https://review.coreboot.org/c/coreboot/+/59608/comment/21e6de1f_0524d99d PS2, Line 15: REGISTER > It is unused, I should have removed it when copied the code from sx9324. Done https://review.coreboot.org/c/coreboot/+/59608/comment/307790c7_3b505d2a PS2, Line 61: describe > described Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59608 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a912f184e6f3501f894cca24c0d71a2c3087516 Gerrit-Change-Number: 59608 Gerrit-PatchSet: 4 Gerrit-Owner: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 16 Dec 2021 05:43:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: driver/i2c: Add sx9360 driver
by Gwendal Grignou (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Tim Wawrzynczak, Gwendal Grignou. Hello build bot (Jenkins), Paul Menzel, SH Kim, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59608 to look at the new patch set (#4). Change subject: driver/i2c: Add sx9360 driver ...................................................................... driver/i2c: Add sx9360 driver Add driver for setting up Semtech sx9360 SAR sensor. The driver is based on sx9310.c. The core of the driver is the same, but the bindings are slightly different. Registers are documented in the kernel tree: Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com> Signed-off-by: Gwendal Grignou <gwendal(a)chromium.org> Change-Id: I0a912f184e6f3501f894cca24c0d71a2c3087516 --- A src/drivers/i2c/sx9360/Kconfig A src/drivers/i2c/sx9360/Makefile.inc A src/drivers/i2c/sx9360/chip.h A src/drivers/i2c/sx9360/sx9360.c 4 files changed, 158 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/59608/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/59608 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a912f184e6f3501f894cca24c0d71a2c3087516 Gerrit-Change-Number: 59608 Gerrit-PatchSet: 4 Gerrit-Owner: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/adlrvp: Configure GPIOs for Alder Lake-N
by Krishna P Bhat D (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Anilkumar N, Kangheui Won, Maulik V Vaghela, Rizwan Qureshi, Subrata Banik, Sridhar Siricilla, Usha P. Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59937 ) Change subject: mb/intel/adlrvp: Configure GPIOs for Alder Lake-N ...................................................................... Patch Set 6: (5 comments) File src/mainboard/intel/adlrvp/gpio_n.c: https://review.coreboot.org/c/coreboot/+/59937/comment/e235560b_ff7af6d9 PS6, Line 147: nit: extra line https://review.coreboot.org/c/coreboot/+/59937/comment/aff7e595_8df786f1 PS6, Line 158: nit: extra line https://review.coreboot.org/c/coreboot/+/59937/comment/4df4b39c_b0bdab7e PS6, Line 164: nit: extra line https://review.coreboot.org/c/coreboot/+/59937/comment/6cbf6633_07e3c9ef PS6, Line 180: nit: extra line https://review.coreboot.org/c/coreboot/+/59937/comment/71961025_f484bd82 PS6, Line 184: nit: extra line -- To view, visit https://review.coreboot.org/c/coreboot/+/59937 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c0ca52d0cc73acfd8503007d5f3d2ad9a48f8ca Gerrit-Change-Number: 59937 Gerrit-PatchSet: 6 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Thu, 16 Dec 2021 04:12:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/brask: Disable autonomous GPIO power management
by Zhuohao Lee (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Paul Menzel. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60100 ) Change subject: mb/google/brya/variants/brask: Disable autonomous GPIO power management ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60100/comment/6fffc78e_12aab3f0 PS2, Line 9: found that > experienced? Done https://review.coreboot.org/c/coreboot/+/60100/comment/bf77a382_86314ec8 PS2, Line 10: cr50 : firmware to the 0.6.70. > Was this firmware supposed to fix it? No. I just apply the latest version but it is still not working. https://review.coreboot.org/c/coreboot/+/60100/comment/3810de50_319f9460 PS2, Line 12: So, we submitted : this patch to disable the gpio power management. > Please describe the problem, and why this fix. […] Done File src/mainboard/google/brya/variants/brask/overridetree.cb: https://review.coreboot.org/c/coreboot/+/60100/comment/82013762_12a57e2c PS2, Line 2: disabled > disables Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f18fea5bc28493107c6d4951805de640a0b8ae5 Gerrit-Change-Number: 60100 Gerrit-PatchSet: 2 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 16 Dec 2021 03:49:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021