Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60100
to look at the new patch set (#5).
Change subject: mb/google/brya/variants/brask: Disable autonomous GPIO power management
......................................................................
mb/google/brya/variants/brask: Disable autonomous GPIO power management
We experienced the `Cr50 i2c TPM IRQ timeout!` error when the device
executed the reboot test even though we have updated the Cr50 firmware
to the latest version 0.6.70. Besides, we also experienced the device
failed with the IRQ timeout when using the 0.3.22 Cr50 firmware in the
factory. In order to fix these issues, we disable the gpio power
management from the devicetree.
BUG=b:210540890
TEST=reboot 100 cycles without the error message.
Change-Id: I5f18fea5bc28493107c6d4951805de640a0b8ae5
Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org>
---
M src/mainboard/google/brya/variants/brask/overridetree.cb
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/60100/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/60100
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f18fea5bc28493107c6d4951805de640a0b8ae5
Gerrit-Change-Number: 60100
Gerrit-PatchSet: 5
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60100
to look at the new patch set (#4).
Change subject: mb/google/brya/variants/brask: Disable autonomous GPIO power management
......................................................................
mb/google/brya/variants/brask: Disable autonomous GPIO power management
We experienced the `Cr50 i2c TPM IRQ timeout!` error when the device
executed the reboot test even though we have updated the Cr50 firmware
to the latest version 0.6.70. Besides, we also experienced the device
failed with the IRQ timeout when using the 0.3.22 Cr50 firmware in the
factory. In order to fix these issues, we disable the gpio power
management from the devicetree.
BUG=b:210540890
TEST=reboot 100 cycles without the error message.
Change-Id: I5f18fea5bc28493107c6d4951805de640a0b8ae5
Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org>
---
M src/mainboard/google/brya/variants/brask/overridetree.cb
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/60100/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/60100
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f18fea5bc28493107c6d4951805de640a0b8ae5
Gerrit-Change-Number: 60100
Gerrit-PatchSet: 4
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Zhuohao Lee.
Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60100
to look at the new patch set (#3).
Change subject: mb/google/brya/variants/brask: Disable autonomous GPIO power management
......................................................................
mb/google/brya/variants/brask: Disable autonomous GPIO power management
We experienced the `Cr50 i2c TPM IRQ timeout!` error when the device
executed the reboot test even though we have updated the Cr50 firmware
to the latest version 0.6.70. Besides, we also experienced the device
failed with the IRQ timeout when using the 0.3.22 Cr50 firmware in the
factory. In order to fix these issues, we disable the gpio power
management from the devicetree.
BUG=b:210540890
TEST=reboot 100 cycles without the error message.
Change-Id: I5f18fea5bc28493107c6d4951805de640a0b8ae5
Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org>
---
M src/mainboard/google/brya/variants/brask/overridetree.cb
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/60100/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/60100
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f18fea5bc28493107c6d4951805de640a0b8ae5
Gerrit-Change-Number: 60100
Gerrit-PatchSet: 3
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Francois Toguo Fotso, Paul Menzel, Patrick Rudolph.
Hello build bot (Jenkins), Francois Toguo Fotso, Tim Wawrzynczak, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59951
to look at the new patch set (#6).
Change subject: soc/intel/common: Do not trigger crashlog on all resets by default
......................................................................
soc/intel/common: Do not trigger crashlog on all resets by default
Crashlog has error records and PMC reset records two parts. When we
send ipc cmd "PMC_IPC_CMD_ID_CRASHLOG_ON_RESET", PMC reset record is
enabled. At each warm/cold/global reset, crashlog would be triggered.
The cause of this crash would be "TRIGGER_ON_ALL_RESETS", it is used to
catch unknown reset reason. At the same time, we would see [Hardware
Error] in the kernel log.
If we default enable TRIGGER_ON_ALL_RESETS, we would have too many false
alarm. Now we disable PMC reset records part by default. And we could
enable it when we need it for the debug purpose.
The generated bert dump is under /var/spool/crash/, we could check this
path to verify this CONFIG disable/enable status.
BUG=b:202737385
TEST=No new bert dump after a warm reset.
Signed-off-by: Curtis Chen <curtis.chen(a)intel.com>
Change-Id: I3ec4ff3c8a3799156de030f4556fe6ce61305139
---
M src/soc/intel/alderlake/Kconfig
M src/soc/intel/common/Kconfig.common
M src/soc/intel/common/block/crashlog/crashlog.c
M src/soc/intel/tigerlake/Kconfig
4 files changed, 18 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/59951/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/59951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ec4ff3c8a3799156de030f4556fe6ce61305139
Gerrit-Change-Number: 59951
Gerrit-PatchSet: 6
Gerrit-Owner: Curtis Chen <curtis.chen(a)intel.com>
Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Henry Sun, Bob Moragues, Julius Werner.
Yunlong Jia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60130 )
Change subject: google/trogdor: Enable Parade ps8640 edp bridge for pazquel
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60130/comment/a2c2772d_2c857752
PS1, Line 7: UPSTREAM
> This *is* upstream. You don't need to write UPSTREAM: in front of patch subjects here.
yes,remove it
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/60130/comment/28317981_18c09fab
PS1, Line 87: 4
> Please write as either 0x4 or BIT(2). Also, please put the (... & ... […]
ok, I have modified it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60130
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6130ee00a0e6f469142f5416627e38c7b5076071
Gerrit-Change-Number: 60130
Gerrit-PatchSet: 3
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kelsey Wang <peihwang(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Patrick Chang <changp(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 16 Dec 2021 02:38:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Paul Menzel, Nick Vaccaro, Zhuohao Lee.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60129 )
Change subject: libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60129/comment/1049d15d_b340cb06
PS1, Line 9: The probe should output the 'INFO' instead of 'ERROR' when
: the i8042 module can't be probed. For the x86 device, which
: enables the PC_I8042 by default, the 'ERROR' message will be
: outputted if the device doesn't connect to an i8042 keyboard controller.
: This is an unexpected error when doing the autotest.
> Please reflow for 72 characters per line.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60129
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2880c854b873a2a00aa0d8b1cbb4f86fa8139255
Gerrit-Change-Number: 60129
Gerrit-PatchSet: 2
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Comment-Date: Thu, 16 Dec 2021 02:38:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Nick Vaccaro, Zhuohao Lee.
Hello build bot (Jenkins), Nico Huber, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60129
to look at the new patch set (#2).
Change subject: libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed
......................................................................
libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed
The probe should output the 'INFO' instead of 'ERROR' when the i8042
module can't be probed. For the x86 device, which enables the PC_I8042
by default, the 'ERROR' message will be outputted if the device doesn't
connect to an i8042 keyboard controller. This is an unexpected error
when doing the autotest.
BUG=b:207077409
TEST=`test_that f:.*power_Resume/control` pass
Change-Id: I2880c854b873a2a00aa0d8b1cbb4f86fa8139255
Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org>
---
M payloads/libpayload/drivers/i8042/i8042.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/60129/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60129
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2880c854b873a2a00aa0d8b1cbb4f86fa8139255
Gerrit-Change-Number: 60129
Gerrit-PatchSet: 2
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Henry Sun, Yunlong Jia, Bob Moragues.
Hello build bot (Jenkins), Henry Sun, Bob Moragues, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60130
to look at the new patch set (#3).
Change subject: google/trogdor: Enable Parade ps8640 edp bridge for pazquel
......................................................................
google/trogdor: Enable Parade ps8640 edp bridge for pazquel
BRANCH=none
BUG=b:201478528
TEST=build and boot
Change-Id: I6130ee00a0e6f469142f5416627e38c7b5076071
Signed-off-by: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
---
M src/mainboard/google/trogdor/mainboard.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/60130/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/60130
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6130ee00a0e6f469142f5416627e38c7b5076071
Gerrit-Change-Number: 60130
Gerrit-PatchSet: 3
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kelsey Wang <peihwang(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Patrick Chang <changp(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-MessageType: newpatchset