coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: libpayload: Parse DDR Information through coreboot tables
by Sudheer Amrabadi (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Ravi kumar, Shelley Chen, mturney mturney, Julius Werner. Sudheer Amrabadi has uploaded a new patch set (#7) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/59193 ) Change subject: libpayload: Parse DDR Information through coreboot tables ...................................................................... libpayload: Parse DDR Information through coreboot tables BUG=b:182963902 TEST=Validated on qualcomm sc7280 developement board Signed-off-by: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Change-Id: Ieca7e9fc0e1a018fcb2e9315aebee088edac858e --- M payloads/libpayload/include/coreboot_tables.h M payloads/libpayload/include/libpayload.h A payloads/libpayload/include/mem_chip_info.h M payloads/libpayload/include/sysinfo.h M payloads/libpayload/libc/coreboot.c 5 files changed, 77 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/59193/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/59193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieca7e9fc0e1a018fcb2e9315aebee088edac858e Gerrit-Change-Number: 59193 Gerrit-PatchSet: 7 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-Reviewer: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Herobrine: sc7280: Add support for audio
by Sudheer Amrabadi (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Shelley Chen, Ravi kumar. Sudheer Amrabadi has uploaded a new patch set (#29) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/57449 ) Change subject: Herobrine: sc7280: Add support for audio ...................................................................... Herobrine: sc7280: Add support for audio Add gpio configuration for target specific i2s ports BUG=b:182963902 TEST=Validated on qualcomm sc7280 developement board Signed-off-by: Srinivasa Rao Mandadapu <srivasam(a)codeaurora.org> Change-Id: I2ce95332f892d5d4acb2755307df84d37feb8002 --- M src/mainboard/google/herobrine/board.h M src/mainboard/google/herobrine/chromeos.c M src/mainboard/google/herobrine/mainboard.c 3 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/57449/29 -- To view, visit https://review.coreboot.org/c/coreboot/+/57449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ce95332f892d5d4acb2755307df84d37feb8002 Gerrit-Change-Number: 57449 Gerrit-PatchSet: 29 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/herobrine: Initialize SPI FW for EC and TPM
by Sudheer Amrabadi (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Julius Werner, Rajesh Patil. Sudheer Amrabadi has uploaded a new patch set (#93) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/50581 ) Change subject: mb/google/herobrine: Initialize SPI FW for EC and TPM ...................................................................... mb/google/herobrine: Initialize SPI FW for EC and TPM Initialize SPI firmware for EC and H1/TPM instances for Piglin and Hoglin. Load QUP FW in respective Serial Engines. BUG=b:182963902 TEST=Validated on qualcomm sc7280 developement board Change-Id: I8cbdd1d59a0166688d52d61646db1b6764879a7c Signed-off-by: Roja Rani Yarubandi <rojay(a)codeaurora.org> --- M src/mainboard/google/herobrine/Kconfig M src/mainboard/google/herobrine/board.h M src/mainboard/google/herobrine/bootblock.c M src/mainboard/google/herobrine/chromeos.c 4 files changed, 59 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/50581/93 -- To view, visit https://review.coreboot.org/c/coreboot/+/50581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8cbdd1d59a0166688d52d61646db1b6764879a7c Gerrit-Change-Number: 50581 Gerrit-PatchSet: 93 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Mukesh Savaliya <msavaliy(a)qualcomm.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush/var/nipperkin: config eSPI as dedicated alert
by Kevin Chiu (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Bhanu Prakash Maiya, Paul Menzel, Eric Peers. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60082 ) Change subject: mb/google/guybrush/var/nipperkin: config eSPI as dedicated alert ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60082/comment/efb086e7_96f80c07 PS2, Line 2: Author: Kevin Chiu <kevin.chiu.17802(a)gmail.com> > Use your company address? […] Done https://review.coreboot.org/c/coreboot/+/60082/comment/d450a1b0_03154f36 PS2, Line 8: > What problem is fixed? Please summarize the bug reports. Done https://review.coreboot.org/c/coreboot/+/60082/comment/f053e76b_b0a1fbae PS2, Line 12: DUT(6 units) > Space before (. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60082 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55cda7a1af22e555a4f55285cb7e337a69e6c234 Gerrit-Change-Number: 60082 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Comment-Date: Thu, 16 Dec 2021 12:06:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/nipperkin: config eSPI as dedicated alert
by Kevin Chiu (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers. Hello build bot (Jenkins), Bhanu Prakash Maiya, Rob Barnes, Eric Peers, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60082 to look at the new patch set (#3). Change subject: mb/google/guybrush/var/nipperkin: config eSPI as dedicated alert ...................................................................... mb/google/guybrush/var/nipperkin: config eSPI as dedicated alert Setup eSPI to dedicated alert per the latest schematic changes. DUT won't hang up at power on boot due to eSPI alert is triggerred unexpectedly. BUG=b:199458949,b:203446084 BRANCH=guybrush TEST=emerge-guybrush coreboot chromeos-bootimage test power on/reboot on DUT (6 units) each 10 loops->pass Change-Id: I55cda7a1af22e555a4f55285cb7e337a69e6c234 Signed-off-by: Kevin Chiu <kevin.chiu(a)quantatw.com> --- M src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/60082/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60082 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55cda7a1af22e555a4f55285cb7e337a69e6c234 Gerrit-Change-Number: 60082 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: commonlib: Add new TS for CSE firmware Sync
by Sridhar Siricilla (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Tim Wawrzynczak, Subrata Banik. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59668 ) Change subject: commonlib: Add new TS for CSE firmware Sync ...................................................................... Patch Set 4: (1 comment) File src/commonlib/include/commonlib/timestamp_serialized.h: https://review.coreboot.org/c/coreboot/+/59668/comment/31426bb9_e2fc7e5b PS3, Line 141: TS_START_CSE_FW_SYNC = 972, : TS_END_CSE_FW_SYNC = 973, > Hm, ideally these would go between 940 and 950 but there's only 1 space left. […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/59668 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9ed82c5358eb94b5e7c91b9fd783c5e09189b77a Gerrit-Change-Number: 59668 Gerrit-PatchSet: 4 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Thu, 16 Dec 2021 11:32:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add timestamp for cse_fw_sync
by Sridhar Siricilla (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph. Hello build bot (Jenkins), Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60135 to look at the new patch set (#2). Change subject: soc/intel/alderlake: Add timestamp for cse_fw_sync ...................................................................... soc/intel/alderlake: Add timestamp for cse_fw_sync The patch add timestamp around cse_fw_sync(). TEST=Verified on Brya, cbmem -t: 948:starting CSE firmware sync 1,381,577 (45,227 949:finished CSE firmware sync 1,459,513 (77,936) Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: Idba11417e0fc7c18d0d938a4293ec3aff1537fb4 --- M src/soc/intel/alderlake/romstage/romstage.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/60135/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60135 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idba11417e0fc7c18d0d938a4293ec3aff1537fb4 Gerrit-Change-Number: 60135 Gerrit-PatchSet: 2 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: commonlib: Add new TS for CSE firmware Sync
by Sridhar Siricilla (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Subrata Banik, Sridhar Siricilla. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59668 to look at the new patch set (#4). Change subject: commonlib: Add new TS for CSE firmware Sync ...................................................................... commonlib: Add new TS for CSE firmware Sync The patch defines new TS for CSE firmware synchronization. Also, removes unused TS_FIT_UCODE_LOADED TS. TEST=Build the code for Brya Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: I9ed82c5358eb94b5e7c91b9fd783c5e09189b77a --- M src/commonlib/include/commonlib/timestamp_serialized.h 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/59668/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/59668 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9ed82c5358eb94b5e7c91b9fd783c5e09189b77a Gerrit-Change-Number: 59668 Gerrit-PatchSet: 4 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: grunt/treeya: Correct Realtek ALC5682 codec SKU ID
by Kevin Chang (Code Review) 16 Dec '21

16 Dec '21

Kevin Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60166 ) Change subject: grunt/treeya: Correct Realtek ALC5682 codec SKU ID ...................................................................... grunt/treeya: Correct Realtek ALC5682 codec SKU ID Correct Realtek ALC5682 codec support SKU ID. BUG=b:185972050 BRANCH=master TEST=check on treeya system ALC5682 audio codec is working normally. Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Change-Id: Ieba7aed92c0def0bee19fd4cb3dd5ff21128ce16 --- M src/mainboard/google/kahlee/variants/treeya/include/variant/sku.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/60166/1 diff --git a/src/mainboard/google/kahlee/variants/treeya/include/variant/sku.h b/src/mainboard/google/kahlee/variants/treeya/include/variant/sku.h index ff2b086..f5d3497 100644 --- a/src/mainboard/google/kahlee/variants/treeya/include/variant/sku.h +++ b/src/mainboard/google/kahlee/variants/treeya/include/variant/sku.h @@ -3,6 +3,6 @@ /* SKU ID enumeration */ enum treeya_sku { SKU_UNKNOWN = -1, - SKU_TREEYA_ALC5682_AE = 174, - SKU_TREEYA_ALC5682_AF = 175, + SKU_TREEYA_ALC5682_BE = 190, + SKU_TREEYA_ALC5682_BF = 191, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/60166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieba7aed92c0def0bee19fd4cb3dd5ff21128ce16 Gerrit-Change-Number: 60166 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/guybrush: Enable PSP_S0I3_RESUME_VERSTAGE
by Paul Menzel (Code Review) 16 Dec '21

16 Dec '21

Attention is currently required from: Rob Barnes, Karthik Ramasubramanian. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60139 ) Change subject: mb/google/guybrush: Enable PSP_S0I3_RESUME_VERSTAGE ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60139/comment/959cd8b6_29d28208 PS1, Line 11: in verstage during s0i3 resume Please add a dot/period at the end of sentences. https://review.coreboot.org/c/coreboot/+/60139/comment/753a91b5_b52ab615 PS1, Line 12: Why does the TPM need to be reinitialized? Why can’t the OS do it for example? -- To view, visit https://review.coreboot.org/c/coreboot/+/60139 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d64fe92ffc67a421be6d5e013e636332ce86dd5 Gerrit-Change-Number: 60139 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 16 Dec 2021 09:56:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021