Rasheed Hsueh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59749 )
Change subject: mb/google/brya/var/taeko: Set vGPIO reset type
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Ping!! Please apply the same change for taeko4es if applicable -- which looks to be the case?
Got that, we will raise new CLs for taeko4es
--
To view, visit https://review.coreboot.org/c/coreboot/+/59749
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice522260f288b165ae66dddc3e1979e806b53f9e
Gerrit-Change-Number: 59749
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-CC: YH Lin <yueherngl(a)google.com>
Gerrit-Comment-Date: Fri, 17 Dec 2021 01:16:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: YH Lin <yueherngl(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60184
to look at the new patch set (#2).
Change subject: soc/amd/common/block/acpimmio/print_reset_status: add missing status bit
......................................................................
soc/amd/common/block/acpimmio/print_reset_status: add missing status bit
Both the Picasso PPR #55570 Rev 3.18 and the Cezanne PPR #56569 Rev 3.03
define bit 9 of the PM_RST_STATUS register as internal Thermal Trip
reset status bit.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Ida8b13fe62b16c18fc9924520b83220e73eca624
---
M src/soc/amd/common/block/acpimmio/print_reset_status.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/60184/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60184
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida8b13fe62b16c18fc9924520b83220e73eca624
Gerrit-Change-Number: 60184
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: newpatchset
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60184 )
Change subject: soc/amd/common/block/acpimmio/print_Reset_status: add missing status bit
......................................................................
soc/amd/common/block/acpimmio/print_Reset_status: add missing status bit
Both the Picasso PPR #55570 Rev 3.18 and the Cezanne PPR #56569 Rev 3.03
define bit 9 of the PM_RST_STATUS register as internal Thermal Trip
reset status bit.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Ida8b13fe62b16c18fc9924520b83220e73eca624
---
M src/soc/amd/common/block/acpimmio/print_reset_status.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/60184/1
diff --git a/src/soc/amd/common/block/acpimmio/print_reset_status.c b/src/soc/amd/common/block/acpimmio/print_reset_status.c
index 3825753..309401e 100644
--- a/src/soc/amd/common/block/acpimmio/print_reset_status.c
+++ b/src/soc/amd/common/block/acpimmio/print_reset_status.c
@@ -33,6 +33,7 @@
[3] = "ThermalTripFromTemp",
[4] = "RemotePowerDownFromASF",
[5] = "ShutDownFan0",
+ [9] = "InternalThermalTrip",
[16] = "UserRst",
[17] = "SoftPciRst",
[18] = "DoInit",
--
To view, visit https://review.coreboot.org/c/coreboot/+/60184
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida8b13fe62b16c18fc9924520b83220e73eca624
Gerrit-Change-Number: 60184
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
xin hua wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54049 )
Change subject: util/crossgcc: Update binutils to 2.37
......................................................................
Patch Set 14:
(1 comment)
Patchset:
PS14:
What this error means
/intel/common/spi.o CC bootblock/southbridge/intel/common/usb_debug.o LINK cbfs/fallback/bootblock.debug /home/kocoman/Downloads/coreboot/util/crossgcc/xgcc/bin/i386-elf-ld.bfd: Error: unable to disambiguate: -nostartfiles (did you mean --nostartfiles ?) make: *** [src/arch/x86/Makefile.inc:90: build/cbfs/fallback/bootblock.debug] Error 1
my error is seen talk here, but what it mean? https://review.coreboot.org/c/coreboot/+/54049
Thx
gcc version 10 vs 11 ?
how to fix
i am lost
--
To view, visit https://review.coreboot.org/c/coreboot/+/54049
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia68d4d9f836ad23fb8f6a7203a78b4ea40c7c43b
Gerrit-Change-Number: 54049
Gerrit-PatchSet: 14
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-CC: xin hua wang <xinhuawang0101(a)gmail.com>
Gerrit-Comment-Date: Fri, 17 Dec 2021 00:54:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Kevin Chiu, Nick Vaccaro, Wisley Chen, Shon Wang.
Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60106 )
Change subject: mb/google/brya/var/vell: Swap TPM I2C with touchscreen I2C
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60106/comment/e72b6ea7_6e9a6330
PS3, Line 9: latest schematic,
> `latest schematic for the next build phase`
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If72717a2c073f5b871c3109399f466a04a9d2484
Gerrit-Change-Number: 60106
Gerrit-PatchSet: 4
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 17 Dec 2021 00:46:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Tim Wawrzynczak, Wisley Chen.
Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60098 )
Change subject: mb/google/brya/var/vell: update overridetree for touchpad
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/vell/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/60098/comment/252b6ec9_e0c3607a
PS3, Line 230: end
> nit: goes on previous line
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60098
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I835958349537ed490191db7c8e35847630de64ed
Gerrit-Change-Number: 60098
Gerrit-PatchSet: 4
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 17 Dec 2021 00:46:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Robert Chen, Nick Vaccaro, Wisley Chen.
Robert Chen has uploaded a new patch set (#4) to the change originally created by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/60106 )
Change subject: mb/google/brya/var/vell: Swap TPM I2C with touchscreen I2C
......................................................................
mb/google/brya/var/vell: Swap TPM I2C with touchscreen I2C
According to the latest schematic for the nect build phase, exchange I2C port for TPM/touchscreen.
TPM: I2C3 -> I2C1
Touchscreen: I2C1 -> I2C3
BUG=b:210572663
TEST=FW_NAME=vell emerge-brya coreboot
Change-Id: If72717a2c073f5b871c3109399f466a04a9d2484
Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/variants/vell/gpio.c
M src/mainboard/google/brya/variants/vell/overridetree.cb
3 files changed, 29 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/60106/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/60106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If72717a2c073f5b871c3109399f466a04a9d2484
Gerrit-Change-Number: 60106
Gerrit-PatchSet: 4
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kevin Chiu, Robert Chen, Wisley Chen.
Hello build bot (Jenkins), Kevin Chiu, Tim Wawrzynczak, Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60098
to look at the new patch set (#4).
Change subject: mb/google/brya/var/vell: update overridetree for touchpad
......................................................................
mb/google/brya/var/vell: update overridetree for touchpad
update override devicetree for touchpad based on schematics
BUG=b:209554950
TEST=emerge-brya coreboot
Change-Id: I835958349537ed490191db7c8e35847630de64ed
Signed-off-by: = <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/vell/overridetree.cb
1 file changed, 16 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/60098/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/60098
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I835958349537ed490191db7c8e35847630de64ed
Gerrit-Change-Number: 60098
Gerrit-PatchSet: 4
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph.
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60126 )
Change subject: soc/intel/alderlake: remove SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60126/comment/ef24f9f9_14aaa570
PS2, Line 7: do not lock GPP_B16/ GPP_B17
> Please remove the space after the slash (/).
Done
https://review.coreboot.org/c/coreboot/+/60126/comment/e3ad8b95_3b192ee0
PS2, Line 9: Do not lock GPP_B16/ GPP_B17 because we set it as NF2. This will let i2c device lost function after warm reboot.
> Please wrap lines after 72 characters.
Done
https://review.coreboot.org/c/coreboot/+/60126/comment/5462a66a_f5741bdd
PS2, Line 9: This will let i2c device lost function after warm reboot.
> Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/60126/comment/85b1b449_5b4583d2
PS2, Line 13: work
> works
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60126
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I106ddc96c3185656d3f1fbcd45f198d2d46f3f4d
Gerrit-Change-Number: 60126
Gerrit-PatchSet: 4
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 17 Dec 2021 00:35:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment