coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: util/cbfstool: Avoid duplicate ntohll/htonll definitions
by Alex James (Code Review) 19 Dec '21

19 Dec '21

Alex James has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60233 ) Change subject: util/cbfstool: Avoid duplicate ntohll/htonll definitions ...................................................................... util/cbfstool: Avoid duplicate ntohll/htonll definitions macOS defines these (as macros) when including arpa/inet.h. This resolves macro redefinition errors on macOS (tested on 10.15.7). Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e Signed-off-by: Alex James <theracermaster(a)gmail.com> --- M util/cbfstool/swab.h 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/60233/1 diff --git a/util/cbfstool/swab.h b/util/cbfstool/swab.h index a45a767..88e41a4 100644 --- a/util/cbfstool/swab.h +++ b/util/cbfstool/swab.h @@ -21,8 +21,12 @@ #else #include <arpa/inet.h> #endif +#ifndef ntohll #define ntohll(x) (is_big_endian() ? (uint64_t)(x) : swab64(x)) +#endif +#ifndef htonll #define htonll(x) (is_big_endian() ? (uint64_t)(x) : swab64(x)) +#endif /* casts are necessary for constants, because we never know how for sure * how U/UL/ULL map to __u16, __u32, __u64. At least not in a portable way. -- To view, visit https://review.coreboot.org/c/coreboot/+/60233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e Gerrit-Change-Number: 60233 Gerrit-PatchSet: 1 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: cbfstool: Avoid defining _XOPEN_SOURCE on macOS
by Alex James (Code Review) 19 Dec '21

19 Dec '21

Alex James has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60232 ) Change subject: cbfstool: Avoid defining _XOPEN_SOURCE on macOS ...................................................................... cbfstool: Avoid defining _XOPEN_SOURCE on macOS Similar to FreeBSD, defining _XOPEN_SOURCE on macOS restricts availability of non-standard functions, including memmem. Remove it to resolve a compilation error on macOS 10.15.7. Change-Id: Iaee1ce7304c89f128a35a385032fce16a2772b13 Signed-off-by: Alex James <theracermaster(a)gmail.com> --- M util/cbfstool/Makefile M util/cbfstool/Makefile.inc 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/60232/1 diff --git a/util/cbfstool/Makefile b/util/cbfstool/Makefile index e853ae5..6edaa0c 100644 --- a/util/cbfstool/Makefile +++ b/util/cbfstool/Makefile @@ -3,6 +3,7 @@ CONFIG_FMD_GENPARSER ?= n +OS_ARCH = $(shell uname) HOSTCC ?= $(CC) PREFIX ?= /usr/local BINDIR ?= $(PREFIX)/bin diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc index 4651f51..1932e01 100644 --- a/util/cbfstool/Makefile.inc +++ b/util/cbfstool/Makefile.inc @@ -134,7 +134,7 @@ TOOLLDFLAGS ?= HOSTCFLAGS += -fms-extensions -ifneq ($(shell uname -o 2>/dev/null), FreeBSD) +ifneq ($(OS_ARCH),$(filter $(OS_ARCH), Darwin FreeBSD)) TOOLCPPFLAGS += -D_XOPEN_SOURCE=700 # strdup() from string.h endif -- To view, visit https://review.coreboot.org/c/coreboot/+/60232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaee1ce7304c89f128a35a385032fce16a2772b13 Gerrit-Change-Number: 60232 Gerrit-PatchSet: 1 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mainboard/starlabs: Add LabTop Mk IV
by Sean Rhodes (Code Review) 19 Dec '21

19 Dec '21

1 0

Change in coreboot[master]: mainboard/starlabs: Add LabTop Mk IV
by Sean Rhodes (Code Review) 19 Dec '21

19 Dec '21

Attention is currently required from: Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58428 ) Change subject: mainboard/starlabs: Add LabTop Mk IV ...................................................................... Patch Set 69: (21 comments) File Documentation/mainboard/starlabs/labtop_cml.md: https://review.coreboot.org/c/coreboot/+/58428/comment/45500f76_410c38d3 PS66, Line 40: [^1] > What does this mean? Added the relating `*1` File src/mainboard/starlabs/labtop/Kconfig.name: https://review.coreboot.org/c/coreboot/+/58428/comment/227bba8d_3c3f82f1 PS66, Line 4: i3-10110u and i7-10710u > nit: `u` in the model names should be uppercase Done File src/mainboard/starlabs/labtop/dsdt.asl: https://review.coreboot.org/c/coreboot/+/58428/comment/606279e5_f89a2f3b PS66, Line 3: #if CONFIG(BOARD_STARLABS_STARBOOK_TGL) : #define EC_GPE_SCI 0x6e : #else : #define EC_GPE_SCI 0x50 : #endif > Idea for another patch: Turn this into a Kconfig option Definitely - added! File src/mainboard/starlabs/labtop/include/memory.h: https://review.coreboot.org/c/coreboot/+/58428/comment/b1f51d6f_61e390fb PS66, Line 6: u8 get_memory_config_straps(void); : const struct cnl_mb_cfg *get_memory_cfg(struct cnl_mb_cfg *mem_cfg); > You don't need this file at all if you make these functions static (in romstage.c). Done File src/mainboard/starlabs/labtop/variants/cml/devicetree.cb: https://review.coreboot.org/c/coreboot/+/58428/comment/af283991_bac16fdf PS66, Line 125: device pci 19.0 off end # I2C4 > Even if it's unused, you should enable this PCI device so that UART #2 can be enumerated properly. […] Would the same apply to TGL? File src/mainboard/starlabs/labtop/variants/cml/romstage.c: https://review.coreboot.org/c/coreboot/+/58428/comment/91812c2e_603b6b18 PS66, Line 12: u8 get_memory_config_straps(void) > This function should be declared as static. Done https://review.coreboot.org/c/coreboot/+/58428/comment/79eef0c1_db662be0 PS66, Line 12: u8 get_memory_config_straps(void) > This function should be declared as static. Done https://review.coreboot.org/c/coreboot/+/58428/comment/407ecab3_8e698b18 PS66, Line 19: > Missing opening parenthesis `(` here Done https://review.coreboot.org/c/coreboot/+/58428/comment/6c58d032_9427e4a5 PS66, Line 19: > Missing opening parenthesis `(` here Done https://review.coreboot.org/c/coreboot/+/58428/comment/5a6e83d5_ffe10193 PS66, Line 38: gpio_t > nit: `const gpio_t` Done https://review.coreboot.org/c/coreboot/+/58428/comment/29505032_0e3010e9 PS66, Line 38: gpio_t > nit: `const gpio_t` Done https://review.coreboot.org/c/coreboot/+/58428/comment/9e497fa8_f6597e25 PS66, Line 39: (u8) > Is it necessary to use `u8`? I'd simply use `u32` or `unsigned int` to avoid casts. Done https://review.coreboot.org/c/coreboot/+/58428/comment/1077e248_4dc96668 PS66, Line 39: (u8) > Is it necessary to use `u8`? I'd simply use `u32` or `unsigned int` to avoid casts. Done https://review.coreboot.org/c/coreboot/+/58428/comment/f663f46c_a4e6009f PS66, Line 42: const struct cnl_mb_cfg *get_memory_cfg(struct cnl_mb_cfg *mem_cfg) > This function should be declared as static. Done https://review.coreboot.org/c/coreboot/+/58428/comment/a5712739_c4c5442f PS66, Line 42: const struct cnl_mb_cfg *get_memory_cfg(struct cnl_mb_cfg *mem_cfg) > This function should be declared as static. Done https://review.coreboot.org/c/coreboot/+/58428/comment/b9262d38_0465038a PS66, Line 46: struct cnl_mb_cfg std_memcfg = { : .rcomp_resistor = {121, 81, 100}, : .rcomp_targets = {100, 40, 20, 20, 26}, : .dq_pins_interleaved = 0, : .vref_ca_config = 2, : .ect = 0, : }; > I'd put this initialisation in `mainboard_memory_init_params()` so that this function only fills in […] Done https://review.coreboot.org/c/coreboot/+/58428/comment/a984e575_61dd7221 PS66, Line 46: struct cnl_mb_cfg std_memcfg = { : .rcomp_resistor = {121, 81, 100}, : .rcomp_targets = {100, 40, 20, 20, 26}, : .dq_pins_interleaved = 0, : .vref_ca_config = 2, : .ect = 0, : }; > I'd put this initialisation in `mainboard_memory_init_params()` so that this function only fills in […] Done https://review.coreboot.org/c/coreboot/+/58428/comment/dbc59c78_47d8d90a PS66, Line 66: memid != 3 && memid != 5 && memid != 7 > Idea: put this into a helper function: […] Done https://review.coreboot.org/c/coreboot/+/58428/comment/ee0a89b2_6f31dea0 PS66, Line 66: memid != 3 && memid != 5 && memid != 7 > Idea: put this into a helper function: […] Done https://review.coreboot.org/c/coreboot/+/58428/comment/243230df_38c05d6d PS66, Line 72: ; > Semicolon not needed Done https://review.coreboot.org/c/coreboot/+/58428/comment/4d18adff_bfcb6d37 PS66, Line 72: ; > Semicolon not needed Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idbaa907dc38dc521961806132f21b7a90324ec9c Gerrit-Change-Number: 58428 Gerrit-PatchSet: 69 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 19 Dec 2021 22:11:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard/starlabs: Add LabTop Mk IV
by Sean Rhodes (Code Review) 19 Dec '21

19 Dec '21

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), Andy Pont, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58428 to look at the new patch set (#70). Change subject: mainboard/starlabs: Add LabTop Mk IV ...................................................................... mainboard/starlabs: Add LabTop Mk IV Tested using MrChromeBox's `uefipayload_202107` branch: * Windows 10 * Ubuntu 20.04 * MX Linux 19.4 * Manjaro 21 No known issues. https://starlabs.systems/pages/labtop-mk-iv-specification Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Idbaa907dc38dc521961806132f21b7a90324ec9c --- M Documentation/mainboard/index.md A Documentation/mainboard/starlabs/labtop_cml.md M src/mainboard/starlabs/labtop/Kconfig M src/mainboard/starlabs/labtop/Kconfig.name M src/mainboard/starlabs/labtop/Makefile.inc M src/mainboard/starlabs/labtop/dsdt.asl A src/mainboard/starlabs/labtop/spd/Makefile.inc A src/mainboard/starlabs/labtop/spd/empty_ddr4.spd.hex A src/mainboard/starlabs/labtop/spd/micron-MT40A1G16KD-062E-E.spd.hex A src/mainboard/starlabs/labtop/spd/samsung-K4A8G165WB-BCRC.spd.hex A src/mainboard/starlabs/labtop/variants/cml/Makefile.inc A src/mainboard/starlabs/labtop/variants/cml/board.fmd A src/mainboard/starlabs/labtop/variants/cml/data.vbt A src/mainboard/starlabs/labtop/variants/cml/devicetree.cb A src/mainboard/starlabs/labtop/variants/cml/devtree.c A src/mainboard/starlabs/labtop/variants/cml/gma-mainboard.ads A src/mainboard/starlabs/labtop/variants/cml/gpio.c A src/mainboard/starlabs/labtop/variants/cml/hda_verb.c A src/mainboard/starlabs/labtop/variants/cml/romstage.c 19 files changed, 1,271 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/58428/70 -- To view, visit https://review.coreboot.org/c/coreboot/+/58428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idbaa907dc38dc521961806132f21b7a90324ec9c Gerrit-Change-Number: 58428 Gerrit-PatchSet: 70 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cbfstool: Fix compilation on macOS
by Alex James (Code Review) 19 Dec '21

19 Dec '21

Alex James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60220 ) Change subject: cbfstool: Fix compilation on macOS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Maybe the commit can be split up into smaller chunks? Sure, I can split up the swab.h/Makefile changes. -- To view, visit https://review.coreboot.org/c/coreboot/+/60220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5997d6d00e12f9f960550e72333ec354593501c Gerrit-Change-Number: 60220 Gerrit-PatchSet: 1 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 19 Dec 2021 21:39:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: starlabs: Convert EC_GPE_SCI to Kconfig
by Sean Rhodes (Code Review) 19 Dec '21

19 Dec '21

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60229 ) Change subject: starlabs: Convert EC_GPE_SCI to Kconfig ...................................................................... starlabs: Convert EC_GPE_SCI to Kconfig Convert EC_GPI_SCI to Kconfig option with default value of 0x50 that is used by most boards. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I8d47ebe76394fe1bcb217e0c6211db1566f82189 --- M src/ec/starlabs/merlin/Kconfig M src/mainboard/starlabs/labtop/Kconfig M src/mainboard/starlabs/labtop/dsdt.asl 3 files changed, 8 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/60229/1 diff --git a/src/ec/starlabs/merlin/Kconfig b/src/ec/starlabs/merlin/Kconfig index fe94b85..f7e7de5 100644 --- a/src/ec/starlabs/merlin/Kconfig +++ b/src/ec/starlabs/merlin/Kconfig @@ -55,3 +55,7 @@ config EC_VARIANT_DIR string default "merlin" if EC_STARLABS_MERLIN + +config EC_GPI_SCI + hex + default 0x50 diff --git a/src/mainboard/starlabs/labtop/Kconfig b/src/mainboard/starlabs/labtop/Kconfig index 65eb576..858541b 100644 --- a/src/mainboard/starlabs/labtop/Kconfig +++ b/src/mainboard/starlabs/labtop/Kconfig @@ -51,6 +51,9 @@ config DRIVER_TPM_SPI_CHIP default 2 +config EC_GPI_SCI + default 0x6e if BOARD_STARLABS_STARBOOK_TGL + config EC_STARLABS_ADD_ITE_BIN default y diff --git a/src/mainboard/starlabs/labtop/dsdt.asl b/src/mainboard/starlabs/labtop/dsdt.asl index 8e6de82..aaea03d 100644 --- a/src/mainboard/starlabs/labtop/dsdt.asl +++ b/src/mainboard/starlabs/labtop/dsdt.asl @@ -1,10 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#if CONFIG(BOARD_STARLABS_STARBOOK_TGL) -#define EC_GPE_SCI 0x6e -#else -#define EC_GPE_SCI 0x50 -#endif +#define EC_GPE_SCI CONFIG_EC_GPE_SCI #include <acpi/acpi.h> DefinitionBlock( -- To view, visit https://review.coreboot.org/c/coreboot/+/60229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d47ebe76394fe1bcb217e0c6211db1566f82189 Gerrit-Change-Number: 60229 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mainboard/starlabs: Add LabTop Mk IV
by Sean Rhodes (Code Review) 19 Dec '21

19 Dec '21

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), Andy Pont, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58428 to look at the new patch set (#69). Change subject: mainboard/starlabs: Add LabTop Mk IV ...................................................................... mainboard/starlabs: Add LabTop Mk IV Tested using MrChromeBox's `uefipayload_202107` branch: * Windows 10 * Ubuntu 20.04 * MX Linux 19.4 * Manjaro 21 No known issues. https://starlabs.systems/pages/labtop-mk-iv-specification Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Idbaa907dc38dc521961806132f21b7a90324ec9c --- M Documentation/mainboard/index.md A Documentation/mainboard/starlabs/labtop_cml.md M src/mainboard/starlabs/labtop/Kconfig M src/mainboard/starlabs/labtop/Kconfig.name M src/mainboard/starlabs/labtop/Makefile.inc M src/mainboard/starlabs/labtop/dsdt.asl A src/mainboard/starlabs/labtop/spd/Makefile.inc A src/mainboard/starlabs/labtop/spd/empty_ddr4.spd.hex A src/mainboard/starlabs/labtop/spd/micron-MT40A1G16KD-062E-E.spd.hex A src/mainboard/starlabs/labtop/spd/samsung-K4A8G165WB-BCRC.spd.hex A src/mainboard/starlabs/labtop/variants/cml/Makefile.inc A src/mainboard/starlabs/labtop/variants/cml/board.fmd A src/mainboard/starlabs/labtop/variants/cml/data.vbt A src/mainboard/starlabs/labtop/variants/cml/devicetree.cb A src/mainboard/starlabs/labtop/variants/cml/devtree.c A src/mainboard/starlabs/labtop/variants/cml/gma-mainboard.ads A src/mainboard/starlabs/labtop/variants/cml/gpio.c A src/mainboard/starlabs/labtop/variants/cml/hda_verb.c A src/mainboard/starlabs/labtop/variants/cml/romstage.c 19 files changed, 1,079 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/58428/69 -- To view, visit https://review.coreboot.org/c/coreboot/+/58428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idbaa907dc38dc521961806132f21b7a90324ec9c Gerrit-Change-Number: 58428 Gerrit-PatchSet: 69 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: commonlib: Add endian definitions for macOS
by Alex James (Code Review) 19 Dec '21

19 Dec '21

Attention is currently required from: Paul Menzel. Alex James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60219 ) Change subject: commonlib: Add endian definitions for macOS ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60219/comment/ebe00a07_a9f29c7f PS1, Line 8: > Please give a short motivation? Since what macOS version is it needed, and what version did you use? Sorry, I should've provided a change description. I've updated it with some background info. -- To view, visit https://review.coreboot.org/c/coreboot/+/60219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44d59869a4420030f3ce26118175304c680d57a1 Gerrit-Change-Number: 60219 Gerrit-PatchSet: 2 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 19 Dec 2021 21:11:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/starlabs/labtop: Tidy up GPIOs
by Sean Rhodes (Code Review) 19 Dec '21

19 Dec '21

Attention is currently required from: Andy Pont. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60123 ) Change subject: mb/starlabs/labtop: Tidy up GPIOs ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3678274dcd52285019fb3cf8ccd22617268ce1a Gerrit-Change-Number: 60123 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Comment-Date: Sun, 19 Dec 2021 21:08:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021