Attention is currently required from: Paul Menzel.
Hello build bot (Jenkins), Bhanu Prakash Maiya, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60090
to look at the new patch set (#4).
Change subject: mb/google/guybrush/var/dewatt: update DRAM ID table
......................................................................
mb/google/guybrush/var/dewatt: update DRAM ID table
1.Samsung LPDDR4X 4266 4G K4UBE3D4AB-MGCL
2.Hynix LPDDR4X 4266 4G H54G56CYRBX247
BUG=b:203014978
BRANCH=guybrush
TEST=emerge-guybrush coreboot chromeos-bootimage
Signed-off-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Change-Id: Ie5ece849a86c75be5af9bc0393090b5f1e33bfed
---
M src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc
M src/mainboard/google/guybrush/variants/dewatt/memory/dram_id.generated.txt
M src/mainboard/google/guybrush/variants/guybrush/memory/mem_parts_used.txt
3 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/60090/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/60090
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5ece849a86c75be5af9bc0393090b5f1e33bfed
Gerrit-Change-Number: 60090
Gerrit-PatchSet: 4
Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel.
Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60090 )
Change subject: mb/google/guybrush/dewatt: update DRAM ID table
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/variants/dewatt/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/60090/comment/3cd3e06e_2d93f311
PS2, Line 19: H54G56CYRBX247
> This is not mentioned? Add it (fix it up) in a separate commit?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60090
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5ece849a86c75be5af9bc0393090b5f1e33bfed
Gerrit-Change-Number: 60090
Gerrit-PatchSet: 3
Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 20 Dec 2021 04:09:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Kenneth Chan has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/60238 )
Change subject: mb/google/guybrush/var/dewatt: update USB 2.0 Lane Parameter settings for USB ports
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/60238
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d82a327fb6e4e69abe335be0bb4619021662e79
Gerrit-Change-Number: 60238
Gerrit-PatchSet: 1
Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: shkim, Henry Sun, SH Kim, Paul Menzel, Simon Yang, Edward Doan, Karthik Ramasubramanian.
Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 )
Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/dedede/variants/bugzzy/ramstage.c:
https://review.coreboot.org/c/coreboot/+/60190/comment/09482c53_b59ba6d0
PS4, Line 47: udelay(20 * 1000); // delay 20ms
> simon@intel, […]
SH,
I believe the code just following bugzzy vbt setting, you need to sync the sequence between vbt and code.
After check current vbt_bugzzy.bin, i think the delay is 20ms.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60190
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db
Gerrit-Change-Number: 60190
Gerrit-PatchSet: 5
Gerrit-Owner: shkim <sh_.kim(a)samsung.com>
Gerrit-Reviewer: Edward Doan <edoan(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: shkim <sh_.kim(a)samsung.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Attention: Edward Doan <edoan(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 20 Dec 2021 03:43:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Edward O'Callaghan, Julius Werner.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60236 )
Change subject: util/futility: Ensure futility checks for flashrom as a dep
......................................................................
Patch Set 1:
(1 comment)
File util/futility/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/60236/comment/471ce0f1_3c588326
PS1, Line 7: |
There should be no veritical bar here?
targets : normal-prerequisites | order-only-prerequisites
This also make Jenkins fail
--
To view, visit https://review.coreboot.org/c/coreboot/+/60236
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9744424f75299eb8335c1c0c2aca2808bde829d
Gerrit-Change-Number: 60236
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Mon, 20 Dec 2021 02:57:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Evan Green, Paul Menzel, Aseda Aboagye, Tyler Wang, Karthik Ramasubramanian.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60185 )
Change subject: mb/google/dedede/var/magolor: Add stylus pen function
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60185/comment/98587b27_81d598d7
PS1, Line 9: Update devicetree and gpio to handle stylus pen detection.
> Please add the documents/source for the implementation. […]
Added the related schematics of pen detect signal:
https://partnerissuetracker.corp.google.com/issues/167983049#comment28
--
To view, visit https://review.coreboot.org/c/coreboot/+/60185
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62489bb289b18f9aa0823005224eda3ef5218e03
Gerrit-Change-Number: 60185
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Evan Green <evgreen(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 20 Dec 2021 02:42:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment