coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/brya: Add new baseboard nissa with variants nivviks and nereid
by Reka Norman (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Kangheui Won, Paul Menzel, Tim Wawrzynczak. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60271 ) Change subject: mb/google/brya: Add new baseboard nissa with variants nivviks and nereid ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60271/comment/632f470d_d9d4aa36 PS2, Line 7: mb/google/brya: Add a new baseboard nissa > _ with variants nivviks and nereid Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a3975fb7a45577fec8ea7c6c9f6ea042ab8cba5 Gerrit-Change-Number: 60271 Gerrit-PatchSet: 3 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 22:13:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
by Tim Wawrzynczak (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: shkim, Henry Sun, Evan Green, SH Kim, Paul Menzel, Simon Yang, Edward Doan, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 ) Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode ...................................................................... Patch Set 11: (1 comment) File src/mainboard/google/dedede/variants/bugzzy/ramstage.c: https://review.coreboot.org/c/coreboot/+/60190/comment/71d8251f_7f4ae541 PS11, Line 58: addr32 = mmio32 + PCH_GPIOB; : data32 = read32((void *) addr32); : data32 |= GPIO_CLOCK_VAL_OUT; : data32 |= GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK; : write32((void *)addr32, data32); > ``` […] It might also be helpful to put these all into functions, e.g. ``` static void panel_power_on(uintptr_t igd_bar) { setbits32((void *)(igd_bar + PCH_PP_CONTROL), 0x1); } static void panel_reset_assert(uintptr_t igd_bar) { clrsetbits32((void *)(igd_bar + PCH_GPIOB), GPIO_CLOCK_VAL_OUT, GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK); } static void panel_reset_deassert(uintptr_t igd_bar) { const uint32_t data32 = GPIO_CLOCK_VAL_MASK | GPIO_CLOCK_VAL_OUT | GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT; setbits32((void *)(igd_bar + PCH_GPIOB), data32); } ``` and then write this function like ``` uintptr_t igd_bar = find_resource(igd_dev, PCI_BASE_ADDRESS_0)->base; if (!igd_bar) return; panel_power_on(); mdelay(20); panel_reset_deassert(); mdelay(2); panel_reset_assert(); mdelay(2); panel_reset_deassert(); ``` WDYT? -- To view, visit https://review.coreboot.org/c/coreboot/+/60190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db Gerrit-Change-Number: 60190 Gerrit-PatchSet: 11 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Evan Green <evgreen(a)chromium.org> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Attention: Edward Doan <edoan(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 21 Dec 2021 22:13:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add new baseboard nissa with variants nivviks and nereid
by Reka Norman (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Reka Norman, Kangheui Won, Tim Wawrzynczak. Hello build bot (Jenkins), Reka Norman, Kangheui Won, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60271 to look at the new patch set (#3). Change subject: mb/google/brya: Add new baseboard nissa with variants nivviks and nereid ...................................................................... mb/google/brya: Add new baseboard nissa with variants nivviks and nereid Add a new baseboard for nissa, an Intel ADL-N based reference design. Also add variants for the two reference boards, nivviks and nereid. This commit is a stub which only adds the minimum code needed for a successful build. BUG=b:197479026 TEST=abuild -a -x -c max -p none -t google/brya -b nivviks abuild -a -x -c max -p none -t google/brya -b nereid Change-Id: I2a3975fb7a45577fec8ea7c6c9f6ea042ab8cba5 Signed-off-by: Reka Norman <rekanorman(a)google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/baseboard/nissa/Makefile.inc A src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb A src/mainboard/google/brya/variants/baseboard/nissa/gpio.c A src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/ec.h A src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/gpio.h A src/mainboard/google/brya/variants/baseboard/nissa/memory.c A src/mainboard/google/brya/variants/nereid/include/variant/ec.h A src/mainboard/google/brya/variants/nereid/include/variant/gpio.h A src/mainboard/google/brya/variants/nereid/overridetree.cb A src/mainboard/google/brya/variants/nivviks/include/variant/ec.h A src/mainboard/google/brya/variants/nivviks/include/variant/gpio.h A src/mainboard/google/brya/variants/nivviks/overridetree.cb 14 files changed, 182 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/60271/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a3975fb7a45577fec8ea7c6c9f6ea042ab8cba5 Gerrit-Change-Number: 60271 Gerrit-PatchSet: 3 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
by Tim Wawrzynczak (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: shkim, Henry Sun, Evan Green, SH Kim, Paul Menzel, Simon Yang, Edward Doan, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 ) Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode ...................................................................... Patch Set 11: (6 comments) File src/mainboard/google/dedede/variants/bugzzy/ramstage.c: https://review.coreboot.org/c/coreboot/+/60190/comment/72dd153e_1f4c8354 PS11, Line 26: if (display_init_required()) `if (display_init_required() || !igd_dev)` https://review.coreboot.org/c/coreboot/+/60190/comment/3dcd6214_e99ff8e6 PS11, Line 29: pci_read_config32(igd_dev, PCI_BASE_ADDRESS_0) & 0xfffffff0; `mmio32 = find_resource(igd_dev, PCI_BASE_ADDRESS_0)->base;` https://review.coreboot.org/c/coreboot/+/60190/comment/aa5fde6f_ccac3c9b PS11, Line 32: addr32 = mmio32 + PCH_PP_CONTROL; : data32 = read32((void *) addr32); : data32 = data32 | 0x1; : write32((void *)addr32, data32); : This can be simplified to: ``` setbits32((void *)(mmio32 + PCH_PP_CONTROL), 0x1); ``` https://review.coreboot.org/c/coreboot/+/60190/comment/e15d1f19_87199c96 PS11, Line 40: addr32 = mmio32 + PCH_GPIOB; : data32 = read32((void *) addr32); : data32 |= GPIO_CLOCK_VAL_OUT; : data32 |= GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK; : write32((void *)addr32, data32); Similarly ``` data32 = GPIO_CLOCK_VAL_MASK | GPIO_CLOCK_VAL_OUT | GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT; setbits32((void *)(mmio32 + PCH_GPIOB), data32); ``` https://review.coreboot.org/c/coreboot/+/60190/comment/8e4c7923_7ca8ba24 PS11, Line 49: addr32 = mmio32 + PCH_GPIOB; : data32 = read32((void *) addr32); : data32 &= ~GPIO_CLOCK_VAL_OUT; : data32 |= GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK; : write32((void *)addr32, data32); ``` clrsetbits32((void *)(mmio32 + PCH_GPIOB), GPIO_CLOCK_VAL_OUT, GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK); ``` https://review.coreboot.org/c/coreboot/+/60190/comment/cc334f68_ec687c1e PS11, Line 58: addr32 = mmio32 + PCH_GPIOB; : data32 = read32((void *) addr32); : data32 |= GPIO_CLOCK_VAL_OUT; : data32 |= GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK; : write32((void *)addr32, data32); ``` data32 = GPIO_CLOCK_VAL_MASK | GPIO_CLOCK_VAL_OUT | GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT; setbits32((void *)(mmio32 + PCH_GPIOB), data32); ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/60190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db Gerrit-Change-Number: 60190 Gerrit-PatchSet: 11 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Evan Green <evgreen(a)chromium.org> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Attention: Edward Doan <edoan(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 21 Dec 2021 22:08:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h
by Julius Werner (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Alex James. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 ) Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h ...................................................................... Patch Set 4: (2 comments) Patchset: PS1: > Done. I also removed is_big_endian in common.c, which was otherwise unused outside of swab.h. Please make sure you keep the difference between ntohl and htonl (use be32toh and htobe32, respectively). While they compile to the same code it's important to distinguish them to communicate the intention behind it. Patchset: PS4: > Should I address the checkpatch lints (in existing code) in this change? No, better leave it in a CL like this. (If you want to you can fix them in a separate patch.) -- To view, visit https://review.coreboot.org/c/coreboot/+/60233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e Gerrit-Change-Number: 60233 Gerrit-PatchSet: 4 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Dec 2021 22:01:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: commonlib: Add endian definitions for macOS
by Julius Werner (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Paul Menzel, Alex James. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60219 ) Change subject: commonlib: Add endian definitions for macOS ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44d59869a4420030f3ce26118175304c680d57a1 Gerrit-Change-Number: 60219 Gerrit-PatchSet: 3 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Dec 2021 21:52:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfstool: Avoid defining _XOPEN_SOURCE on macOS
by Julius Werner (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Patrick Georgi, Alex James. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60232 ) Change subject: cbfstool: Avoid defining _XOPEN_SOURCE on macOS ...................................................................... Patch Set 2: (1 comment) File util/cbfstool/Makefile.inc: https://review.coreboot.org/c/coreboot/+/60232/comment/1890e476_cc6ed119 PS1, Line 137: ifneq ($(OS_ARCH),$(filter $(OS_ARCH), Darwin FreeBSD)) > This seems broadly similar to what I did in CB:59891. […] As long as glibc still builds that way that's fine by me too. -- To view, visit https://review.coreboot.org/c/coreboot/+/60232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaee1ce7304c89f128a35a385032fce16a2772b13 Gerrit-Change-Number: 60232 Gerrit-PatchSet: 2 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Dec 2021 21:49:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/soc/intel/alderlake/: Add Alder Lake FSP headers for FSP v2511
by Saurabh Mishra (Code Review) 21 Dec '21

21 Dec '21

1 0

Change in coreboot[master]: src/soc/intel/alderlake/: Add Alder Lake FSP headers for FSP v2511
by Saurabh Mishra (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Paul Menzel, Balaji Manigandan, Patrick Rudolph. Hello Tim Wawrzynczak, Balaji Manigandan, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60259 to look at the new patch set (#5). Change subject: src/soc/intel/alderlake/: Add Alder Lake FSP headers for FSP v2511 ...................................................................... src/soc/intel/alderlake/: Add Alder Lake FSP headers for FSP v2511 Previous FSP version was v2471 Changes Include: - Updated spd_upds and dq_upds structure variables in meminit.c - Updated structure member of s_cfg->LpmStateEnableMask to PmcLpmS0ixSubStateEnableMask in fsp_params.c change-Id: I0c6ae72610da39fc18ff252c440d006e83c576f3 Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com> --- M src/soc/intel/alderlake/fsp_params.c M src/soc/intel/alderlake/meminit.c 2 files changed, 27 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/60259/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/60259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c6ae72610da39fc18ff252c440d006e83c576f3 Gerrit-Change-Number: 60259 Gerrit-PatchSet: 5 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/soc/intel/alderlake/: Add Alder Lake FSP headers for FSP v2511 Pr...
by Saurabh Mishra (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Paul Menzel, Balaji Manigandan, Patrick Rudolph. Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60259 ) Change subject: src/soc/intel/alderlake/: Add Alder Lake FSP headers for FSP v2511 Previous FSP version was v2471. ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60259/comment/78c021d4_cee6c314 PS1, Line 7: Meminit function call in coreboot has been updated as per new FSP : UPD and DQS in headers. : : src/soc/intel/alderlake/meminit.c : Changes adopted as per new FSP DQS & : UPD calls. : src/soc/intel/alderlake/fsp_params.c : Updated LpmStateEnableMask UPD > The message summary still does not follow the common style. […] Formatted the commit message. Please review. -- To view, visit https://review.coreboot.org/c/coreboot/+/60259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c6ae72610da39fc18ff252c440d006e83c576f3 Gerrit-Change-Number: 60259 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 21:41:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Saurabh Mishra <mishra.saurabh(a)intel.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021