coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/brya/var/vell: update overridetree for DP
by Robert Chen (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Tim Wawrzynczak, Shon Wang. Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60251 ) Change subject: mb/google/brya/var/vell: update overridetree for DP ...................................................................... Patch Set 5: (2 comments) File src/mainboard/google/brya/variants/vell/overridetree.cb: https://review.coreboot.org/c/coreboot/+/60251/comment/ba6978ea_47bb59cc PS2, Line 136: 0 > why did this comment change? Done File src/mainboard/google/brya/variants/vell/overridetree.cb: https://review.coreboot.org/c/coreboot/+/60251/comment/19828e28_06000846 PS4, Line 250: device i2c 15 on : end > why did this change? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd2f5de38df0eb89fb92ea2abe25851c0d6ec53f Gerrit-Change-Number: 60251 Gerrit-PatchSet: 5 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 01:49:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Swap TPM I2C with touchscreen I2C
by Robert Chen (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Kevin Chiu, Robert Chen, Nick Vaccaro, Wisley Chen. Robert Chen has uploaded a new patch set (#6) to the change originally created by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/60106 ) Change subject: mb/google/brya/var/vell: Swap TPM I2C with touchscreen I2C ...................................................................... mb/google/brya/var/vell: Swap TPM I2C with touchscreen I2C According to the latest schematic for the next build phase, exchange I2C port for TPM/touchscreen. TPM: I2C3 -> I2C1 Touchscreen: I2C1 -> I2C3 BUG=b:210572663 TEST=FW_NAME=vell emerge-brya coreboot Change-Id: If72717a2c073f5b871c3109399f466a04a9d2484 Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/variants/vell/gpio.c M src/mainboard/google/brya/variants/vell/overridetree.cb 3 files changed, 15 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/60106/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/60106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If72717a2c073f5b871c3109399f466a04a9d2484 Gerrit-Change-Number: 60106 Gerrit-PatchSet: 6 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/vell: update overridetree for DP
by Robert Chen (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Shon Wang. Robert Chen has uploaded a new patch set (#5) to the change originally created by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/60251 ) Change subject: mb/google/brya/var/vell: update overridetree for DP ...................................................................... mb/google/brya/var/vell: update overridetree for DP update override devicetree for type-c display based on schematics BUG=b:209489126 TEST=emerge-brya coreboot Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Change-Id: Icd2f5de38df0eb89fb92ea2abe25851c0d6ec53f --- M src/mainboard/google/brya/variants/vell/overridetree.cb 1 file changed, 60 insertions(+), 34 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/60251/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/60251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd2f5de38df0eb89fb92ea2abe25851c0d6ec53f Gerrit-Change-Number: 60251 Gerrit-PatchSet: 5 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/herobrine: Initialize SPI FW for EC and TPM
by Sudheer Amrabadi (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Shelley Chen, Ravi kumar, Paul Menzel, mturney mturney, Julius Werner, Rajesh Patil. Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50581 ) Change subject: mb/google/herobrine: Initialize SPI FW for EC and TPM ...................................................................... Patch Set 93: (8 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/50581/comment/a47c39e2_814f7edc PS71, Line 11: > Please mention the two variants, and what is done with them. Ack Commit Message: https://review.coreboot.org/c/coreboot/+/50581/comment/4a0198b7_a666aaff PS72, Line 7: mb/mainboard/herobrine > mb/google/herobrine Ack Patchset: PS93: will be part of next patch train File src/mainboard/google/herobrine/Kconfig: https://review.coreboot.org/c/coreboot/+/50581/comment/b6959680_41670fb5 PS79, Line 27: BOARD_GOOGLE_PIGLIN > || BOARD_GOOGLE_HOGLIN Ack https://review.coreboot.org/c/coreboot/+/50581/comment/1b8509d4_f4920530 PS79, Line 67: BOARD_GOOGLE_PIGLIN > || BOARD_GOOGLE_HOGLIN Ack https://review.coreboot.org/c/coreboot/+/50581/comment/a2e3e4cf_6af87b48 PS79, Line 72: BOARD_GOOGLE_PIGLIN > || BOARD_GOOGLE_HOGLIN Ack File src/mainboard/google/herobrine/bootblock.c: https://review.coreboot.org/c/coreboot/+/50581/comment/669850e3_40bf9b6b PS79, Line 16: if (CONFIG(BOARD_GOOGLE_PIGLIN)) > || CONFIG(BOARD_GOOGLE_HOGLIN) Ack https://review.coreboot.org/c/coreboot/+/50581/comment/97f55a02_03f35a40 PS79, Line 17: qup_spi_init(CONFIG_DRIVER_TPM_SPI_BUS, 1010 * KHz); > Please add "/* H1/TPM SPI */" comment. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/50581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8cbdd1d59a0166688d52d61646db1b6764879a7c Gerrit-Change-Number: 50581 Gerrit-PatchSet: 93 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Mukesh Savaliya <msavaliy(a)qualcomm.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 01:33:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: google/herobrine: configure gpio to detect board ID.
by Sudheer Amrabadi (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Shelley Chen, Ravi kumar, Ravi Kumar Bokka. Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56642 ) Change subject: google/herobrine: configure gpio to detect board ID. ...................................................................... Patch Set 35: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56642/comment/92f177b6_38824679 PS35, Line 9: change binary board ID to tri-state mode. > I don't think that you're doing this anymore in this CL... Ack Patchset: PS35: Fixing as part of next patch train File src/mainboard/google/herobrine/board.h: https://review.coreboot.org/c/coreboot/+/56642/comment/3fc70567_5fc64d54 PS20, Line 14: #define QCOM_SC7280_SKU3 0x3 : #define QCOM_SC7280_SKU4 0x9 > HI Shelly, […] Ack File src/mainboard/google/herobrine/boardid.c: https://review.coreboot.org/c/coreboot/+/56642/comment/b8456b3d_9dbb07aa PS18, Line 13: #if CONFIG(BOARD_GOOGLE_HEROBRINE) : const gpio_t pins[] = {[2] = GPIO(75), [1] = GPIO(74), [0] = GPIO(73)}; : #elif CONFIG(BOARD_GOOGLE_PIGLIN) || CONFIG(BOARD_GOOGLE_HOGLIN) || CONFIG(BOARD_GOOGLE_SENOR) : const gpio_t pins[] = {[2] = GPIO(50), [1] = GPIO(49), [0] = GPIO(48)}; : #end > use C code? Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/56642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6de2a7e7b11ecce8325e0fd44dc7221d73729390 Gerrit-Change-Number: 56642 Gerrit-PatchSet: 35 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 01:33:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Comment-In-Reply-To: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Add options to separate signed firmwares
by Kangheui Won (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Karthik Ramasubramanian, Felix Held. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59866 ) Change subject: amdfwtool: Add options to separate signed firmwares ...................................................................... Patch Set 2: (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/59866/comment/9869ee69_316b78b5 PS2, Line 825: pspdir->entries[count].addr = fw_table[i].addr_signed; : bytes = fw_table[i].file_size; > Why is the address & size being tracked? […] Address and size are filled in the psp directory entry. We only pass psp directory table to the PSP which has addresses and sizes for each firmware. -- To view, visit https://review.coreboot.org/c/coreboot/+/59866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f3610a7002b2a9c70946b083b0b3be6934200b0 Gerrit-Change-Number: 59866 Gerrit-PatchSet: 2 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 22 Dec 2021 01:07:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Add options to separate signed firmwares
by Karthik Ramasubramanian (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Kangheui Won, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59866 ) Change subject: amdfwtool: Add options to separate signed firmwares ...................................................................... Patch Set 2: (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/59866/comment/0c6d3837_2f86f2c6 PS2, Line 825: pspdir->entries[count].addr = fw_table[i].addr_signed; : bytes = fw_table[i].file_size; Why is the address & size being tracked? Same for unsigned firmware. I am seeing that the blob is copied into mirror buffer. If so, why is the address being tracked there? -- To view, visit https://review.coreboot.org/c/coreboot/+/59866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f3610a7002b2a9c70946b083b0b3be6934200b0 Gerrit-Change-Number: 59866 Gerrit-PatchSet: 2 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 22 Dec 2021 00:46:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: Swap TPM I2C with touchscreen I2C
by Robert Chen (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Kevin Chiu, Robert Chen, Nick Vaccaro, Wisley Chen, Shon Wang. Robert Chen has uploaded a new patch set (#5) to the change originally created by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/60106 ) Change subject: mb/google/brya/var/vell: Swap TPM I2C with touchscreen I2C ...................................................................... mb/google/brya/var/vell: Swap TPM I2C with touchscreen I2C According to the latest schematic for the next build phase, exchange I2C port for TPM/touchscreen. TPM: I2C3 -> I2C1 Touchscreen: I2C1 -> I2C3 BUG=b:210572663 TEST=FW_NAME=vell emerge-brya coreboot Change-Id: If72717a2c073f5b871c3109399f466a04a9d2484 Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/variants/vell/gpio.c M src/mainboard/google/brya/variants/vell/overridetree.cb 3 files changed, 29 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/60106/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/60106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If72717a2c073f5b871c3109399f466a04a9d2484 Gerrit-Change-Number: 60106 Gerrit-PatchSet: 5 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mainboard: Fix DPTF device state in the devicetree on CFL boards
by Felix Singer (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Tim Crawford, Nico Huber, Patrick Rudolph, Jeremy Soller, Tim Wawrzynczak, Christian Walter. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60203 ) Change subject: mainboard: Fix DPTF device state in the devicetree on CFL boards ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60203/comment/6467180c_7e73f7c7 PS2, Line 12: * google/hatch > Actually, it's only true for half of the variants. Those that […] As Tim wrote, he tested google/dratini. Anything left to do here? https://review.coreboot.org/c/coreboot/+/60203/comment/66b37953_f151e7ae PS2, Line 14: Thus, set it to on to make the resource allocator aware of it. > It also activates `soc/intel/common/block/dtt/dtt.c`. This simply […] Anything to do here? -- To view, visit https://review.coreboot.org/c/coreboot/+/60203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I561598c252c5da64ece569c6ba336852e713ccab Gerrit-Change-Number: 60203 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Tue, 21 Dec 2021 23:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Add options to separate signed firmwares
by Raul Rangel (Code Review) 22 Dec '21

22 Dec '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Kangheui Won, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59866 ) Change subject: amdfwtool: Add options to separate signed firmwares ...................................................................... Patch Set 2: (1 comment) File util/amdfwtool/amdfwtool.h: https://review.coreboot.org/c/coreboot/+/59866/comment/210e028b_500727bb PS2, Line 225: amd_fw_header > Please refer to the bug here for details: b/203597980#comment4 Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/59866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f3610a7002b2a9c70946b083b0b3be6934200b0 Gerrit-Change-Number: 59866 Gerrit-PatchSet: 2 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 21 Dec 2021 23:55:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021