coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/intel/adlrvp: Configure GPIOs for Alder Lake-N
by Usha P (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Anilkumar N, Subrata Banik, Maulik V Vaghela, Kangheui Won, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D. Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59937 ) Change subject: mb/intel/adlrvp: Configure GPIOs for Alder Lake-N ...................................................................... Patch Set 11: (1 comment) File src/mainboard/intel/adlrvp/early_gpio_n.c: https://review.coreboot.org/c/coreboot/+/59937/comment/893d04bd_df3f837f PS10, Line 5: #include <commonlib/helpers.h> > You don't need this, please look at CB:60305 Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/59937 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c0ca52d0cc73acfd8503007d5f3d2ad9a48f8ca Gerrit-Change-Number: 59937 Gerrit-PatchSet: 11 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Comment-Date: Thu, 23 Dec 2021 04:19:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/{adlrvp,sm}: Remove unused header `helpers.h`
by Subrata Banik (Code Review) 23 Dec '21

23 Dec '21

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60305 ) Change subject: mb/intel/{adlrvp,sm}: Remove unused header `helpers.h` ...................................................................... mb/intel/{adlrvp,sm}: Remove unused header `helpers.h` This patch removes unused header inclusion as <commonlib/helpers.h> from several mainboard gpio definition files. Change-Id: I36758089a4981bba916f4d9cf485f64fca2f81ae Signed-off-by: subratabanik <subratabanik(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60305 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/intel/adlrvp/early_gpio.c M src/mainboard/intel/adlrvp/early_gpio_m.c M src/mainboard/intel/adlrvp/gpio_m.c M src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c 4 files changed, 0 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved EricR Lai: Looks good to me, approved diff --git a/src/mainboard/intel/adlrvp/early_gpio.c b/src/mainboard/intel/adlrvp/early_gpio.c index 5af355b..57cadfa 100644 --- a/src/mainboard/intel/adlrvp/early_gpio.c +++ b/src/mainboard/intel/adlrvp/early_gpio.c @@ -2,7 +2,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <commonlib/helpers.h> #include <soc/gpio.h> /* Early pad configuration in bootblock */ diff --git a/src/mainboard/intel/adlrvp/early_gpio_m.c b/src/mainboard/intel/adlrvp/early_gpio_m.c index 3798593..fbc6467 100644 --- a/src/mainboard/intel/adlrvp/early_gpio_m.c +++ b/src/mainboard/intel/adlrvp/early_gpio_m.c @@ -2,7 +2,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <commonlib/helpers.h> #include <soc/gpio.h> /* Early pad configuration in bootblock */ diff --git a/src/mainboard/intel/adlrvp/gpio_m.c b/src/mainboard/intel/adlrvp/gpio_m.c index 6eb670b..62ae0f3 100644 --- a/src/mainboard/intel/adlrvp/gpio_m.c +++ b/src/mainboard/intel/adlrvp/gpio_m.c @@ -2,7 +2,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <commonlib/helpers.h> /* Pad configuration in ramstage */ static const struct pad_config gpio_table[] = { diff --git a/src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c b/src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c index 6a74468..ea05b89 100644 --- a/src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c +++ b/src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c @@ -2,7 +2,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <commonlib/helpers.h> /* Early pad configuration in bootblock */ static const struct pad_config early_gpio_table[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/60305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36758089a4981bba916f4d9cf485f64fca2f81ae Gerrit-Change-Number: 60305 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: Pass the EN_SPKR gpio in devicetree for nipperkin
by V sujith kumar Reddy (Code Review) 23 Dec '21

23 Dec '21

V sujith kumar Reddy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60315 ) Change subject: Pass the EN_SPKR gpio in devicetree for nipperkin ...................................................................... Pass the EN_SPKR gpio in devicetree for nipperkin Change-Id: Icbf1e2055c30ca595d6b048e4fcf31a9bb805439 Signed-off-by: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> --- M src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/60315/1 diff --git a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb index 2d3b162..b975acf 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb +++ b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb @@ -48,6 +48,7 @@ device ref acp on chip drivers/amd/i2s_machine_dev register "hid" = ""10029836"" + register "enspkr_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_70)" device generic 0.0 on end end end # Audio -- To view, visit https://review.coreboot.org/c/coreboot/+/60315 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbf1e2055c30ca595d6b048e4fcf31a9bb805439 Gerrit-Change-Number: 60315 Gerrit-PatchSet: 1 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Pass the EN_SPKR gpio in devicetree for guybrush
by V sujith kumar Reddy (Code Review) 23 Dec '21

23 Dec '21

V sujith kumar Reddy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60314 ) Change subject: Pass the EN_SPKR gpio in devicetree for guybrush ...................................................................... Pass the EN_SPKR gpio in devicetree for guybrush Change-Id: I00e433e48cd7ac157163ed9e49c3aa8dc6a850c6 Signed-off-by: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> --- M src/mainboard/google/guybrush/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/60314/1 diff --git a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb index 7fb3c7e..2b1fe3b 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb @@ -325,6 +325,7 @@ device ref acp on chip drivers/amd/i2s_machine_dev register "hid" = ""AMDI1019"" + register "enspkr_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_31)" device generic 0.0 on end end end # Audio -- To view, visit https://review.coreboot.org/c/coreboot/+/60314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00e433e48cd7ac157163ed9e49c3aa8dc6a850c6 Gerrit-Change-Number: 60314 Gerrit-PatchSet: 1 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Passing EN_SPKR gpio descriptor from coreboot to kernel
by V sujith kumar Reddy (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Raul Rangel, Yu-hsuan Hsu. Hello build bot (Jenkins), Raul Rangel, Yu-hsuan Hsu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60072 to look at the new patch set (#4). Change subject: Passing EN_SPKR gpio descriptor from coreboot to kernel ...................................................................... Passing EN_SPKR gpio descriptor from coreboot to kernel Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Signed-off-by: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> --- M src/drivers/amd/i2s_machine_dev/chip.h M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c 2 files changed, 20 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/60072/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Gerrit-Change-Number: 60072 Gerrit-PatchSet: 4 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Passing EN_SPKR gpio descriptor from coreboot to kernel
by V sujith kumar Reddy (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Raul Rangel, Yu-hsuan Hsu. V sujith kumar Reddy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60072 ) Change subject: Passing EN_SPKR gpio descriptor from coreboot to kernel ...................................................................... Patch Set 3: (5 comments) File src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c: https://review.coreboot.org/c/coreboot/+/60072/comment/7b02751e_36767933 PS2, Line 21: dmic_select_gpio > So this function expected the dmic_select_gpio to always have pin_count > 0 since it was checked bef […] done https://review.coreboot.org/c/coreboot/+/60072/comment/1d2acf79_5aa08cb2 PS2, Line 35: acpi_dp_add_gpio > This needs a guard too done https://review.coreboot.org/c/coreboot/+/60072/comment/45ffdb48_b30b2a9d PS2, Line 39: enspkr_gpio > Should be `enspkr_gpio->pin_count` done https://review.coreboot.org/c/coreboot/+/60072/comment/e9e3b13a_9d563a4c PS2, Line 40: 1 > This index will change depending if dmic-gpios is passed in. done File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb: PS2: > Please split this into a separate file. ok -- To view, visit https://review.coreboot.org/c/coreboot/+/60072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Gerrit-Change-Number: 60072 Gerrit-PatchSet: 3 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Comment-Date: Thu, 23 Dec 2021 03:58:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Passing EN_SPKR gpio descriptor from coreboot to kernel
by V sujith kumar Reddy (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: V sujith kumar Reddy, Yu-hsuan Hsu. Hello build bot (Jenkins), Raul Rangel, Yu-hsuan Hsu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60072 to look at the new patch set (#3). Change subject: Passing EN_SPKR gpio descriptor from coreboot to kernel ...................................................................... Passing EN_SPKR gpio descriptor from coreboot to kernel Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Signed-off-by: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> --- M src/drivers/amd/i2s_machine_dev/chip.h M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c 2 files changed, 20 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/60072/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Gerrit-Change-Number: 60072 Gerrit-PatchSet: 3 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Attention: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/cherry: add configuration for dojo
by Chen-Tsung Hsieh (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Hung-Te Lin, Kevin Chiu, Yu-Ping Wu. Chen-Tsung Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60313 ) Change subject: mb/google/cherry: add configuration for dojo ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60313 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3bd9803b4e47882df9fe351229478e4cb1630363 Gerrit-Change-Number: 60313 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 23 Dec 2021 03:41:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/{adlrvp,sm}: Remove unused header `helpers.h`
by Felix Singer (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Nick Vaccaro, Tim Wawrzynczak. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60305 ) Change subject: mb/intel/{adlrvp,sm}: Remove unused header `helpers.h` ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36758089a4981bba916f4d9cf485f64fca2f81ae Gerrit-Change-Number: 60305 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Thu, 23 Dec 2021 03:32:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/primus:Fix some GPIO programming
by Felix Singer (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Ariel Fang, Tim Wawrzynczak, Casper Chang. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60104 ) Change subject: mb/google/brya/var/primus:Fix some GPIO programming ...................................................................... Patch Set 14: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60104/comment/a8390adf_57eeaf3f PS14, Line 7: Fix Add a space before that https://review.coreboot.org/c/coreboot/+/60104/comment/116df745_6c5bbf6e PS14, Line 9: - Remove dash https://review.coreboot.org/c/coreboot/+/60104/comment/4d9fcfc1_c8a1408d PS14, Line 12:  Please only use ASCII characters. I would just remove these and leave it as it is. https://review.coreboot.org/c/coreboot/+/60104/comment/3ae1e786_654bfab3 PS14, Line 14: Remove space Patchset: PS14: Thanks Ariel 👍 Last todos, then I'm good 😊 File src/mainboard/google/brya/variants/primus4es/gpio.c: https://review.coreboot.org/c/coreboot/+/60104/comment/d2622261_7b21a663 PS14, Line 39: /* D3 : ISH_GP3 ==> M2_SSD_PLN_L */ : PAD_CFG_GPO(GPP_D3, 1, PLTRST), Remove this one? -- To view, visit https://review.coreboot.org/c/coreboot/+/60104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e269bc6fb6eda7b2de57e1a9c900864d3e86e98 Gerrit-Change-Number: 60104 Gerrit-PatchSet: 14 Gerrit-Owner: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Thu, 23 Dec 2021 03:24:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021