coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: Pass the EN_SPKR gpio in devicetree for guybrush
by Yu-hsuan Hsu (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: V sujith kumar Reddy. Yu-hsuan Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60314 ) Change subject: Pass the EN_SPKR gpio in devicetree for guybrush ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00e433e48cd7ac157163ed9e49c3aa8dc6a850c6 Gerrit-Change-Number: 60314 Gerrit-PatchSet: 2 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 23 Dec 2021 16:28:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Passing EN_SPKR gpio descriptor from coreboot to kernel
by Yu-hsuan Hsu (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: V sujith kumar Reddy, Raul Rangel. Yu-hsuan Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60072 ) Change subject: Passing EN_SPKR gpio descriptor from coreboot to kernel ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Gerrit-Change-Number: 60072 Gerrit-PatchSet: 5 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 16:28:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/types.h: #include <limits.h>
by Tim Wawrzynczak (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Paul Menzel, Angel Pons, Julius Werner, Kyösti Mälkki, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55320 ) Change subject: include/types.h: #include <limits.h> ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/55320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ba189b998644c68068b85f25b11cff4d70c037d Gerrit-Change-Number: 55320 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 16:28:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Add CdClock frequency config
by Tim Wawrzynczak (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Nico Huber, Jamie Chen, Subrata Banik, Henry Sun, Paul Menzel, Ren Kuo, Simon Yang, Kane Chen, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60009 ) Change subject: soc/intel/jasperlake: Add CdClock frequency config ...................................................................... Patch Set 17: (1 comment) File src/soc/intel/jasperlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/60009/comment/166e03a6_dcf1c129 PS17, Line 212: params->CdClock = config->cd_clock ? config->cd_clock - 1 : 0xff; > I guess there are 2 problems […] Here are the actual values used by/expected by JSL FSP: ``` CdClock 0: 172.8Mhz CdClock 1: 180Mhz CdClock 2: 192Mhz CdClock 3: 307.2Mhz CdClock 4: 312Mhz CdClock 5: 552Mhz CdClock 6: 556.8Mhz CdClock 7: 648Mhz CdClock 8: 652.8Mhz CdClock:0xFF Program Max based on reference clock:- For 19.2MHz, 38.4MHz = 652.8 MHz. For 24MHz = 648MHz. ``` So the comment in the FSP header is definitely wrong. However a comment here might help explain why the games are being played here (i.e., we intentionally want the default to be Auto (0xff), so we reserve the `0` value here to mean auto instead, and shift the other values by 1) -- To view, visit https://review.coreboot.org/c/coreboot/+/60009 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I917c2f10b130b0cd54f60e2ba98eb971d5ec3c97 Gerrit-Change-Number: 60009 Gerrit-PatchSet: 17 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 16:27:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Passing EN_SPKR gpio descriptor from coreboot to kernel
by V sujith kumar Reddy (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Raul Rangel, Yu-hsuan Hsu. V sujith kumar Reddy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60072 ) Change subject: Passing EN_SPKR gpio descriptor from coreboot to kernel ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60072/comment/f14334ba_46b0f20b PS4, Line 8: > It should be better to add the bug and test field like other changes here. done File src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c: https://review.coreboot.org/c/coreboot/+/60072/comment/cb815850_69192ee8 PS4, Line 38: enspkr_gpio > dmic_select_gpio? done File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/60072/comment/5c78cf3e_ee4a830d PS2, Line 328: GPIO_31 > So this is true for `board id >= 2`: […] splitted the device tree. done. As we written code for guybrush proto-2 and for nipperkin. -- To view, visit https://review.coreboot.org/c/coreboot/+/60072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Gerrit-Change-Number: 60072 Gerrit-PatchSet: 4 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Comment-Date: Thu, 23 Dec 2021 16:22:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Pass the EN_SPKR gpio in devicetree for nipperkin
by V sujith kumar Reddy (Code Review) 23 Dec '21

23 Dec '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60315 to look at the new patch set (#2). Change subject: Pass the EN_SPKR gpio in devicetree for nipperkin ...................................................................... Pass the EN_SPKR gpio in devicetree for nipperkin BUG=b:168749907 TEST=probed on enspkr voltage value at soi3 state to zero. Change-Id: Icbf1e2055c30ca595d6b048e4fcf31a9bb805439 Signed-off-by: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> --- M src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/60315/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60315 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbf1e2055c30ca595d6b048e4fcf31a9bb805439 Gerrit-Change-Number: 60315 Gerrit-PatchSet: 2 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Pass the EN_SPKR gpio in devicetree for guybrush
by V sujith kumar Reddy (Code Review) 23 Dec '21

23 Dec '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60314 to look at the new patch set (#2). Change subject: Pass the EN_SPKR gpio in devicetree for guybrush ...................................................................... Pass the EN_SPKR gpio in devicetree for guybrush BUG=b:195748546 TEST=probed on enspkr voltage value at soi3 state to zero. Change-Id: I00e433e48cd7ac157163ed9e49c3aa8dc6a850c6 Signed-off-by: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> --- M src/mainboard/google/guybrush/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/60314/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00e433e48cd7ac157163ed9e49c3aa8dc6a850c6 Gerrit-Change-Number: 60314 Gerrit-PatchSet: 2 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Passing EN_SPKR gpio descriptor from coreboot to kernel
by V sujith kumar Reddy (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: V sujith kumar Reddy, Raul Rangel. Hello build bot (Jenkins), Raul Rangel, Yu-hsuan Hsu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60072 to look at the new patch set (#5). Change subject: Passing EN_SPKR gpio descriptor from coreboot to kernel ...................................................................... Passing EN_SPKR gpio descriptor from coreboot to kernel BUG=b:195748546 TEST=probed on enspkr voltage value at soi3 state to zero. Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Signed-off-by: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> --- M src/drivers/amd/i2s_machine_dev/chip.h M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c 2 files changed, 20 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/60072/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/60072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Gerrit-Change-Number: 60072 Gerrit-PatchSet: 5 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/{skl,cnl}: Guard USB macro parameters
by Tim Wawrzynczak (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Felix Singer, Angel Pons, Michael Niewöhner, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60324 ) Change subject: soc/intel/{skl,cnl}: Guard USB macro parameters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61fbacc129cbfb42ade7e64ee40cd07c98d87683 Gerrit-Change-Number: 60324 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 16:18:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: update overridetree for touchpad
by Paul Menzel (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Robert Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60098 ) Change subject: mb/google/brya/var/vell: update overridetree for touchpad ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60098/comment/c8680cf8_4b9bf3b9 PS5, Line 2: = Please fix the author name. https://review.coreboot.org/c/coreboot/+/60098/comment/6c2af5f7_eee04b59 PS5, Line 15: = Please fix the author name. -- To view, visit https://review.coreboot.org/c/coreboot/+/60098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I835958349537ed490191db7c8e35847630de64ed Gerrit-Change-Number: 60098 Gerrit-PatchSet: 5 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 23 Dec 2021 15:55:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021