coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/brya: fix taniks' and vell's override.cb
by Nick Vaccaro (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Tim Wawrzynczak. Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60326 ) Change subject: mb/google/brya: fix taniks' and vell's override.cb ...................................................................... mb/google/brya: fix taniks' and vell's override.cb Taniks and vell were still using an older (and now obsolete) way of defining the port numbers for the pmc_mux connectors. Update taniks and vell to use new method of defining the ports. BUG=None TEST='emerge-brya coreboot chromeos-bootimage' and verify it builds correctly. Change-Id: Ie69a143ea2a43a1ee5a3c9f79975e1831e88c4b4 Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/brya/variants/taniks/overridetree.cb M src/mainboard/google/brya/variants/vell/overridetree.cb 2 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/60326/1 diff --git a/src/mainboard/google/brya/variants/taniks/overridetree.cb b/src/mainboard/google/brya/variants/taniks/overridetree.cb index deb31ce..cb8c99a 100644 --- a/src/mainboard/google/brya/variants/taniks/overridetree.cb +++ b/src/mainboard/google/brya/variants/taniks/overridetree.cb @@ -365,13 +365,13 @@ chip drivers/intel/pmc_mux device generic 0 on chip drivers/intel/pmc_mux/conn - register "usb2_port_number" = "1" - register "usb3_port_number" = "1" + use usb2_port1 as usb2_port + use tcss_usb3_port1 as usb3_port device generic 0 alias conn0 on end end chip drivers/intel/pmc_mux/conn - register "usb2_port_number" = "3" - register "usb3_port_number" = "3" + use usb2_port3 as usb2_port + use tcss_usb3_port3 as usb3_port device generic 2 alias conn1 on end end end diff --git a/src/mainboard/google/brya/variants/vell/overridetree.cb b/src/mainboard/google/brya/variants/vell/overridetree.cb index 7595c6f..4f5da7f 100644 --- a/src/mainboard/google/brya/variants/vell/overridetree.cb +++ b/src/mainboard/google/brya/variants/vell/overridetree.cb @@ -253,13 +253,13 @@ chip drivers/intel/pmc_mux device generic 0 on chip drivers/intel/pmc_mux/conn - register "usb2_port_number" = "1" - register "usb3_port_number" = "1" + use usb2_port1 as usb2_port + use tcss_usb3_port1 as usb3_port device generic 0 alias conn0 on end end chip drivers/intel/pmc_mux/conn - register "usb2_port_number" = "3" - register "usb3_port_number" = "3" + use usb2_port3 as usb2_port + use tcss_usb3_port3 as usb3_port device generic 1 alias conn1 on end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/60326 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie69a143ea2a43a1ee5a3c9f79975e1831e88c4b4 Gerrit-Change-Number: 60326 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya: add variant_gpio_lock_config()
by Nick Vaccaro (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Tim Wawrzynczak, Zhuohao Lee, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Zhuohao Lee, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60274 to look at the new patch set (#10). Change subject: mb/google/brya: add variant_gpio_lock_config() ...................................................................... mb/google/brya: add variant_gpio_lock_config() Add variant_gpio_lock_config() to give variants a way to provide a list of gpios that the variant wants locked, such as gpios connected to the TPM. BUG=b:208827718 TEST='emerge-brya coreboot chromeos-bootimage', flash and boot brya0 to kernel. Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> Change-Id: I3edc309335b2751a85b479250ee0c470ea842c2e --- M src/mainboard/google/brya/variants/baseboard/brya/gpio.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h M src/soc/intel/common/block/include/intelblocks/gpio.h M src/soc/intel/common/block/smm/smihandler.c 4 files changed, 59 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/60274/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/60274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3edc309335b2751a85b479250ee0c470ea842c2e Gerrit-Change-Number: 60274 Gerrit-PatchSet: 10 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: add variant_gpio_lock_config()
by Nick Vaccaro (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Tim Wawrzynczak, Zhuohao Lee, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Zhuohao Lee, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60274 to look at the new patch set (#9). Change subject: mb/google/brya: add variant_gpio_lock_config() ...................................................................... mb/google/brya: add variant_gpio_lock_config() Add variant_gpio_lock_config() to give variants a way to provide a list of gpios that the variant wants locked, such as gpios connected to the TPM. BUG=b:208827718 TEST='emerge-brya coreboot chromeos-bootimage', flash and boot brya0 to kernel. I then added a gpio lock list for brya0 and verified that the code does the right thing in the case of a variant exporting a list of gpios to lock. Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> Change-Id: I3edc309335b2751a85b479250ee0c470ea842c2e --- M src/mainboard/google/brya/variants/baseboard/brya/gpio.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h M src/soc/intel/common/block/include/intelblocks/gpio.h M src/soc/intel/common/block/smm/smihandler.c 4 files changed, 59 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/60274/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/60274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3edc309335b2751a85b479250ee0c470ea842c2e Gerrit-Change-Number: 60274 Gerrit-PatchSet: 9 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: add variant_gpio_lock_config()
by Nick Vaccaro (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Tim Wawrzynczak, Zhuohao Lee, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Zhuohao Lee, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60274 to look at the new patch set (#7). Change subject: mb/google/brya: add variant_gpio_lock_config() ...................................................................... mb/google/brya: add variant_gpio_lock_config() Add variant_gpio_lock_config() to give variants a way to provide a list of gpios that the variant wants locked, such as gpios connected to the TPM. BUG=b:208827718 TEST='emerge-brya coreboot chromeos-bootimage', flash and boot brya0 to kernel. Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> Change-Id: I3edc309335b2751a85b479250ee0c470ea842c2e --- M src/mainboard/google/brya/variants/baseboard/brya/gpio.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h M src/soc/intel/common/block/include/intelblocks/gpio.h M src/soc/intel/common/block/smm/smihandler.c 4 files changed, 59 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/60274/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/60274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3edc309335b2751a85b479250ee0c470ea842c2e Gerrit-Change-Number: 60274 Gerrit-PatchSet: 7 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: add variant_gpio_lock_config()
by Nick Vaccaro (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Tim Wawrzynczak, Zhuohao Lee, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Zhuohao Lee, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60274 to look at the new patch set (#6). Change subject: mb/google/brya: add variant_gpio_lock_config() ...................................................................... mb/google/brya: add variant_gpio_lock_config() Add variant_gpio_lock_config() to give variants a way to provide a list of gpios that the variant wants locked, such as gpios connected to the TPM. BUG=b:208827718 TEST='emerge-brya coreboot chromeos-bootimage', flash and boot brya0 to kernel. Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> Change-Id: I3edc309335b2751a85b479250ee0c470ea842c2e --- M src/mainboard/google/brya/variants/baseboard/brya/gpio.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h M src/soc/intel/common/block/include/intelblocks/gpio.h M src/soc/intel/common/block/smm/smihandler.c 4 files changed, 65 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/60274/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/60274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3edc309335b2751a85b479250ee0c470ea842c2e Gerrit-Change-Number: 60274 Gerrit-PatchSet: 6 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/{skl,cnl}: Guard USB macro parameters
by Felix Singer (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Angel Pons, Michael Niewöhner, Patrick Rudolph. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60324 ) Change subject: soc/intel/{skl,cnl}: Guard USB macro parameters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61fbacc129cbfb42ade7e64ee40cd07c98d87683 Gerrit-Change-Number: 60324 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 16:54:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Add CdClock frequency config
by Subrata Banik (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Nico Huber, Jamie Chen, Henry Sun, Tim Wawrzynczak, Paul Menzel, Ren Kuo, Simon Yang, Kane Chen, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60009 ) Change subject: soc/intel/jasperlake: Add CdClock frequency config ...................................................................... Patch Set 17: (1 comment) File src/soc/intel/jasperlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/60009/comment/73449e90_acd69e82 PS17, Line 212: params->CdClock = config->cd_clock ? config->cd_clock - 1 : 0xff; > Here are the actual values used by/expected by JSL FSP: […] I agree with Tim, we just need to ack here , this is a FSP bug in documenting things and this code just W/A it to make it proper. may be in the code comment and in commit msg as well ? -- To view, visit https://review.coreboot.org/c/coreboot/+/60009 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I917c2f10b130b0cd54f60e2ba98eb971d5ec3c97 Gerrit-Change-Number: 60009 Gerrit-PatchSet: 17 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 16:34:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Implement new CBFS access API
by Jakub Czapiga (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Paul Menzel, Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59497 ) Change subject: libpayload: Implement new CBFS access API ...................................................................... Patch Set 11: (5 comments) File payloads/libpayload/include/cbfs_boot_device.h: PS8: > Will be merged again with cbfs_glue. […] Done File payloads/libpayload/libcbfs/cbfs.c: https://review.coreboot.org/c/coreboot/+/59497/comment/7f64d021_f1147c54 PS3, Line 60: void cbfs_boot_device_find_mcache(struct cbfs_boot_device *cbd, bool is_ro); > I marked it as static. Please take a look at current solution (in tests too). Done File payloads/libpayload/libcbfs/cbfs.c: https://review.coreboot.org/c/coreboot/+/59497/comment/20f99be6_9457dc14 PS8, Line 172: if (!size_inout || *size_inout < out_size) > nit: might want to print an error here too? Done File payloads/libpayload/libcbfs/cbfs.c: https://review.coreboot.org/c/coreboot/+/59497/comment/e0c2027a_af655975 PS10, Line 17: static struct cbfs_boot_device rw; > nit: Don't really see why you moved these out of the function? I mean it works this way, but it work […] I did it to make testing easier. However, I found a way to test it without making it outside of the function, so it is now back inside. File payloads/libpayload/tests/libcbfs/cbfs-lookup-test.c: PS1: > I'm re-writing this test to mock-out all commonlib dependencies and to cover all of the new API. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00da0658dbac0cddf92ad55611def947932d23c7 Gerrit-Change-Number: 59497 Gerrit-PatchSet: 11 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 23 Dec 2021 16:32:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Implement new CBFS access API
by Jakub Czapiga (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: Jakub Czapiga, Paul Menzel. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59497 to look at the new patch set (#11). Change subject: libpayload: Implement new CBFS access API ...................................................................... libpayload: Implement new CBFS access API Change-Id: I00da0658dbac0cddf92ad55611def947932d23c7 Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> --- M payloads/libpayload/Kconfig M payloads/libpayload/Makefile.inc M payloads/libpayload/include/cbfs.h M payloads/libpayload/include/cbfs_core.h A payloads/libpayload/include/cbfs_glue.h A payloads/libpayload/include/cbfs_legacy.h A payloads/libpayload/libcbfs/Kconfig M payloads/libpayload/libcbfs/Makefile.inc M payloads/libpayload/libcbfs/cbfs.c M payloads/libpayload/libcbfs/cbfs_core.c A payloads/libpayload/libcbfs/cbfs_legacy.c M payloads/libpayload/tests/Makefile.inc A payloads/libpayload/tests/include/mocks/cbfs_util.h A payloads/libpayload/tests/libcbfs/Makefile.inc A payloads/libpayload/tests/libcbfs/cbfs-lookup-test.c A payloads/libpayload/tests/libcbfs/cbfs-lookup.test.c A payloads/libpayload/tests/libcbfs/cbfs-verification-test.c A payloads/libpayload/tests/mocks/cbfs_file_mock.c A payloads/libpayload/tests/mocks/die.c 19 files changed, 1,807 insertions(+), 432 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/59497/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/59497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00da0658dbac0cddf92ad55611def947932d23c7 Gerrit-Change-Number: 59497 Gerrit-PatchSet: 11 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Pass the EN_SPKR gpio in devicetree for nipperkin
by Yu-hsuan Hsu (Code Review) 23 Dec '21

23 Dec '21

Attention is currently required from: V sujith kumar Reddy. Yu-hsuan Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60315 ) Change subject: Pass the EN_SPKR gpio in devicetree for nipperkin ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60315 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbf1e2055c30ca595d6b048e4fcf31a9bb805439 Gerrit-Change-Number: 60315 Gerrit-PatchSet: 2 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 23 Dec 2021 16:29:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021