coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/corsola: Add DRAM full calibration support
by Paul Menzel (Code Review) 27 Dec '21

27 Dec '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Ryan Chuang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60386 ) Change subject: mb/google/corsola: Add DRAM full calibration support ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60386/comment/7d5f29f0_7fee6c09 PS3, Line 7: mb/google/corsola: Add DRAM full calibration support Fully calibrate DRAM File src/mainboard/google/corsola/sdram_configs.c: https://review.coreboot.org/c/coreboot/+/60386/comment/6e2d14ee_c4164503 PS3, Line 8: MT8186 platform supports "dram adaptive" feature to : * automatically detect dram information, including channel, rank, die size..., : * and can automatically configure EMI settings Please reference the datasheet name, revision, and section about that feature. Is that done in hardware or in some firmware blob? -- To view, visit https://review.coreboot.org/c/coreboot/+/60386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80a18a8be5b1d47a5f0f7afed9601c0884e69035 Gerrit-Change-Number: 60386 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Mon, 27 Dec 2021 09:05:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cherry: add configuration for dojo
by Kevin Chiu (Code Review) 27 Dec '21

27 Dec '21

Attention is currently required from: Paul Menzel. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60313 ) Change subject: mb/google/cherry: add configuration for dojo ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60313/comment/b4c62b39_65bc9007 PS3, Line 8: > so far no Done https://review.coreboot.org/c/coreboot/+/60313/comment/ab1c7d47_50405e1f PS3, Line 12: Kevin Chiu <kevin.chiu.17802(a)gmail.com> > no, but I can't link to my original account "kevin.chiu(a)quantatw.com". Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60313 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3bd9803b4e47882df9fe351229478e4cb1630363 Gerrit-Change-Number: 60313 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 27 Dec 2021 09:03:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cherry: add configuration for dojo
by Kevin Chiu (Code Review) 27 Dec '21

27 Dec '21

Attention is currently required from: Paul Menzel. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60313 ) Change subject: mb/google/cherry: add configuration for dojo ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60313/comment/648e4565_0d8b7331 PS3, Line 8: > Are GPIO(?) changes going to follow? so far no https://review.coreboot.org/c/coreboot/+/60313/comment/9fc1b1c6_dba4da76 PS3, Line 12: Kevin Chiu <kevin.chiu.17802(a)gmail.com> > Do you do that work privately? no, but I can't link to my original account "kevin.chiu(a)quantatw.com". -- To view, visit https://review.coreboot.org/c/coreboot/+/60313 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3bd9803b4e47882df9fe351229478e4cb1630363 Gerrit-Change-Number: 60313 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 27 Dec 2021 09:02:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/corsola: Add DRAM full calibration support
by Paul Menzel (Code Review) 27 Dec '21

27 Dec '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Ryan Chuang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60386 ) Change subject: mb/google/corsola: Add DRAM full calibration support ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60386/comment/8ee4928a_6e6aa130 PS3, Line 9: Initialize and calibrate DRAM in romstage. Did the board boot before? https://review.coreboot.org/c/coreboot/+/60386/comment/f6ae7e1a_bf52fd67 PS3, Line 11: TEST=DRAM full calibration pass. Maybe paste some log messages. -- To view, visit https://review.coreboot.org/c/coreboot/+/60386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80a18a8be5b1d47a5f0f7afed9601c0884e69035 Gerrit-Change-Number: 60386 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Mon, 27 Dec 2021 09:02:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Add DRAM full calibration support
by Paul Menzel (Code Review) 27 Dec '21

27 Dec '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Ryan Chuang, Yu-Ping Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60318 ) Change subject: soc/mediatek/mt8186: Add DRAM full calibration support ...................................................................... Patch Set 11: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60318/comment/88560acb_8eec67e6 PS11, Line 9: Add drivers to support DRAM calibration in the soc folder. Maybe: > Use common SOC drivers for DRAM calibration support. -- To view, visit https://review.coreboot.org/c/coreboot/+/60318 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1a1e04da0cce9aaf86588a94c64d2242e7cb4b7 Gerrit-Change-Number: 60318 Gerrit-PatchSet: 11 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 27 Dec 2021 09:01:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/corsola: Initialize kingler display
by Rex-BC Chen (Code Review) 27 Dec '21

27 Dec '21

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60398 ) Change subject: mb/google/corsola: Initialize kingler display ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/corsola/display.c: https://review.coreboot.org/c/coreboot/+/60398/comment/05a69fff_e76e4043 PS1, Line 110: (void) > no need to add this (void) ? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8de5d8ba150d3ae086c7635601dbc0846aebe91 Gerrit-Change-Number: 60398 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 27 Dec 2021 09:01:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/corsola: Initialize kingler display
by Rex-BC Chen (Code Review) 27 Dec '21

27 Dec '21

Attention is currently required from: Rex-BC Chen, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60398 to look at the new patch set (#2). Change subject: mb/google/corsola: Initialize kingler display ...................................................................... mb/google/corsola: Initialize kingler display ANX7625 is used on Kingler board as the eDP bridge IC. Enable ANX7625 and configure display in mainboard_init() to support display in firmware screen. BUG=b:209930699 TEST=see fw display on kingler panel Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: Ie8de5d8ba150d3ae086c7635601dbc0846aebe91 --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/Makefile.inc A src/mainboard/google/corsola/display.c A src/mainboard/google/corsola/display.h M src/mainboard/google/corsola/gpio.h M src/mainboard/google/corsola/mainboard.c 6 files changed, 145 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/60398/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8de5d8ba150d3ae086c7635601dbc0846aebe91 Gerrit-Change-Number: 60398 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/cherry: add configuration for dojo
by Paul Menzel (Code Review) 27 Dec '21

27 Dec '21

Attention is currently required from: Kevin Chiu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60313 ) Change subject: mb/google/cherry: add configuration for dojo ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60313/comment/aae1a61d_0197c204 PS3, Line 8: Are GPIO(?) changes going to follow? https://review.coreboot.org/c/coreboot/+/60313/comment/68a0f14d_cc51eae1 PS3, Line 12: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Do you do that work privately? -- To view, visit https://review.coreboot.org/c/coreboot/+/60313 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3bd9803b4e47882df9fe351229478e4cb1630363 Gerrit-Change-Number: 60313 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Comment-Date: Mon, 27 Dec 2021 09:00:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Adjust usage of SRAM L2C
by Rex-BC Chen (Code Review) 27 Dec '21

27 Dec '21

Attention is currently required from: Hung-Te Lin, Paul Menzel. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60316 ) Change subject: soc/mediatek/mt8186: Adjust usage of SRAM L2C ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60316/comment/22259cd2_f305c131 PS4, Line 9: However the BootROM : has configured only half of L2/L3 cache as SRAM. > "unchangeable" does not mean it's not a bug - it can still be a silicon bug. […] After discussing with internal MTKers. We think this is not a correct solution to reduce the size of cache. There could be some impact for speed of running fw. Maybe it just a method for debugging. -- To view, visit https://review.coreboot.org/c/coreboot/+/60316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6041767a1ac0a48ecdda29a0c35d90acf6ad0ef2 Gerrit-Change-Number: 60316 Gerrit-PatchSet: 5 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 27 Dec 2021 08:59:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Move some definations of devapc to common folder
by build bot (Jenkins) (Code Review) 27 Dec '21

27 Dec '21

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60394 ) Change subject: soc/mediatek/mt8195: Move some definations of devapc to common folder ...................................................................... Patch Set 1: (18 comments) File src/soc/mediatek/common/include/soc/devapc_common.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/b16a3bf1_51a1040f PS1, Line 6: #define DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/df7ffbb3_3121fab6 PS1, Line 11: #define DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/193407c5_65e01799 PS1, Line 19: #define DAPC_PERM_ATTR_16(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/ebddd3ac_09be582c PS1, Line 33: #define FORBIDDEN2 FORBIDDEN, FORBIDDEN Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/17fdaf62_5b93938c PS1, Line 34: #define FORBIDDEN3 FORBIDDEN2, FORBIDDEN Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/fa37f058_38ec267d PS1, Line 35: #define FORBIDDEN4 FORBIDDEN3, FORBIDDEN Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/d783b661_24af1ba4 PS1, Line 36: #define FORBIDDEN5 FORBIDDEN4, FORBIDDEN Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/5a9c9f8f_f55db267 PS1, Line 37: #define FORBIDDEN6 FORBIDDEN5, FORBIDDEN Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/592772c7_f032ea72 PS1, Line 38: #define FORBIDDEN7 FORBIDDEN6, FORBIDDEN Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/0ec06552_7df71e11 PS1, Line 39: #define FORBIDDEN10 FORBIDDEN3, FORBIDDEN7 Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/e7ad2d74_2a12f761 PS1, Line 40: #define FORBIDDEN11 FORBIDDEN10, FORBIDDEN Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/b7f0da13_8aa9c236 PS1, Line 41: #define FORBIDDEN12 FORBIDDEN11, FORBIDDEN Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/f35364fd_010a52c8 PS1, Line 42: #define FORBIDDEN13 FORBIDDEN12, FORBIDDEN Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/a8cff800_a5f6fa92 PS1, Line 43: #define FORBIDDEN14 FORBIDDEN13, FORBIDDEN Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/f4cb26a9_cdaee86a PS1, Line 44: #define FORBIDDEN15 FORBIDDEN14, FORBIDDEN Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/cead5147_9f01a827 PS1, Line 46: #define NO_PROTECTION2 NO_PROTECTION, NO_PROTECTION Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/d30643ca_035b5ce2 PS1, Line 47: #define NO_PROTECTION3 NO_PROTECTION2, NO_PROTECTION Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/a7226c72_0318f9ba PS1, Line 48: #define NO_PROTECTION4 NO_PROTECTION3, NO_PROTECTION Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/c/coreboot/+/60394 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1769ede790f106a320ead9be7e2a596fe96930a Gerrit-Change-Number: 60394 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 27 Dec 2021 08:54:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021