Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60386 )
Change subject: mb/google/corsola: Fully calibrate DRAM
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60386/comment/fe77e6d1_856991c2
PS3, Line 9: Initialize and calibrate DRAM in romstage.
> what do you mean?
Without full calibration (basic(?)), did the board boot?
Commit Message:
https://review.coreboot.org/c/coreboot/+/60386/comment/3e71792d_ec512eb0
PS4, Line 13: 20014 msecs
That’s 20 seconds, wow!
Maybe also post a log with already warm MRC cache.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60386
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80a18a8be5b1d47a5f0f7afed9601c0884e69035
Gerrit-Change-Number: 60386
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Comment-Date: Mon, 27 Dec 2021 13:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60396 )
Change subject: soc/mediatek/mt8186: Add DDP driver
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60396/comment/1935b4c0_1525836c
PS3, Line 11:
Is there a Linux kernel driver, and are they quite similar?
File src/soc/mediatek/mt8186/ddp.c:
https://review.coreboot.org/c/coreboot/+/60396/comment/14f45e12_03251b08
PS3, Line 13: * POSTMASK0->DITHER->DSI0
Fits on the line above?
https://review.coreboot.org/c/coreboot/+/60396/comment/cf9157f1_51f868e3
PS3, Line 136: /* Turn off M4U port. */
Remove dot/period at the end?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60396
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4fb40832b5dc7a815b37266259b2e3281ee79f1
Gerrit-Change-Number: 60396
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 27 Dec 2021 13:12:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chang, Tim Wawrzynczak, YH Lin.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60330 )
Change subject: mb/google/brya/var/taeko: swap TPM i2c with TS i2c for the next build
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60330/comment/ab065244_755fa20f
PS2, Line 9: Taeko will
1. Do the schematics have revisions?
2. s/will/is going to/
--
To view, visit https://review.coreboot.org/c/coreboot/+/60330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7273ba107c58e4cd90db00e301a399d7a7df76d
Gerrit-Change-Number: 60330
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Mon, 27 Dec 2021 13:07:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, YH Lin.
Kevin Chang has removed Joey Peng from this change. ( https://review.coreboot.org/c/coreboot/+/60400 )
Change subject: mb/google/taeko: Modify DPTF setting for taeko
......................................................................
Removed cc Joey Peng.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60400
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d5c9b6dff87a2e8897d74f3be89c965db22fe16
Gerrit-Change-Number: 60400
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Paul Menzel, Rob Barnes, Karthik Ramasubramanian.
Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60328 )
Change subject: mb/google/guybrush/var/dewatt: disable unused PCIe clock setting
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60328/comment/f15be6b1_8496aec0
PS1, Line 9: Disable unused PCIe GPP_CLK1 and GPP_CLK2 for dewatt.
> Just for correctness, or does this fix some problem? The source is the schematics?
For correctness, unused with dewatt chematics.
Patchset:
PS1:
> GPP_CLK1 is for SD and GPP_CLK2 is for WWAN on guybrush right? Can you add this to the commit messag […]
Yes. Done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60328
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If449453bc60ed41e104346429babc06a73acef64
Gerrit-Change-Number: 60328
Gerrit-PatchSet: 2
Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 27 Dec 2021 11:03:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com>
Gerrit-MessageType: comment