coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Andrey Petrov, Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60504 ) Change subject: soc/intel/apollolake/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/apollolake/acpi: Replace Add(a,b) with ASL 2.0 syntax Replace `Add (a, b)` with `a + b`. Change-Id: Id465558f054494d3273d5cd6077476d878d7c183 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/apollolake/acpi/gpiolib.asl M src/soc/intel/apollolake/acpi/northbridge.asl 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/60504/1 diff --git a/src/soc/intel/apollolake/acpi/gpiolib.asl b/src/soc/intel/apollolake/acpi/gpiolib.asl index e01d549..c579d14 100644 --- a/src/soc/intel/apollolake/acpi/gpiolib.asl +++ b/src/soc/intel/apollolake/acpi/gpiolib.asl @@ -31,7 +31,7 @@ Method (GPC1, 0x1, Serialized) { /* Arg0 - GPIO DW0 address */ - Store (Add (Arg0, 0x4), Local0) + Store (Arg0 + 4, Local0) OperationRegion (PDW1, SystemMemory, Local0, 4) Field (PDW1, AnyAcc, NoLock, Preserve) { TEMP, 32 @@ -44,7 +44,7 @@ { /* Arg0 - GPIO DW0 address */ /* Arg1 - Value for DW1 register */ - Store (Add (Arg0, 0x4), Local0) + Store (Arg0 + 0x4, Local0) OperationRegion (PDW1, SystemMemory, Local0, 4) Field(PDW1, AnyAcc, NoLock, Preserve) { TEMP,32 @@ -60,8 +60,8 @@ Store (0, Local1) Or( Or (ShiftLeft (Arg0, 16), CONFIG_PCR_BASE_ADDRESS), Local1, Local1) - Or( Add (PAD_CFG_BASE, Multiply (Arg1, Multiply ( - GPIO_NUM_PAD_CFG_REGS, 4))), Local1, Local1) + Or(PAD_CFG_BASE + Multiply (Arg1, Multiply ( + GPIO_NUM_PAD_CFG_REGS, 4)), Local1, Local1) Return (Local1) } diff --git a/src/soc/intel/apollolake/acpi/northbridge.asl b/src/soc/intel/apollolake/acpi/northbridge.asl index 4f2acbb..ea9d5b4 100644 --- a/src/soc/intel/apollolake/acpi/northbridge.asl +++ b/src/soc/intel/apollolake/acpi/northbridge.asl @@ -109,7 +109,7 @@ /* Set 64bit MMIO resource base and length */ Store (A4GS, MLEN) Store (A4GB, MMIN) - MMAX = Add (MMIN, MLEN) - 1 + MMAX = MMIN + MLEN - 1 } Return (MCRS) -- To view, visit https://review.coreboot.org/c/coreboot/+/60504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id465558f054494d3273d5cd6077476d878d7c183 Gerrit-Change-Number: 60504 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/cannonlake/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60503 ) Change subject: soc/intel/cannonlake/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/cannonlake/acpi: Replace Add(a,b) with ASL 2.0 syntax Replace `Add (a, b)` with `a + b`. Change-Id: I90dc0ecb1e3f16874a72cdf01afb097d4e7b6076 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/cannonlake/acpi/gpio.asl M src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl M src/soc/intel/cannonlake/acpi/xhci.asl 3 files changed, 3 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/60503/1 diff --git a/src/soc/intel/cannonlake/acpi/gpio.asl b/src/soc/intel/cannonlake/acpi/gpio.asl index fb122ad..5461c38 100644 --- a/src/soc/intel/cannonlake/acpi/gpio.asl +++ b/src/soc/intel/cannonlake/acpi/gpio.asl @@ -92,7 +92,7 @@ } Store (PCRB (Local0), Local2) Local2 = Local2 + PAD_CFG_BASE - Return (Add (Local2, Multiply (Local1, 16))) + Return (Local2 + Multiply (Local1, 16)) } /* diff --git a/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl b/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl index 5c14317..705c216 100644 --- a/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl +++ b/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl @@ -92,5 +92,5 @@ } Store (PCRB (Local0), Local2) Local2 = Local2 + PAD_CFG_BASE - Return (Add (Local2, Multiply (Local1, 16))) + Return (Local2 + Multiply (Local1, 16)) } diff --git a/src/soc/intel/cannonlake/acpi/xhci.asl b/src/soc/intel/cannonlake/acpi/xhci.asl index 50c0cb8..614268c 100644 --- a/src/soc/intel/cannonlake/acpi/xhci.asl +++ b/src/soc/intel/cannonlake/acpi/xhci.asl @@ -19,8 +19,7 @@ Local0 = Arg1 + ((Arg0 - 1) * 0x10) /* Map ((XMEM << 16) + Local0 in PSCR */ - OperationRegion (PSCR, SystemMemory, - Add (ShiftLeft (Arg2, 16), Local0), 0x10) + OperationRegion (PSCR, SystemMemory, ShiftLeft (Arg2, 16) + Local0, 0x10) Field (PSCR, DWordAcc, NoLock, Preserve) { PSCT, 32, -- To view, visit https://review.coreboot.org/c/coreboot/+/60503 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90dc0ecb1e3f16874a72cdf01afb097d4e7b6076 Gerrit-Change-Number: 60503 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/skylake/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60502 ) Change subject: soc/intel/skylake/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/skylake/acpi: Replace Add(a,b) with ASL 2.0 syntax Replace `Add (a, b)` with `a + b`. Change-Id: Id35c24663f529238fe17721b99ad8e93a4f5433f Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/skylake/acpi/xhci.asl 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/60502/1 diff --git a/src/soc/intel/skylake/acpi/xhci.asl b/src/soc/intel/skylake/acpi/xhci.asl index 196af97..da5c10b 100644 --- a/src/soc/intel/skylake/acpi/xhci.asl +++ b/src/soc/intel/skylake/acpi/xhci.asl @@ -17,8 +17,7 @@ Local0 = Arg1 + ((Arg0 - 1) * 0x10) /* Map ((XMEM << 16) + Local0 in PSCR */ - OperationRegion (PSCR, SystemMemory, - Add (ShiftLeft (Arg2, 16), Local0), 0x10) + OperationRegion (PSCR, SystemMemory, ShiftLeft (Arg2, 16) + Local0, 0x10) Field (PSCR, DWordAcc, NoLock, Preserve) { PSCT, 32, @@ -101,8 +100,7 @@ D3HE, 1, /* D3_hot_en */ } - OperationRegion (XREG, SystemMemory, - Add (ShiftLeft (XMEM, 16), 0x8000), 0x200) + OperationRegion (XREG, SystemMemory, ShiftLeft (XMEM, 16) + 0x8000, 0x200) Field (XREG, DWordAcc, Lock, Preserve) { Offset (0x1c4), /* USB2PMCTRL */ -- To view, visit https://review.coreboot.org/c/coreboot/+/60502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id35c24663f529238fe17721b99ad8e93a4f5433f Gerrit-Change-Number: 60502 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/cbfstool: Port elogtool to libflashrom
by Edward O'Callaghan (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Jack Rosenthal, Nikolai Artemiev. Hello build bot (Jenkins), Jack Rosenthal, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59714 to look at the new patch set (#5). Change subject: util/cbfstool: Port elogtool to libflashrom ...................................................................... util/cbfstool: Port elogtool to libflashrom This also uncouples cbfstool from being overly Chromium specific. However the main objective is to not subprocess flashrom any more and instead use the programmatic API. BUG=b:207808292 TEST=built and ran `elogtool list`. Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M util/cbfstool/Makefile.inc M util/cbfstool/elogtool.c A util/cbfstool/uflashrom.c A util/cbfstool/uflashrom.h 4 files changed, 175 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/59714/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/59714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231 Gerrit-Change-Number: 59714 Gerrit-PatchSet: 5 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sam McNally <sammc(a)google.com> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/smsc/mec1308/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60501 ) Change subject: ec/smsc/mec1308/acpi: Replace Subtract(a,b) with ASL 2.0 syntax ...................................................................... ec/smsc/mec1308/acpi: Replace Subtract(a,b) with ASL 2.0 syntax Replace `Subtract (a, b)` with `a - b`. Change-Id: Ia736b0080848e029eaeae094f1d2cc12aace3730 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/smsc/mec1308/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/60501/1 diff --git a/src/ec/smsc/mec1308/acpi/battery.asl b/src/ec/smsc/mec1308/acpi/battery.asl index bbbcfe2..603b1d4 100644 --- a/src/ec/smsc/mec1308/acpi/battery.asl +++ b/src/ec/smsc/mec1308/acpi/battery.asl @@ -157,7 +157,7 @@ // See if within ~3% of full ShiftRight (Local2, 5, Local3) - If (LGreater (Local1, Subtract (Local2, Local3)) && + If (LGreater (Local1, Local2 - Local3) && LLess (Local1, Add (Local2, Local3))) { Store (Local2, Local1) -- To view, visit https://review.coreboot.org/c/coreboot/+/60501 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia736b0080848e029eaeae094f1d2cc12aace3730 Gerrit-Change-Number: 60501 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60500 ) Change subject: ec/quanta/it8518/acpi: Replace Subtract(a,b) with ASL 2.0 syntax ...................................................................... ec/quanta/it8518/acpi: Replace Subtract(a,b) with ASL 2.0 syntax Replace `Subtract (a, b)` with `a - b`. Change-Id: Ibdc3faa5c888b1bd0e5234ed8185dcf29b2f1d4d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/quanta/it8518/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/60500/1 diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index 9294733..0015021 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -317,7 +317,7 @@ // See if within ~3% of full ShiftRight (Local2, 5, Local3) - If (LGreater (Local1, Subtract (Local2, Local3)) && LLess (Local1, Add (Local2, Local3))) + If (LGreater (Local1, Local2 - Local3) && LLess (Local1, Add (Local2, Local3))) { Store (Local2, Local1) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdc3faa5c888b1bd0e5234ed8185dcf29b2f1d4d Gerrit-Change-Number: 60500 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Alexander Couzens. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60499 ) Change subject: ec/lenovo/h8/acpi: Replace Subtract(a,b) with ASL 2.0 syntax ...................................................................... ec/lenovo/h8/acpi: Replace Subtract(a,b) with ASL 2.0 syntax Replace `Subtract (a, b)` with `a - b`. Change-Id: Id8fec71cc174008f48fc0a80c36942e6941982ac Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/lenovo/h8/acpi/thinkpad.asl 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/60499/1 diff --git a/src/ec/lenovo/h8/acpi/thinkpad.asl b/src/ec/lenovo/h8/acpi/thinkpad.asl index 40d6e14..5532dac 100644 --- a/src/ec/lenovo/h8/acpi/thinkpad.asl +++ b/src/ec/lenovo/h8/acpi/thinkpad.asl @@ -51,7 +51,7 @@ /* Report event */ Method (RHK, 1, NotSerialized) { - ShiftLeft (One, Subtract (Arg0, 1), Local0) + ShiftLeft (One, Arg0 - 1, Local0) If (And (EMSK, Local0)) { Store (Arg0, BTN) Notify (HKEY, 0x80) @@ -60,7 +60,7 @@ /* Report tablet */ Method (RTAB, 1, NotSerialized) { - ShiftLeft (One, Subtract (Arg0, 1), Local0) + ShiftLeft (One, Arg0 - 1, Local0) If (And (ETAB, Local0)) { Store (Arg0, BTAB) Notify (HKEY, 0x80) @@ -84,7 +84,7 @@ /* Enable/disable event. */ Method (MHKM, 2, NotSerialized) { If (LLessEqual (Arg0, 0x20)) { - ShiftLeft (One, Subtract (Arg0, 1), Local0) + ShiftLeft (One, Arg0 - 1, Local0) If (Arg1) { Or (DHKN, Local0, DHKN) -- To view, visit https://review.coreboot.org/c/coreboot/+/60499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8fec71cc174008f48fc0a80c36942e6941982ac Gerrit-Change-Number: 60499 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60498 ) Change subject: ec/google/chromeec/acpi: Replace Subtract(a,b) with ASL 2.0 syntax ...................................................................... ec/google/chromeec/acpi: Replace Subtract(a,b) with ASL 2.0 syntax Replace `Subtract (a, b)` with `a - b`. Change-Id: Ib47fdb28c2047e001902345ad2f1b25fe5d8a152 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/google/chromeec/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/60498/1 diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl index 7569728..0672885 100644 --- a/src/ec/google/chromeec/acpi/battery.asl +++ b/src/ec/google/chromeec/acpi/battery.asl @@ -210,7 +210,7 @@ // See if within ~6% of full ShiftRight (Local2, 4, Local3) - If (LGreater (Local1, Subtract (Local2, Local3)) && LLess (Local1, Add (Local2, Local3))) + If (LGreater (Local1, Local2 - Local3) && LLess (Local1, Add (Local2, Local3))) { Store (Local2, Local1) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib47fdb28c2047e001902345ad2f1b25fe5d8a152 Gerrit-Change-Number: 60498 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/gma/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Patrick Rudolph. Hello Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60497 to look at the new patch set (#2). Change subject: drivers/intel/gma/acpi: Replace Subtract(a,b) with ASL 2.0 syntax ...................................................................... drivers/intel/gma/acpi: Replace Subtract(a,b) with ASL 2.0 syntax Replace `Subtract (a, b)` with `a - b`. Change-Id: I4f6ffd6bbf6a37e041879e50fe41ce3cc856371f Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/drivers/intel/gma/acpi/common.asl M src/drivers/intel/gma/acpi/configure_brightness_levels.asl 2 files changed, 4 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/60497/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f6ffd6bbf6a37e041879e50fe41ce3cc856371f Gerrit-Change-Number: 60497 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/gma/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60497 ) Change subject: drivers/intel/gma/acpi: Replace Subtract(a,b) with ASL 2.0 syntax ...................................................................... drivers/intel/gma/acpi: Replace Subtract(a,b) with ASL 2.0 syntax Replace `Subtract (a, b)` with `a - b`. Change-Id: I4f6ffd6bbf6a37e041879e50fe41ce3cc856371f Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/drivers/intel/gma/acpi/common.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/60497/1 diff --git a/src/drivers/intel/gma/acpi/common.asl b/src/drivers/intel/gma/acpi/common.asl index 254a66d..02169ae 100644 --- a/src/drivers/intel/gma/acpi/common.asl +++ b/src/drivers/intel/gma/acpi/common.asl @@ -9,7 +9,7 @@ Store (Match (BRIG, MEQ, Arg0, MTR, Zero, 2), Local0) If (LEqual (Local0, Ones)) { - Return (Subtract(SizeOf(BRIG), One)) + Return (SizeOf(BRIG) - 1) } Return (Local0) } @@ -56,7 +56,7 @@ Notify (LCD0, 0x86) } Else { Store (BRID (XBQC ()), Local0) - If (LNotEqual (Local0, Subtract(SizeOf(BRIG), One))) + If (LNotEqual (Local0, SizeOf(BRIG) - 1)) { Increment (Local0) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f6ffd6bbf6a37e041879e50fe41ce3cc856371f Gerrit-Change-Number: 60497 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021