Attention is currently required from: Selma Bensaid, Tim Wawrzynczak, Julius Werner.
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59555 )
Change subject: util/cbmem: Rebase to handle negative timestamps
......................................................................
Patch Set 5:
(1 comment)
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/59555/comment/c67b8eff_e7c1966d
PS2, Line 665: /*
> No, I don't think you should need all this. […]
Thanks Julius for the explanation. It worked like you said, but I had to change it to prev_stamp = 0 instead of prev_stamp = sorted_tst_p->base_time;
3001 is a place holder for "CSME started executing"
3001:<unknown> 0
944:CSE sent 'Boot Stall Done' to PMC 296,000
945:CSE started to handle ICC configuration 303,000 (7,000)
946:CSE sent 'Host BIOS Prep Done' to PMC 308,000 (5,000)
947:CSE received 'CPU Reset Done Ack sent' from PMC 1,074,000 (766,000)
0:1st timestamp 1,162,757 (88,757)
11:start of bootblock 1,190,331 (27,573)
--
To view, visit https://review.coreboot.org/c/coreboot/+/59555
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7eb519c360e066d48dde205401e4ccd3b0b3d8a5
Gerrit-Change-Number: 59555
Gerrit-PatchSet: 5
Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 30 Dec 2021 00:31:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak.
Hello build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59555
to look at the new patch set (#5).
Change subject: util/cbmem: Rebase to handle negative timestamps
......................................................................
util/cbmem: Rebase to handle negative timestamps
Rebase all of the timestamps to the lowest(negative) value in the list
when displaying them.
TEST=Boot to OS after adding negative timestamps, cbmem -t
Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com>
Change-Id: I7eb519c360e066d48dde205401e4ccd3b0b3d8a5
---
M util/cbmem/cbmem.c
1 file changed, 13 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/59555/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/59555
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7eb519c360e066d48dde205401e4ccd3b0b3d8a5
Gerrit-Change-Number: 59555
Gerrit-PatchSet: 5
Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset