coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: sb/intel/i82801ix/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60514 ) Change subject: sb/intel/i82801ix/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... sb/intel/i82801ix/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: I09a37ff47002640c7bbc151028b4d4576f9fbfac Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/southbridge/intel/i82801ix/acpi/lpc.asl 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/60514/1 diff --git a/src/southbridge/intel/i82801ix/acpi/lpc.asl b/src/southbridge/intel/i82801ix/acpi/lpc.asl index f90386d..b97b010 100644 --- a/src/southbridge/intel/i82801ix/acpi/lpc.asl +++ b/src/southbridge/intel/i82801ix/acpi/lpc.asl @@ -73,15 +73,15 @@ If (HPTE) { CreateDWordField(BUF0, \_SB.PCI0.LPCB.HPET.FED0._BAS, HPT0) If (Lequal(HPAS, 1)) { - Add(CONFIG_HPET_ADDRESS, 0x1000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x1000 } If (Lequal(HPAS, 2)) { - Add(CONFIG_HPET_ADDRESS, 0x2000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x2000 } If (Lequal(HPAS, 3)) { - Add(CONFIG_HPET_ADDRESS, 0x3000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x3000 } } -- To view, visit https://review.coreboot.org/c/coreboot/+/60514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09a37ff47002640c7bbc151028b4d4576f9fbfac Gerrit-Change-Number: 60514 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: sb/intel/i82801jx/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60513 ) Change subject: sb/intel/i82801jx/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... sb/intel/i82801jx/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: I738a521a12363e0b6123e3d4e22721fb459925d1 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/southbridge/intel/i82801jx/acpi/lpc.asl 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/60513/1 diff --git a/src/southbridge/intel/i82801jx/acpi/lpc.asl b/src/southbridge/intel/i82801jx/acpi/lpc.asl index f90386d..b97b010 100644 --- a/src/southbridge/intel/i82801jx/acpi/lpc.asl +++ b/src/southbridge/intel/i82801jx/acpi/lpc.asl @@ -73,15 +73,15 @@ If (HPTE) { CreateDWordField(BUF0, \_SB.PCI0.LPCB.HPET.FED0._BAS, HPT0) If (Lequal(HPAS, 1)) { - Add(CONFIG_HPET_ADDRESS, 0x1000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x1000 } If (Lequal(HPAS, 2)) { - Add(CONFIG_HPET_ADDRESS, 0x2000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x2000 } If (Lequal(HPAS, 3)) { - Add(CONFIG_HPET_ADDRESS, 0x3000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x3000 } } -- To view, visit https://review.coreboot.org/c/coreboot/+/60513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I738a521a12363e0b6123e3d4e22721fb459925d1 Gerrit-Change-Number: 60513 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: sb/intel/bd82x6x/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60512 ) Change subject: sb/intel/bd82x6x/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... sb/intel/bd82x6x/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: I17ab35629b5545052c214e3cb2d57788b6a5b7ad Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/southbridge/intel/bd82x6x/acpi/lpc.asl 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/60512/1 diff --git a/src/southbridge/intel/bd82x6x/acpi/lpc.asl b/src/southbridge/intel/bd82x6x/acpi/lpc.asl index 9df8ac6..2e86157 100644 --- a/src/southbridge/intel/bd82x6x/acpi/lpc.asl +++ b/src/southbridge/intel/bd82x6x/acpi/lpc.asl @@ -91,15 +91,15 @@ If (HPTE) { CreateDWordField(BUF0, \_SB.PCI0.LPCB.HPET.FED0._BAS, HPT0) If (Lequal(HPAS, 1)) { - Add(CONFIG_HPET_ADDRESS, 0x1000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x1000 } If (Lequal(HPAS, 2)) { - Add(CONFIG_HPET_ADDRESS, 0x2000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x2000 } If (Lequal(HPAS, 3)) { - Add(CONFIG_HPET_ADDRESS, 0x3000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x3000 } } -- To view, visit https://review.coreboot.org/c/coreboot/+/60512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17ab35629b5545052c214e3cb2d57788b6a5b7ad Gerrit-Change-Number: 60512 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60511 ) Change subject: ec/quanta/it8518/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... ec/quanta/it8518/acpi: Replace Add(a,b) with ASL 2.0 syntax Replace `Add (a, b)` with `a + b`. Change-Id: Ib00f671d448aa1987542dd1ec81410df65695708 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/quanta/it8518/acpi/ec.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/60511/1 diff --git a/src/ec/quanta/it8518/acpi/ec.asl b/src/ec/quanta/it8518/acpi/ec.asl index 36f966f..ea6f730 100644 --- a/src/ec/quanta/it8518/acpi/ec.asl +++ b/src/ec/quanta/it8518/acpi/ec.asl @@ -10,7 +10,7 @@ { Name (_HID, EISAID ("PNP0C09")) Name (_UID, 1) - Name (_GPE, Add(EC_SCI_GPI, 16)) // GPE for Runtime SCI + Name (_GPE, EC_SCI_GPI + 16) // GPE for Runtime SCI // EC RAM fields OperationRegion(ERAM, EmbeddedControl, 0, 0xFF) -- To view, visit https://review.coreboot.org/c/coreboot/+/60511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib00f671d448aa1987542dd1ec81410df65695708 Gerrit-Change-Number: 60511 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/quanta/ene_kb3940q/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60510 ) Change subject: ec/quanta/ene_kb3940q/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... ec/quanta/ene_kb3940q/acpi: Replace Add(a,b) with ASL 2.0 syntax Replace `Add (a, b)` with `a + b`. Change-Id: I2b93cf20a96f85e1a5e130bebdd72fbb86acc266 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/quanta/ene_kb3940q/acpi/ec.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/60510/1 diff --git a/src/ec/quanta/ene_kb3940q/acpi/ec.asl b/src/ec/quanta/ene_kb3940q/acpi/ec.asl index bc84bf1..6d22f9a 100644 --- a/src/ec/quanta/ene_kb3940q/acpi/ec.asl +++ b/src/ec/quanta/ene_kb3940q/acpi/ec.asl @@ -12,7 +12,7 @@ { Name (_HID, EISAID ("PNP0C09")) Name (_UID, 1) - Name (_GPE, Add(EC_SCI_GPI, 16)) // GPE for Runtime SCI + Name (_GPE, EC_SCI_GPI + 16) // GPE for Runtime SCI OperationRegion (ERAM, EmbeddedControl, 0x00, 0xff) Field (ERAM, ByteAcc, Lock, Preserve) -- To view, visit https://review.coreboot.org/c/coreboot/+/60510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b93cf20a96f85e1a5e130bebdd72fbb86acc266 Gerrit-Change-Number: 60510 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/gma/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60509 ) Change subject: drivers/intel/gma/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... drivers/intel/gma/acpi: Replace Add(a,b) with ASL 2.0 syntax Replace `Add (a, b)` with `a + b`. Change-Id: I9d9f1d04f39ffd420655d9297b01b8811339ad08 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/drivers/intel/gma/acpi/configure_brightness_levels.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/60509/1 diff --git a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl index 3581f4d..c168d63 100644 --- a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl +++ b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl @@ -100,7 +100,7 @@ /* Divide round closest */ Method (DRCL, 2) { - Return (Divide (Add (Arg0, Divide (Arg1, 2)), Arg1)) + Return (Divide (Arg0 + Divide (Arg1, 2), Arg1)) } Method (XBCM, 1, NotSerialized) @@ -124,7 +124,7 @@ While (LLess (Local1, SizeOf (BRIG) - 1)) { /* Local[23]: adjacent values in BRIG */ Store (DeRefOf (BRIG[Local1]), Local2) - Store (DeRefOf (BRIG[Add (Local1, 1)]), Local3) + Store (DeRefOf (BRIG[Local1 + 1]), Local3) If (LLess (Local0, Local3)) { If (LOr (LLess (Local0, Local2), LLess (Local0 - Local2, Local3 - Local0))) { -- To view, visit https://review.coreboot.org/c/coreboot/+/60509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d9f1d04f39ffd420655d9297b01b8811339ad08 Gerrit-Change-Number: 60509 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Tim Wawrzynczak. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60508 ) Change subject: ec/google/chromeec/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... ec/google/chromeec/acpi: Replace Add(a,b) with ASL 2.0 syntax Replace `Add (a, b)` with `a + b`. Change-Id: I7a0f9685130cdb124cf5e3ee517328e949a023e3 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/google/chromeec/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/60508/1 diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl index 0672885..663cc25 100644 --- a/src/ec/google/chromeec/acpi/battery.asl +++ b/src/ec/google/chromeec/acpi/battery.asl @@ -210,7 +210,7 @@ // See if within ~6% of full ShiftRight (Local2, 4, Local3) - If (LGreater (Local1, Local2 - Local3) && LLess (Local1, Add (Local2, Local3))) + If (LGreater (Local1, Local2 - Local3) && LLess (Local1, Local2 + Local3)) { Store (Local2, Local1) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60508 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a0f9685130cdb124cf5e3ee517328e949a023e3 Gerrit-Change-Number: 60508 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/kontron/it8516e/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60507 ) Change subject: ec/kontron/it8516e/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... ec/kontron/it8516e/acpi: Replace Add(a,b) with ASL 2.0 syntax Replace `Add (a, b)` with `a + b`. Change-Id: Ie1c21437a0d97ff1039775adcb915547fac71bf5 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/kontron/it8516e/acpi/pm_channels.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/60507/1 diff --git a/src/ec/kontron/it8516e/acpi/pm_channels.asl b/src/ec/kontron/it8516e/acpi/pm_channels.asl index ebfd872..9217406 100644 --- a/src/ec/kontron/it8516e/acpi/pm_channels.asl +++ b/src/ec/kontron/it8516e/acpi/pm_channels.asl @@ -36,7 +36,7 @@ Return (0) } Multiply (Local0, 10, Local0) /* Convert to 10th °C */ - Return (Add (Local0, 2732)) /* Return as 10th Kelvin */ + Return (Local0 + 2732) /* Return as 10th Kelvin */ } } #endif @@ -92,7 +92,7 @@ Or (ShiftLeft (Local1, 8), Local0, Local0) Store (Divide (Multiply (Local0, 10), 64), Local0) /* Convert to 10th °C */ - Return (Add (Local0, 2732)) /* Return as 10th Kelvin */ + Return (Local0 + 2732) /* Return as 10th Kelvin */ } } #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/60507 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1c21437a0d97ff1039775adcb915547fac71bf5 Gerrit-Change-Number: 60507 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60506 ) Change subject: ec/quanta/it8518/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... ec/quanta/it8518/acpi: Replace Add(a,b) with ASL 2.0 syntax Replace `Add (a, b)` with `a + b`. Change-Id: I5ed8c8a8cfc92b0af1602bee15cd6971536b61ad Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/quanta/it8518/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/60506/1 diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index 0015021..9c48442 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -317,7 +317,7 @@ // See if within ~3% of full ShiftRight (Local2, 5, Local3) - If (LGreater (Local1, Local2 - Local3) && LLess (Local1, Add (Local2, Local3))) + If (LGreater (Local1, Local2 - Local3) && LLess (Local1, Local2 + Local3)) { Store (Local2, Local1) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60506 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ed8c8a8cfc92b0af1602bee15cd6971536b61ad Gerrit-Change-Number: 60506 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/smsc/mec1308/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60505 ) Change subject: ec/smsc/mec1308/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... ec/smsc/mec1308/acpi: Replace Add(a,b) with ASL 2.0 syntax Replace `Add (a, b)` with `a + b`. Change-Id: I82a960f9b5748ccdde3c07b78963b44b8dbef37e Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/smsc/mec1308/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/60505/1 diff --git a/src/ec/smsc/mec1308/acpi/battery.asl b/src/ec/smsc/mec1308/acpi/battery.asl index 603b1d4..2aa5ace 100644 --- a/src/ec/smsc/mec1308/acpi/battery.asl +++ b/src/ec/smsc/mec1308/acpi/battery.asl @@ -158,7 +158,7 @@ // See if within ~3% of full ShiftRight (Local2, 5, Local3) If (LGreater (Local1, Local2 - Local3) && - LLess (Local1, Add (Local2, Local3))) + LLess (Local1, Local2 + Local3)) { Store (Local2, Local1) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82a960f9b5748ccdde3c07b78963b44b8dbef37e Gerrit-Change-Number: 60505 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021