coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: util/cbmem: Rebase to handle negative timestamps
by Bora Guvendik (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak. Bora Guvendik has removed Subrata Banik from this change. ( https://review.coreboot.org/c/coreboot/+/59555 ) Change subject: util/cbmem: Rebase to handle negative timestamps ...................................................................... Removed reviewer Subrata Banik. -- To view, visit https://review.coreboot.org/c/coreboot/+/59555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7eb519c360e066d48dde205401e4ccd3b0b3d8a5 Gerrit-Change-Number: 59555 Gerrit-PatchSet: 4 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: timestamp: Allow timestamp_add to accept a negative number
by Bora Guvendik (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Selma Bensaid, Tim Wawrzynczak, Julius Werner, Subrata Banik. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59554 ) Change subject: timestamp: Allow timestamp_add to accept a negative number ...................................................................... Patch Set 3: (1 comment) File src/lib/timestamp.c: https://review.coreboot.org/c/coreboot/+/59554/comment/d3cd9b5e_08191ece PS1, Line 134: if (ts_time >= 0) > No, not like this. […] thanks, done. -- To view, visit https://review.coreboot.org/c/coreboot/+/59554 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90afc13a8e92693d86e3358f05e0a0cb7cdbca9b Gerrit-Change-Number: 59554 Gerrit-PatchSet: 3 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Thu, 30 Dec 2021 00:19:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: timestamp: Allow timestamp_add to accept a negative number
by Bora Guvendik (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak, Subrata Banik. Hello build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Julius Werner, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59554 to look at the new patch set (#3). Change subject: timestamp: Allow timestamp_add to accept a negative number ...................................................................... timestamp: Allow timestamp_add to accept a negative number Change timestamp_add to accept negative values for events that took place before coreboot started executing. TEST=Boot to OS, check cbmem -t Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> Change-Id: I90afc13a8e92693d86e3358f05e0a0cb7cdbca9b --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/include/timestamp.h M src/lib/timestamp.c 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/59554/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/59554 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90afc13a8e92693d86e3358f05e0a0cb7cdbca9b Gerrit-Change-Number: 59554 Gerrit-PatchSet: 3 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/cbmem: Rebase to handle negative timestamps
by Bora Guvendik (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak, Subrata Banik. Hello build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Subrata Banik, Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59555 to look at the new patch set (#3). Change subject: util/cbmem: Rebase to handle negative timestamps ...................................................................... util/cbmem: Rebase to handle negative timestamps Rebase all of the timestamps to the lowest(negative) value in the list when displaying them. TEST=Boot to OS after adding negative timestamps, cbmem -t Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> Change-Id: I7eb519c360e066d48dde205401e4ccd3b0b3d8a5 --- M util/cbmem/cbmem.c 1 file changed, 14 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/59555/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/59555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7eb519c360e066d48dde205401e4ccd3b0b3d8a5 Gerrit-Change-Number: 59555 Gerrit-PatchSet: 3 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: timestamp: Allow timestamp_add to accept a negative number
by Bora Guvendik (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak, Subrata Banik. Hello build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Julius Werner, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59554 to look at the new patch set (#2). Change subject: timestamp: Allow timestamp_add to accept a negative number ...................................................................... timestamp: Allow timestamp_add to accept a negative number Change timestamp_add to accept negative values for events that took place before coreboot started executing. TEST=Boot to OS, check cbmem -t Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> Change-Id: I90afc13a8e92693d86e3358f05e0a0cb7cdbca9b --- M src/commonlib/include/commonlib/timestamp_serialized.h M src/include/timestamp.h M src/lib/timestamp.c 3 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/59554/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59554 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90afc13a8e92693d86e3358f05e0a0cb7cdbca9b Gerrit-Change-Number: 59554 Gerrit-PatchSet: 2 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Andrey Petrov, Patrick Rudolph. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60481 ) Change subject: soc/intel/apollolake/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax ...................................................................... soc/intel/apollolake/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax Replace `Subtract (a, b, c)` with `c = a - b`. Change-Id: I8c98f4e3c3aed6209fd36398134a36778a560708 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/apollolake/acpi/northbridge.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/60481/1 diff --git a/src/soc/intel/apollolake/acpi/northbridge.asl b/src/soc/intel/apollolake/acpi/northbridge.asl index f6b337c..929bdd1 100644 --- a/src/soc/intel/apollolake/acpi/northbridge.asl +++ b/src/soc/intel/apollolake/acpi/northbridge.asl @@ -109,7 +109,7 @@ /* Set 64bit MMIO resource base and length */ Store (A4GS, MLEN) Store (A4GB, MMIN) - Subtract (Add (MMIN, MLEN), 1, MMAX) + MMAX = Add (MMIN, MLEN) - 1 } Return (MCRS) -- To view, visit https://review.coreboot.org/c/coreboot/+/60481 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c98f4e3c3aed6209fd36398134a36778a560708 Gerrit-Change-Number: 60481 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60480 ) Change subject: ec/quanta/it8518/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax ...................................................................... ec/quanta/it8518/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax Replace `Subtract (a, b, c)` with `c = a - b`. Change-Id: Ifcdc29dbc3874180bd0692260ea250a1a6c86d41 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/quanta/it8518/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/60480/1 diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index de51206..9294733 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -265,7 +265,7 @@ { If (And (Local0, 1)) { - Subtract (0x10000, Local1, Local1) + Local1 = 0x10000 - Local1 } Else { -- To view, visit https://review.coreboot.org/c/coreboot/+/60480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifcdc29dbc3874180bd0692260ea250a1a6c86d41 Gerrit-Change-Number: 60480 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/aopen/dxplplusu/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60479 ) Change subject: mb/aopen/dxplplusu/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax ...................................................................... mb/aopen/dxplplusu/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax Replace `Subtract (a, b, c)` with `c = a - b`. Change-Id: I22088a584c1d6d5188cb74ff8b03f51ea02e4b68 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl M src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/60479/1 diff --git a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl index 7216d33..c5ae2448 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl @@ -52,7 +52,7 @@ Decrement (Local1) If (LGreater (Local1, 0x10)) { - Subtract (Local1, 0x0F, Local1) + Local1 = Local1 - 0x0F Store (ShiftLeft (Local1, 0x14), MEM2) Store (0x01000000, MS00) Store (MS00, MS01) diff --git a/src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl b/src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl index 0ba808d..400a5d7 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl @@ -44,8 +44,8 @@ And (\_SB.PCI0.TOLM, 0xF800, Local1) ShiftRight (Local1, 0x04, Local1) ShiftLeft (Local1, 0x14, MEML) - Subtract (IO_APIC_ADDR, 0x01, MEMH) - Subtract (IO_APIC_ADDR, MEML, LENM) + MEMH = IO_APIC_ADDR - 1 + LENM = IO_APIC_ADDR - MEML Return (PBRS) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60479 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22088a584c1d6d5188cb74ff8b03f51ea02e4b68 Gerrit-Change-Number: 60479 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60478 ) Change subject: ec/lenovo/h8/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax ...................................................................... ec/lenovo/h8/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax Replace `Subtract (a, b, c)` with `c = a - b`. Change-Id: Ic38c60503fedaffc66153e103d40fda86781f9c8 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/lenovo/h8/acpi/thermal.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/60478/1 diff --git a/src/ec/lenovo/h8/acpi/thermal.asl b/src/ec/lenovo/h8/acpi/thermal.asl index b21dafc..348a930 100644 --- a/src/ec/lenovo/h8/acpi/thermal.asl +++ b/src/ec/lenovo/h8/acpi/thermal.asl @@ -85,11 +85,11 @@ Store (GPSV (), Local0) /* Active fan 10 degree below passive threshold */ - Subtract (Local0, 10, Local0) + Local0 = Local0 - 10 If (\FLVL) { /* Turn of 5 degree below trip point */ - Subtract (Local0, 5, Local0) + Local0 = Local0 - 5 } Return (C2K (Local0)) -- To view, visit https://review.coreboot.org/c/coreboot/+/60478 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic38c60503fedaffc66153e103d40fda86781f9c8 Gerrit-Change-Number: 60478 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Update vboot submodule to upstream master
by Edward O'Callaghan (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Hsuan-ting Chen, Julius Werner. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60078 ) Change subject: Update vboot submodule to upstream master ...................................................................... Patch Set 2: (1 comment) File 3rdparty/vboot: https://review.coreboot.org/c/coreboot/+/60078/comment/e1d1acaa_ece62893 PS2, Line 1: 8028cac33c9c408f90de9ceffc714a1a0ca9d583 25b9493525325dfb5bc2c36321c43ec7665060fa contains the required fixes to build in the coreboot tree again without flashrom present. -- To view, visit https://review.coreboot.org/c/coreboot/+/60078 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife75d21ddfa0b956fdf7a638cd53b55b11f6cb7d Gerrit-Change-Number: 60078 Gerrit-PatchSet: 2 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 29 Dec 2021 23:42:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021