coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: superio/winbond/w83627hf/acpi: Replace Subtract(a,b,c) with ASL 2.0 s...
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60476 ) Change subject: superio/winbond/w83627hf/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax ...................................................................... superio/winbond/w83627hf/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax Replace `Subtract (a, b, c)` with `c = a - b`. Change-Id: Idd97e662ec4be7092a655bc298dffb6d826bc497 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60476 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/superio/winbond/w83627hf/acpi/superio.asl 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl index 2061030..5db7ca8 100644 --- a/src/superio/winbond/w83627hf/acpi/superio.asl +++ b/src/superio/winbond/w83627hf/acpi/superio.asl @@ -583,7 +583,7 @@ /* DMA off */ Store (0x04, DMA0) /* IRQ */ - Subtract(FindSetLeftBit (IRQL), 1, IRQ0) + IRQ0 = FindSetLeftBit (IRQL) - 1 /* Activate */ Store (One, ACTR) EXIT_CONFIG_MODE () @@ -701,7 +701,7 @@ Divide(IOA0, 256, Local0, Local1) - Subtract(FindSetLeftBit (IRQL), 1, Local3) + Local3 = FindSetLeftBit (IRQL) - 1 ENTER_CONFIG_MODE (2) Store (Local0, IO1L) @@ -826,7 +826,7 @@ Divide(IOA0, 256, Local0, Local1) - Subtract(FindSetLeftBit (IRQL), 1, Local3) + Local3 = FindSetLeftBit (IRQL) - 1 ENTER_CONFIG_MODE (3) Store (Local0, IO1L) @@ -951,7 +951,7 @@ Divide(IOA0, 256, Local0, Local1) - Subtract(FindSetLeftBit (IRQL), 1, Local3) + Local3 = FindSetLeftBit (IRQL) - 1 ENTER_CONFIG_MODE (3) Store (Local0, IO1L) @@ -1038,7 +1038,7 @@ Divide(IOA0, 256, Local0, Local1) - Subtract(FindSetLeftBit (IRQL), 1, Local3) + Local3 = FindSetLeftBit (IRQL) - 1 ENTER_CONFIG_MODE (6) Store (Local0, IO1L) @@ -1143,7 +1143,7 @@ Divide(IOA0, 256, Local0, Local1) Divide(IOA1, 256, Local2, Local3) - Subtract(FindSetLeftBit (IRQL), 1, Local4) + Local4 = FindSetLeftBit (IRQL) - 1 ENTER_CONFIG_MODE (5) Store (Local0, IO1L) @@ -1222,7 +1222,7 @@ }) CreateWordField (Arg0, IRQX._INT, IRQL) - Subtract(FindSetLeftBit (IRQL), 1, Local0) + Local0 = FindSetLeftBit (IRQL) - 1 ENTER_CONFIG_MODE (5) Store (Local0, IRQ1) 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd97e662ec4be7092a655bc298dffb6d826bc497 Gerrit-Change-Number: 60476 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60475 ) Change subject: ec/google/chromeec/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax ...................................................................... ec/google/chromeec/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax Replace `Subtract (a, b, c)` with `c = a - b`. Change-Id: If35c90d0e7d523f67f94d542e37fdca43bb16d7c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60475 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/google/chromeec/acpi/ec.asl 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index f521e27..5974e2c 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -426,7 +426,7 @@ Divide (ToInteger (Arg1), 10, , Local1) /* Adjust by EC temperature offset */ - Subtract (Local1, ^TOFS, ^PATT) + ^PATT = Local1 - ^TOFS /* Set commit value with SELECT=0 and ENABLE=1 */ Store (0x02, ^PATC) @@ -453,7 +453,7 @@ Divide (ToInteger (Arg1), 10, , Local1) /* Adjust by EC temperature offset */ - Subtract (Local1, ^TOFS, ^PATT) + ^PATT = Local1 - ^TOFS /* Set commit value with SELECT=1 and ENABLE=1 */ Store (0x03, ^PATC) @@ -542,7 +542,7 @@ If (LEqual (^DDPN, 0)) { Return (^TBMD) } Else { - Subtract (^DDPN, 1, Local0) + Local0 = ^DDPN - 1 Return (Local0) } } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If35c90d0e7d523f67f94d542e37fdca43bb16d7c Gerrit-Change-Number: 60475 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/jecht/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60474 ) Change subject: mb/google/jecht/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax ...................................................................... mb/google/jecht/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax Replace `Subtract (a, b, c)` with `c = a - b`. Change-Id: I604a5c56e1941dd2932eaa5b44966e6ea06abb4c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60474 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl 4 files changed, 8 insertions(+), 8 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl index d5c943a..1d64669 100644 --- a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl @@ -74,7 +74,7 @@ } // PECI raw value is an offset from Tj_max - Subtract (255, Local0, Local1) + Local1 = 255 - Local0 // Handle values greater than Tj_max If (LGreaterEqual (Local1, \TMAX)) { @@ -82,7 +82,7 @@ } // Subtract from Tj_max to get temperature - Subtract (\TMAX, Local1, Local0) + Local0 = \TMAX - Local1 Return (CTOK (Local0)) } diff --git a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl index d5c943a..1d64669 100644 --- a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl @@ -74,7 +74,7 @@ } // PECI raw value is an offset from Tj_max - Subtract (255, Local0, Local1) + Local1 = 255 - Local0 // Handle values greater than Tj_max If (LGreaterEqual (Local1, \TMAX)) { @@ -82,7 +82,7 @@ } // Subtract from Tj_max to get temperature - Subtract (\TMAX, Local1, Local0) + Local0 = \TMAX - Local1 Return (CTOK (Local0)) } diff --git a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl index d5c943a..1d64669 100644 --- a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl @@ -74,7 +74,7 @@ } // PECI raw value is an offset from Tj_max - Subtract (255, Local0, Local1) + Local1 = 255 - Local0 // Handle values greater than Tj_max If (LGreaterEqual (Local1, \TMAX)) { @@ -82,7 +82,7 @@ } // Subtract from Tj_max to get temperature - Subtract (\TMAX, Local1, Local0) + Local0 = \TMAX - Local1 Return (CTOK (Local0)) } diff --git a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl index 2b79320..adde850 100644 --- a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl @@ -182,7 +182,7 @@ } // PECI raw value is an offset from Tj_max - Subtract (255, Local0, Local1) + Local1 = 255 - Local0 // Handle values greater than Tj_max If (LGreaterEqual (Local1, \TMAX)) { @@ -190,7 +190,7 @@ } // Subtract from Tj_max to get temperature - Subtract (\TMAX, Local1, Local0) + Local0 = \TMAX - Local1 Return (CTOK (Local0)) } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I604a5c56e1941dd2932eaa5b44966e6ea06abb4c Gerrit-Change-Number: 60474 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/intel/cannonlake/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60473 ) Change subject: soc/intel/cannonlake/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax ...................................................................... soc/intel/cannonlake/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax Replace `Subtract (a, b, c)` with `c = a - b`. Change-Id: I764bf6c8b068c1b7471a28aa064f7a3a47d7811e Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60473 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/soc/intel/cannonlake/acpi/gpio.asl M src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl 2 files changed, 9 insertions(+), 9 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/soc/intel/cannonlake/acpi/gpio.asl b/src/soc/intel/cannonlake/acpi/gpio.asl index 6b15f80..a1bc375 100644 --- a/src/soc/intel/cannonlake/acpi/gpio.asl +++ b/src/soc/intel/cannonlake/acpi/gpio.asl @@ -64,31 +64,31 @@ If (LGreaterEqual (Arg0, GPP_A0) && LLessEqual (Arg0, SPI0_CLK_LOOPBK)) { Store (PID_GPIOCOM0, Local0) - Subtract (Arg0, GPP_A0, Local1) + Local1 = Arg0 - GPP_A0 } /* GPIO Community 1 */ If (LGreaterEqual (Arg0, GPP_D0) && LLessEqual (Arg0, vSD3_CD_B)) { Store (PID_GPIOCOM1, Local0) - Subtract (Arg0, GPP_D0, Local1) + Local1 = Arg0 - GPP_D0 } /* GPIO Community 2 */ If (LGreaterEqual (Arg0, GPD0) && LLessEqual (Arg0, DRAM_RESET_B)) { Store (PID_GPIOCOM2, Local0) - Subtract (Arg0, GPD0, Local1) + Local1 = Arg0 - GPD0 } /* GPIO Community 3 */ If (LGreaterEqual (Arg0, HDA_BCLK) && LLessEqual (Arg0, TRIGGER_OUT)) { Store (PID_GPIOCOM3, Local0) - Subtract (Arg0, HDA_BCLK, Local1) + Local1 = Arg0 - HDA_BCLK } /* GPIO Community 4*/ If (LGreaterEqual (Arg0, GPP_C0) && LLessEqual (Arg0, CL_RST_B)) { Store (PID_GPIOCOM4, Local0) - Subtract (Arg0, GPP_C0, Local1) + Local1 = Arg0 - GPP_C0 } Store (PCRB (Local0), Local2) Add (Local2, PAD_CFG_BASE, Local2) diff --git a/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl b/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl index db2b22c..5007d96 100644 --- a/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl +++ b/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl @@ -70,25 +70,25 @@ If (LGreaterEqual (Arg0, GPP_A0) && LLessEqual (Arg0, GSPI1_CLK_LOOPBK)) { Store (PID_GPIOCOM0, Local0) - Subtract (Arg0, GPP_A0, Local1) + Local1 = Arg0 - GPP_A0 } /* GPIO Community 1 */ If (LGreaterEqual (Arg0, GPP_C0) && LLessEqual (Arg0, vSSP2_RXD)) { Store (PID_GPIOCOM1, Local0) - Subtract (Arg0, GPP_C0, Local1) + Local1 = Arg0 - GPP_C0 } /* GPIO Community 3*/ If (LGreaterEqual (Arg0, GPP_K0) && LLessEqual (Arg0, SPI0_CLK_LOOPBK)) { Store (PID_GPIOCOM3, Local0) - Subtract (Arg0, GPP_K0, Local1) + Local1 = Arg0 - GPP_K0 } /* GPIO Community 4*/ If (LGreaterEqual (Arg0, HDACPU_SDI) && LLessEqual (Arg0, GPP_J11)) { Store (PID_GPIOCOM4, Local0) - Subtract (Arg0, GPP_I0, Local1) + Local1 = Arg0 - GPP_I0 } Store (PCRB (Local0), Local2) Add (Local2, PAD_CFG_BASE, Local2) 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60473 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I764bf6c8b068c1b7471a28aa064f7a3a47d7811e Gerrit-Change-Number: 60473 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: vendorcode/intel/fsp/elkhartlake: Drop unnecessary headers
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60541 ) Change subject: vendorcode/intel/fsp/elkhartlake: Drop unnecessary headers ...................................................................... vendorcode/intel/fsp/elkhartlake: Drop unnecessary headers Elkhartlake was hooked up to the FSP repo with commit 79fcadb3c46 making these headers unnecessary. Thus, drop them. Change-Id: I2d6a4d4614ae21d5b8e77eceb85baa13e491c2ae Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- D src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FirmwareVersionInfoHob.h D src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspUpd.h D src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspmUpd.h D src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspsUpd.h D src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FsptUpd.h D src/vendorcode/intel/fsp/fsp2_0/elkhartlake/MemInfoHob.h 6 files changed, 0 insertions(+), 8,501 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/60541/1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60541 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d6a4d4614ae21d5b8e77eceb85baa13e491c2ae Gerrit-Change-Number: 60541 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/cannonlake/acpi: Replace Add(a,b) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer, Patrick Rudolph. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60503 ) Change subject: soc/intel/cannonlake/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60503 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90dc0ecb1e3f16874a72cdf01afb097d4e7b6076 Gerrit-Change-Number: 60503 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 30 Dec 2021 21:08:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer, Alexander Couzens. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60478 ) Change subject: ec/lenovo/h8/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60478 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic38c60503fedaffc66153e103d40fda86781f9c8 Gerrit-Change-Number: 60478 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 30 Dec 2021 21:07:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/aopen/dxplplusu/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60479 ) Change subject: mb/aopen/dxplplusu/acpi: Replace Subtract(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60479 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22088a584c1d6d5188cb74ff8b03f51ea02e4b68 Gerrit-Change-Number: 60479 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 30 Dec 2021 21:04:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer, Tim Wawrzynczak. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60484 ) Change subject: ec/google/chromeec/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60484 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa79ea4bdb4a33fd2445ae9033c740dacc090037 Gerrit-Change-Number: 60484 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 30 Dec 2021 21:03:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cannonlake/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer, Patrick Rudolph. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60486 ) Change subject: soc/intel/cannonlake/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc5aeb5e8d85556d7564033ec92deb5b2dae093d Gerrit-Change-Number: 60486 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 30 Dec 2021 21:03:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021