coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: [RFC] smp/spinlock: Use compiler builtins
by Kyösti Mälkki (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Raul Rangel, Tim Wawrzynczak, Arthur Heymans. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60253 ) Change subject: [RFC] smp/spinlock: Use compiler builtins ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Arthur reported x86 arch/smp/spinlock.h failures, it can overflow with >128 cores, as it uses byte operand for the lock variable. -- To view, visit https://review.coreboot.org/c/coreboot/+/60253 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6694784aa0810cd877886ef95434f62e3aefce6c Gerrit-Change-Number: 60253 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 30 Dec 2021 20:02:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Alexander Couzens, HAOUAS Elyes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60492 ) Change subject: ec/lenovo/h8/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: (1 comment) File src/ec/lenovo/h8/acpi/thermal.asl: https://review.coreboot.org/c/coreboot/+/60492/comment/d694ab15_57e9179c PS1, Line 15: Local0 = Local0 + 2732 > Local0 += 2732 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60492 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbc0831e688b62d7ed0dec5e4b7224688ed0ae6d Gerrit-Change-Number: 60492 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 30 Dec 2021 19:48:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/kahlee/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: HAOUAS Elyes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60491 ) Change subject: mb/google/kahlee/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl: https://review.coreboot.org/c/coreboot/+/60491/comment/ac4adf6e_47ac8c81 PS1, Line 27: Local0 = Local0 + 2732 > Local0 += 2732 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60491 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If80d97abc831e17bc8bc6e379bbae26e65db23f1 Gerrit-Change-Number: 60491 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 30 Dec 2021 19:46:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cannonlake/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Patrick Rudolph, HAOUAS Elyes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60486 ) Change subject: soc/intel/cannonlake/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/cannonlake/acpi/gpio.asl: https://review.coreboot.org/c/coreboot/+/60486/comment/2235b273_503e0e62 PS1, Line 94: Local2 = Local2 + PAD_CFG_BASE > Local2 += PAD_CFG_BASE Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc5aeb5e8d85556d7564033ec92deb5b2dae093d Gerrit-Change-Number: 60486 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 30 Dec 2021 19:45:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Andrey Petrov, Patrick Rudolph, HAOUAS Elyes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60504 ) Change subject: soc/intel/apollolake/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/apollolake/acpi/gpiolib.asl: https://review.coreboot.org/c/coreboot/+/60504/comment/a07565af_46fe2001 PS2, Line 47: 0x4 > 4 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id465558f054494d3273d5cd6077476d878d7c183 Gerrit-Change-Number: 60504 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 30 Dec 2021 19:45:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: HAOUAS Elyes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60493 ) Change subject: ec/starlabs/merlin/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: (1 comment) File src/ec/starlabs/merlin/acpi/ec.asl: https://review.coreboot.org/c/coreboot/+/60493/comment/d729d37b_01b42e00 PS1, Line 129: Local1 = Local1 + 1 > maybe : Local1 += 1 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f8b71c90f0c56fdb29c4d2e9a2a737f704f3265 Gerrit-Change-Number: 60493 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 30 Dec 2021 19:44:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Tim Wawrzynczak, HAOUAS Elyes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60484 ) Change subject: ec/google/chromeec/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: (1 comment) File src/ec/google/chromeec/acpi/ec.asl: https://review.coreboot.org/c/coreboot/+/60484/comment/e72c882a_ccfd2ae9 PS1, Line 201: Local0 = Local0 + \_SB.PCI0.LPCB.EC0.TOFS > Local0 += \_SB.PCI0.LPCB.EC0. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60484 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa79ea4bdb4a33fd2445ae9033c740dacc090037 Gerrit-Change-Number: 60484 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 30 Dec 2021 19:43:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Andrey Petrov, Patrick Rudolph. Hello build bot (Jenkins), Andrey Petrov, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60504 to look at the new patch set (#3). Change subject: soc/intel/apollolake/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/apollolake/acpi: Replace Add(a,b) with ASL 2.0 syntax Replace `Add (a, b)` with `a + b`. Change-Id: Id465558f054494d3273d5cd6077476d878d7c183 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/apollolake/acpi/gpiolib.asl M src/soc/intel/apollolake/acpi/northbridge.asl 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/60504/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id465558f054494d3273d5cd6077476d878d7c183 Gerrit-Change-Number: 60504 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/cannonlake/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Patrick Rudolph. Hello build bot (Jenkins), Patrick Rudolph, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60503 to look at the new patch set (#3). Change subject: soc/intel/cannonlake/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/cannonlake/acpi: Replace Add(a,b) with ASL 2.0 syntax Replace `Add (a, b)` with `a + b`. Change-Id: I90dc0ecb1e3f16874a72cdf01afb097d4e7b6076 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/cannonlake/acpi/gpio.asl M src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl M src/soc/intel/cannonlake/acpi/xhci.asl 3 files changed, 3 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/60503/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60503 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90dc0ecb1e3f16874a72cdf01afb097d4e7b6076 Gerrit-Change-Number: 60503 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/starlabs/merlin/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60493 to look at the new patch set (#2). Change subject: ec/starlabs/merlin/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... ec/starlabs/merlin/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: I4f8b71c90f0c56fdb29c4d2e9a2a737f704f3265 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/starlabs/merlin/acpi/ec.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/60493/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f8b71c90f0c56fdb29c4d2e9a2a737f704f3265 Gerrit-Change-Number: 60493 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021