coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/slippy/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60488 ) Change subject: mb/google/slippy/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/slippy/acpi/thermal.asl: https://review.coreboot.org/c/coreboot/+/60488/comment/1d363f7a_ff81ba94 PS2, Line 90: Local0 = Local0 + \_SB.PCI0.LPCB.EC0.TOFS Local0 += \_SB.PCI0.LPCB.EC0.TOFS -- To view, visit https://review.coreboot.org/c/coreboot/+/60488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f18a327b5500eacfe8895ebabb1f2b294cef0d0 Gerrit-Change-Number: 60488 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 30 Dec 2021 21:03:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cyan/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60490 ) Change subject: mb/google/cyan/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I771c855e8885238c7fc3b0a7a6e9c2002274c0f2 Gerrit-Change-Number: 60490 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 30 Dec 2021 21:01:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/kahlee/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60491 ) Change subject: mb/google/kahlee/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60491 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If80d97abc831e17bc8bc6e379bbae26e65db23f1 Gerrit-Change-Number: 60491 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 30 Dec 2021 21:01:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/jecht/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60489 ) Change subject: mb/google/jecht/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie7fa132623c7834e3d2f1acda032928579819a84 Gerrit-Change-Number: 60489 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 30 Dec 2021 21:01:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60493 ) Change subject: ec/starlabs/merlin/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f8b71c90f0c56fdb29c4d2e9a2a737f704f3265 Gerrit-Change-Number: 60493 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 30 Dec 2021 21:00:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer, Alexander Couzens. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60492 ) Change subject: ec/lenovo/h8/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60492 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbc0831e688b62d7ed0dec5e4b7224688ed0ae6d Gerrit-Change-Number: 60492 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 30 Dec 2021 20:59:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace Add(a,b) with ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Felix Singer, Andrey Petrov, Patrick Rudolph. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60504 ) Change subject: soc/intel/apollolake/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id465558f054494d3273d5cd6077476d878d7c183 Gerrit-Change-Number: 60504 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 30 Dec 2021 20:57:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util: Allow overriding install options
by Felix Singer (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Tim Crawford, Stefan Reinauer. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60540 ) Change subject: util: Allow overriding install options ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a31ea0fde9922731e1621dcc8f94b2c1326c93c Gerrit-Change-Number: 60540 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Dec 2021 20:55:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util: Allow overriding install options
by Tim Crawford (Code Review) 30 Dec '21

30 Dec '21

Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60540 ) Change subject: util: Allow overriding install options ...................................................................... util: Allow overriding install options Modify util Makefiles to allow: - overriding the install prefix - installing to a build root by specifying DESTDIR Change-Id: I3a31ea0fde9922731e1621dcc8f94b2c1326c93c Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M util/ectool/Makefile M util/ifdtool/Makefile M util/nvramtool/Makefile M util/pmh7tool/Makefile M util/spkmodem_recv/Makefile 5 files changed, 10 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/60540/1 diff --git a/util/ectool/Makefile b/util/ectool/Makefile index 1ef74d2..5ea8240 100644 --- a/util/ectool/Makefile +++ b/util/ectool/Makefile @@ -5,7 +5,7 @@ CFLAGS = -O2 -Wall -Wextra -Wshadow $(WERROR) PROGRAM = ectool INSTALL = /usr/bin/env install -PREFIX = /usr/local +PREFIX ?= /usr/local OS_ARCH = $(shell uname) ifeq ($(shell uname -o 2>/dev/null), Cygwin) @@ -22,7 +22,8 @@ $(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) install: $(PROGRAM) - $(INSTALL) $(PROGRAM) $(PREFIX)/sbin + $(INSTALL) -d $(DESTDIR)$(PREFIX)/sbin + $(INSTALL) $(PROGRAM) $(DESTDIR)$(PREFIX)/sbin clean: rm -f *.o $(PROGRAM) junit.xml diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index 83d19b8..cce68dd 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -4,7 +4,7 @@ CC ?= gcc INSTALL = /usr/bin/env install -PREFIX = /usr/local +PREFIX ?= /usr/local HOSTCC ?= $(CC) HOSTCFLAGS ?= $(CFLAGS) diff --git a/util/nvramtool/Makefile b/util/nvramtool/Makefile index 0d7f687..35698ce 100644 --- a/util/nvramtool/Makefile +++ b/util/nvramtool/Makefile @@ -10,7 +10,7 @@ CC ?= gcc INSTALL = /usr/bin/env install -PREFIX = /usr/local +PREFIX ?= /usr/local CFLAGS = -O2 -g -Wall -Wextra -Wmissing-prototypes -I. -DCMOS_HAL=1 #CFLAGS = -Os -Wall diff --git a/util/pmh7tool/Makefile b/util/pmh7tool/Makefile index 9b3921a..a2763cd 100644 --- a/util/pmh7tool/Makefile +++ b/util/pmh7tool/Makefile @@ -4,7 +4,7 @@ CFLAGS = -O2 -Wall -Wextra -Werror PROGRAM = pmh7tool INSTALL = /usr/bin/env install -PREFIX = /usr/local +PREFIX ?= /usr/local all: $(PROGRAM) @@ -12,7 +12,8 @@ $(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) install: $(PROGRAM) - $(INSTALL) $(PROGRAM) $(PREFIX)/sbin + $(INSTALL) -d $(DESTDIR)$(PREFIX)/sbin + $(INSTALL) $(PROGRAM) $(DESTDIR)$(PREFIX)/sbin clean: rm -f *.o $(PROGRAM) diff --git a/util/spkmodem_recv/Makefile b/util/spkmodem_recv/Makefile index c9659b4..92a3bfe 100644 --- a/util/spkmodem_recv/Makefile +++ b/util/spkmodem_recv/Makefile @@ -5,4 +5,5 @@ spkmodem-recv: $(CC) -o $@ $@.c install: spkmodem-recv - $(INSTALL) $< -t $(PREFIX)/bin/ + $(INSTALL) -d $(DESTDIR)$(PREFIX)/bin/ + $(INSTALL) $< -t $(DESTDIR)$(PREFIX)/bin/ -- To view, visit https://review.coreboot.org/c/coreboot/+/60540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a31ea0fde9922731e1621dcc8f94b2c1326c93c Gerrit-Change-Number: 60540 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: arch/x86/spinlock.h: Support systems with >128 cores
by Arthur Heymans (Code Review) 30 Dec '21

30 Dec '21

Attention is currently required from: Arthur Heymans. Hello Arthur Heymans, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/60539 to review the following change. Change subject: arch/x86/spinlock.h: Support systems with >128 cores ...................................................................... arch/x86/spinlock.h: Support systems with >128 cores Each time the spinlock is acquired a bytes is decreased and then the sign of the byte is checked. If there are more than 128 cores the sign check will overflow. An easy fix is to increase the word size of the spinlock acquiring and releasing. Change-Id: I76afaa60669335090743d99381280e74aa9fb5b1 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/x86/include/arch/smp/spinlock.h 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/60539/1 diff --git a/src/arch/x86/include/arch/smp/spinlock.h b/src/arch/x86/include/arch/smp/spinlock.h index c7008c1..713485e 100644 --- a/src/arch/x86/include/arch/smp/spinlock.h +++ b/src/arch/x86/include/arch/smp/spinlock.h @@ -31,11 +31,11 @@ #define spin_lock_string \ "\n1:\t" \ - "lock ; decb %0\n\t" \ + "lock ; decl %0\n\t" \ "js 2f\n" \ ".section .text.lock,\"ax\"\n" \ "2:\t" \ - "cmpb $0,%0\n\t" \ + "cmpl $0,%0\n\t" \ "rep;nop\n\t" \ "jle 2b\n\t" \ "jmp 1b\n" \ @@ -45,7 +45,7 @@ * This works. Despite all the confusion. */ #define spin_unlock_string \ - "movb $1,%0" + "movl $1,%0" static __always_inline void spin_lock(spinlock_t *lock) { -- To view, visit https://review.coreboot.org/c/coreboot/+/60539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76afaa60669335090743d99381280e74aa9fb5b1 Gerrit-Change-Number: 60539 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021