coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: SMBIOS/SCONFIG: Allow devtree-defined Type 41 entries
by Tim Wawrzynczak (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Nico Huber, Martin Roth, Furquan Shaikh, Paul Menzel, Angel Pons, Arthur Heymans, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57370 ) Change subject: SMBIOS/SCONFIG: Allow devtree-defined Type 41 entries ...................................................................... Patch Set 6: (1 comment) File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/57370/comment/16e11f1f_9eff2e6e PS6, Line 1186: = {} > It's not necessary, but I prefer explicit initialisation. We don't have any rule about it. […] ack -- To view, visit https://review.coreboot.org/c/coreboot/+/57370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecca9ada6ee1000674cb5dd7afd5c309d8e1a64b Gerrit-Change-Number: 57370 Gerrit-PatchSet: 6 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 02 Nov 2021 14:31:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in edk2[master]: UefiPayloadPkg: Allow below 4GB memory
by Sean Rhodes (Code Review) 02 Nov '21

02 Nov '21

Attention is currently required from: Sean Rhodes. Hello Matt DeVillier, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/edk2/+/58802 to look at the new patch set (#4). Change subject: UefiPayloadPkg: Allow below 4GB memory ...................................................................... UefiPayloadPkg: Allow below 4GB memory Add build option `ABOVE_4G_MEMORY`, which when disabled, will dispatch everything under 4GB. This allows Operating System's that require EFI_LOADED_IMAGE to be under 4GB to start. e.g. Xen hypervisor used in Qubes Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ic600e08c9d46d0a291b8b119a3c268e432267cdf --- M UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c M UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf M UefiPayloadPkg/UefiPayloadPkg.dec M UefiPayloadPkg/UefiPayloadPkg.dsc 4 files changed, 54 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/edk2 refs/changes/02/58802/4 -- To view, visit https://review.coreboot.org/c/edk2/+/58802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: master Gerrit-Change-Id: Ic600e08c9d46d0a291b8b119a3c268e432267cdf Gerrit-Change-Number: 58802 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/system76/oryp6: Convert to variant setup
by Tim Crawford (Code Review) 02 Nov '21

02 Nov '21

Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57786 ) Change subject: mb/system76/oryp6: Convert to variant setup ...................................................................... Patch Set 5: (1 comment) File src/mainboard/system76/oryp6/Kconfig: https://review.coreboot.org/c/coreboot/+/57786/comment/a24cbc2e_d51c9cee PS4, Line 26: select TPM_RDRESP_NEED_DELAY > We have it selected downstream for both boards. […] Added in oryp7 change instead. -- To view, visit https://review.coreboot.org/c/coreboot/+/57786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I976750c7724d23b303d0012f2d83c21a459e5eed Gerrit-Change-Number: 57786 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Tue, 02 Nov 2021 14:30:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com> Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/system76/oryp6: Add Oryx Pro 7 as a variant
by build bot (Jenkins) (Code Review) 02 Nov '21

02 Nov '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52296 ) Change subject: mb/system76/oryp6: Add Oryx Pro 7 as a variant ...................................................................... Patch Set 14: (1 comment) File src/mainboard/system76/oryp6/include/variant/romstage.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132032): https://review.coreboot.org/c/coreboot/+/52296/comment/97f9bd3a_bb07a536 PS14, Line 8: void variant_configure_fspm(FSPM_UPD *memupd); need consistent spacing around '*' (ctx:WxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/52296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id00a45a6a6acf0880934c55f1a3f18e63f2aed43 Gerrit-Change-Number: 52296 Gerrit-PatchSet: 14 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeremy Soller <jeremy(a)system76.com> Gerrit-Comment-Date: Tue, 02 Nov 2021 14:29:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/system76/oryp6: Add Oryx Pro 7 as a variant
by Tim Crawford (Code Review) 02 Nov '21

02 Nov '21

Hello build bot (Jenkins), Jeremy Soller, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52296 to look at the new patch set (#14). Change subject: mb/system76/oryp6: Add Oryx Pro 7 as a variant ...................................................................... mb/system76/oryp6: Add Oryx Pro 7 as a variant Change-Id: Id00a45a6a6acf0880934c55f1a3f18e63f2aed43 Signed-off-by: Jeremy Soller <jeremy(a)system76.com> Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M Documentation/mainboard/index.md A Documentation/mainboard/system76/oryp7.md M src/mainboard/system76/oryp6/Kconfig M src/mainboard/system76/oryp6/Kconfig.name M src/mainboard/system76/oryp6/Makefile.inc A src/mainboard/system76/oryp6/include/variant/romstage.h M src/mainboard/system76/oryp6/romstage.c A src/mainboard/system76/oryp6/variants/oryp6/romstage.c A src/mainboard/system76/oryp6/variants/oryp7/board_info.txt A src/mainboard/system76/oryp6/variants/oryp7/data.vbt A src/mainboard/system76/oryp6/variants/oryp7/gpio.c A src/mainboard/system76/oryp6/variants/oryp7/gpio_early.c A src/mainboard/system76/oryp6/variants/oryp7/hda_verb.c A src/mainboard/system76/oryp6/variants/oryp7/overridetree.cb A src/mainboard/system76/oryp6/variants/oryp7/romstage.c 15 files changed, 437 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/52296/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/52296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id00a45a6a6acf0880934c55f1a3f18e63f2aed43 Gerrit-Change-Number: 52296 Gerrit-PatchSet: 14 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeremy Soller <jeremy(a)system76.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/system76/oryp6: Convert to variant setup
by Tim Crawford (Code Review) 02 Nov '21

02 Nov '21

Hello build bot (Jenkins), Jeremy Soller, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57786 to look at the new patch set (#5). Change subject: mb/system76/oryp6: Convert to variant setup ...................................................................... mb/system76/oryp6: Convert to variant setup The Oryx Pro 6 has the same board layout as the next model in series, Oryx Pro 7. The primary difference between the two is the dGPU (20 series to 30 series). Convert oryp6 to a variant setup in preparation for adding the oryp7. Change-Id: I976750c7724d23b303d0012f2d83c21a459e5eed Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/oryp6/Kconfig M src/mainboard/system76/oryp6/Makefile.inc M src/mainboard/system76/oryp6/board_info.txt M src/mainboard/system76/oryp6/bootblock.c M src/mainboard/system76/oryp6/devicetree.cb M src/mainboard/system76/oryp6/dsdt.asl D src/mainboard/system76/oryp6/include/mainboard/gpio.h A src/mainboard/system76/oryp6/include/variant/gpio.h M src/mainboard/system76/oryp6/ramstage.c A src/mainboard/system76/oryp6/variants/oryp6/board_info.txt R src/mainboard/system76/oryp6/variants/oryp6/data.vbt R src/mainboard/system76/oryp6/variants/oryp6/gpio.c R src/mainboard/system76/oryp6/variants/oryp6/gpio_early.c R src/mainboard/system76/oryp6/variants/oryp6/hda_verb.c A src/mainboard/system76/oryp6/variants/oryp6/overridetree.cb 15 files changed, 52 insertions(+), 46 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/57786/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/57786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I976750c7724d23b303d0012f2d83c21a459e5eed Gerrit-Change-Number: 57786 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/system76/kbl-u: Add System76 Galago Pro 3 Rev B
by Tim Crawford (Code Review) 02 Nov '21

02 Nov '21

Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52217 ) Change subject: mb/system76/kbl-u: Add System76 Galago Pro 3 Rev B ...................................................................... Patch Set 10: (1 comment) File src/mainboard/system76/kbl-u/cmos.layout: https://review.coreboot.org/c/coreboot/+/52217/comment/ef686ecf_4348b933 PS9, Line 14: 409 2 e 7 power_on_after_fail > I will remove it here. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/52217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25464d3a2dd02e613a8392db90b1eaf0f9b3ca70 Gerrit-Change-Number: 52217 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeremy Soller <jeremy(a)system76.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 02 Nov 2021 14:19:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com> Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/system76/kbl-u: Add System76 Galago Pro 3 Rev B
by Tim Crawford (Code Review) 02 Nov '21

02 Nov '21

Hello build bot (Jenkins), Patrick Georgi, Jeremy Soller, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52217 to look at the new patch set (#10). Change subject: mb/system76/kbl-u: Add System76 Galago Pro 3 Rev B ...................................................................... mb/system76/kbl-u: Add System76 Galago Pro 3 Rev B Change-Id: I25464d3a2dd02e613a8392db90b1eaf0f9b3ca70 Signed-off-by: Jeremy Soller <jeremy(a)system76.com> Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- A src/mainboard/system76/kbl-u/Kconfig A src/mainboard/system76/kbl-u/Kconfig.name A src/mainboard/system76/kbl-u/Makefile.inc A src/mainboard/system76/kbl-u/acpi/ac.asl A src/mainboard/system76/kbl-u/acpi/battery.asl A src/mainboard/system76/kbl-u/acpi/buttons.asl A src/mainboard/system76/kbl-u/acpi/ec.asl A src/mainboard/system76/kbl-u/acpi/ec_ram.asl A src/mainboard/system76/kbl-u/acpi/gpe.asl A src/mainboard/system76/kbl-u/acpi/hid.asl A src/mainboard/system76/kbl-u/acpi/lid.asl A src/mainboard/system76/kbl-u/acpi/mainboard.asl A src/mainboard/system76/kbl-u/acpi/s76.asl A src/mainboard/system76/kbl-u/acpi/sleep.asl A src/mainboard/system76/kbl-u/acpi/superio.asl A src/mainboard/system76/kbl-u/board_info.txt A src/mainboard/system76/kbl-u/bootblock.c A src/mainboard/system76/kbl-u/cmos.default A src/mainboard/system76/kbl-u/cmos.layout A src/mainboard/system76/kbl-u/devicetree.cb A src/mainboard/system76/kbl-u/dsdt.asl A src/mainboard/system76/kbl-u/gpio.c A src/mainboard/system76/kbl-u/gpio_early.c A src/mainboard/system76/kbl-u/include/mainboard/gpio.h A src/mainboard/system76/kbl-u/ramstage.c A src/mainboard/system76/kbl-u/romstage.c A src/mainboard/system76/kbl-u/variants/galp3-b/data.vbt A src/mainboard/system76/kbl-u/variants/galp3-b/hda_verb.c A src/mainboard/system76/kbl-u/variants/galp3-b/overridetree.cb 29 files changed, 1,445 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/52217/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/52217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25464d3a2dd02e613a8392db90b1eaf0f9b3ca70 Gerrit-Change-Number: 52217 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeremy Soller <jeremy(a)system76.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/system76/oryp6: Convert to variant setup
by Tim Crawford (Code Review) 02 Nov '21

02 Nov '21

Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57786 ) Change subject: mb/system76/oryp6: Convert to variant setup ...................................................................... Patch Set 4: (1 comment) File src/mainboard/system76/oryp6/Kconfig: https://review.coreboot.org/c/coreboot/+/57786/comment/128ac107_1253f89c PS4, Line 26: select TPM_RDRESP_NEED_DELAY > This doesn't look like part of the variants shuffling to me, where is this coming from? We have it selected downstream for both boards. If it's a problem, I can put it in the oryp7 change instead. We've had problems with this chip on a couple of other boards, so we'd rather have a delay than a potentially not working TPM chip. -- To view, visit https://review.coreboot.org/c/coreboot/+/57786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I976750c7724d23b303d0012f2d83c21a459e5eed Gerrit-Change-Number: 57786 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Tue, 02 Nov 2021 14:16:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/system76/kbl-u: Add System76 Galago Pro 3 Rev B
by Tim Crawford (Code Review) 02 Nov '21

02 Nov '21

Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52217 ) Change subject: mb/system76/kbl-u: Add System76 Galago Pro 3 Rev B ...................................................................... Patch Set 9: (1 comment) File src/mainboard/system76/kbl-u/cmos.layout: https://review.coreboot.org/c/coreboot/+/52217/comment/1340ab49_4e1cac5c PS9, Line 14: 409 2 e 7 power_on_after_fail > CB:58673 just got rid of this for your other boards. […] I will remove it here. -- To view, visit https://review.coreboot.org/c/coreboot/+/52217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25464d3a2dd02e613a8392db90b1eaf0f9b3ca70 Gerrit-Change-Number: 52217 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 02 Nov 2021 14:08:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021