coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: Documentation/releases: Update index.md
by Felix Singer (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Martin Roth, Jason Glenesk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59058 ) Change subject: Documentation/releases: Update index.md ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59058/comment/b45f69ec_3dafed99 PS1, Line 9: upcoming That might be a little bit confusing. I would use 4.16 here, otherwise one could understand this as 4.15. -- To view, visit https://review.coreboot.org/c/coreboot/+/59058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ff5849cb4b7bd3bc6c1d91637536b6e94d92a1a Gerrit-Change-Number: 59058 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 09 Nov 2021 21:57:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Matt DeVillier, Paul Menzel, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 37: (23 comments) File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/4ac1612c_efda71fe PS37, Line 13: using Parameters = QMap < QString,QString >; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/ceb93996_2f3ff452 PS37, Line 13: using Parameters = QMap < QString,QString >; spaces required around that '>' (ctx:WxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/903dc62b_b775edc7 PS37, Line 16: bool toFile(const QString & curr_path, const Parameters & params); function definition argument 'const Parameters' should also have an identifier name File util/coreboot-configurator/src/application/nvramtoolcli.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/6757df3f_0236ff1f PS37, Line 19: bool writeParameters(const Configuration::Parameters & parameters, function definition argument 'Parameters' should also have an identifier name File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/cdf58443_fbea1481 PS37, Line 20: static Node encode(const QString & rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/0962fd52_f0c16dfe PS37, Line 25: static bool decode(const Node & node, QString & rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/33fa61a5_5d0e769b PS37, Line 38: static Node encode(const QMap < Key,Value > &rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/12203ef6_37a526f9 PS37, Line 38: static Node encode(const QMap < Key,Value > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/70a41fb8_2944415a PS37, Line 49: static bool decode(const Node & node, QMap < Key, Value > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/f2424240_3d3311b0 PS37, Line 68: static Node encode(const QVector < T > & rhs) space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/871b6ce4_98b586e5 PS37, Line 68: static Node encode(const QVector < T > & rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/497b3e81_65eb652c PS37, Line 77: static bool decode(const Node & node, QVector < T > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/c43f4b78_ddb2759d PS37, Line 96: static Node encode(const QList < T > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/22c09272_f79fcc84 PS37, Line 99: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/1c539ca6_5457e812 PS37, Line 105: static bool decode(const Node & node, QList < T > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/c3b0be19_e78f62ca PS37, Line 124: static Node encode(const QPair < T, U > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/7bbb12eb_e3ca976e PS37, Line 133: static bool decode(const Node & node, QPair < T, U > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/d4795044_0d6aee1f PS37, Line 150: static Node encode(const QStringList & rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/011220e0_e815c950 PS37, Line 153: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/749fc95f_48dbb191 PS37, Line 153: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/ef3930b2_c08e301e PS37, Line 153: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/f0c9f701_8bb534c0 PS37, Line 159: static bool decode(const Node & node, QStringList & rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132749): https://review.coreboot.org/c/coreboot/+/58854/comment/fd17d55e_3db1a2eb PS37, Line 166: while (it != node.end()) that open brace { should be on the previous line -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 37 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Tue, 09 Nov 2021 21:57:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by Sean Rhodes (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Matt DeVillier, Paul Menzel, Tim Wawrzynczak, Angel Pons. Hello build bot (Jenkins), Martin Roth, Matt DeVillier, Tim Wawrzynczak, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58854 to look at the new patch set (#37). Change subject: [WIP] util: Add coreboot Configurator ...................................................................... [WIP] util: Add coreboot Configurator A simple GUI to change settings in coreboot's CBFS, via the nvramtool utility. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 --- A util/coreboot-configurator/README.md A util/coreboot-configurator/contrib/PKGBUILD A util/coreboot-configurator/contrib/README.md A util/coreboot-configurator/contrib/debian/changelog A util/coreboot-configurator/contrib/debian/compat A util/coreboot-configurator/contrib/debian/control A util/coreboot-configurator/contrib/debian/files A util/coreboot-configurator/contrib/debian/rules A util/coreboot-configurator/contrib/debian/source/format A util/coreboot-configurator/contrib/flatpak/coreboot-configurator.json A util/coreboot-configurator/contrib/flatpak/org.coreboot.coreboot-configurator.json A util/coreboot-configurator/meson.build A util/coreboot-configurator/meson_options.txt A util/coreboot-configurator/screenshots/coreboot-configurator.gif A util/coreboot-configurator/screenshots/coreboot-configurator.png A util/coreboot-configurator/src/application/aboutwindow.cpp A util/coreboot-configurator/src/application/aboutwindow.h A util/coreboot-configurator/src/application/aboutwindow.ui A util/coreboot-configurator/src/application/categories.yaml A util/coreboot-configurator/src/application/configuration.cpp A util/coreboot-configurator/src/application/configuration.h A util/coreboot-configurator/src/application/corebootconfigurator.cpp A util/coreboot-configurator/src/application/corebootconfigurator.h A util/coreboot-configurator/src/application/corebootconfigurator.ui A util/coreboot-configurator/src/application/images.qrc A util/coreboot-configurator/src/application/main.cpp A util/coreboot-configurator/src/application/meson.build A util/coreboot-configurator/src/application/nvramtoolcli.cpp A util/coreboot-configurator/src/application/nvramtoolcli.h A util/coreboot-configurator/src/application/qtyaml.h A util/coreboot-configurator/src/application/toggle-off.svg A util/coreboot-configurator/src/application/toggle-on.svg A util/coreboot-configurator/src/application/toggleswitch.cpp A util/coreboot-configurator/src/application/toggleswitch.h A util/coreboot-configurator/src/application/util.h A util/coreboot-configurator/src/meson.build A util/coreboot-configurator/src/static/aboutIcon.png A util/coreboot-configurator/src/static/categories.yaml A util/coreboot-configurator/src/static/coreboot-configurator.desktop A util/coreboot-configurator/src/static/coreboot_configurator.svg A util/coreboot-configurator/src/static/meson.build A util/coreboot-configurator/src/static/org.coreboot.nvramtool.policy A util/coreboot-configurator/src/static/org.coreboot.reboot.policy 43 files changed, 3,171 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/58854/37 -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 37 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: treewide: Remove unused spinlock functions
by Raul Rangel (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Jason Glenesk, Nico Huber, Marshall Dawson, Julius Werner, Kyösti Mälkki, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59020 ) Change subject: treewide: Remove unused spinlock functions ...................................................................... Patch Set 2: (3 comments) File src/arch/x86/include/arch/smp/spinlock.h: https://review.coreboot.org/c/coreboot/+/59020/comment/fcb780bc_849d65eb PS2, Line 31: #define barrier() __asm__ __volatile__("" : : : "memory") > In CB:43810 you said it doesn't belong here. […] Ack File src/soc/amd/common/psp_verstage/include/arch/smp/spinlock.h: https://review.coreboot.org/c/coreboot/+/59020/comment/77efc16f_aee1b4be PS2, Line 8: #define spin_unlock(lock) do {} while (0) > You can't have <smp/spinlock. […] Martin, Furquan and Aaron are no longer working on firmware. Building a zork board should trigger the failure. Here is the failure when deleting this file: ``` In file included from src/drivers/pc80/rtc/post.c:8: src/include/smp/spinlock.h:5:10: fatal error: arch/smp/spinlock.h: No such file or directory 5 | #include <arch/smp/spinlock.h> | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. make: *** [Makefile:380: /tmp/coreboot/guybrush/verstage/drivers/pc80/rtc/post.o] Error 1 ``` I suspect that its caused by the `all-` here: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thi… As for this CL, It's just cleaning up unused functions. This CL + https://review.coreboot.org/c/coreboot/+/59069 leaves this file pretty empty. I'm going to resolve this comment since I'm not planning on untangling this any more. I don't have the time. https://review.coreboot.org/c/coreboot/+/59020/comment/117a9ebe_186f2b5f PS2, Line 11: #define boot_cpu() 1 > no idea. this was copied from the arm spinlock.h. I removed it here: https://review.coreboot.org/c/coreboot/+/59069 -- To view, visit https://review.coreboot.org/c/coreboot/+/59020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e9a742e6b311d972a260039401bfd8f8766dd36 Gerrit-Change-Number: 59020 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 09 Nov 2021 21:47:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/psp_verstage: Remove confusing boot_cpu()
by Raul Rangel (Code Review) 09 Nov '21

09 Nov '21

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59069 ) Change subject: soc/amd/common/psp_verstage: Remove confusing boot_cpu() ...................................................................... soc/amd/common/psp_verstage: Remove confusing boot_cpu() This function is not needed for psp_verstage. BUG=b:179699789 TEST=Build guybrush PSP verstage Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: If4e0604b37f036dcf07debbd8d796d7a493dbd30 --- M src/soc/amd/common/psp_verstage/include/arch/smp/spinlock.h 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/59069/1 diff --git a/src/soc/amd/common/psp_verstage/include/arch/smp/spinlock.h b/src/soc/amd/common/psp_verstage/include/arch/smp/spinlock.h index 0a3a4d4..d7b6004 100644 --- a/src/soc/amd/common/psp_verstage/include/arch/smp/spinlock.h +++ b/src/soc/amd/common/psp_verstage/include/arch/smp/spinlock.h @@ -9,7 +9,4 @@ #define spin_lock(lock) do {} while (0) #define spin_unlock(lock) do {} while (0) -#include <smp/node.h> -#define boot_cpu() 1 - #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/59069 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4e0604b37f036dcf07debbd8d796d7a493dbd30 Gerrit-Change-Number: 59069 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/tigerlake/apci: Only use SCM for ChromeOS
by Tim Crawford (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Felix Singer, Sean Rhodes, Tim Wawrzynczak, Paul Menzel, Patrick Rudolph. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58798 ) Change subject: soc/intel/tigerlake/apci: Only use SCM for ChromeOS ...................................................................... Patch Set 12: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58798/comment/23fb0cb0_3d461b13 PS11, Line 15: Orpy8 > I was just looking it up! Is Oryx Pro 8 right? Yes -- To view, visit https://review.coreboot.org/c/coreboot/+/58798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e Gerrit-Change-Number: 58798 Gerrit-PatchSet: 12 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 09 Nov 2021 21:27:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com> Comment-In-Reply-To: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake/apci: Only use SCM for ChromeOS
by Sean Rhodes (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Felix Singer, Tim Crawford, Tim Wawrzynczak, Paul Menzel, Patrick Rudolph. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58798 ) Change subject: soc/intel/tigerlake/apci: Only use SCM for ChromeOS ...................................................................... Patch Set 12: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58798/comment/7c487777_84fecd53 PS9, Line 9: Linux 5.13 or later > c6da62a219d0 ("thunderbolt: Add support for native USB4 _OSC") […] Done https://review.coreboot.org/c/coreboot/+/58798/comment/fe9184ad_50f3d143 PS9, Line 12: > Tested on what device? Done Commit Message: https://review.coreboot.org/c/coreboot/+/58798/comment/8f581a97_ef6582e4 PS11, Line 15: Orpy8 > oryp8 I was just looking it up! Is Oryx Pro 8 right? Patchset: PS5: > This is probably `_PR3` right? Including the `_PR3` method indicates support for D3cold in the lates […] That would've been far too easy ;) CB:59024 -- To view, visit https://review.coreboot.org/c/coreboot/+/58798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e Gerrit-Change-Number: 58798 Gerrit-PatchSet: 12 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 09 Nov 2021 21:23:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com> Comment-In-Reply-To: Sean Rhodes <admin(a)starlabs.systems> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake/apci: Only use SCM for ChromeOS
by Sean Rhodes (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Felix Singer, Sean Rhodes, Paul Menzel, Patrick Rudolph. Hello build bot (Jenkins), Tim Crawford, Jeremy Soller, Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58798 to look at the new patch set (#12). Change subject: soc/intel/tigerlake/apci: Only use SCM for ChromeOS ...................................................................... soc/intel/tigerlake/apci: Only use SCM for ChromeOS Software Connection Manager doesn't work with Linux 5.13 or later and results in TBT ports timing out. Not advertising this results in Firmware Connection Manager being used and TBT works correctly. Linux patch: https://github.com/torvalds/linux/commit/c6da62a219d028de10f2e22e93a34c7ee2… Tested on: * StarBook Mk V * System76 Oryx Pro 8 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/58798/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/58798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e Gerrit-Change-Number: 58798 Gerrit-PatchSet: 12 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation/releases: Update index.md
by Jason Glenesk (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Felix Singer, Martin Roth. Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59058 ) Change subject: Documentation/releases: Update index.md ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Please help to review this. -- To view, visit https://review.coreboot.org/c/coreboot/+/59058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ff5849cb4b7bd3bc6c1d91637536b6e94d92a1a Gerrit-Change-Number: 59058 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 09 Nov 2021 21:17:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/releases: Update index.md
by Jason Glenesk (Code Review) 09 Nov '21

09 Nov '21

Jason Glenesk has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59058 ) Change subject: Documentation/releases: Update index.md ...................................................................... Documentation/releases: Update index.md Fix date for upcoming release. Change-Id: I6ff5849cb4b7bd3bc6c1d91637536b6e94d92a1a Signed-off-by: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> --- M Documentation/releases/index.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/59058/1 diff --git a/Documentation/releases/index.md b/Documentation/releases/index.md index 157f631..16d2fef 100644 --- a/Documentation/releases/index.md +++ b/Documentation/releases/index.md @@ -27,4 +27,4 @@ ---------------- Please add to the release notes as changes are added: -* [4.16 - May 2022](coreboot-4.16-relnotes.md) +* [4.16 - Feb 2022](coreboot-4.16-relnotes.md) -- To view, visit https://review.coreboot.org/c/coreboot/+/59058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ff5849cb4b7bd3bc6c1d91637536b6e94d92a1a Gerrit-Change-Number: 59058 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021