coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: soc/amd/cezanne/fsp_m_parameters: add curly braces around else block
by Felix Held (Code Review) 10 Nov '21

10 Nov '21

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59070 ) Change subject: soc/amd/cezanne/fsp_m_parameters: add curly braces around else block ...................................................................... soc/amd/cezanne/fsp_m_parameters: add curly braces around else block Since the if block contains multiple statements, it uses curly braces around them, so also add curly braces around the else block even though it only contains one statement. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ia8d6b45ec16916ff77078446414de259cffa1475 --- M src/soc/amd/cezanne/fsp_m_params.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/59070/1 diff --git a/src/soc/amd/cezanne/fsp_m_params.c b/src/soc/amd/cezanne/fsp_m_params.c index 9f594d9..1a2c6d9 100644 --- a/src/soc/amd/cezanne/fsp_m_params.c +++ b/src/soc/amd/cezanne/fsp_m_params.c @@ -153,9 +153,9 @@ mcfg->usb_phy->Version_Major = 0xd; mcfg->usb_phy->Version_Minor = 0x6; mcfg->usb_phy->TableLength = 100; - } - else + } else { mcfg->usb_phy = NULL; + } fsp_fill_pcie_ddi_descriptors(mcfg); fsp_assign_ioapic_upds(mcfg); -- To view, visit https://review.coreboot.org/c/coreboot/+/59070 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d6b45ec16916ff77078446414de259cffa1475 Gerrit-Change-Number: 59070 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: treewide: Remove unused spinlock functions
by Raul Rangel (Code Review) 10 Nov '21

10 Nov '21

Attention is currently required from: Jason Glenesk, Nico Huber, Marshall Dawson, Julius Werner, Kyösti Mälkki, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59020 ) Change subject: treewide: Remove unused spinlock functions ...................................................................... Patch Set 2: (1 comment) File src/soc/amd/common/psp_verstage/include/arch/smp/spinlock.h: https://review.coreboot.org/c/coreboot/+/59020/comment/db7eeebb_53994ae3 PS2, Line 8: #define spin_unlock(lock) do {} while (0) > Martin, Furquan and Aaron are no longer working on firmware. […] Just FYI, the following diff allows the psp_verstage spinlock.h to be removed: diff --git a/src/drivers/pc80/rtc/Makefile.inc b/src/drivers/pc80/rtc/Makefile.inc index 5f6055e872bc..12aeb3724d86 100644 --- a/src/drivers/pc80/rtc/Makefile.inc +++ b/src/drivers/pc80/rtc/Makefile.inc @@ -8,7 +8,14 @@ smm-$(CONFIG_DRIVERS_MC146818) += mc146818rtc.c all-$(CONFIG_USE_OPTION_TABLE) += option.c smm-$(CONFIG_USE_OPTION_TABLE) += option.c -all-$(CONFIG_CMOS_POST) += post.c +ifeq ($(CONFIG_CMOS_POST),y) +bootblock-y += post.c +verstage_x86-y += post.c +romstage-y += post.c +postcar-y += post.c +ramstage-y += post.c +smm-y += post.c +endif ifeq ($(CONFIG_USE_OPTION_TABLE),y) cbfs-files-$(CONFIG_HAVE_CMOS_DEFAULT) += cmos.default --- The patch isn't correct though since there is no reason post.c shouldn't work in psp verstage. -- To view, visit https://review.coreboot.org/c/coreboot/+/59020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e9a742e6b311d972a260039401bfd8f8766dd36 Gerrit-Change-Number: 59020 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 09 Nov 2021 23:14:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/psp_verstage: Remove confusing boot_cpu()
by Felix Held (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59069 ) Change subject: soc/amd/common/psp_verstage: Remove confusing boot_cpu() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59069 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4e0604b37f036dcf07debbd8d796d7a493dbd30 Gerrit-Change-Number: 59069 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Tue, 09 Nov 2021 22:42:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/cezanne,picasso/include/southbridge: use bitwise or in defines
by Raul Rangel (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59030 ) Change subject: soc/amd/cezanne,picasso/include/southbridge: use bitwise or in defines ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42cc6686d8fa3f694a46ba4ca801a822ef1db1d7 Gerrit-Change-Number: 59030 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 09 Nov 2021 22:39:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/spd_tools: Document adding support for a new memory technology
by Karthik Ramasubramanian (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Reka Norman, Tim Wawrzynczak, Nick Vaccaro. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59005 ) Change subject: util/spd_tools: Document adding support for a new memory technology ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie710c1c686ddf5288db35cf43e5f1ac9b1974305 Gerrit-Change-Number: 59005 Gerrit-PatchSet: 5 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 09 Nov 2021 22:29:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/spd_tools: Document adding support for a new memory technology
by Reka Norman (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59005 ) Change subject: util/spd_tools: Document adding support for a new memory technology ...................................................................... Patch Set 5: (1 comment) File util/spd_tools/src/spd_gen/spd_gen.go: https://review.coreboot.org/c/coreboot/+/59005/comment/dd70183f_fb0329ed PS4, Line 54: number of SPD bytes > suggestion: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie710c1c686ddf5288db35cf43e5f1ac9b1974305 Gerrit-Change-Number: 59005 Gerrit-PatchSet: 5 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 09 Nov 2021 22:21:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/spd_tools: Document adding support for a new memory technology
by Reka Norman (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Reka Norman, Nick Vaccaro. Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59005 to look at the new patch set (#5). Change subject: util/spd_tools: Document adding support for a new memory technology ...................................................................... util/spd_tools: Document adding support for a new memory technology Add documentation describing how to add support for a new memory technology to spd_tools: - Add a section to the README. - Document the memTech interface in spd_gen.go. BUG=b:191776301 TEST=None Signed-off-by: Reka Norman <rekanorman(a)google.com> Change-Id: Ie710c1c686ddf5288db35cf43e5f1ac9b1974305 --- M util/spd_tools/README.md M util/spd_tools/src/spd_gen/spd_gen.go 2 files changed, 72 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/59005/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/59005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie710c1c686ddf5288db35cf43e5f1ac9b1974305 Gerrit-Change-Number: 59005 Gerrit-PatchSet: 5 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/*/me.c: Always print registers if me_state
by Sean Rhodes (Code Review) 09 Nov '21

09 Nov '21

Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/58149 ) Change subject: soc/intel/*/me.c: Always print registers if me_state ...................................................................... Abandoned Seems to be behaving now... -- To view, visit https://review.coreboot.org/c/coreboot/+/58149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ad1215cceb75651b7890f3bab5df39b1b72ecf6 Gerrit-Change-Number: 58149 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/intel: Allow enable/disable ME via CMOS
by Sean Rhodes (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Tim Crawford, SRIDHAR SIRICILLA, Furquan Shaikh, Paul Menzel, Rizwan Qureshi, Angel Pons, Subrata Banik, Sridhar Siricilla, Arthur Heymans, Evgeny Zinoviev, Patrick Rudolph, Felix Held. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 ) Change subject: soc/intel: Allow enable/disable ME via CMOS ...................................................................... Patch Set 85: (1 comment) Patchset: PS81: > @Tim: would be good if you can have another look at the patch. […] Which Tim did you mean? (Hint hint :D ) -- To view, visit https://review.coreboot.org/c/coreboot/+/52800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I374db3b7c0ded71cdc18f27970252fec7220cc20 Gerrit-Change-Number: 52800 Gerrit-PatchSet: 85 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: SRIDHAR SIRICILLA Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: SRIDHAR SIRICILLA Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 09 Nov 2021 22:04:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] util: Add coreboot Configurator
by build bot (Jenkins) (Code Review) 09 Nov '21

09 Nov '21

Attention is currently required from: Sean Rhodes, Martin Roth, Matt DeVillier, Paul Menzel, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 ) Change subject: [WIP] util: Add coreboot Configurator ...................................................................... Patch Set 38: (23 comments) File util/coreboot-configurator/src/application/configuration.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/9f3e0635_c5a218c5 PS38, Line 13: using Parameters = QMap < QString,QString >; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/75788106_aa8532d4 PS38, Line 13: using Parameters = QMap < QString,QString >; spaces required around that '>' (ctx:WxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/c6cb2414_8108c84b PS38, Line 16: bool toFile(const QString & curr_path, const Parameters & params); function definition argument 'const Parameters' should also have an identifier name File util/coreboot-configurator/src/application/nvramtoolcli.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/72dc2881_c3ede9b9 PS38, Line 19: bool writeParameters(const Configuration::Parameters & parameters, function definition argument 'Parameters' should also have an identifier name File util/coreboot-configurator/src/application/qtyaml.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/03108f77_457eb8b9 PS38, Line 20: static Node encode(const QString & rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/adcf54b1_d9831271 PS38, Line 25: static bool decode(const Node & node, QString & rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/a50e1948_3ade44ef PS38, Line 38: static Node encode(const QMap < Key,Value > &rhs) space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/43f59acf_e7d63373 PS38, Line 38: static Node encode(const QMap < Key,Value > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/71246b8e_454f7cad PS38, Line 49: static bool decode(const Node & node, QMap < Key, Value > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/82c3f2b5_773d8981 PS38, Line 68: static Node encode(const QVector < T > & rhs) space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/bb69ebb9_6ff663b8 PS38, Line 68: static Node encode(const QVector < T > & rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/977998f5_13fbf924 PS38, Line 77: static bool decode(const Node & node, QVector < T > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/e69d98d6_51d4b006 PS38, Line 96: static Node encode(const QList < T > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/5706fa2a_adbca75b PS38, Line 99: foreach (T value, rhs) { space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/4155bb7b_3c95f6cf PS38, Line 105: static bool decode(const Node & node, QList < T > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/22348d1e_726858e7 PS38, Line 124: static Node encode(const QPair < T, U > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/1af6cb88_0bfb2213 PS38, Line 133: static bool decode(const Node & node, QPair < T, U > &rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/7ff5bba3_1b1bec1e PS38, Line 150: static Node encode(const QStringList & rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/07345312_1a30e2b9 PS38, Line 153: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/d74387e3_261f403c PS38, Line 153: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/73389c07_5c772b47 PS38, Line 153: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/f4d08991_c899997e PS38, Line 159: static bool decode(const Node & node, QStringList & rhs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132750): https://review.coreboot.org/c/coreboot/+/58854/comment/9bb8d33c_ad9fd1c7 PS38, Line 166: while (it != node.end()) that open brace { should be on the previous line -- To view, visit https://review.coreboot.org/c/coreboot/+/58854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1 Gerrit-Change-Number: 58854 Gerrit-PatchSet: 38 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Tue, 09 Nov 2021 21:58:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021