Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59244 )
Change subject: soc/mediatek: change help text of FLASH_DUAL_READ
......................................................................
soc/mediatek: change help text of FLASH_DUAL_READ
Change help text to "dual IO read mode" to reduce noun confusion.
Suggestion from this comment:
https://review.coreboot.org/c/coreboot/+/58837/comment/40a98af1_dce6bb2b/
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: I54b81cdeba3b693451f66e003fb470c9f8c19ad9
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59244
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Yu-Ping Wu <yupingso(a)google.com>
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M src/soc/mediatek/mt8186/Kconfig
M src/soc/mediatek/mt8192/Kconfig
M src/soc/mediatek/mt8195/Kconfig
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Held: Looks good to me, approved
Yu-Ping Wu: Looks good to me, approved
diff --git a/src/soc/mediatek/mt8186/Kconfig b/src/soc/mediatek/mt8186/Kconfig
index 1821fa9..9b8708a 100644
--- a/src/soc/mediatek/mt8186/Kconfig
+++ b/src/soc/mediatek/mt8186/Kconfig
@@ -21,6 +21,6 @@
default y
help
When this option is enabled, the flash controller provides the ability
- to dual read mode.
+ to dual IO read mode.
endif
diff --git a/src/soc/mediatek/mt8192/Kconfig b/src/soc/mediatek/mt8192/Kconfig
index e099ffd..9b55295 100644
--- a/src/soc/mediatek/mt8192/Kconfig
+++ b/src/soc/mediatek/mt8192/Kconfig
@@ -55,7 +55,7 @@
default y
help
When this option is enabled, the flash controller provides the ability
- to dual read mode.
+ to dual IO read mode.
config SRCLKEN_RC_SUPPORT
bool
diff --git a/src/soc/mediatek/mt8195/Kconfig b/src/soc/mediatek/mt8195/Kconfig
index b96ccd8..d1cb09b 100644
--- a/src/soc/mediatek/mt8195/Kconfig
+++ b/src/soc/mediatek/mt8195/Kconfig
@@ -54,6 +54,6 @@
default y
help
When this option is enabled, the flash controller provides the ability
- to dual read mode.
+ to dual IO read mode.
endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/59244
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54b81cdeba3b693451f66e003fb470c9f8c19ad9
Gerrit-Change-Number: 59244
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Hung-Te Lin.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59255 )
Change subject: mb/google/corsola: Add VMCH and VMC for regulator interface
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
@Hung-Te,
can we merge all these patches inside review ToT?
Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/59255
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50fc87415086eb22ff35d157dba38cfd7594cc40
Gerrit-Change-Number: 59255
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Comment-Date: Mon, 15 Nov 2021 03:03:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment