Attention is currently required from: Hung-Te Lin.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59294 )
Change subject: soc/mediatek/mt8186: add early initialization for eMMC
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8186/msdc.c:
https://review.coreboot.org/c/coreboot/+/59294/comment/3556c82a_ecf9178b
PS2, Line 62: mtk_emmc_early_init((void *)MSDC0_BASE, (void *)MSDC0_TOP_BASE);
> give this is a board-specific feature (e.g. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/59294
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bc06b1fc506b1d6f54f7f456117d22477a87e29
Gerrit-Change-Number: 59294
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Comment-Date: Mon, 15 Nov 2021 07:03:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Rex-BC Chen.
Hello Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59294
to look at the new patch set (#3).
Change subject: soc/mediatek/mt8186: add early initialization for eMMC
......................................................................
soc/mediatek/mt8186: add early initialization for eMMC
Some eMMCs need 80+ms for CMD1 to complete. And the payload may need to
access eMMC in the very early stage (for example, depthcharge needs it
20ms after started) so we have to start initialization in coreboot.
TEST=boot kernel from eMMC ok
BUG=b:202871018
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: I3bc06b1fc506b1d6f54f7f456117d22477a87e29
---
M src/mainboard/google/corsola/mainboard.c
M src/soc/mediatek/common/include/soc/msdc.h
M src/soc/mediatek/mt8186/msdc.c
3 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/59294/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/59294
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bc06b1fc506b1d6f54f7f456117d22477a87e29
Gerrit-Change-Number: 59294
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Reka Norman has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59297 )
Change subject: util/mb/google: Change comments in memory Makefile.inc templates
......................................................................
util/mb/google: Change comments in memory Makefile.inc templates
Begin comments with # instead of ## to match the Makefile.inc generated
by spd_tools.
BUG=None
TEST=None
Signed-off-by: Reka Norman <rekanorman(a)google.com>
Change-Id: If2d716a7338fd5af8216b2bcd894fc88a9df137e
---
M util/mainboard/google/brya0/template/memory/Makefile.inc
M util/mainboard/google/dalboz/template/spd/Makefile.inc
M util/mainboard/google/guybrush/template/memory/Makefile.inc
M util/mainboard/google/trembyle/template/spd/Makefile.inc
M util/mainboard/google/volteer/template/memory/Makefile.inc
M util/mainboard/google/waddledee/template/memory/Makefile.inc
M util/mainboard/google/waddledoo/template/memory/Makefile.inc
7 files changed, 21 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/59297/1
diff --git a/util/mainboard/google/brya0/template/memory/Makefile.inc b/util/mainboard/google/brya0/template/memory/Makefile.inc
index 6751a42..eace2e4 100644
--- a/util/mainboard/google/brya0/template/memory/Makefile.inc
+++ b/util/mainboard/google/brya0/template/memory/Makefile.inc
@@ -1,5 +1,5 @@
-## SPDX-License-Identifier: GPL-2.0-or-later
-## This is an auto-generated file. Do not edit!!
-## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
SPD_SOURCES = placeholder
diff --git a/util/mainboard/google/dalboz/template/spd/Makefile.inc b/util/mainboard/google/dalboz/template/spd/Makefile.inc
index 6751a42..eace2e4 100644
--- a/util/mainboard/google/dalboz/template/spd/Makefile.inc
+++ b/util/mainboard/google/dalboz/template/spd/Makefile.inc
@@ -1,5 +1,5 @@
-## SPDX-License-Identifier: GPL-2.0-or-later
-## This is an auto-generated file. Do not edit!!
-## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
SPD_SOURCES = placeholder
diff --git a/util/mainboard/google/guybrush/template/memory/Makefile.inc b/util/mainboard/google/guybrush/template/memory/Makefile.inc
index 6751a42..eace2e4 100644
--- a/util/mainboard/google/guybrush/template/memory/Makefile.inc
+++ b/util/mainboard/google/guybrush/template/memory/Makefile.inc
@@ -1,5 +1,5 @@
-## SPDX-License-Identifier: GPL-2.0-or-later
-## This is an auto-generated file. Do not edit!!
-## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
SPD_SOURCES = placeholder
diff --git a/util/mainboard/google/trembyle/template/spd/Makefile.inc b/util/mainboard/google/trembyle/template/spd/Makefile.inc
index 6751a42..eace2e4 100644
--- a/util/mainboard/google/trembyle/template/spd/Makefile.inc
+++ b/util/mainboard/google/trembyle/template/spd/Makefile.inc
@@ -1,5 +1,5 @@
-## SPDX-License-Identifier: GPL-2.0-or-later
-## This is an auto-generated file. Do not edit!!
-## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
SPD_SOURCES = placeholder
diff --git a/util/mainboard/google/volteer/template/memory/Makefile.inc b/util/mainboard/google/volteer/template/memory/Makefile.inc
index 6751a42..eace2e4 100644
--- a/util/mainboard/google/volteer/template/memory/Makefile.inc
+++ b/util/mainboard/google/volteer/template/memory/Makefile.inc
@@ -1,5 +1,5 @@
-## SPDX-License-Identifier: GPL-2.0-or-later
-## This is an auto-generated file. Do not edit!!
-## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
SPD_SOURCES = placeholder
diff --git a/util/mainboard/google/waddledee/template/memory/Makefile.inc b/util/mainboard/google/waddledee/template/memory/Makefile.inc
index 6751a42..eace2e4 100644
--- a/util/mainboard/google/waddledee/template/memory/Makefile.inc
+++ b/util/mainboard/google/waddledee/template/memory/Makefile.inc
@@ -1,5 +1,5 @@
-## SPDX-License-Identifier: GPL-2.0-or-later
-## This is an auto-generated file. Do not edit!!
-## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
SPD_SOURCES = placeholder
diff --git a/util/mainboard/google/waddledoo/template/memory/Makefile.inc b/util/mainboard/google/waddledoo/template/memory/Makefile.inc
index 6751a42..eace2e4 100644
--- a/util/mainboard/google/waddledoo/template/memory/Makefile.inc
+++ b/util/mainboard/google/waddledoo/template/memory/Makefile.inc
@@ -1,5 +1,5 @@
-## SPDX-License-Identifier: GPL-2.0-or-later
-## This is an auto-generated file. Do not edit!!
-## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
SPD_SOURCES = placeholder
--
To view, visit https://review.coreboot.org/c/coreboot/+/59297
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2d716a7338fd5af8216b2bcd894fc88a9df137e
Gerrit-Change-Number: 59297
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org>
Gerrit-MessageType: newchange
Attention is currently required from: Subrata Banik, Mark Hsieh, Patrick Rudolph.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59264 )
Change subject: soc/intel/adl: Enable GPIO PM after booting to OS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> This CL looks good to me and _INI is one of popular ASL method being used by OS driver hence, we can […]
sure Subrata...I'll check it and update here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59264
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5be925caace7a58052476d0995fb9ee0efc2fd2
Gerrit-Change-Number: 59264
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 15 Nov 2021 06:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment