coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: mb/google/hatch: Add VBTs for variants
by Tim Wawrzynczak (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Matt DeVillier. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59329 ) Change subject: mb/google/hatch: Add VBTs for variants ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c62ce204e3272e778ba0a34f7a47a65d8125f53 Gerrit-Change-Number: 59329 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Tue, 16 Nov 2021 02:48:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Enable EC software sync
by Tim Wawrzynczak (Code Review) 16 Nov '21

16 Nov '21

Tim Wawrzynczak has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/52228 ) Change subject: mb/google/brya: Enable EC software sync ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/52228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4059d10d341d619d412456dfb587b8fe2e238075 Gerrit-Change-Number: 52228 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/brya: Enable early EC sync
by Tim Wawrzynczak (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Boris Mittelberg. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59274 ) Change subject: mb/google/brya: Enable early EC sync ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e480d64a5d90d5bb9cf59ed60b7b53af9edf46a Gerrit-Change-Number: 59274 Gerrit-PatchSet: 1 Gerrit-Owner: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Tue, 16 Nov 2021 02:46:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: test
by Rory Liu (Code Review) 16 Nov '21

16 Nov '21

Rory Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59331 ) Change subject: test ...................................................................... test Change-Id: I0028e9ee3f65365e99d94328c42d048c05d2031b Signed-off-by: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> --- A src/mainboard/google/brya/variants/baseboard/brask/test 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/59331/1 diff --git a/src/mainboard/google/brya/variants/baseboard/brask/test b/src/mainboard/google/brya/variants/baseboard/brask/test new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/src/mainboard/google/brya/variants/baseboard/brask/test -- To view, visit https://review.coreboot.org/c/coreboot/+/59331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0028e9ee3f65365e99d94328c42d048c05d2031b Gerrit-Change-Number: 59331 Gerrit-PatchSet: 1 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/guybrush: Update SPKR GPIO configuration for guybrush/nippe...
by Kevin Chiu (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Bhanu Prakash Maiya, Rob Barnes, Eric Peers, Karthik Ramasubramanian. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59051 ) Change subject: mb/google/guybrush: Update SPKR GPIO configuration for guybrush/nipperkin ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/guybrush/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/59051/comment/199e7a6b_56c2aa13 PS4, Line 70: PAD_NC(GPIO_31), > Hi Rob, […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d82292b116f53d85d9518364ffd2169bd915a7e Gerrit-Change-Number: 59051 Gerrit-PatchSet: 5 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 16 Nov 2021 02:30:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Update SPKR GPIO configuration for guybrush/nippe...
by Kevin Chiu (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Bhanu Prakash Maiya, Rob Barnes, Eric Peers, Karthik Ramasubramanian. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59051 ) Change subject: mb/google/guybrush: Update SPKR GPIO configuration for guybrush/nipperkin ...................................................................... Patch Set 5: (2 comments) File src/mainboard/google/guybrush/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/59051/comment/d378add4_18c2c402 PS4, Line 70: PAD_NC(GPIO_31), > Guybrush reference board v2 still uses GPIO_31 for EN_SPKR. So this needs to be overridden there. Hi Rob, per the suggestion from Karthik, I'll add GPIO_31 override in guybrush variant, thanks. https://review.coreboot.org/c/coreboot/+/59051/comment/f0995530_cc686f8e PS4, Line 87: PAD_NC(GPIO_70), > Please configure the following GPIOs in the baseboard here. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d82292b116f53d85d9518364ffd2169bd915a7e Gerrit-Change-Number: 59051 Gerrit-PatchSet: 5 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 16 Nov 2021 02:30:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Update SPKR GPIO configuration for guybrush/nippe...
by Kevin Chiu (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers. Hello build bot (Jenkins), Bhanu Prakash Maiya, Rob Barnes, Eric Peers, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59051 to look at the new patch set (#5). Change subject: mb/google/guybrush: Update SPKR GPIO configuration for guybrush/nipperkin ...................................................................... mb/google/guybrush: Update SPKR GPIO configuration for guybrush/nipperkin For Guybrush Board Version 2, Nipperking Board Version 1, update SPKR GPIO to match H/W schematic: SPKR: GPIO31 For Nipperkin Board Version 2, update SPKR GPIO to match H/W schematic: SPKR: GPIO70 BUG=b:202992077 BRANCH=guybrush TEST=emerge-guybrush coreboot chromeos-bootimage Change-Id: I3d82292b116f53d85d9518364ffd2169bd915a7e Signed-off-by: Kevin Chiu <kevin.chiu(a)quantatw.com> --- M src/mainboard/google/guybrush/variants/baseboard/gpio.c M src/mainboard/google/guybrush/variants/guybrush/gpio.c M src/mainboard/google/guybrush/variants/nipperkin/gpio.c M src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb 4 files changed, 15 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/59051/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/59051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d82292b116f53d85d9518364ffd2169bd915a7e Gerrit-Change-Number: 59051 Gerrit-PatchSet: 5 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/slippy/peppy: use shared touchpad interrupts
by Matt DeVillier (Code Review) 16 Nov '21

16 Nov '21

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59330 ) Change subject: mb/google/slippy/peppy: use shared touchpad interrupts ...................................................................... mb/google/slippy/peppy: use shared touchpad interrupts Windows (10/11) freaks out and generates an interrupt storm if two ACPI devices are enabled and share an interrupt, even when only one device is actually present. To mitigate this, mark Peppy's interrupts as Shared rather than the default of Exclusive. Test: build/boot Windows 10 on Peppy, observe normal CPU usage in Task Manager for System Interrupts task when touchpad in use. Change-Id: Ida78ddec3105cef6581cdde78da2e2c97d983a0a Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/59330/1 diff --git a/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl b/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl index babf9a0..e793090 100644 --- a/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl @@ -18,7 +18,7 @@ AddressingMode7Bit, // AddressingMode "\\_SB.PCI0.I2C0" // ResourceSource ) - Interrupt (ResourceConsumer, Level, ActiveLow) + Interrupt (ResourceConsumer, Level, ActiveLow, Shared) { BOARD_TRACKPAD_IRQ } @@ -60,7 +60,7 @@ AddressingMode7Bit, // AddressingMode "\\_SB.PCI0.I2C0" // ResourceSource ) - Interrupt (ResourceConsumer, Edge, ActiveLow) + Interrupt (ResourceConsumer, Edge, ActiveLow, Shared) { BOARD_TRACKPAD_IRQ } -- To view, visit https://review.coreboot.org/c/coreboot/+/59330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida78ddec3105cef6581cdde78da2e2c97d983a0a Gerrit-Change-Number: 59330 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/hatch: Add VBTs for variants
by Matt DeVillier (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Tim Wawrzynczak. Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59329 ) Change subject: mb/google/hatch: Add VBTs for variants ...................................................................... mb/google/hatch: Add VBTs for variants Add VBTs for all hatch variants currently supported by ChromeOS recovery images. For variants which use multiple VBTs and select at runtime, ensure these are added directly to CBFS. Change-Id: I3c62ce204e3272e778ba0a34f7a47a65d8125f53 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/hatch/Kconfig.name A src/mainboard/google/hatch/variants/akemi/data.vbt A src/mainboard/google/hatch/variants/dooly/data.vbt A src/mainboard/google/hatch/variants/dratini/data.vbt A src/mainboard/google/hatch/variants/duffy/data.vbt A src/mainboard/google/hatch/variants/faffy/data.vbt A src/mainboard/google/hatch/variants/hatch/data.vbt A src/mainboard/google/hatch/variants/helios/data.vbt A src/mainboard/google/hatch/variants/helios_diskswap/data.vbt A src/mainboard/google/hatch/variants/jinlon/data.vbt A src/mainboard/google/hatch/variants/kaisa/data.vbt M src/mainboard/google/hatch/variants/kindred/Makefile.inc A src/mainboard/google/hatch/variants/kindred/data.vbt A src/mainboard/google/hatch/variants/kindred/kled-data.vbt A src/mainboard/google/hatch/variants/kohaku/data.vbt M src/mainboard/google/hatch/variants/nightfury/Makefile.inc A src/mainboard/google/hatch/variants/nightfury/data.vbt A src/mainboard/google/hatch/variants/nightfury/nightfury-qled-data.vbt A src/mainboard/google/hatch/variants/noibat/data.vbt A src/mainboard/google/hatch/variants/puff/data.vbt A src/mainboard/google/hatch/variants/wyvern/data.vbt 21 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/59329/1 diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index be69a54..59e2b69 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -3,6 +3,7 @@ config BOARD_GOOGLE_AKEMI bool "-> Akemi (IdeaPad Flex 5/5i Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_AMBASSADOR bool "-> Ambassador" @@ -11,23 +12,28 @@ config BOARD_GOOGLE_DOOLY bool "-> Dooly" select BOARD_GOOGLE_BASEBOARD_PUFF + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_DRATINI bool "-> Dratini (HP Pro c640 Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_DUFFY_LEGACY bool "-> Duffy Legacy (32MB)" select BOARD_GOOGLE_BASEBOARD_PUFF select BOARD_ROMSIZE_KB_32768 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_DUFFY bool "-> Duffy (ASUS Chromebox 4)" select BOARD_GOOGLE_BASEBOARD_PUFF + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_FAFFY bool "-> Faffy (ASUS Fanless Chromebox)" select BOARD_GOOGLE_BASEBOARD_PUFF + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_GENESIS bool "-> Genesis" @@ -37,41 +43,49 @@ bool "-> Hatch" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_32768 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_HELIOS bool "-> Helios (ASUS Chromebook Flip C436FA)" select BOARD_GOOGLE_BASEBOARD_HATCH select CHROMEOS_DSM_CALIB if CHROMEOS select DRIVERS_I2C_RT1011 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_HELIOS_DISKSWAP bool "-> Helios_Diskswap" select BOARD_GOOGLE_BASEBOARD_HATCH select CHROMEOS_DSM_CALIB if CHROMEOS select DRIVERS_I2C_RT1011 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_JINLON bool "-> Jinlon (HP Elite c1030 Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH select DRIVERS_GFX_GENERIC + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_KAISA_LEGACY bool "-> Kaisa Legacy (32MB)" select BOARD_GOOGLE_BASEBOARD_PUFF select BOARD_ROMSIZE_KB_32768 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_KAISA bool "-> Kaisa (Acer Chromebox CXI4)" select BOARD_GOOGLE_BASEBOARD_PUFF + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_KINDRED bool "-> Kindred (Acer Chromebook 712)" select BOARD_GOOGLE_BASEBOARD_HATCH + select INTEL_GMA_HAVE_VBT select SOC_INTEL_COMMON_MMC_OVERRIDE config BOARD_GOOGLE_KOHAKU bool "-> Kohaku (Samsung Galaxy Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_MOONBUGGY bool "-> Moonbuggy" @@ -86,10 +100,12 @@ select BOARD_GOOGLE_BASEBOARD_HATCH select CHROMEOS_DSM_CALIB if CHROMEOS select DRIVERS_I2C_MAX98390 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_NOIBAT bool "-> Noibat (HP Chromebox G3)" select BOARD_GOOGLE_BASEBOARD_PUFF + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_PALKIA bool "-> Palkia" @@ -101,6 +117,7 @@ bool "-> Puff" select BOARD_GOOGLE_BASEBOARD_PUFF select BOARD_ROMSIZE_KB_32768 + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_SCOUT bool "-> Scout" @@ -113,3 +130,4 @@ config BOARD_GOOGLE_WYVERN bool "-> Wyvern (CTL Chromebox CBx2)" select BOARD_GOOGLE_BASEBOARD_PUFF + select INTEL_GMA_HAVE_VBT diff --git a/src/mainboard/google/hatch/variants/akemi/data.vbt b/src/mainboard/google/hatch/variants/akemi/data.vbt new file mode 100644 index 0000000..a972fa2 --- /dev/null +++ b/src/mainboard/google/hatch/variants/akemi/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/dooly/data.vbt b/src/mainboard/google/hatch/variants/dooly/data.vbt new file mode 100644 index 0000000..42fc269 --- /dev/null +++ b/src/mainboard/google/hatch/variants/dooly/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/dratini/data.vbt b/src/mainboard/google/hatch/variants/dratini/data.vbt new file mode 100644 index 0000000..a8a028c --- /dev/null +++ b/src/mainboard/google/hatch/variants/dratini/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/duffy/data.vbt b/src/mainboard/google/hatch/variants/duffy/data.vbt new file mode 100644 index 0000000..cda1c25 --- /dev/null +++ b/src/mainboard/google/hatch/variants/duffy/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/faffy/data.vbt b/src/mainboard/google/hatch/variants/faffy/data.vbt new file mode 100644 index 0000000..cda1c25 --- /dev/null +++ b/src/mainboard/google/hatch/variants/faffy/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/hatch/data.vbt b/src/mainboard/google/hatch/variants/hatch/data.vbt new file mode 100644 index 0000000..72ef315 --- /dev/null +++ b/src/mainboard/google/hatch/variants/hatch/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/helios/data.vbt b/src/mainboard/google/hatch/variants/helios/data.vbt new file mode 100644 index 0000000..a972fa2 --- /dev/null +++ b/src/mainboard/google/hatch/variants/helios/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/helios_diskswap/data.vbt b/src/mainboard/google/hatch/variants/helios_diskswap/data.vbt new file mode 100644 index 0000000..a972fa2 --- /dev/null +++ b/src/mainboard/google/hatch/variants/helios_diskswap/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/jinlon/data.vbt b/src/mainboard/google/hatch/variants/jinlon/data.vbt new file mode 100644 index 0000000..a8a028c --- /dev/null +++ b/src/mainboard/google/hatch/variants/jinlon/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/kaisa/data.vbt b/src/mainboard/google/hatch/variants/kaisa/data.vbt new file mode 100644 index 0000000..cda1c25 --- /dev/null +++ b/src/mainboard/google/hatch/variants/kaisa/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/kindred/Makefile.inc b/src/mainboard/google/hatch/variants/kindred/Makefile.inc index 1676fd9..767e119 100644 --- a/src/mainboard/google/hatch/variants/kindred/Makefile.inc +++ b/src/mainboard/google/hatch/variants/kindred/Makefile.inc @@ -12,3 +12,5 @@ bootblock-y += gpio.c ramstage-y += gpio.c ramstage-y += variant.c + +$(call add_vbt_to_cbfs, vbt-kled.bin, kled-data.vbt) diff --git a/src/mainboard/google/hatch/variants/kindred/data.vbt b/src/mainboard/google/hatch/variants/kindred/data.vbt new file mode 100644 index 0000000..a972fa2 --- /dev/null +++ b/src/mainboard/google/hatch/variants/kindred/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/kindred/kled-data.vbt b/src/mainboard/google/hatch/variants/kindred/kled-data.vbt new file mode 100644 index 0000000..f07cb69 --- /dev/null +++ b/src/mainboard/google/hatch/variants/kindred/kled-data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/kohaku/data.vbt b/src/mainboard/google/hatch/variants/kohaku/data.vbt new file mode 100644 index 0000000..31fcd1e --- /dev/null +++ b/src/mainboard/google/hatch/variants/kohaku/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/nightfury/Makefile.inc b/src/mainboard/google/hatch/variants/nightfury/Makefile.inc index c0a68a8..a856f44 100644 --- a/src/mainboard/google/hatch/variants/nightfury/Makefile.inc +++ b/src/mainboard/google/hatch/variants/nightfury/Makefile.inc @@ -11,3 +11,5 @@ ramstage-y += gpio.c ramstage-y += ramstage.c ramstage-y += variant.c + +$(call add_vbt_to_cbfs, vbt-nightfury-qled.bin, nightfury-qled-data.vbt) diff --git a/src/mainboard/google/hatch/variants/nightfury/data.vbt b/src/mainboard/google/hatch/variants/nightfury/data.vbt new file mode 100644 index 0000000..31fcd1e --- /dev/null +++ b/src/mainboard/google/hatch/variants/nightfury/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/nightfury/nightfury-qled-data.vbt b/src/mainboard/google/hatch/variants/nightfury/nightfury-qled-data.vbt new file mode 100644 index 0000000..a972fa2 --- /dev/null +++ b/src/mainboard/google/hatch/variants/nightfury/nightfury-qled-data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/noibat/data.vbt b/src/mainboard/google/hatch/variants/noibat/data.vbt new file mode 100644 index 0000000..cda1c25 --- /dev/null +++ b/src/mainboard/google/hatch/variants/noibat/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/puff/data.vbt b/src/mainboard/google/hatch/variants/puff/data.vbt new file mode 100644 index 0000000..cda1c25 --- /dev/null +++ b/src/mainboard/google/hatch/variants/puff/data.vbt Binary files differ diff --git a/src/mainboard/google/hatch/variants/wyvern/data.vbt b/src/mainboard/google/hatch/variants/wyvern/data.vbt new file mode 100644 index 0000000..cda1c25 --- /dev/null +++ b/src/mainboard/google/hatch/variants/wyvern/data.vbt Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/59329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c62ce204e3272e778ba0a34f7a47a65d8125f53 Gerrit-Change-Number: 59329 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/hatch: Alphabetize variants in Kconfig.name
by Matt DeVillier (Code Review) 16 Nov '21

16 Nov '21

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59328 ) Change subject: mb/google/hatch: Alphabetize variants in Kconfig.name ...................................................................... mb/google/hatch: Alphabetize variants in Kconfig.name Change-Id: Ie29242e635bae1e2754bc1109754a64cb496af29 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/hatch/Kconfig.name 1 file changed, 39 insertions(+), 39 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/59328/1 diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index 9102d03..be69a54 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -4,6 +4,14 @@ bool "-> Akemi (IdeaPad Flex 5/5i Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH +config BOARD_GOOGLE_AMBASSADOR + bool "-> Ambassador" + select BOARD_GOOGLE_BASEBOARD_PUFF + +config BOARD_GOOGLE_DOOLY + bool "-> Dooly" + select BOARD_GOOGLE_BASEBOARD_PUFF + config BOARD_GOOGLE_DRATINI bool "-> Dratini (HP Pro c640 Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH @@ -21,11 +29,27 @@ bool "-> Faffy (ASUS Fanless Chromebox)" select BOARD_GOOGLE_BASEBOARD_PUFF +config BOARD_GOOGLE_GENESIS + bool "-> Genesis" + select BOARD_GOOGLE_BASEBOARD_PUFF + config BOARD_GOOGLE_HATCH bool "-> Hatch" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_32768 +config BOARD_GOOGLE_HELIOS + bool "-> Helios (ASUS Chromebook Flip C436FA)" + select BOARD_GOOGLE_BASEBOARD_HATCH + select CHROMEOS_DSM_CALIB if CHROMEOS + select DRIVERS_I2C_RT1011 + +config BOARD_GOOGLE_HELIOS_DISKSWAP + bool "-> Helios_Diskswap" + select BOARD_GOOGLE_BASEBOARD_HATCH + select CHROMEOS_DSM_CALIB if CHROMEOS + select DRIVERS_I2C_RT1011 + config BOARD_GOOGLE_JINLON bool "-> Jinlon (HP Elite c1030 Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH @@ -40,31 +64,23 @@ bool "-> Kaisa (Acer Chromebox CXI4)" select BOARD_GOOGLE_BASEBOARD_PUFF -config BOARD_GOOGLE_KOHAKU - bool "-> Kohaku (Samsung Galaxy Chromebook)" - select BOARD_GOOGLE_BASEBOARD_HATCH - config BOARD_GOOGLE_KINDRED bool "-> Kindred (Acer Chromebook 712)" select BOARD_GOOGLE_BASEBOARD_HATCH select SOC_INTEL_COMMON_MMC_OVERRIDE -config BOARD_GOOGLE_HELIOS - bool "-> Helios (ASUS Chromebook Flip C436FA)" +config BOARD_GOOGLE_KOHAKU + bool "-> Kohaku (Samsung Galaxy Chromebook)" select BOARD_GOOGLE_BASEBOARD_HATCH - select CHROMEOS_DSM_CALIB if CHROMEOS - select DRIVERS_I2C_RT1011 + +config BOARD_GOOGLE_MOONBUGGY + bool "-> Moonbuggy" + select BOARD_GOOGLE_BASEBOARD_PUFF config BOARD_GOOGLE_MUSHU bool "-> Mushu" select BOARD_GOOGLE_BASEBOARD_HATCH -config BOARD_GOOGLE_PALKIA - bool "-> Palkia" - select BOARD_GOOGLE_BASEBOARD_HATCH - select CHROMEOS_DSM_CALIB if CHROMEOS - select DRIVERS_I2C_RT1011 - config BOARD_GOOGLE_NIGHTFURY bool "-> Nightfury (Samsung Galaxy Chromebook 2)" select BOARD_GOOGLE_BASEBOARD_HATCH @@ -75,16 +91,20 @@ bool "-> Noibat (HP Chromebox G3)" select BOARD_GOOGLE_BASEBOARD_PUFF +config BOARD_GOOGLE_PALKIA + bool "-> Palkia" + select BOARD_GOOGLE_BASEBOARD_HATCH + select CHROMEOS_DSM_CALIB if CHROMEOS + select DRIVERS_I2C_RT1011 + config BOARD_GOOGLE_PUFF bool "-> Puff" select BOARD_GOOGLE_BASEBOARD_PUFF select BOARD_ROMSIZE_KB_32768 -config BOARD_GOOGLE_HELIOS_DISKSWAP - bool "-> Helios_Diskswap" - select BOARD_GOOGLE_BASEBOARD_HATCH - select CHROMEOS_DSM_CALIB if CHROMEOS - select DRIVERS_I2C_RT1011 +config BOARD_GOOGLE_SCOUT + bool "-> Scout" + select BOARD_GOOGLE_BASEBOARD_PUFF config BOARD_GOOGLE_STRYKE bool "-> Stryke" @@ -93,23 +113,3 @@ config BOARD_GOOGLE_WYVERN bool "-> Wyvern (CTL Chromebox CBx2)" select BOARD_GOOGLE_BASEBOARD_PUFF - -config BOARD_GOOGLE_DOOLY - bool "-> Dooly" - select BOARD_GOOGLE_BASEBOARD_PUFF - -config BOARD_GOOGLE_AMBASSADOR - bool "-> Ambassador" - select BOARD_GOOGLE_BASEBOARD_PUFF - -config BOARD_GOOGLE_GENESIS - bool "-> Genesis" - select BOARD_GOOGLE_BASEBOARD_PUFF - -config BOARD_GOOGLE_SCOUT - bool "-> Scout" - select BOARD_GOOGLE_BASEBOARD_PUFF - -config BOARD_GOOGLE_MOONBUGGY - bool "-> Moonbuggy" - select BOARD_GOOGLE_BASEBOARD_PUFF -- To view, visit https://review.coreboot.org/c/coreboot/+/59328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie29242e635bae1e2754bc1109754a64cb496af29 Gerrit-Change-Number: 59328 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021