coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: mb/google/octopus: Add missing VBTs for variants
by build bot (Jenkins) (Code Review) 16 Nov '21

16 Nov '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59327 ) Change subject: mb/google/octopus: Add missing VBTs for variants ...................................................................... Patch Set 1: (2 comments) File src/mainboard/google/octopus/variants/meep/Makefile.inc: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133368): https://review.coreboot.org/c/coreboot/+/59327/comment/21b8e429_0c9d6d2a PS1, Line 6: $(call add_vbt_to_cbfs, vbt_dorp_hdmi.bin, dorp-hdmi-data.vbt) 'dorp' may be misspelled - perhaps 'drop'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133368): https://review.coreboot.org/c/coreboot/+/59327/comment/cf4fdb98_81c1f693 PS1, Line 6: $(call add_vbt_to_cbfs, vbt_dorp_hdmi.bin, dorp-hdmi-data.vbt) 'dorp' may be misspelled - perhaps 'drop'? -- To view, visit https://review.coreboot.org/c/coreboot/+/59327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4b5c4268f9255d658f9762d94488db66e0677830 Gerrit-Change-Number: 59327 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 16 Nov 2021 02:24:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/octopus: Add missing VBTs for variants
by Matt DeVillier (Code Review) 16 Nov '21

16 Nov '21

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59327 ) Change subject: mb/google/octopus: Add missing VBTs for variants ...................................................................... mb/google/octopus: Add missing VBTs for variants Add VBTs for all octopus variants currently supported by ChromeOS recovery images. For variants which use multiple VBTs and select at runtime, ensure these are added directly to CBFS. Change-Id: I4b5c4268f9255d658f9762d94488db66e0677830 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/octopus/Kconfig M src/mainboard/google/octopus/Kconfig.name M src/mainboard/google/octopus/variants/bloog/Makefile.inc A src/mainboard/google/octopus/variants/bloog/blooguard-data.vbt A src/mainboard/google/octopus/variants/bloog/data.vbt A src/mainboard/google/octopus/variants/bobba/data.vbt A src/mainboard/google/octopus/variants/casta/data.vbt A src/mainboard/google/octopus/variants/fleex/data.vbt M src/mainboard/google/octopus/variants/garg/Makefile.inc A src/mainboard/google/octopus/variants/garg/data.vbt A src/mainboard/google/octopus/variants/garg/garfour-data.vbt A src/mainboard/google/octopus/variants/garg/garfour-hdmi-data.vbt A src/mainboard/google/octopus/variants/garg/garg-hdmi-data.vbt A src/mainboard/google/octopus/variants/lick/data.vbt M src/mainboard/google/octopus/variants/meep/Makefile.inc A src/mainboard/google/octopus/variants/meep/data.vbt A src/mainboard/google/octopus/variants/meep/dorp-hdmi-data.vbt A src/mainboard/google/octopus/variants/meep/vortininja-data.vbt A src/mainboard/google/octopus/variants/phaser/data.vbt A src/mainboard/google/octopus/variants/yorp/data.vbt 20 files changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/59327/1 diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index eb6cbc6..25d08eb8 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -18,7 +18,6 @@ select EC_GOOGLE_CHROMEEC_ESPI select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES - select INTEL_GMA_HAVE_VBT if BOARD_GOOGLE_AMPTON select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS select SOC_ESPI diff --git a/src/mainboard/google/octopus/Kconfig.name b/src/mainboard/google/octopus/Kconfig.name index 4fcc3e1..4168411 100644 --- a/src/mainboard/google/octopus/Kconfig.name +++ b/src/mainboard/google/octopus/Kconfig.name @@ -4,12 +4,14 @@ bool "-> Ampton (ASUS Chromebook Flip C214)" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT select NHLT_RT5682 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_BLOOG bool "-> Bloog (HP Chromebook x360 12b, 14a, x360 14b)" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT select NHLT_DA7219 if INCLUDE_NHLT_BLOBS select NHLT_RT5682 if INCLUDE_NHLT_BLOBS @@ -17,6 +19,7 @@ bool "-> Bobba (Acer Chromebook 311 / Spin 511)" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT select NHLT_DA7219 if INCLUDE_NHLT_BLOBS select NHLT_RT5682 if INCLUDE_NHLT_BLOBS @@ -24,6 +27,7 @@ bool "-> Bluebird/Casta (Samsung Chromebook 4, 4+)" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT select NHLT_DA7219 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_DOOD @@ -36,6 +40,7 @@ bool "-> Fleex (Dell Chromebook 3100)" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT select NHLT_DA7219 if INCLUDE_NHLT_BLOBS select NHLT_RT5682 if INCLUDE_NHLT_BLOBS @@ -49,6 +54,7 @@ bool "-> Garg" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT select NHLT_DA7219 if INCLUDE_NHLT_BLOBS select NHLT_RT5682 if INCLUDE_NHLT_BLOBS @@ -56,12 +62,14 @@ bool "-> Lick (Ideapad 3 Chromebook)" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT select NHLT_DA7219 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_MEEP bool "-> Meep (HP Chromebook x360 11 G2 EE)" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT select NHLT_DA7219 if INCLUDE_NHLT_BLOBS select NHLT_RT5682 if INCLUDE_NHLT_BLOBS @@ -74,6 +82,7 @@ bool "-> Phaser (Lenovo 100e/300e/500e Chromebook 2nd Gen (Intel))" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT select NHLT_DA7219 if INCLUDE_NHLT_BLOBS select NHLT_RT5682 if INCLUDE_NHLT_BLOBS @@ -81,4 +90,5 @@ bool "-> Yorp" select BOARD_GOOGLE_BASEBOARD_OCTOPUS select BASEBOARD_OCTOPUS_LAPTOP + select INTEL_GMA_HAVE_VBT select NHLT_DA7219 if INCLUDE_NHLT_BLOBS diff --git a/src/mainboard/google/octopus/variants/bloog/Makefile.inc b/src/mainboard/google/octopus/variants/bloog/Makefile.inc index ba865e9..98c1e44 100644 --- a/src/mainboard/google/octopus/variants/bloog/Makefile.inc +++ b/src/mainboard/google/octopus/variants/bloog/Makefile.inc @@ -2,3 +2,5 @@ ramstage-y += gpio.c ramstage-y += variant.c + +$(call add_vbt_to_cbfs, vbt_blooguard.bin, blooguard-data.vbt) diff --git a/src/mainboard/google/octopus/variants/bloog/blooguard-data.vbt b/src/mainboard/google/octopus/variants/bloog/blooguard-data.vbt new file mode 100644 index 0000000..1d93571 --- /dev/null +++ b/src/mainboard/google/octopus/variants/bloog/blooguard-data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/bloog/data.vbt b/src/mainboard/google/octopus/variants/bloog/data.vbt new file mode 100644 index 0000000..fbcf46e --- /dev/null +++ b/src/mainboard/google/octopus/variants/bloog/data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/bobba/data.vbt b/src/mainboard/google/octopus/variants/bobba/data.vbt new file mode 100644 index 0000000..fbcf46e --- /dev/null +++ b/src/mainboard/google/octopus/variants/bobba/data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/casta/data.vbt b/src/mainboard/google/octopus/variants/casta/data.vbt new file mode 100644 index 0000000..fbcf46e --- /dev/null +++ b/src/mainboard/google/octopus/variants/casta/data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/fleex/data.vbt b/src/mainboard/google/octopus/variants/fleex/data.vbt new file mode 100644 index 0000000..2848abe --- /dev/null +++ b/src/mainboard/google/octopus/variants/fleex/data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/garg/Makefile.inc b/src/mainboard/google/octopus/variants/garg/Makefile.inc index 7ee7e70..a443e8d 100644 --- a/src/mainboard/google/octopus/variants/garg/Makefile.inc +++ b/src/mainboard/google/octopus/variants/garg/Makefile.inc @@ -4,3 +4,7 @@ ramstage-y += variant.c smm-y += variant.c + +$(call add_vbt_to_cbfs, vbt_garg_hdmi.bin, garg-hdmi-data.vbt) +$(call add_vbt_to_cbfs, vbt_garfour.bin, garfour-data.vbt) +$(call add_vbt_to_cbfs, vbt_garfour_hdmi.bin, garfour-hdmi-data.vbt) diff --git a/src/mainboard/google/octopus/variants/garg/data.vbt b/src/mainboard/google/octopus/variants/garg/data.vbt new file mode 100644 index 0000000..fbcf46e --- /dev/null +++ b/src/mainboard/google/octopus/variants/garg/data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/garg/garfour-data.vbt b/src/mainboard/google/octopus/variants/garg/garfour-data.vbt new file mode 100644 index 0000000..1d93571 --- /dev/null +++ b/src/mainboard/google/octopus/variants/garg/garfour-data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/garg/garfour-hdmi-data.vbt b/src/mainboard/google/octopus/variants/garg/garfour-hdmi-data.vbt new file mode 100644 index 0000000..abf1d88 --- /dev/null +++ b/src/mainboard/google/octopus/variants/garg/garfour-hdmi-data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/garg/garg-hdmi-data.vbt b/src/mainboard/google/octopus/variants/garg/garg-hdmi-data.vbt new file mode 100644 index 0000000..2073536 --- /dev/null +++ b/src/mainboard/google/octopus/variants/garg/garg-hdmi-data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/lick/data.vbt b/src/mainboard/google/octopus/variants/lick/data.vbt new file mode 100644 index 0000000..fbcf46e --- /dev/null +++ b/src/mainboard/google/octopus/variants/lick/data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/meep/Makefile.inc b/src/mainboard/google/octopus/variants/meep/Makefile.inc index ba865e9..7a6301c 100644 --- a/src/mainboard/google/octopus/variants/meep/Makefile.inc +++ b/src/mainboard/google/octopus/variants/meep/Makefile.inc @@ -2,3 +2,6 @@ ramstage-y += gpio.c ramstage-y += variant.c + +$(call add_vbt_to_cbfs, vbt_dorp_hdmi.bin, dorp-hdmi-data.vbt) +$(call add_vbt_to_cbfs, vbt_vortininja.bin, vortininja-data.vbt) diff --git a/src/mainboard/google/octopus/variants/meep/data.vbt b/src/mainboard/google/octopus/variants/meep/data.vbt new file mode 100644 index 0000000..fbcf46e --- /dev/null +++ b/src/mainboard/google/octopus/variants/meep/data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/meep/dorp-hdmi-data.vbt b/src/mainboard/google/octopus/variants/meep/dorp-hdmi-data.vbt new file mode 100644 index 0000000..ac58bd4 --- /dev/null +++ b/src/mainboard/google/octopus/variants/meep/dorp-hdmi-data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/meep/vortininja-data.vbt b/src/mainboard/google/octopus/variants/meep/vortininja-data.vbt new file mode 100644 index 0000000..1d93571 --- /dev/null +++ b/src/mainboard/google/octopus/variants/meep/vortininja-data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/phaser/data.vbt b/src/mainboard/google/octopus/variants/phaser/data.vbt new file mode 100644 index 0000000..fbcf46e --- /dev/null +++ b/src/mainboard/google/octopus/variants/phaser/data.vbt Binary files differ diff --git a/src/mainboard/google/octopus/variants/yorp/data.vbt b/src/mainboard/google/octopus/variants/yorp/data.vbt new file mode 100644 index 0000000..764ee94 --- /dev/null +++ b/src/mainboard/google/octopus/variants/yorp/data.vbt Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/59327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4b5c4268f9255d658f9762d94488db66e0677830 Gerrit-Change-Number: 59327 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/octopus: Alphabetize variants in Kconfig.name
by Matt DeVillier (Code Review) 16 Nov '21

16 Nov '21

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59326 ) Change subject: mb/google/octopus: Alphabetize variants in Kconfig.name ...................................................................... mb/google/octopus: Alphabetize variants in Kconfig.name Change-Id: I2e57c4f1baa8a42bde2642e7f76ddead7bfd6a58 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/octopus/Kconfig.name 1 file changed, 41 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/59326/1 diff --git a/src/mainboard/google/octopus/Kconfig.name b/src/mainboard/google/octopus/Kconfig.name index f5cb536..4fcc3e1 100644 --- a/src/mainboard/google/octopus/Kconfig.name +++ b/src/mainboard/google/octopus/Kconfig.name @@ -1,31 +1,13 @@ comment "Octopus" -config BOARD_GOOGLE_OCTOPUS - bool "-> Octopus" - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select BASEBOARD_OCTOPUS_LAPTOP - -config BOARD_GOOGLE_YORP - bool "-> Yorp" - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select BASEBOARD_OCTOPUS_LAPTOP - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS - -config BOARD_GOOGLE_PHASER - bool "-> Phaser (Lenovo 100e/300e/500e Chromebook 2nd Gen (Intel))" +config BOARD_GOOGLE_AMPTON + bool "-> Ampton (ASUS Chromebook Flip C214)" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS select NHLT_RT5682 if INCLUDE_NHLT_BLOBS -config BOARD_GOOGLE_LICK - bool "-> Lick (Ideapad 3 Chromebook)" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS - -config BOARD_GOOGLE_FLEEX - bool "-> Fleex (Dell Chromebook 3100)" +config BOARD_GOOGLE_BLOOG + bool "-> Bloog (HP Chromebook x360 12b, 14a, x360 14b)" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS select NHLT_DA7219 if INCLUDE_NHLT_BLOBS @@ -38,32 +20,31 @@ select NHLT_DA7219 if INCLUDE_NHLT_BLOBS select NHLT_RT5682 if INCLUDE_NHLT_BLOBS -config BOARD_GOOGLE_MEEP - bool "-> Meep (HP Chromebook x360 11 G2 EE)" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS - select NHLT_RT5682 if INCLUDE_NHLT_BLOBS - -config BOARD_GOOGLE_AMPTON - bool "-> Ampton (ASUS Chromebook Flip C214)" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select NHLT_RT5682 if INCLUDE_NHLT_BLOBS - config BOARD_GOOGLE_CASTA bool "-> Bluebird/Casta (Samsung Chromebook 4, 4+)" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS select NHLT_DA7219 if INCLUDE_NHLT_BLOBS -config BOARD_GOOGLE_BLOOG - bool "-> Bloog (HP Chromebook x360 12b, 14a, x360 14b)" +config BOARD_GOOGLE_DOOD + bool "-> Dood" + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_FLEEX + bool "-> Fleex (Dell Chromebook 3100)" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS select NHLT_DA7219 if INCLUDE_NHLT_BLOBS select NHLT_RT5682 if INCLUDE_NHLT_BLOBS +config BOARD_GOOGLE_FOOB + bool "-> Foob" + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + config BOARD_GOOGLE_GARG bool "-> Garg" select BASEBOARD_OCTOPUS_LAPTOP @@ -71,14 +52,33 @@ select NHLT_DA7219 if INCLUDE_NHLT_BLOBS select NHLT_RT5682 if INCLUDE_NHLT_BLOBS -config BOARD_GOOGLE_DOOD - bool "-> Dood" +config BOARD_GOOGLE_LICK + bool "-> Lick (Ideapad 3 Chromebook)" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS select NHLT_DA7219 if INCLUDE_NHLT_BLOBS -config BOARD_GOOGLE_FOOB - bool "-> Foob" +config BOARD_GOOGLE_MEEP + bool "-> Meep (HP Chromebook x360 11 G2 EE)" select BASEBOARD_OCTOPUS_LAPTOP select BOARD_GOOGLE_BASEBOARD_OCTOPUS select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + select NHLT_RT5682 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_OCTOPUS + bool "-> Octopus" + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select BASEBOARD_OCTOPUS_LAPTOP + +config BOARD_GOOGLE_PHASER + bool "-> Phaser (Lenovo 100e/300e/500e Chromebook 2nd Gen (Intel))" + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + select NHLT_RT5682 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_YORP + bool "-> Yorp" + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select BASEBOARD_OCTOPUS_LAPTOP + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS -- To view, visit https://review.coreboot.org/c/coreboot/+/59326 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e57c4f1baa8a42bde2642e7f76ddead7bfd6a58 Gerrit-Change-Number: 59326 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/mediatek: move i2c function to common folder
by Yu-Ping Wu (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Hung-Te Lin, Xi Chen, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59295 ) Change subject: soc/mediatek: move i2c function to common folder ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a702741c763bf9261cea90d0d71c08b6e28c261 Gerrit-Change-Number: 59295 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Tue, 16 Nov 2021 01:55:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile.inc: Split of image generation in multiple targets
by Yu-Ping Wu (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Arthur Heymans, Martin Roth. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56114 ) Change subject: Makefile.inc: Split of image generation in multiple targets ...................................................................... Patch Set 4: (1 comment) File Makefile.inc: https://review.coreboot.org/c/coreboot/+/56114/comment/eea9fdd9_4374a197 PS4, Line 1129: mv $@.tmp $@ I think the point of this is to prevent corrupt or incomplete data written to $@, but you're changing that in this patch. I'm not sure what's the right way to fix it though. -- To view, visit https://review.coreboot.org/c/coreboot/+/56114 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If36aee0bd2f75f3941b3bc424a7ec6c775eb1353 Gerrit-Change-Number: 56114 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 16 Nov 2021 01:49:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: move i2c function to common folder
by Rex-BC Chen (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Hung-Te Lin, Xi Chen, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59295 ) Change subject: soc/mediatek: move i2c function to common folder ...................................................................... Patch Set 6: (2 comments) File src/soc/mediatek/common/i2c.c: https://review.coreboot.org/c/coreboot/+/59295/comment/cf88b96a_6a675b24 PS5, Line 35: { /* do nothing */ } > Could you take the chance to fix this as well? Done https://review.coreboot.org/c/coreboot/+/59295/comment/ed605311_cb167ee1 PS5, Line 549: This function is only used from MT8195. > No need to mention this in the common file. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a702741c763bf9261cea90d0d71c08b6e28c261 Gerrit-Change-Number: 59295 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 16 Nov 2021 01:43:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: move i2c function to common folder
by Rex-BC Chen (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Hung-Te Lin, Xi Chen, Rex-BC Chen. Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59295 to look at the new patch set (#6). Change subject: soc/mediatek: move i2c function to common folder ...................................................................... soc/mediatek: move i2c function to common folder Move mtk_i2c_max_step_cnt, mtk_i2c_check_ac_timing, mtk_i2c_speed_init and mtk_i2c_calculate_speed to common folder to share with MT8186. TEST=test on tomato ok TEST=emerge-asurada coreboot BUG=b:202871018 Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I4a702741c763bf9261cea90d0d71c08b6e28c261 --- M src/soc/mediatek/common/i2c.c M src/soc/mediatek/common/include/soc/i2c_common.h M src/soc/mediatek/mt8173/i2c.c M src/soc/mediatek/mt8173/include/soc/i2c.h M src/soc/mediatek/mt8183/i2c.c M src/soc/mediatek/mt8183/include/soc/i2c.h M src/soc/mediatek/mt8192/i2c.c M src/soc/mediatek/mt8192/include/soc/i2c.h M src/soc/mediatek/mt8195/i2c.c M src/soc/mediatek/mt8195/include/soc/i2c.h 10 files changed, 297 insertions(+), 258 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/59295/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/59295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a702741c763bf9261cea90d0d71c08b6e28c261 Gerrit-Change-Number: 59295 Gerrit-PatchSet: 6 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP] [DO NOT MERGE] src/drivers/intel/fsp2_0: Add FSP 2.3 support
by Anil Kumar K (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Anil Kumar K, Andrey Petrov, Patrick Rudolph. Hello build bot (Jenkins), Andrey Petrov, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59324 to look at the new patch set (#3). Change subject: [WIP] [DO NOT MERGE] src/drivers/intel/fsp2_0: Add FSP 2.3 support ...................................................................... [WIP] [DO NOT MERGE] src/drivers/intel/fsp2_0: Add FSP 2.3 support Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> Change-Id: Ica1bd004286c785aa8a431f39d8efc69982874c1 --- M src/drivers/intel/fsp2_0/Kconfig M src/drivers/intel/fsp2_0/hand_off_block.c M src/drivers/intel/fsp2_0/header_display.c M src/drivers/intel/fsp2_0/include/fsp/info_header.h M src/drivers/intel/fsp2_0/include/fsp/util.h M src/drivers/intel/fsp2_0/util.c 6 files changed, 46 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/59324/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/59324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica1bd004286c785aa8a431f39d8efc69982874c1 Gerrit-Change-Number: 59324 Gerrit-PatchSet: 3 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [WIP] [DO NOT MERGE] src/drivers/intel/fsp2_0: Add FSP 2.3 support
by build bot (Jenkins) (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Andrey Petrov, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59324 ) Change subject: [WIP] [DO NOT MERGE] src/drivers/intel/fsp2_0: Add FSP 2.3 support ...................................................................... Patch Set 2: (4 comments) File src/drivers/intel/fsp2_0/hand_off_block.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133362): https://review.coreboot.org/c/coreboot/+/59324/comment/57462fa2_7f7dddd6 PS2, Line 27: 0x8f, 0x78, 0x66, 0x48, 0xa8, 0x6b, 0xd8, 0x47, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133362): https://review.coreboot.org/c/coreboot/+/59324/comment/a23afeb1_0242ebff PS2, Line 27: 0x8f, 0x78, 0x66, 0x48, 0xa8, 0x6b, 0xd8, 0x47, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133362): https://review.coreboot.org/c/coreboot/+/59324/comment/414a65be_4febbb33 PS2, Line 28: 0x83, 0x6, 0xac, 0xf7, 0x7f, 0x55, 0x10, 0x46 code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133362): https://review.coreboot.org/c/coreboot/+/59324/comment/5a1157e8_81f25cd4 PS2, Line 28: 0x83, 0x6, 0xac, 0xf7, 0x7f, 0x55, 0x10, 0x46 please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/59324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica1bd004286c785aa8a431f39d8efc69982874c1 Gerrit-Change-Number: 59324 Gerrit-PatchSet: 2 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 16 Nov 2021 01:16:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] [DO NOT MERGE] src/drivers/intel/fsp2_0: Add FSP 2.3 support
by Anil Kumar K (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Anil Kumar K, Andrey Petrov, Patrick Rudolph. Hello build bot (Jenkins), Andrey Petrov, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59324 to look at the new patch set (#2). Change subject: [WIP] [DO NOT MERGE] src/drivers/intel/fsp2_0: Add FSP 2.3 support ...................................................................... [WIP] [DO NOT MERGE] src/drivers/intel/fsp2_0: Add FSP 2.3 support Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> Change-Id: Ica1bd004286c785aa8a431f39d8efc69982874c1 --- M src/drivers/intel/fsp2_0/Kconfig M src/drivers/intel/fsp2_0/hand_off_block.c M src/drivers/intel/fsp2_0/header_display.c M src/drivers/intel/fsp2_0/include/fsp/info_header.h M src/drivers/intel/fsp2_0/include/fsp/util.h M src/drivers/intel/fsp2_0/util.c 6 files changed, 46 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/59324/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica1bd004286c785aa8a431f39d8efc69982874c1 Gerrit-Change-Number: 59324 Gerrit-PatchSet: 2 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021