Attention is currently required from: Reka Norman, Subrata Banik, Balaji Manigandan, Usha P, Tim Wawrzynczak, Patrick Rudolph, Kangheui Won.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59306 )
Change subject: soc/intel/common: Include Alder Lake device IDs
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/59306/comment/73906e9c_ed968629
PS1, Line 30: -N
> may be make it as "Alderlake" alone like other does without additional overhead ?
If everything is just going to be "Alderlake", do we even need this table? 😊
--
To view, visit https://review.coreboot.org/c/coreboot/+/59306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0974fc6ee2ca41d9525cc83155772f111c1fdf86
Gerrit-Change-Number: 59306
Gerrit-PatchSet: 1
Gerrit-Owner: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Kangheui Won <khwon(a)google.com>
Gerrit-Comment-Date: Tue, 16 Nov 2021 04:00:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Shon Wang.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59334
to look at the new patch set (#2).
Change subject: mb/google/brya/var/vell: update memory settings
......................................................................
mb/google/brya/var/vell: update memory settings
BUG=b:205908918
TEST=emerge-brya coreboot
Change-Id: Ic0bbac5eaebc77639be6c1bc399658ac90e72fbb
---
M src/mainboard/google/brya/variants/vell/Makefile.inc
A src/mainboard/google/brya/variants/vell/memory.c
2 files changed, 32 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/59334/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/59334
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0bbac5eaebc77639be6c1bc399658ac90e72fbb
Gerrit-Change-Number: 59334
Gerrit-PatchSet: 2
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59271 )
Change subject: soc/intel/alderlake: Allow thermal configuration for ADL
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59271/comment/4a46e6f6_420a7078
PS3, Line 7: for ADL
Not needed. Already mentioned in the first part.
https://review.coreboot.org/c/coreboot/+/59271/comment/91fec063_78897f64
PS3, Line 7: Allow thermal configuration
How about this:
Hook up common code for thermal configuration
--
To view, visit https://review.coreboot.org/c/coreboot/+/59271
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f972f47845c123f4f74fd75091c9703d54db796
Gerrit-Change-Number: 59271
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 16 Nov 2021 03:52:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Robert Chen.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59333
to look at the new patch set (#2).
Change subject: mb/google/dedede/var/drawcia: Add fw_config probe for MIPI camera
......................................................................
mb/google/dedede/var/drawcia: Add fw_config probe for MIPI camera
Add fw_config probe for MIPI camera
BUG=b:2059201110
TEST=FW_NAME=drawcia emerge-dedede coreboot
Change-Id: I89d84b6eb77c18b36b1ff946cec057889013c58f
---
M src/mainboard/google/dedede/variants/drawcia/overridetree.cb
1 file changed, 12 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/59333/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/59333
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89d84b6eb77c18b36b1ff946cec057889013c58f
Gerrit-Change-Number: 59333
Gerrit-PatchSet: 2
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59333 )
Change subject: mb/google/dedede/var/drawcia: Add fw_config probe for MIPI camera
......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133377):
https://review.coreboot.org/c/coreboot/+/59333/comment/a3a794f8_3f6c30e9
PS1, Line 333: device i2c 36 on
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133377):
https://review.coreboot.org/c/coreboot/+/59333/comment/ac3f6c9a_592e42cc
PS1, Line 355: device i2c 0C on
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133377):
https://review.coreboot.org/c/coreboot/+/59333/comment/b557c19d_6bfde24f
PS1, Line 381: device i2c 50 on
trailing whitespace
--
To view, visit https://review.coreboot.org/c/coreboot/+/59333
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89d84b6eb77c18b36b1ff946cec057889013c58f
Gerrit-Change-Number: 59333
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 16 Nov 2021 03:45:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Angel Pons, Patrick Rudolph.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59311 )
Change subject: soc/intel/../thermal: Modified `pch_get_ltt_value()` return type
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Just curious, why need change to int32? PCH register enlarge to DWORD?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59311
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f46ccb457b9cfebf13a512eabb3fb0fab8adb39
Gerrit-Change-Number: 59311
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 16 Nov 2021 03:26:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment