coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: mb/google/octopus: Alphabetize variants in Kconfig.name
by Tim Wawrzynczak (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Matt DeVillier. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59326 ) Change subject: mb/google/octopus: Alphabetize variants in Kconfig.name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59326 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e57c4f1baa8a42bde2642e7f76ddead7bfd6a58 Gerrit-Change-Number: 59326 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Tue, 16 Nov 2021 05:05:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/herobrine: Initialize USB by calling SOC method
by Sandeep Maheswaram (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Julius Werner. Sandeep Maheswaram has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56093 ) Change subject: mb/google/herobrine: Initialize USB by calling SOC method ...................................................................... Patch Set 37: (2 comments) File src/mainboard/google/herobrine/mainboard.c: https://review.coreboot.org/c/coreboot/+/56093/comment/da113863_5b35d645 PS34, Line 19: void mainboard_blob_fix(void); > What is this and what does it have to do with this patch? Done https://review.coreboot.org/c/coreboot/+/56093/comment/d967ca05_cbca7494 PS34, Line 23: usb0_board_data > If the SNPS doesn't use any board_data, just pass NULL (and don't define a struct for it that is nev […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic378352a97e4f3ed89089f1f7545f8ebb172b1f2 Gerrit-Change-Number: 56093 Gerrit-PatchSet: 37 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Sandeep Maheswaram <sanm(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 16 Nov 2021 04:55:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Update SPKR GPIO configuration for guybrush/nippe...
by Karthik Ramasubramanian (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59051 ) Change subject: mb/google/guybrush: Update SPKR GPIO configuration for guybrush/nipperkin ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d82292b116f53d85d9518364ffd2169bd915a7e Gerrit-Change-Number: 59051 Gerrit-PatchSet: 6 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Comment-Date: Tue, 16 Nov 2021 04:53:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: utils: Add initial version of "remove_unused_code" script
by Martin Roth (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Martin Roth, Piotr Król. Hello build bot (Jenkins), Raul Rangel, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59169 to look at the new patch set (#2). Change subject: utils: Add initial version of "remove_unused_code" script ...................................................................... utils: Add initial version of "remove_unused_code" script This script creates a patch to remove all of the coreboot code that a platform doesn't use. This is useful for auditing the codebase for an individual platform or releasing a platform's code. Unlike the script that Sage used that did something similar, this keeps the entire Kconfig tree (Though in a single file), all makefiles that are required to build, and the standard build tools can still be used. This will allow for much easier re-integration back into the coreboot codebase if code is released after running this. This is just the initial version and more features needed to be added to make it fully functional. - It should be able to build multiple configurations to retain the code for all of those configurations. - Flag to remove submodules files as well - Additional variable flags to replace hardcoded values. - The list of makefiles that need to be kept is pretty long, and could be updated so that they aren't needed by the top level makefiles. - Add flag to show changed files - Show number of files before and after script is run Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Iec69db2ad1358846d649db627b6d60ac8c2204e4 --- M util/scripts/description.md A util/scripts/rm_unused_code 2 files changed, 295 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/59169/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec69db2ad1358846d649db627b6d60ac8c2204e4 Gerrit-Change-Number: 59169 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/variants/kano: Support MIPI device probe in non-zero A...
by Jim Lai (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Tim Wawrzynczak. Jim Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59332 ) Change subject: mb/google/brya/variants/kano: Support MIPI device probe in non-zero ACPI D state ...................................................................... Patch Set 1: Code-Review-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/59332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I166e85f9bd0727ea5a8ffb6b3e99c62b0b1c0ae5 Gerrit-Change-Number: 59332 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Lai <jim.lai(a)intel.com> Gerrit-Reviewer: Jim Lai <jim.lai(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 16 Nov 2021 04:18:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/drawcia: Add fw_config probe for MIPI camera
by Robert Chen (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Robert Chen. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59333 to look at the new patch set (#4). Change subject: mb/google/dedede/var/drawcia: Add fw_config probe for MIPI camera ...................................................................... mb/google/dedede/var/drawcia: Add fw_config probe for MIPI camera Add fw_config probe for MIPI camera BUG=b:2059201110 TEST=FW_NAME=drawcia emerge-dedede coreboot Change-Id: I89d84b6eb77c18b36b1ff946cec057889013c58f Signed-off-by: RobertChen <robert.chen(a)quanta.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 12 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/59333/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/59333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89d84b6eb77c18b36b1ff946cec057889013c58f Gerrit-Change-Number: 59333 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/drawcia: Add fw_config probe for MIPI camera
by Robert Chen (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Robert Chen. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59333 to look at the new patch set (#3). Change subject: mb/google/dedede/var/drawcia: Add fw_config probe for MIPI camera ...................................................................... mb/google/dedede/var/drawcia: Add fw_config probe for MIPI camera Add fw_config probe for MIPI camera BUG=b:2059201110 TEST=FW_NAME=drawcia emerge-dedede coreboot Change-Id: I89d84b6eb77c18b36b1ff946cec057889013c58f --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 12 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/59333/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/59333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89d84b6eb77c18b36b1ff946cec057889013c58f Gerrit-Change-Number: 59333 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in blobs[master]: soc/mediatek/mt8186: Add MT8186 basic files
by Rex-BC Chen (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/59335 ) Change subject: soc/mediatek/mt8186: Add MT8186 basic files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/blobs/+/59335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: Ic6198353b1f7cca683875339a5fc4378a783d7a2 Gerrit-Change-Number: 59335 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 16 Nov 2021 04:02:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in blobs[master]: soc/mediatek/mt8186: Add MT8186 basic files
by Rex-BC Chen (Code Review) 16 Nov '21

16 Nov '21

Rex-BC Chen has uploaded this change for review. ( https://review.coreboot.org/c/blobs/+/59335 ) Change subject: soc/mediatek/mt8186: Add MT8186 basic files ...................................................................... soc/mediatek/mt8186: Add MT8186 basic files Add README.md and license.txt. Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: Ic6198353b1f7cca683875339a5fc4378a783d7a2 --- A soc/mediatek/mt8186/README.md A soc/mediatek/mt8186/license.txt 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/35/59335/1 diff --git a/soc/mediatek/mt8186/README.md b/soc/mediatek/mt8186/README.md new file mode 100644 index 0000000..6582718 --- /dev/null +++ b/soc/mediatek/mt8186/README.md @@ -0,0 +1,3 @@ +# Firmware list + +-------------------------------------------------------------------------------- diff --git a/soc/mediatek/mt8186/license.txt b/soc/mediatek/mt8186/license.txt new file mode 100644 index 0000000..6886c61 --- /dev/null +++ b/soc/mediatek/mt8186/license.txt @@ -0,0 +1,9 @@ +MediaTek Inc. grants permission to use and redistribute aforementioned firmware +files for the use with devices containing MediaTek chipsets, but not as part of +the Linux kernel or in any other form which would require these files themselves +to be covered by the terms of the GNU General Public License or the GNU Lesser +General Public License. + +These firmware files are distributed in the hope that they will be useful, but +are provided WITHOUT ANY WARRANTY, INCLUDING BUT NOT LIMITED TO IMPLIED WARRANTY +OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE. -- To view, visit https://review.coreboot.org/c/blobs/+/59335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: Ic6198353b1f7cca683875339a5fc4378a783d7a2 Gerrit-Change-Number: 59335 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/../thermal: Modified `pch_get_ltt_value()` return type
by Felix Singer (Code Review) 16 Nov '21

16 Nov '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Angel Pons, Patrick Rudolph. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59311 ) Change subject: soc/intel/../thermal: Modified `pch_get_ltt_value()` return type ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59311/comment/273d898c_04dd7c8b PS1, Line 7: Modified `pch_get_ltt_value()` return type How about this: Change return type of `pch_get_ltt_value()` to uint32 Or this, since you're mentioning a bug number below: Fix return type of `pch_get_ltt_value()` https://review.coreboot.org/c/coreboot/+/59311/comment/42b69758_57284dd8 PS1, Line 9: This patch modifies the pch_get_ltt_value() function return type from : uint16_t to uint32_t. Please explain why. That bug number below isn't very helpful for outstanding people. -- To view, visit https://review.coreboot.org/c/coreboot/+/59311 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f46ccb457b9cfebf13a512eabb3fb0fab8adb39 Gerrit-Change-Number: 59311 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 16 Nov 2021 04:00:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021