coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: drivers/analogix/anx7625: Fix return code handling
by Hung-Te Lin (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59539 ) Change subject: drivers/analogix/anx7625: Fix return code handling ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: BRANCH should be none or asurada? -- To view, visit https://review.coreboot.org/c/coreboot/+/59539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I955b9aae11e20d75fac414d15714330e364dad2f Gerrit-Change-Number: 59539 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Wei-Shun Chang <weishunc(a)google.com> Gerrit-Reviewer: Xin Ji <xji(a)analogix.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 22 Nov 2021 12:43:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add warning about "private" changes on Gerrit
by Patrick Georgi (Code Review) 22 Nov '21

22 Nov '21

Hello Felix Singer, build bot (Jenkins), David Hendricks, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59229 to look at the new patch set (#2). Change subject: Documentation: Add warning about "private" changes on Gerrit ...................................................................... Documentation: Add warning about "private" changes on Gerrit Private changes on Gerrit are a tricky beast in that they're well hidden in the UI and a few other places but still reachable under certain circumstances. Change-Id: I1c8c6cccfd023bc1d839dc5d9544204c88f89c7e Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M Documentation/getting_started/gerrit_guidelines.md M Documentation/tutorial/part2.md 2 files changed, 7 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/59229/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c8c6cccfd023bc1d839dc5d9544204c88f89c7e Gerrit-Change-Number: 59229 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/beetley: Enable Wifi SAR for beetley
by Wizard Shen (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Henry Sun, Weimin Wu, Karthik Ramasubramanian. Wizard Shen has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/coreboot/+/59544 ) Change subject: mb/google/dedede/var/beetley: Enable Wifi SAR for beetley ...................................................................... Removed reviewer build bot (Jenkins) with the following votes: * Verified+1 by build bot (Jenkins) <no-reply(a)coreboot.org> -- To view, visit https://review.coreboot.org/c/coreboot/+/59544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1682cdafe1b6ed7cc0cf23624f83d2e5bbfb92e Gerrit-Change-Number: 59544 Gerrit-PatchSet: 2 Gerrit-Owner: Wizard Shen <shenhu5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-CC: Krystal Han <hanlijing(a)huaqin.corp-partner.google.com> Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: mb/google/dedede/var/beetley: Enable Wifi SAR for beetley
by zanxi chen (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Weimin Wu, Wizard Shen. zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59544 ) Change subject: mb/google/dedede/var/beetley: Enable Wifi SAR for beetley ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: LGTM. -- To view, visit https://review.coreboot.org/c/coreboot/+/59544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1682cdafe1b6ed7cc0cf23624f83d2e5bbfb92e Gerrit-Change-Number: 59544 Gerrit-PatchSet: 2 Gerrit-Owner: Wizard Shen <shenhu5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-CC: Krystal Han <hanlijing(a)huaqin.corp-partner.google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Wizard Shen <shenhu5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 22 Nov 2021 12:05:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/txt: Implement GETSEC PARAMETER dumping
by build bot (Jenkins) (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59516 ) Change subject: security/intel/txt: Implement GETSEC PARAMETER dumping ...................................................................... Patch Set 3: (2 comments) File src/security/intel/txt/logging.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134003): https://review.coreboot.org/c/coreboot/+/59516/comment/280b5b08_c19a4562 PS3, Line 253: if (txt_feature_flags & GETSEC_PARAMS_TXT_EXT_CRTM_SUPPORT) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134003): https://review.coreboot.org/c/coreboot/+/59516/comment/9c5f08b1_7891af07 PS3, Line 259: if (txt_feature_flags & GETSEC_PARAMS_TXT_EXT_MACHINE_CHECK) { braces {} are not necessary for any arm of this statement -- To view, visit https://review.coreboot.org/c/coreboot/+/59516 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3b2c8337a8d86000a5b43788840d15146b662598 Gerrit-Change-Number: 59516 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 22 Nov 2021 12:04:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/txt: Correct reporting of chipset production fuse state
by Michał Żygowski (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Patrick Rudolph. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59514 ) Change subject: security/intel/txt: Correct reporting of chipset production fuse state ...................................................................... Patch Set 3: (1 comment) File src/security/intel/txt/common.c: https://review.coreboot.org/c/coreboot/+/59514/comment/8bd8bec9_85aaa33a PS2, Line 155: reg = read64((void *)TXT_VER_QPIIF); > this seems to be 32bit register as well Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic86c5a9e1d162630a1cf61435d1014edabf104b0 Gerrit-Change-Number: 59514 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 22 Nov 2021 12:04:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/txt: Correct reporting of chipset production fuse state
by Michał Żygowski (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Michał Żygowski. Hello build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59514 to look at the new patch set (#3). Change subject: security/intel/txt: Correct reporting of chipset production fuse state ...................................................................... security/intel/txt: Correct reporting of chipset production fuse state Implement the chipset production fuse state reporting as described in the Intel TXT Software Development Guide. TEST=Dell OptiPlex 9010 with i7-3770/Q77 reports the chipset is production fused Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Ic86c5a9e1d162630a1cf61435d1014edabf104b0 --- M src/security/intel/txt/common.c M src/security/intel/txt/logging.c M src/security/intel/txt/txt.h 3 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/59514/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/59514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic86c5a9e1d162630a1cf61435d1014edabf104b0 Gerrit-Change-Number: 59514 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel/sandybridge/romstage.c: Configure DPR and initialize TXT
by Michał Żygowski (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Angel Pons, Patrick Rudolph. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59523 ) Change subject: nb/intel/sandybridge/romstage.c: Configure DPR and initialize TXT ...................................................................... Patch Set 2: (1 comment) File src/northbridge/intel/sandybridge/romstage.c: https://review.coreboot.org/c/coreboot/+/59523/comment/c7a0d5f4_54679108 PS2, Line 78: #if CONFIG(INTEL_TXT) > use if(CONFIG(INTEL_TXT)) { But then if INTEL_TXT is not selected in the configuration, the intel_txt_romstage_init will not have any implementation. Are you fine with an empty __weak intel_txt_romstage_init in this file? Or alternatively we may always compile the romstage part of TXT driver. If MLE will not set up, we should not hit the situation when there is a TXT wake error and TPM establishment asserted. ACM doesn't have to be included because there would be no need for SCLEAN if I am deducting correctly. -- To view, visit https://review.coreboot.org/c/coreboot/+/59523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4b912f121593fa55c11813262f09be1a1055e950 Gerrit-Change-Number: 59523 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 22 Nov 2021 12:00:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/txt/romstage.c: Unlock memory when SCLEAN not needed
by Michał Żygowski (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Patrick Rudolph. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59521 ) Change subject: security/intel/txt/romstage.c: Unlock memory when SCLEAN not needed ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59521/comment/59c51990_f4b34c6c PS2, Line 10: memory on a TXT enabled platform. Previosuly on Sandybridge raminit the > this MSR is actually written in init_dram_ddr3(). […] Since TXT is optional, we would still need to have this fragment just in case the memory controller would be locked. Having it in the TXT driver allows to use it in a controlled manner, i.e. only when TXT is checked to be supported by the chipset and CPU. By the way, this MSR should generate #GP when CPU or chipset is not TXT capable, we do not guard this in src/northbridge/intel/sandybridge/raminit.c. have you experienced such issues? -- To view, visit https://review.coreboot.org/c/coreboot/+/59521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd29d163a2310f0b574fc72d575f23088ab1d11d Gerrit-Change-Number: 59521 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 22 Nov 2021 11:51:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/lenovo: Enable MEI on Sandy Bridge ThinkPads
by Evgeny Zinoviev (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Paul Menzel, Angel Pons, Patrick Rudolph. Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59527 to look at the new patch set (#4). Change subject: mb/lenovo: Enable MEI on Sandy Bridge ThinkPads ...................................................................... mb/lenovo: Enable MEI on Sandy Bridge ThinkPads It was already enabled on T520 and L520, but disabled on X220, T420 and T420s. On X220, it was disabled by commit 0793afe9 (mb/lenovo/x220: disable ME). I can't reproduce those issues today on linux 4.4 and linux 5.13. Also, it breaks the me_disable feature, we already have a Kconfig option to hide MEI in case of errors, and it will be hidden on disabled, recovery, firmware update paths anyway. Change-Id: I8e6d067a9c728443d00df541ac7a9a878df58b6a Signed-off-by: Evgeny Zinoviev <me(a)ch1p.io> --- M src/mainboard/lenovo/t420/devicetree.cb M src/mainboard/lenovo/t420s/devicetree.cb M src/mainboard/lenovo/x220/devicetree.cb 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/59527/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/59527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e6d067a9c728443d00df541ac7a9a878df58b6a Gerrit-Change-Number: 59527 Gerrit-PatchSet: 4 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021