coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: oprom/realmode/x86.c: Fix building for ENV_X86_64
by Arthur Heymans (Code Review) 25 Nov '21

25 Nov '21

Hello Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59660 to look at the new patch set (#2). Change subject: oprom/realmode/x86.c: Fix building for ENV_X86_64 ...................................................................... oprom/realmode/x86.c: Fix building for ENV_X86_64 Not tested on hardware. Change-Id: I8ce8d56da326aeff5ff9b400ded02d4309372519 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/device/oprom/realmode/x86.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/59660/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ce8d56da326aeff5ff9b400ded02d4309372519 Gerrit-Change-Number: 59660 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: oprom/realmode/x86.c: Fix building for ENV_X86_64
by build bot (Jenkins) (Code Review) 25 Nov '21

25 Nov '21

Attention is currently required from: Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59660 ) Change subject: oprom/realmode/x86.c: Fix building for ENV_X86_64 ...................................................................... Patch Set 1: (2 comments) File src/device/oprom/realmode/x86.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134319): https://review.coreboot.org/c/coreboot/+/59660/comment/d607a773_1e81f1ac PS1, Line 93: .rip=X86_EIP, spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134319): https://review.coreboot.org/c/coreboot/+/59660/comment/7eb7977d_3b3aa1bb PS1, Line 99: .rflags=X86_EFLAGS spaces required around that '=' (ctx:VxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/59660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ce8d56da326aeff5ff9b400ded02d4309372519 Gerrit-Change-Number: 59660 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 25 Nov 2021 08:40:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: oprom/yabel/io.c: Fix building for ENV_X86_64
by Arthur Heymans (Code Review) 25 Nov '21

25 Nov '21

Attention is currently required from: Arthur Heymans. Hello Arthur Heymans, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/59661 to review the following change. Change subject: oprom/yabel/io.c: Fix building for ENV_X86_64 ...................................................................... oprom/yabel/io.c: Fix building for ENV_X86_64 Unknown if yabel works for X86_64 but now it builds. Change-Id: Iacdb9fde91a992b5010120f5824383ca4aebdd1a Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/device/oprom/yabel/io.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/59661/1 diff --git a/src/device/oprom/yabel/io.c b/src/device/oprom/yabel/io.c index 051a601..07d2fd1 100644 --- a/src/device/oprom/yabel/io.c +++ b/src/device/oprom/yabel/io.c @@ -32,6 +32,7 @@ * IBM Corporation - initial implementation *****************************************************************************/ +#include <stdint.h> #include <types.h> #include "compat/rtas.h" #include "compat/time.h" @@ -103,7 +104,7 @@ { unsigned int ret; /* since we are using inb instructions, we need the port number as 16bit value */ - u16 port = (u16)(u32) addr; + u16 port = (u16)(uintptr_t) addr; switch (sz) { case 1: @@ -125,7 +126,7 @@ static int write_io(void *addr, unsigned int value, size_t sz) { - u16 port = (u16)(u32) addr; + u16 port = (u16)(uintptr_t) addr; switch (sz) { /* since we are using inb instructions, we need the port number as 16bit value */ case 1: -- To view, visit https://review.coreboot.org/c/coreboot/+/59661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacdb9fde91a992b5010120f5824383ca4aebdd1a Gerrit-Change-Number: 59661 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: oprom/realmode/x86.c: Fix building for ENV_X86_64
by Arthur Heymans (Code Review) 25 Nov '21

25 Nov '21

Attention is currently required from: Arthur Heymans. Hello Arthur Heymans, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/59660 to review the following change. Change subject: oprom/realmode/x86.c: Fix building for ENV_X86_64 ...................................................................... oprom/realmode/x86.c: Fix building for ENV_X86_64 Not tested on hardware. Change-Id: I8ce8d56da326aeff5ff9b400ded02d4309372519 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/device/oprom/realmode/x86.c 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/59660/1 diff --git a/src/device/oprom/realmode/x86.c b/src/device/oprom/realmode/x86.c index 224e49b..38452f5 100644 --- a/src/device/oprom/realmode/x86.c +++ b/src/device/oprom/realmode/x86.c @@ -89,13 +89,21 @@ .edi=X86_EDI, .vector=M.x86.intno, .error_code=0, // FIXME: fill in +#if ENV_X86_64 + .rip=X86_EIP, +#else .eip=X86_EIP, +#endif .cs=X86_CS, +#if ENV_X86_64 + .rflags=X86_EFLAGS +#else .eflags=X86_EFLAGS +#endif }; struct eregs *regs = &reg_info; - printk(BIOS_INFO, "Oops, exception %d while executing option rom\n", + printk(BIOS_INFO, "Oops, exception %lld while executing option rom\n", regs->vector); x86_exception(regs); // Call coreboot exception handler -- To view, visit https://review.coreboot.org/c/coreboot/+/59660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ce8d56da326aeff5ff9b400ded02d4309372519 Gerrit-Change-Number: 59660 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/analogix/anx7625: Utilize retry() macro
by Yu-Ping Wu (Code Review) 25 Nov '21

25 Nov '21

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59659 ) Change subject: drivers/analogix/anx7625: Utilize retry() macro ...................................................................... drivers/analogix/anx7625: Utilize retry() macro Utilize retry() macro in wait_aux_op_finish() and anx7625_init() to simplify the code. BUG=none TEST=emerge-asurada coreboot BRANCH=none Change-Id: I207e7075e8ac905efd5f201dd54658dedf531568 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/drivers/analogix/anx7625/anx7625.c 1 file changed, 5 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/59659/1 diff --git a/src/drivers/analogix/anx7625/anx7625.c b/src/drivers/analogix/anx7625/anx7625.c index 153266c..81f27d0 100644 --- a/src/drivers/analogix/anx7625/anx7625.c +++ b/src/drivers/analogix/anx7625/anx7625.c @@ -6,6 +6,7 @@ #include <edid.h> #include <gpio.h> #include <string.h> +#include <types.h> #include "anx7625.h" @@ -133,20 +134,11 @@ static int wait_aux_op_finish(uint8_t bus) { uint8_t val; - int loop; - int success = 0; int ret; - for (loop = 0; loop < 150; loop++) { - mdelay(2); - anx7625_reg_read(bus, RX_P0_ADDR, AP_AUX_CTRL_STATUS, &val); - if (!(val & AP_AUX_CTRL_OP_EN)) { - success = 1; - break; - } - } - - if (!success) { + if (!retry(150, + (anx7625_reg_read(bus, RX_P0_ADDR, AP_AUX_CTRL_STATUS, &val), + !(val & AP_AUX_CTRL_OP_EN)), mdelay(2))) { ANXERROR("Timed out waiting aux operation.\n"); return -1; } @@ -874,13 +866,8 @@ int anx7625_init(uint8_t bus) { int retry_hpd_change = 50; - int retry_power_on = 3; - while (--retry_power_on) { - if (anx7625_power_on_init(bus) >= 0) - break; - } - if (!retry_power_on) { + if (!retry(3, anx7625_power_on_init(bus) >= 0)) { ANXERROR("Failed to power on.\n"); return -1; } -- To view, visit https://review.coreboot.org/c/coreboot/+/59659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I207e7075e8ac905efd5f201dd54658dedf531568 Gerrit-Change-Number: 59659 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/analogix/anx7625: Fix edid_read()
by Yu-Ping Wu (Code Review) 25 Nov '21

25 Nov '21

Attention is currently required from: Paul Menzel, Yu-Ping Wu. Hello Hung-Te Lin, build bot (Jenkins), Wei-Shun Chang, Paul Menzel, Xin Ji, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59540 to look at the new patch set (#4). Change subject: drivers/analogix/anx7625: Fix edid_read() ...................................................................... drivers/analogix/anx7625: Fix edid_read() The current implementations of edid_read() and segments_edid_read() have a few problems: 1. The type of variable `c` is incorrect, not matching the return type of sp_tx_aux_rd(). In addition, the meaning of `c` is unknown. 2. It is pointless to do `cnt++` when sp_tx_aux_rd() fails. 3. These two functions ignore the return value of anx7625_reg_block_read(). 4. In segments_edid_read(), anx7625_reg_write() might return a positive value on failure. Fix all of the 4 issues, and modify the code to be closer to kernel 5.10's implementation (drivers/gpu/drm/bridge/analogix/anx7625.c). Note that, however, unlike in kernel, anx7625_reg_block_read() here doesn't return the number of bytes. On success, 0 is returned instead. In addition, following coreboot's convention, always return negative error codes. In particular, change the return value to -1 for edid_read() and segments_edid_read() on failure. BUG=b:207055969 TEST=emerge-asurada coreboot BRANCH=none Change-Id: Ife9d7d97df2926b4581ba519a152c9efed8cd969 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/drivers/analogix/anx7625/anx7625.c 1 file changed, 76 insertions(+), 68 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/59540/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/59540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife9d7d97df2926b4581ba519a152c9efed8cd969 Gerrit-Change-Number: 59540 Gerrit-PatchSet: 4 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Wei-Shun Chang <weishunc(a)google.com> Gerrit-Reviewer: Xin Ji <xji(a)analogix.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/x86: Rename X86_AMD_INIT_SIPI to X86_INIT_SIPI
by Arthur Heymans (Code Review) 25 Nov '21

25 Nov '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56651 ) Change subject: cpu/x86: Rename X86_AMD_INIT_SIPI to X86_INIT_SIPI ...................................................................... Patch Set 3: (2 comments) File src/cpu/x86/Kconfig: https://review.coreboot.org/c/coreboot/+/56651/comment/1c6b9077_d0d481d2 PS3, Line 174: and SIPI, nit: wrap on the next line. File src/cpu/x86/mp_init.c: https://review.coreboot.org/c/coreboot/+/56651/comment/3bc7fbb2_bee77347 PS3, Line 472: X86_INIT_SIPI maybe use a more descriptive name: X86_INIT_NEED_1_SIPI -- To view, visit https://review.coreboot.org/c/coreboot/+/56651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a4e6a8b1edc6e8ba43597259bd8b2de697e4e62 Gerrit-Change-Number: 56651 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 25 Nov 2021 08:10:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Select X86_INIT_SIPI Kconfig for Alder Lake
by Maulik V Vaghela (Code Review) 25 Nov '21

25 Nov '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph. Maulik V Vaghela has uploaded a new patch set (#2) to the change originally created by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/56652 ) Change subject: soc/intel/alderlake: Select X86_INIT_SIPI Kconfig for Alder Lake ...................................................................... soc/intel/alderlake: Select X86_INIT_SIPI Kconfig for Alder Lake This patch helps to save ~20ms of booting time without any issue seen during MP Init. All cores are out from reset and alive. Change-Id: I4a358409beb18fc2517020fae88f528b58ab3907 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/alderlake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/56652/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a358409beb18fc2517020fae88f528b58ab3907 Gerrit-Change-Number: 56652 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/x86: Rename X86_AMD_INIT_SIPI to X86_INIT_SIPI
by Maulik V Vaghela (Code Review) 25 Nov '21

25 Nov '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Tim Wawrzynczak, Subrata Banik, Felix Held. Maulik V Vaghela has uploaded a new patch set (#3) to the change originally created by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/56651 ) Change subject: cpu/x86: Rename X86_AMD_INIT_SIPI to X86_INIT_SIPI ...................................................................... cpu/x86: Rename X86_AMD_INIT_SIPI to X86_INIT_SIPI This patch renames X86_AMD_INIT_SIPI Kconfig to leverage this logic on latest Intel platform. Change-Id: I7a4e6a8b1edc6e8ba43597259bd8b2de697e4e62 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/cpu/x86/Kconfig M src/cpu/x86/mp_init.c M src/soc/amd/cezanne/Kconfig M src/soc/amd/picasso/Kconfig 4 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/56651/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a4e6a8b1edc6e8ba43597259bd8b2de697e4e62 Gerrit-Change-Number: 56651 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/medaitek/mt8186: fix wrong condition of RTC drivers
by Yu-Ping Wu (Code Review) 25 Nov '21

25 Nov '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59653 ) Change subject: soc/medaitek/mt8186: fix wrong condition of RTC drivers ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fdf4de0383ef373dd45e8d8741aa861c9c4bdc6 Gerrit-Change-Number: 59653 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Thu, 25 Nov 2021 07:48:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021